AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 78 Bitcoin

Restrict signing and Teleport retry QR scans to expected types

Public commit record

What the developer wrote

Authored by scgbckbone

50/100 · Thin
Restrict signing and Teleport retry QR scans to expected types
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This update fixes a bug in the COLDCARD Q1 hardware wallet where scanning a QR code from the 'Ready To Sign' or 'Key Teleport retry' screens could accidentally replace the device's master seed with seed words or an extended private key shown in the QR code. The fix restricts those screens so they only accept the specific QR types they expect (a PSBT file for signing, or a Key Teleport code), and rejects seed/private-key QR codes. A related assertion that protects the master seed was also tightened.

Recommended action

Treat this as a security fix and include it in the next firmware release. Users with Q1 devices should update when available. Review other QR entry points for similar missing expect_type constraints, and ensure set_seed_value() callers cannot be reached with an active secret.

Security signals we found

01

Unintended master seed replacement via QR scan in signing/Teleport flows

02

Missing input-type validation on context-sensitive QR scanner

03

Tightened secure-element secret-overwrite guard in set_seed_value()

04

Regression test demonstrates secret remains unchanged after rejected scans

Risk score

Why this scored 78/100

Our methodology →
Potential impact 24/30
Exploitability 18/25
Stealth signal 12/15
Affected reach 10/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.