Bitcoin Core

This commit is a simple code reorganization: it moves a data structure called CreatedTransactionResult from one internal header file to another so other parts of the codebase can use it without pulling in the entire wallet header. There is no change to behavior, no bug fix, and no security-related content.

This commit removes a special error message in the Bitcoin Core graphical wallet that told users when their balance was too small to cover both the payment amount and the transaction fee. The wallet now lets an underlying internal function produce the error message instead. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a code cleanup and user-experience simplification.

This commit is a code cleanup in Bitcoin Core's RPC (remote procedure call) output code. It removes explicit type casts when adding numeric values to JSON responses, relying on the underlying types instead. There is no direct evidence this fixes a security vulnerability; it is presented by the author as a refactoring to make the code less confusing and brittle.

This change improves the error message shown when a Bitcoin wallet user tries to send an amount that fits their balance but leaves no room for the network transaction fee. Previously the wallet just said 'Insufficient funds.' Now it explains that the total exceeds the balance once the fee is included. It is a user-experience and diagnostic improvement, not a security fix.

This commit simply removes an unused internal data structure called PreSelectedInputs from a wallet header file. It is a code cleanup change with no functional behavior change and no apparent security relevance.

This is a Bitcoin Core wallet code cleanup that replaces an internal data structure called PreSelectedInputs with a cleaner one called CoinsResult. The commit message says the old structure was confusing because a field named total_amount could hold two different kinds of amounts, which could lead to accidentally mixing them. The patch separates those amounts and adds an explicit safety check where it matters. It is a defensive refactor rather than a fix for a known live bug or exploit.

This commit simply moves the Windows CI build command out of the GitHub Actions YAML file and into a small Python helper script. It does not change what software is built, how it is built, or any user-facing behavior. There is no security issue here.

This is a routine code cleanup in Bitcoin Core that swaps one internal data-reading helper (DataStream) for another (SpanReader) across many files. The commit message explicitly says it does not change behavior, and the diff only shows mechanical replacements with no new logic. There is no security issue visible in the change.

This Bitcoin Core change fixes a subtle bug in how the wallet keeps track of selected coins. Previously, the wallet used a set of coin objects directly, which automatically prevented duplicates. After a recent refactor, it started using a set of pointers to coin objects, where the default behavior only prevents duplicate pointer addresses—not duplicate coins. This meant two different pointers representing the same coin could both end up in the selection, potentially causing the wallet to try to spend the same coin twice or miscalculate fees and change. The fix makes the set compare the actual coin data, not just pointer addresses, restoring the old duplicate-prevention behavior.

This is a tiny performance fix in the Bitcoin Core wallet code. A helper function that gathers all spendable coins into one flat list was reserving memory based on the number of coin categories (for example, how many output types exist) rather than the actual total number of coins. The change makes it reserve the correct, larger amount of memory up front. It does not change any security logic, balances, or transaction construction rules.

This is a small, clean code refactor inside the Bitcoin Core wallet. It moves an existing calculation into a new helper function and makes a few methods 'const' (read-only). There is no change to behavior, no bug fix, and no security issue visible in the diff.

This is a small code cleanup in Bitcoin Core's wallet coin-selection logic. The change makes a cached optional value behave as actually optional (unset by default) and only updated when it has a value. It fixes a logic inconsistency found during code review, but there is no direct evidence it prevents a real-world exploit or user-visible bug on its own.

This commit is a simple code cleanup: it creates a project-specific alias `btcsignals` for the external library namespace `boost::signals2`, and replaces all direct uses of `boost::signals2` with the new alias. There is no functional change, no bug fix, and no security-relevant behavior change.

This commit is a simple code cleanup: it creates a new internal header file called btcsignals.h that currently just forwards to Boost's signals library, and then replaces direct Boost signals includes across several source files with this new header. There is no functional change, no bug fix, and no security-relevant behavior change.

This commit removes an old wallet-loading code path called NEED_REWRITE that was used to automatically rewrite certain very old Berkeley DB (BDB) wallets from Bitcoin versions 0.4.0 and 0.5.0. The change is described as cleanup because those wallets can no longer be loaded outside of migration, and migration already rewrites the database. There is no direct evidence in the commit of a security vulnerability being fixed.

This commit removes leftover calls to a wallet method called RewriteDB that no longer had any real implementation. It is a small code cleanup with no security impact.

This commit only adds documentation: a release note explaining that the Bitcoin Core fee estimator now tracks lower fee rates (down to 0.1 sat/vB instead of 1 sat/vB). There is no code change, no bug fix, and no security issue in the diff itself.

This commit adds a new automated fuzz test for Bitcoin Core's coin selection algorithm. It does not change any production wallet code, network behavior, or consensus rules. The test brute-forces small coin-selection problems and checks that the Branch-and-Bound (BnB) solver finds a minimum-waste solution. It is purely a testing/quality-assurance addition.

This is a routine build-system cleanup. Bitcoin Core's internal 'kernel' library no longer needs to force programs that use it to also depend on the Boost C++ library, because the kernel's public interface has been rewritten to avoid BOOST. The change simply removes one line from a CMake build file so BOOST is kept as a private dependency of the kernel itself rather than being propagated to downstream consumers. There is no security-relevant code change.

This commit changes one Bitcoin Core continuous integration (CI) test job to compile the software with the embedded asmap feature turned off. It does not change any production code, user-facing behavior, or network logic. It is purely a build/test configuration tweak to ensure that building without embedded asmap still works in CI.

This commit only adds new test cases for an existing Bitcoin wallet feature (MuSig multi-signature support inside miniscript expressions). It does not change production wallet logic, consensus rules, or network behavior. The changes are confined to a single functional test file and expand coverage for different miniscript patterns such as pkh and pk_h.

This commit adds new internal test-only checks to make sure Bitcoin Core's descriptor parser correctly counts key expressions. It does not change user-facing behavior or fix a known live bug; it is a regression test and small helper-code addition to verify an invariant (every key has a unique index and the count matches).

This is a small code-quality cleanup in Bitcoin Core's wallet code. It changes how an internal notification signal is wired up so that it no longer relies on an obscure, undocumented feature of the Boost signals library. The change prevents a future risk that a Boost update could silently break wallet address notifications, but there is no known current bug or security vulnerability being exploited.

This commit is a simple code reorganization: it moves the list of logging categories from one header file to a new header file, without changing what the categories are or how they behave. It is purely a structural cleanup to make future work easier.

This commit is a straightforward code cleanup: it renames the stream check from eof() (end-of-file) to empty() because the streams actually wrap in-memory buffers, not files. The behavior is identical, so there is no security issue here.