Bitcoin Core

This commit changes three internal wallet-loading call sites in Bitcoin Core to use a dedicated CWallet::LoadExisting() method instead of the more general CWallet::Create(). The change is a code-quality and correctness refactor: it makes it explicit that these paths are loading an already-existing wallet rather than creating a new one. There is no direct evidence in the commit that this fixes a security vulnerability, and the diff does not show any new input validation, bounds checks, or cryptographic changes.

This is a small, safe code cleanup in Bitcoin Core's wallet database code. It moves the logic that writes the wallet's version marker into its own reusable function, with no change to what data is actually written. There is no security issue here.

This commit is a simple code cleanup: it moves three existing wallet logging lines into a new helper function called LogStats(). There is no change to what is logged, no change to security behavior, and no bug fix.

This commit only changes Bitcoin Core's internal test helpers and benchmarks. It splits a single test function called TestLoadWallet into two separate helpers: TestCreateWallet (for making a new wallet) and TestLoadWallet (for opening an existing wallet). No production wallet code, network code, or consensus code is changed. There is no security issue here.

This commit is a code cleanup change in Bitcoin Core's wallet creation logic. It removes the ability to load an existing wallet from within the CWallet::Create function, making Create only handle brand-new wallets. Loading existing wallets is moved elsewhere. The change also updates a test to verify that a version message is logged when loading a wallet, not when creating one. There is no indication this fixes a security vulnerability.

This commit removes a small piece of code in Bitcoin Core's wallet startup that recalculated the wallet's 'birth time' (the earliest known key creation date) by scanning all script-pubkey managers. The author argues this recalculation is unnecessary because every path that adds a script-pubkey manager already calls the same birth-time update function. There is no indication in the commit that this fixes a security bug; it appears to be a code-cleanup/refactoring change.

This commit is a simple rename of a wallet creation function from CWallet::Create() to CWallet::CreateNew(). It does not change what the code does, only its name. There is no security issue here.

This commit is a simple code cleanup: it takes the part of Bitcoin Core's wallet creation code that handles loading an already-existing wallet and moves it into a new, separate function called LoadExisting. The actual behavior and security checks are unchanged; only the internal organization of the code is different.

This commit is a code-quality and fuzz-testing efficiency change. It refactors how Bitcoin Core's fuzz tests skip descriptor inputs that are too computationally expensive to process, combining several checks into one helper function and adding a new leaf-size check. It does not change production wallet or node behavior, and there is no indication it fixes a security vulnerability in live software.

This commit adds a new internal helper called LineReader for parsing text lines from network data buffers. It is a clean, defensive implementation with length limits and explicit error handling. There is no indication it fixes a security bug or introduces a vulnerability.

This commit adds a new helper function that converts a timestamp into the RFC1123 date format used in HTTP headers. It is purely additive: it introduces a formatting routine and unit tests, with no changes to existing behavior or network-facing code. There is no security issue visible in the change itself.

This commit adds two small helper tools for comparing text strings in a case-insensitive way, intended for use when handling HTTP headers. It only introduces the helpers and their unit tests; it does not change any live network or wallet code. There is no security issue visible in the change itself.

This commit adds an optional new feature to a string-to-number helper so it can understand hexadecimal (base-16) input. It does not change existing behavior unless callers explicitly request base 16, and there is no indication it fixes a security bug or introduces a vulnerability.

This commit is a minor code cleanup in Bitcoin Core's networking code. It replaces an old-style C cast with a modern C++ reinterpret_cast and renames a few local variables. There is no functional change and no security issue.

This commit removes one line from a test file. It deletes an entry for 'UNKNOWN_ERROR' from a list of script error descriptions used only in unit tests. There is no change to the actual Bitcoin network code, consensus rules, or wallet behavior. It is a test-only cleanup with no security relevance visible in the commit.

This commit is a small cleanup in how Bitcoin reports script errors. It makes the software return a specific 'script number' error code when a transaction script tries to use an oversized or non-minimally encoded number, instead of the generic 'unknown error' it used before. The scripts still fail exactly as they did; only the error label changed. There is no indication this fixes a security vulnerability or changes consensus behavior.

This commit adds a new, more descriptive error code for problems with numbers inside Bitcoin's script language. Previously, these problems were reported as a generic 'unknown error.' The change only defines the new error label and its human-readable message; it does not yet change any code that actually raises the error. By itself, this is a small cleanup that does not fix or introduce a security vulnerability.

This commit adds new public programming interfaces (APIs) for the Bitcoin Core 'kernel' library so external programs can create, inspect, and validate block headers without downloading full blocks. It is a feature addition, not a fix for a known security bug. The code follows the existing patterns for memory handles and validation, and includes tests. There is no evidence in the commit or supplied references that this resolves a security vulnerability.

This commit only changes a code comment in a header file. It deletes an outdated, incorrect description of the removeUnchecked function and replaces it with a short, accurate note. No program logic, behavior, or security boundary is changed.

This commit fixes a test case in Bitcoin Core's own test suite. It changes a P2PK (pay-to-pubkey) script test so that it actually enables the P2SH validation flag it claims to be testing. The bug was only in the test data and test code, not in the production Bitcoin consensus or networking code. There is no change to how real Bitcoin transactions are validated.

This is a tiny test-only change that renames a wallet used in a single functional test to avoid intermittent failures on Windows. It does not change any production code, network behavior, or wallet security logic.

This is a follow-up cleanup commit that only touches benchmark and test files. It rewrites a loop for readability and adds explanatory comments about why a test uses an odd number of leaves and how the coinbase witness hash is initialized. No production code is changed, so there is no security impact.

This is a test-only change for Bitcoin Core's internal Python test framework. It fixes a port-conflict problem that could occur when running automated tests on FreeBSD, by making sure randomly chosen network ports for test P2P listeners come from a range that does not clash with the test framework's hard-coded ports. It does not affect the Bitcoin Core software that users run, does not change consensus or networking behavior, and has no security relevance for live Bitcoin nodes.

This commit only changes Bitcoin Core's internal test framework. It makes the network cleanup timeout scale with a test-configurable slowdown factor, so slow test environments don't falsely fail. There is no change to production Bitcoin node code, no user-facing behavior, and no security issue.

This commit is a routine internal API refactor for Bitcoin Core's experimental libbitcoinkernel C API. It adds create/copy/destroy functions for a block-validation state object and splits a C++ wrapper class into a read-only 'View' and an owning 'Handle'. There is no security fix, no bug fix, and no externally reported issue. It simply lets outside code allocate and own these state objects.