BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

2902 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

254security candidates607second-pass queue2881AI analyses
192commits · 30 days
486commits · 60 days
1502commits · 180 days
2875commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

70/100 average clarity
939Strong · 80–100
1188Adequate · 60–79
687Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Antoine Poinsot22422170
Ava Chow15750157064
MarcoFalke41021406074
Lőrinc17721177081
fanquake22719226057
Hennadii Stepanov20914208063
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Hodlinator66566076
Analysis record

Published AI watches

Last scanned 26 minutes ago

Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35928: doc: mention -DWITH_ZMQ=ON in macOS build guide

This is a one-line documentation update to the macOS build guide. It adds a note telling users to pass a specific CMake option if they want ZeroMQ notification support. There is no code change and no security impact.

8397e09eby merge-script+1−11 file
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35482: fuzz: exercise the transaction-handling path in process_message(s)

This commit only changes Bitcoin Core's internal fuzz testing code. It makes the fuzz tests exercise more of the transaction-handling code path by toggling Initial Block Download mode and resetting the mempool between test runs. There is n…

No production code modifiedNo consensus, validation, net_processing, or wallet logic changedOnly fuzz test harnesses and test utilities affected
f11dc617by merge-script+105−798 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35914: test, fuzz: Remove unused variables

This commit removes unused variables from Bitcoin Core's test and fuzzing code. It is a cleanup/refactoring change with no effect on the live network software or user funds. It does not fix or introduce any security vulnerability.

d36bf709by merge-script+1−138 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35896: refactor: Default uint256::operator==, add operator<=>

This commit is a routine code cleanup in Bitcoin Core. It switches the uint256 equality and comparison operators to use standard C++20 defaults, removes an old custom Compare() helper, and marks an internal assertion-failure function as ne…

ed2c59abby merge-script+99−245 files
No security note in commit
Moderate 62 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35872: rpc: avoid descriptor range counter overflow

This update fixes a counting bug in several Bitcoin Core RPC commands that scan descriptors. When a user requested a descriptor range ending at the maximum allowed value (2,147,483,647), the internal counter used a smaller integer type and…

Signed integer overflow in descriptor expansion loopCrash/undefined behavior on maximum-range descriptor scansAuthenticated RPC surface affected (scantxoutset, scanblocks, getdescriptoractivity, utxoupdatepsbt, descriptorprocesspsbt)
b388674aby Ava Chow+3−12 files
Vendor flagged security relevance
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35842: rpc: Properly make RPCResult::Type::ANY non-test-only

This is a small cleanup and documentation fix for Bitcoin Core's RPC help system. It removes a comment that incorrectly said a certain output type was 'for testing only' and makes the help text properly display those outputs. There is no d…

No memory safety, cryptography, consensus, or authorization changes observedChange is confined to RPC help/schema metadata generationComment-only/type-label change from 'for testing only' to general use
c36ffd87by merge-script+42−364 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35895: refactor: Enable clang-tidy rule to reject anon namespace in header

This is a code cleanup change that turns on a static-analysis rule to prevent a specific C++ coding pattern (anonymous namespaces in header files) and updates two headers to comply. It does not change how Bitcoin Core behaves at runtime an…

No security-relevant code changeNo memory safety, cryptography, consensus, or network changesTooling-only refactor (clang-tidy configuration)
c4fbd3c7by merge-script+9−123 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35630: test: Add importdescriptors rpc error test coverage

This commit only adds new test cases to Bitcoin Core's functional test suite. It does not change any production wallet, node, or RPC code. The tests verify that the importdescriptors RPC reports errors in the right order, rejects bad times…

465196d0by merge-script+77−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35180: coins: group private cache helpers

This change is purely a code cleanup: it moves two internal helper functions of a Bitcoin Core cache class into the private section of the class and removes a duplicate 'private:' label. There is no change to what the code does, no bug fix…

c940fd75by merge-script+13−141 file
No security note in commit
Low 29 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35582: rpc: reject null for optional parameters

This Bitcoin Core change tightens how three RPC commands (scantxoutset, scanblocks, deriveaddresses) handle the value null when it is passed for optional parameters. Previously, explicitly passing null could be treated differently from sim…

RPC parameter validation changeNull value handling changeAddition of explicit error checks for missing required contextual parameters
3db96eb5by merge-script+18−75 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Enable misc-definitions-in-headers

This commit is a code cleanup: it turns on a clang-tidy style check called 'misc-definitions-in-headers' and suppresses that check around a large inline implementation block in a benchmark header. There is no change to Bitcoin's runtime be…

fa93132dby MarcoFalke+3−02 files
No security note in commit
Informational 15 AI analysisMessage 85 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Enable clang-tidy rule to reject anon namespace in header

This commit only changes a linting configuration file for the project's code style checker. It enables a rule that prevents anonymous namespaces from being used in header files, which is a code-quality and build-hygiene practice. There is …

No security-relevant signals in the diff or commit message.Change is purely a static-analysis/linting configuration update.
fa5ca877by MarcoFalke+2−11 file
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Use C++20 std::identity over IntIdentity

This commit is a straightforward code cleanup: it replaces a small custom helper named IntIdentity with the standard C++20 std::identity from the <functional> header. The behavior of the ConvertBits function is unchanged; only the implemen…

fafe5042by MarcoFalke+4−111 file
No security note in commit
Informational 15 AI analysisMessage 87 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: test the result order of a multiple import request is correct

This commit only adds a new automated test to Bitcoin Core. It checks that when a user asks the wallet to import multiple descriptors at once, the list of results comes back in the same order as the original request, including any error me…

3ac8b806by Pol Espinasa+40−01 file
No security note in commit
Informational 15 AI analysisMessage 87 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: test invalid or missing timestamp throws importdescriptors

This commit only adds new automated tests for the Bitcoin Core wallet's importdescriptors RPC. It checks that the command correctly rejects requests with a missing or invalid timestamp. No production wallet code is changed, so this cannot …

No changes to consensus, networking, wallet logic, or cryptographyOnly functional test code is modifiedAdded assertions are for expected error handling paths
e4732bf0by Pol Espinasa+28−11 file
No security note in commit
Informational 15 AI analysisMessage 80 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Remove unused #include in common/system

This is a minor code cleanup that removes one unused header file include and swaps another for a more specific one. It does not change any program behavior or fix any security issue.

fa7304f3by MarcoFalke+1−22 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

iwyu: Fix warnings in `src/consensus` and treat them as errors

This commit is a routine code cleanup: it adjusts which C++ header files are included in several consensus-related source files and turns on a stricter compiler hygiene check (Include What You Use, or IWYU) for the src/consensus directory.…

13b53f8bby Hennadii Stepanov+42−79 files
No security note in commit
Informational 15 AI analysisMessage 55 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

fuzz: don't connman.ReceiveMsgFrom oversized msg

This is a small fix to a Bitcoin Core fuzz test (an automated internal testing harness), not to the live network code. The fuzzer was sometimes creating fake P2P messages larger than the real protocol allows and passing them into a test he…

Test-only fuzz harness hardeningOversized message guard added before ReceiveMsgFrom() in fuzz targetNo change to production P2P message acceptance logic
bb19f1daby Greg Sanders+5−01 file
No security note in commit
Informational 15 AI analysisMessage 97 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: Temporarily remove riscv32 config from GHA matrix

This commit simply removes one failing test configuration (RISC-V 32-bit bare metal) from the project's GitHub Actions CI matrix because it was failing. It is a routine CI maintenance change with no security implications.

fa06ea42by MarcoFalke+0−61 file
No security note in commit
Low 47 AI analysisMessage 90 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: verify cross-build SDK archives

This change adds checksum verification to the build system's downloads of Apple, FreeBSD, NetBSD, and OpenBSD software development kits (SDKs). Before this patch, those SDK archives were downloaded at build time and extracted without confi…

Adds cryptographic digest verification for downloaded SDK archivesRemoves unchecked extraction of remote SDK archives in CIHardens CI supply chain for macOS/BSD cross-builds
873550beby Lőrinc+25−126 files
Vendor flagged security relevance
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityImprove comments for getTransactionAncestry to reference cluster counts instead of descendantsby Suhas Daftuar · 957ae232 · Dec 1, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

Improve comments for getTransactionAncestry to reference cluster counts instead of descendants

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes two comment lines in a header file. It renames 'descendants' to 'cluster_count' in documentation to match what the code actually calculates. No executable code, logic, or behavior was changed, so there is no security impact.

Lower-prioritydoc: add comment to explain correctness of GatherClusters()by Suhas Daftuar · b8d279a8 · Dec 1, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

doc: add comment to explain correctness of GatherClusters()

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a code comment explaining that a function returns results in a deterministic order. No code behavior was changed, so it cannot introduce or fix a security issue on its own.

Lower-priorityFix comment to reference cluster limits, not chain limitsby Suhas Daftuar · d97d6199 · Dec 1, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

Fix comment to reference cluster limits, not chain limits

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes a single word in a code comment, replacing 'chain' with 'cluster count' to accurately describe what the following code checks. It does not alter any program logic, behavior, or security properties.

Lower-prioritySanity check feerate diagram in CTxMemPool::check()by Suhas Daftuar · a1b341ef · Dec 1, 2025 · 1 fileMessage 77 · AdequateInformational 22Details
Commit message · Suhas Daftuar

Sanity check feerate diagram in CTxMemPool::check()

Also switch Assume()'s to assert()'s, so that failures in this function are
always caught.

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Explains rationale or failure mode
AI analysis · Informational 22/100

This commit adds extra internal consistency checks to Bitcoin Core's memory pool validation routine and turns some soft 'Assume' warnings into hard 'assert' failures. It does not change network rules or how transactions are accepted; it only makes the program crash more reliably if its own bookkeeping about transaction fees and weights becomes internally inconsistent. That helps developers catch bugs during testing but is not a fix for an externally exploitable vulnerability.

Lower-priorityFix parameter name in getmempoolcluster rpcby Suhas Daftuar · aba7500a · Dec 1, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Suhas Daftuar

Fix parameter name in getmempoolcluster rpc

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a one-word documentation fix in a Bitcoin Core RPC help message. The error message shown when a user provides an invalid transaction ID now says 'txid' instead of 'parameter 1'. There is no security impact.

Lower-priorityRename weight -> clusterweight in RPC output, and add doc explaining mempool terminologyby Suhas Daftuar · 6c1325a0 · Dec 1, 2025 · 3 filesMessage 65 · AdequateInformational 20Details
Commit message · Suhas Daftuar

Rename weight -> clusterweight in RPC output, and add doc explaining mempool terminology

Co-authored-by: glozow <gloriajzhao@gmail.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 20/100

This commit renames a single field in a Bitcoin Core RPC output from 'weight' to 'clusterweight' and adds documentation explaining mempool fee/size terminology. It is a user-facing clarity/documentation change with no security-relevant code behavior change.

Lower-priorityRequire mempool lock to be held when invoking TRUC checksby Suhas Daftuar · bc2eb931 · Dec 1, 2025 · 2 filesMessage 50 · ThinLow 35Details
Commit message · Suhas Daftuar

Require mempool lock to be held when invoking TRUC checks

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 35/100

This commit changes two Bitcoin Core functions that enforce special rules for a new type of transaction called TRUC. Previously, one function locked the memory pool (mempool) itself. Now both functions require their callers to already hold the mempool lock. This is a defensive coding change that makes it explicit who is responsible for thread safety, but it does not by itself fix a known exploitable bug.

AI review queuedrpc: improve getmempoolcluster outputby Suhas Daftuar · 23d6f457 · Dec 1, 2025 · 2 filesMessage 35 · OpaqueInformational 18Details
Commit message · Suhas Daftuar

rpc: improve getmempoolcluster output

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 18/100

This commit changes the format of a Bitcoin Core RPC command called getmempoolcluster so it groups transactions into 'chunks' rather than listing each transaction separately. It also adds a clearer error message when the requested transaction is not in the memory pool. The change is a user-facing output improvement, not a fix for a security vulnerability.

Lower-priorityAvoid using mapTx.modify() to update modified feesby Suhas Daftuar · d2dcd37a · Dec 1, 2025 · 2 filesMessage 65 · AdequateInformational 18Details
Commit message · Suhas Daftuar

Avoid using mapTx.modify() to update modified fees

Now that the mempool no longer keeps any feerate-based indices, we can modify
feerates in mempool entries directly.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 18/100

This is a small internal cleanup in Bitcoin Core's memory pool (mempool) code. It changes how transaction fee adjustments are updated, removing an unnecessary wrapper and making a fee field directly mutable. There is no indication this fixes a security bug; it appears to be a refactoring or simplification after an earlier data structure change removed fee-based indexes.

Lower-prioritydoc: add release notes snippet for cluster mempoolby Suhas Daftuar · d84ffc24 · Dec 1, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

doc: add release notes snippet for cluster mempool

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds a release notes document describing a previously implemented mempool redesign called 'cluster mempool.' It contains no code changes, no bug fixes, and no security-related disclosures. It is purely documentation.

AI review queueddoc: Add design notes for cluster mempool and explain new mempool limitsby Suhas Daftuar · b0417ba9 · Dec 1, 2025 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

doc: Add design notes for cluster mempool and explain new mempool limits

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes documentation. It adds a new design document explaining Bitcoin Core's cluster mempool concept, renames a link in the policy README, and deletes an older document about mempool limits. No code, configuration, or behavior is modified. There is no security issue in this change.

Lower-priorityfuzz: gate mempool entry based on weightby Greg Sanders · 80432940 · Dec 1, 2025 · 1 fileMessage 78 · AdequateInformational 17Details
Commit message · Greg Sanders

fuzz: gate mempool entry based on weight

The mempool implementation now uses TxGraph with entries
using FeePerWeight, not vsize. This means our package_rbf
harness will erroneously add more transaction weight than we
can support inside of FeeFrac. Gate more aggressively using
WITNESS_SCALE_FACTOR.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 17/100

This is a small fix to a Bitcoin Core fuzz test (an automated testing harness, not production code). The test was using an outdated size check after the real mempool code switched from measuring transaction size in 'vsize' to measuring it in 'weight'. The change tightens a guard so the fuzzer stops adding transactions before hitting an internal integer limit. It does not change how real nodes handle transactions and is not a vulnerability in live Bitcoin Core.

Lower-priorityminer: replace "package" with "chunk"by Suhas Daftuar · 2d88966e · Nov 30, 2025 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Suhas Daftuar

miner: replace "package" with "chunk"

This makes the terminology consistent with other parts of the codebase, as part
of the cluster mempool implementation.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a simple renaming of internal function names and variables in Bitcoin Core's block-building code. It changes words like 'package' to 'chunk' to match terminology used elsewhere in the project. No behavior changes, no security fixes, and no bug fixes are visible in the code.

Lower-priorityAdd a GetFeePerVSize() accessor to CFeeRate, and use it in the BlockAssemblerby Suhas Daftuar · 6f3e8eb3 · Nov 30, 2025 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

Add a GetFeePerVSize() accessor to CFeeRate, and use it in the BlockAssembler

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a small code cleanup change. It adds a new accessor method to retrieve a fee rate and uses it in one place when building blocks. There is no security-relevant change visible in the diff.

Lower-priorityUse cluster size limit instead of ancestor size limit in txpackage unit testby Suhas Daftuar · 1dac54d5 · Nov 30, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Suhas Daftuar

Use cluster size limit instead of ancestor size limit in txpackage unit test

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This is a one-line change inside a Bitcoin Core unit test file. It updates a test assertion to use the newer 'cluster size limit' constant instead of the older 'ancestor size limit' constant when checking that a deliberately oversized placeholder transaction is recognized as too large. The change only affects test code and does not alter any production behavior, network rules, or security logic.

Lower-priorityUse cluster size limit instead of ancestor/descendant size limits when sanity checking TRUC policy limitsby Suhas Daftuar · 04f65488 · Nov 30, 2025 · 1 fileMessage 50 · ThinInformational 18Details
Commit message · Suhas Daftuar

Use cluster size limit instead of ancestor/descendant size limits when sanity checking TRUC policy limits

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100

This is a tiny code-comment and compile-time sanity-check update in Bitcoin Core's TRUC transaction policy. It changes which default mempool limit is referenced in a static_assert, switching from ancestor/descendant size limits to the newer cluster size limit. There is no runtime behavior change, no bug fix for active code, and no disclosed security relevance.

Lower-priorityRemove ancestor and descendant vsize limits from MemPoolLimitsby Suhas Daftuar · fc18ef1f · Nov 30, 2025 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

Remove ancestor and descendant vsize limits from MemPoolLimits

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit removes two size-based controls from Bitcoin Core's memory pool (mempool) settings: the maximum virtual-byte size of an ancestor package and of a descendant package. It is a code cleanup that follows earlier work to replace those limits with a single 'cluster size' limit. There is no indication in the commit that this fixes a security bug; it appears to be a refactoring change.

Lower-priorityRemove unused DEFAULT_ANCESTOR_SIZE_LIMIT_KVB and DEFAULT_DESCENDANT_SIZE_LIMIT_KVBby Suhas Daftuar · b5f245f6 · Nov 30, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Suhas Daftuar

Remove unused DEFAULT_ANCESTOR_SIZE_LIMIT_KVB and DEFAULT_DESCENDANT_SIZE_LIMIT_KVB

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply deletes two unused constant definitions from a header file. These constants were leftover default values for mempool ancestor and descendant size limits. They had no effect on running code because nothing referenced them. There is no security issue.

Lower-priorityUse cluster limits instead of ancestor/descendant limits when sanity checking package policy limitsby Suhas Daftuar · 634291a7 · Nov 30, 2025 · 1 fileMessage 50 · ThinLow 26Details
Commit message · Suhas Daftuar

Use cluster limits instead of ancestor/descendant limits when sanity checking package policy limits

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 26/100

This commit updates internal compile-time sanity checks for Bitcoin Core's package transaction limits. It replaces checks based on older 'ancestor/descendant' mempool limits with checks based on newer 'cluster' limits. The change is defensive: it ensures that when users submit groups (packages) of related transactions, the configured limits won't accidentally reject transactions that should be acceptable. There is no direct evidence in the commit that this fixes an active security bug or vulnerability.

Lower-priorityWarn user if using -limitancestorsize/-limitdescendantsize that the options have no effectby Suhas Daftuar · ed8e8191 · Nov 30, 2025 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · Suhas Daftuar

Warn user if using -limitancestorsize/-limitdescendantsize that the options have no effect

Also update the help text for -limitancestorcount/-limitdescendantcount to
explain they no longer affect the mempool, and are only used by the wallet for
coin selection.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This commit only changes help text and adds warning messages for two command-line options that no longer affect how Bitcoin Core handles transactions. It does not fix a security bug, change network behavior, or introduce a vulnerability. It is a user-facing cleanup to prevent confusion after an earlier redesign replaced ancestor/descendant size limits with new cluster limits.

Lower-priorityInvoke removeUnchecked() directly in removeForBlock()by Suhas Daftuar · 80d8df2d · Nov 30, 2025 · 1 fileMessage 50 · ThinInformational 16Details
Commit message · Suhas Daftuar

Invoke removeUnchecked() directly in removeForBlock()

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100

This commit simplifies how Bitcoin Core removes transactions from the memory pool when they are included in a newly mined block. It replaces a small two-step staging process with a direct call to the underlying removal function. The change appears to be a straightforward code cleanup with no obvious security impact, though it removes a thin abstraction layer that previously ensured removal events were recorded consistently.

AI review queuedRewrite GetChildren without setsby Suhas Daftuar · 9292570f · Nov 30, 2025 · 1 fileMessage 35 · OpaqueInformational 11Details
Commit message · Suhas Daftuar

Rewrite GetChildren without sets

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 11/100

This is a small internal code cleanup in Bitcoin Core's transaction memory pool. It rewrites a helper function called GetChildren so that it no longer builds a temporary set to remove duplicate child transactions; instead it uses a lightweight 'epoch' marker to skip duplicates. There is no user-facing change, no bug fix, and no security-relevant behavior change visible in the diff.

Lower-priorityRewrite removeForReorg to avoid using setsby Suhas Daftuar · 3e39ea8c · Nov 30, 2025 · 2 filesMessage 90 · StrongLow 31Details
Commit message · Suhas Daftuar

Rewrite removeForReorg to avoid using sets

Also improve test coverage for removeForReorg by creating a scenario where
there are in-mempool descendants that are only invalidated due to an in-mempool
parent no longer spending a mature coin.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
defensive validation
AI analysis · Low 31/100

This Bitcoin Core commit rewrites the mempool cleanup logic that runs during blockchain reorganizations. It replaces an older set-based approach with a newer graph-based method for finding all transactions that must be removed because an ancestor became invalid. The change also adds a test for a tricky edge case where a transaction's child is only invalidated because its parent no longer spends a mature coinbase output. The commit itself does not describe a security bug, but the rewrite touches consensus-adjacent mempool code and improves test coverage for a previously untested scenario.

AI review queuedSimplify removeRecursiveby Suhas Daftuar · a5a7905d · Nov 30, 2025 · 2 filesMessage 18 · OpaqueLow 26Details
Commit message · Suhas Daftuar

Simplify removeRecursive

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 26/100

This commit refactors how Bitcoin Core removes a transaction and all of its dependent transactions from the memory pool (mempool). It replaces an older, more manual descendant-finding method with a newer graph-based helper. The change is described as a simplification. There is no direct evidence in the commit that this fixes a security bug, but any change to mempool removal logic carries a small risk of introducing or masking consistency issues.

Lower-priorityscripted-diff: rename AddToMempool -> TryAddToMempoolby Suhas Daftuar · a3c31dfd · Nov 30, 2025 · 17 filesMessage 83 · StrongInformational 15Details
Commit message · Suhas Daftuar

scripted-diff: rename AddToMempool -> TryAddToMempool

-BEGIN VERIFY SCRIPT-
find src/test -type f -exec sed -i 's/AddToMempool/TryAddToMempool/g' {} +
find src/bench -type f -exec sed -i 's/AddToMempool/TryAddToMempool/g' {} +
-END VERIFY SCRIPT-

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit is a simple automated rename of a test helper function from AddToMempool to TryAddToMempool across test and benchmark files. It does not change any behavior, logic, or security properties of the Bitcoin Core software. The function body remains identical and the change only affects internal test/bench code, not production network code.