Bitcoin Core

args: extract lock-requiring internal helpers

Extract GetSetting_(), GetArgFlags_(), and GetPathArg_() as private
lock-held helpers with EXCLUSIVE_LOCKS_REQUIRED(cs_args) annotations.
Public methods delegate to these after acquiring the lock.

Annotate GetDataDir() with EXCLUSIVE_LOCKS_REQUIRED(cs_args) and move
its lock acquisition into GetDataDirBase()/GetDataDirNet().

Annotate logArgsPrefix() with EXCLUSIVE_LOCKS_REQUIRED(cs_args).

This is a pure refactoring with no behavior change, preparing for
the conversion of cs_args from RecursiveMutex to Mutex.

args: replace cs_args RecursiveMutex with Mutex

Replace the RecursiveMutex with a plain Mutex now that all recursive
lock acquisitions have been eliminated in the preceding commits.

Add EXCLUSIVE_LOCKS_REQUIRED(!cs_args) negative capability annotations
to all public and protected methods that acquire cs_args, following the
pattern established in prior RecursiveMutex conversions (e.g. CAddrMan,
CBlockPolicyEstimator).

test: scope cs_args locks to avoid recursive locking

Restructure argsman tests to use scoped LOCK(cs_args) blocks only
around direct protected member access (m_settings, m_network), keeping
public method calls outside lock scopes. This avoids recursive lock
acquisitions that would deadlock with a non-recursive Mutex.

- util_ParseParameters: scope locks around m_settings checks
- util_GetBoolArg: scope lock around m_settings size check
- util_ReadConfigStream: scope lock around m_settings checks
- util_GetArg: scope lock around m_settings writes
- util_ArgsMerge: use SelectConfigNetwork() instead of m_network
- util_ChainMerge: remove unnecessary lock

args: eliminate all recursive locking of cs_args

In methods that already hold cs_args, replace public method calls with
their lock-held private counterparts:

- ParseParameters: GetArgFlags() -> GetArgFlags_()
- GetBlocksDirPath: IsArgSet()/GetPathArg()/GetDataDirBase() ->
GetSetting_()/GetPathArg_()/GetDataDir()
- ReadSettingsFile: GetArgFlags() -> GetArgFlags_()
- SoftSetArg: IsArgSet()/ForceSetArg() -> GetSetting_()/direct write
- CheckMultipleCLIArgs: IsArgSet() -> GetSetting_()
- logArgsPrefix: GetArgFlags() -> GetArgFlags_()
- ReadConfigStream: GetArgFlags() -> GetArgFlags_()
- ReadConfigFiles: GetPathArg() -> GetPathArg_()

No behavior change. This eliminates all recursive lock acquisitions,
preparing for the conversion of cs_args from RecursiveMutex to Mutex.

args: make most ArgsManager members private

Move the first `protected` block (struct Arg, cs_args, m_settings, and
all other member variables) to `private`. Only `ReadConfigStream` and
`ReadConfigString` remain `protected` for test access.

Changes:
- Move `ReadConfigString` from `TestArgsManager` into `ArgsManager`
itself (declared in args.h, defined in config.cpp) so tests no longer
need direct access to `cs_args` or `m_settings` for config parsing.
- Replace test-only `SetNetworkOnlyArg` helper with the existing
`NETWORK_ONLY` flag passed through `SetupArgs`/`AddArg`.
- Remove `TestArgsManager` constructor that cleared
`m_network_only_args`.
- Remove `using` declarations for `cs_args`, `m_settings`, `GetSetting`,
and `GetSettingsList` from `TestArgsManager`.
- Clear `m_config_sections` in `ClearArgs()`.

Co-authored-by: Anthony Towns <aj@erisian.com.au>

Remove Taproot activation height

Drop DEPLOYMENT_TAPROOT from consensus.vDeployments.

Bump MinBIP9WarningHeight.

Clarify what is considered a BuriedDeployment and
drop taproot from getdeploymentinfo RPC.

Add a test to getblocktemplate to ensure the taproot
rule is still set.

Co-Authored-By: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>

doc: update build guides pre v31

We are testing on FreeBSD 15 (nightly) and macOS 26 (CI).

fuzz: register PeerManager in process_message(s)

This lets CValidationInterface callbacks be hit. Also remove
no-op SyncWithValidationInterfaceQueue since there are no validation
interfaces registered in ResetChainman.

Fix compatibility with `-debuglogfile` command-line option

This change avoids hardcoding the "debug.log" filename, ensuring
compatibility with custom filenames provided via the `-debuglogfile`
command-line option.

ci: remove TODOs from retry

TODOs are good targets for LLMs to generate PRs. Remove these TODOs,
which aren't needed, to prevent that.

ci: use latest versions of lint deps

Use the latest available versions, except for LIEF, which is
changed with Guix.

test: Scale feature_dbcrash.py timeout with factor

This allows to run the test under valgrind:

./bld-cmake/test/functional/feature_dbcrash.py --timeout-factor=10 --valgrind

For testing, the same test can be run multiple times in parallel:

./bld-cmake/test/functional/test_runner.py -j 10 $( printf 'feature_dbcrash.py %.0s' {1..10} ) --timeout-factor=10 --valgrind

(Running the test under valgrind may take several hours!)

I found that before this commit, 9 out of the 10 runs failed via:

```
...
TestFramework (INFO): Iteration 36, generating 2500 transactions [11, 5, 6]
TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
File "/b-c/test/functional/test_framework/test_framework.py", line 142, in main
self.run_test()
~~~~~~~~~~~~~^^
File "/b-c/bld-cmake/test/functional/feature_dbcrash.py", line 262, in run_test
self.sync_node3blocks(block_hashes)
~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
File "/b-c/bld-cmake/test/functional/feature_dbcrash.py", line 151, in sync_node3blocks
nodei_utxo_hash = self.restart_node(i, block_hash)
File "/b-c/bld-cmake/test/functional/feature_dbcrash.py", line 102, in restart_node
raise AssertionError(f"Unable to successfully restart node {node_index} in allotted time")
AssertionError: Unable to successfully restart node 0 in allotted time
```

With this commit, all 10 runs passed.

depends: link to upstream qt issue

Follows up to:
https://github.com/bitcoin/bitcoin/pull/34650#discussion_r2837726376.

https://qt-project.atlassian.net/browse/QTBUG-144864

test: Add NodeClockContext

This makes it easier to use mock-time in tests. Also, it resets the
global mocktime, so that no state is leaked between test cases.

fuzz: Use NodeClockContext

This refactor does not change any behavior.

However, it is nice to know that no global mocktime leaks from the fuzz
init step to the first fuzz input, or from one fuzz input execution to
the next.
With the clock context, the global is re-set at the end of the context.

qt: 31.0 translations update

test: Remove fixed TODO in address_to_scriptpubkey

doc: update http worker thread names

After using `Threadpool` for HTTP server in PR 33689, the previously
documented HTTP worker thread names are outdated. This commit makes
the corresponding changes to document new names for the HTTP worker
threads. Below is the output from the `thead list` command after
attaching `lldb` to `bitcoind`.

```zsh
thread #3: tid = 0xfe551, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_0'
thread #4: tid = 0xfe552, 0x00007ff80e3536f6 libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'b-http_pool_1'
```

guix: Make guix-clean less destructive

* Show preview and ask for confirmation before git clean unless used with "--force"
* Error out when trying to pass args such as "guix-clean --help"

validation: do not add the snapshot block to candidates of bg chainstate

The snapshot block needs to be added to the candidates set of the
assumed-valid chain because it will be the tip of that chainstate
right after snapshot activation.
However, adding it also to the background chainstate is not necessary
for anything. Before, the index would linger in the set without being
connectable. It will be eventually added to the set as part of the
normal block download - no extra logic is necessary here.

walletdb: hash pubkey/privkey in one shot to avoid leaking secret data

Avoid storing the privkey in a vector, which could linger in memory
and potentially leak sensitive data. An alternative approach is to
use `secure_allocator` for the `std::vector` instances, but this
commit has the advantage of also deduplicating code at the same shot.

Thanks to @theuni for suggesting this.

refactor: improve benchmark setup and execution for various tests

Note that `make_hard_case` already clears the UTXO pool in `coin_selection.cpp`.

./build/bin/bench_bitcoin -filter='^(BnBExhaustion|AddrManAddThenGood|DeserializeBlockTest|DeserializeAndCheckBlockTest|CheckBlockTest|LoadExternalBlockFile|FindByte|WalletCreatePlain|WalletCreateEncrypted|WalletLoadingDescriptors)$'

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 15,088,500.00 | 66.28 | 0.2% | 0.17 | `AddrManAddThenGood`
| 179,208.00 | 5,580.11 | 2.0% | 0.00 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 318,166.00 | 3,143.01 | 3.5% | 0.00 | `CheckBlockTest`
| 886,750.00 | 1,127.71 | 0.8% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 42.00 | 23,809,523.81 | 2.4% | 0.00 | `FindByte`
| 5,473,208.00 | 182.71 | 0.4% | 0.06 | `LoadExternalBlockFile`
| 584,168,041.00 | 1.71 | 0.3% | 6.43 | `WalletCreateEncrypted`
| 168,040,458.00 | 5.95 | 1.1% | 1.85 | `WalletCreatePlain`
| 155,446,625.00 | 6.43 | 0.7% | 0.78 | `WalletLoadingDescriptors`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 14,894,917.00 | 67.14 | 0.3% | 0.16 | `AddrManAddThenGood`
| 177,667.00 | 5,628.51 | 1.3% | 0.00 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 313,791.00 | 3,186.83 | 3.8% | 0.00 | `CheckBlockTest`
| 888,208.00 | 1,125.86 | 0.7% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 41.00 | 24,390,243.90 | 2.4% | 0.00 | `FindByte`
| 5,445,208.00 | 183.65 | 1.0% | 0.06 | `LoadExternalBlockFile`
| 581,800,500.00 | 1.72 | 0.4% | 6.40 | `WalletCreateEncrypted`
| 166,035,583.00 | 6.02 | 0.5% | 1.82 | `WalletCreatePlain`
| 153,574,792.00 | 6.51 | 0.1% | 0.77 | `WalletLoadingDescriptors`

bench: add fluent API for untimed setup steps in `nanobench`

Some benchmarks need per-epoch state reset so every measured run does the same work.
Add `Bench::setup(...).run(...)` for untimed per-epoch setup.
The existing `run()` now delegates to `runImpl()` with an empty setup lambda, keeping the old API unchanged.

This vendors the upstream change from `martinus/nanobench`.
The upstream PR also adds tests that verify setup is excluded from timing and runs once before each epoch's iterations.
Those tests are not copied here because wiring them into `src/bench/nanobench.h` outside the benchmarking setup would be awkward.

The `Default is 1ms, so we are mostly relying ...` comment update matches current upstream `nanobench` master.

-------

Running a few benchmarks (which will be migrated in the next commit to use the new setup method) several times to showcase the spread:

./build/bin/bench_bitcoin -filter='^(BnBExhaustion|AddrManAddThenGood|DeserializeBlockTest|DeserializeAndCheckBlockTest|CheckBlockTest|LoadExternalBlockFile|FindByte|WalletCreatePlain|WalletCreateEncrypted|WalletLoadingDescriptors)$'

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 26,400,542.00 | 37.88 | 0.4% | 0.29 | `AddrManAddThenGood`
| 189,075.00 | 5,288.91 | 0.4% | 0.01 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 1,237,000.00 | 808.41 | 2.4% | 0.01 | `DeserializeAndCheckBlockTest`
| 893,333.00 | 1,119.40 | 0.6% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 31.62 | 31,622,370.70 | 0.2% | 0.01 | `FindByte`
| 5,506,875.00 | 181.59 | 1.4% | 0.06 | `LoadExternalBlockFile`
| 593,480,333.00 | 1.68 | 0.4% | 6.53 | `WalletCreateEncrypted`
| 174,305,167.00 | 5.74 | 0.7% | 1.93 | `WalletCreatePlain`
| 160,833,875.00 | 6.22 | 0.2% | 0.80 | `WalletLoadingDescriptors`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 26,005,125.00 | 38.45 | 1.3% | 0.29 | `AddrManAddThenGood`
| 181,909.67 | 5,497.23 | 0.1% | 0.01 | `BnBExhaustion`

| ns/block | block/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 1,223,000.00 | 817.66 | 2.8% | 0.01 | `DeserializeAndCheckBlockTest`
| 892,917.00 | 1,119.92 | 0.7% | 0.01 | `DeserializeBlockTest`

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 31.58 | 31,660,608.70 | 0.5% | 0.01 | `FindByte`
| 5,612,750.00 | 178.17 | 1.1% | 0.06 | `LoadExternalBlockFile`
| 594,012,250.00 | 1.68 | 0.2% | 6.53 | `WalletCreateEncrypted`
| 174,668,334.00 | 5.73 | 0.8% | 1.92 | `WalletCreatePlain`
| 158,494,375.00 | 6.31 | 0.3% | 0.79 | `WalletLoadingDescriptors`

Bugfix: GUI/Intro: Handle errors from SelectParams the same as if during InitConfig

Without this, invalid vbparams just silently exit with no message

build: bump to 31.99