Bitcoin Core

This commit is a simple cleanup: it removes extra line-break characters from the ends of log messages in the Tor control code. Modern logging functions already add their own line breaks, so the old manual ones were creating blank lines in log files. There is no security issue here.

This commit is a pure code cleanup: it renames variables in Bitcoin Core's Tor control module to follow the project's modern naming style (adding 'm_' prefixes to member variables and using snake_case for local names). No behavior, logic, or security properties of the code are changed.

This commit is a straightforward code cleanup in Bitcoin Core's Tor control module. It changes several constant variable declarations from 'static const' to 'constexpr' for integer and float values. This is a non-functional style/refactoring change with no security relevance.

This is a small internal cleanup in Bitcoin Core's lock-tracking code. It swaps the standard C++ mutex for a project-specific wrapper (StdMutex) and adds compile-time annotations that tell the compiler which data structures are protected by the mutex. There is no change to network behavior, consensus rules, or user-facing functionality, and no security bug is being fixed.

This commit is a purely mechanical rename in Bitcoin Core's logging code. It replaces the old name 'StdLockGuard scoped_lock' with a shorter macro name 'STDLOCK' everywhere it appears. The actual locking behavior is unchanged, so there is no security impact.

This commit adds compiler hints about which locks must not be held when calling two logging helper functions. It does not change any actual code behavior, memory layout, or runtime logic. The change helps automated tools detect potential future threading mistakes during development, but it does not fix an active bug by itself.

This commit tightens a compile-time safety check in Bitcoin Core's custom mutex wrapper. It adds a macro called STDLOCK() that, when used, asks the compiler to verify the same lock is not being acquired twice in a row by the same thread. It does not change runtime behavior or fix an active exploit; it is a defensive hardening change to catch a specific programming mistake during compilation.

This commit fixes a small user-interface bug in Bitcoin Core's Qt wallet GUI. When the user turns on 'privacy mode' (the 'mask values' checkbox that hides balances), then switches to a different wallet, the 'History' button was incorrectly staying enabled. Clicking it would reveal the transaction list for the newly selected wallet, defeating the intended privacy setting. The fix makes the transaction view stay disabled when privacy mode is active during a wallet switch. It is a local, UI-only information-disclosure issue that requires the attacker to already have access to the unlocked GUI and the ability to switch wallets.

This commit is a routine maintenance update for the project's automated code-quality tooling. It upgrades the Include-What-You-Use (IWYU) static-analysis tool from version 0.21 to 0.26 to match Clang 22, refreshes the tool's internal header-mapping patch, removes now-unnecessary workarounds, and adds or removes a few C++ standard-library #include lines in two source files so the code continues to pass the updated analyzer. There is no change to Bitcoin Core's runtime behavior, consensus logic, networking, wallet handling, or any user-facing feature.

A single missing semicolon in Bitcoin Core's wallet coin-selection code caused a comparison to run before an assignment. As a result, the variable that was supposed to hold the total available amount instead held just true or false. The code still mostly worked by accident, but the wrong value could mislead the wallet's decision about whether it has enough funds, especially when unconfirmed transactions with long chains are involved. This could lead to confusing error messages or, in edge cases, incorrect transaction creation.

This commit only updates the help text for the generateblock command in Bitcoin Core. It adds a note explaining that the command does not collect transaction fees in the block reward. There is no code behavior change, no bug fix, and no security issue.

This commit is a routine cleanup of Bitcoin Core's GitHub Actions CI configuration for Windows builds. It switches the build from using a standalone vcpkg installation to the one that comes bundled with Visual Studio, matching the project's own documentation. The change only affects internal continuous-integration tooling and does not alter the Bitcoin Core software that users run.

This commit is a simple code cleanup in Bitcoin Core's test suite. It moves a small helper function that creates a mining test object from two individual test files into a shared utility file, so the same code isn't duplicated. There is no change to the actual Bitcoin node software, no change to how tests behave, and no security relevance.

This commit only adjusts timeout values in a single automated test file. It makes the test wait longer under slow CI conditions to avoid false failures. There is no change to the actual Bitcoin Core software that users run, and no security issue is present.

This commit only adds a new automated test and a small test helper. It checks that the Bitcoin Core IPC mining server returns a clean error when given invalid data, instead of crashing. There is no change to production code, so it does not introduce or fix a live security vulnerability by itself.

This commit adds a new automated test to Bitcoin Core. It checks that a mining-related function called createNewBlock() wakes up quickly when a new block is submitted, instead of waiting for an internal cooldown timer. There is no code change to the actual Bitcoin node software—only a new test in the test suite.

This is a code cleanup change only. It tells the Include What You Use (IWYU) tool that the project's main synchronization header (`sync.h`) re-exports another header (`threadsafety.h`), so other files don't need to include both. No program behavior changes, no security fix.

This is a minor code cleanup and documentation change. It replaces direct includes of the standard C++ time library (`<chrono>`) in two files with a project-specific header (`util/time.h`) and adds a comment explaining that `util/time.h` is intended as a drop-in replacement for `<chrono>`. There is no functional code change and no security impact.

This commit only adds documentation to the developer notes. It explains when and why developers may use a specific code-comment directive (`IWYU pragma: export`) for header files. There is no code change, no bug fix, and no security relevance.

This commit only adds a comment explaining how two source-code files relate to each other. It does not change any program behavior, fix a bug, or alter executable code.

This commit is a simple code reorganization: it moves two helper classes (StdMutex and StdLockGuard) from one header file to a new header file and updates which files include them. There is no change to how the code behaves, no bug fix, and no security-related change.

This commit changes how Bitcoin Core's Windows continuous-integration builds select a release-only configuration for vcpkg dependencies. It replaces a workaround that patched vcpkg's source code with a built-in triplet name. There is no security-relevant change to the software users run.

This commit removes a temporary build-system workaround for the Windows CI pipeline. The workaround forced an older CMake compatibility setting when compiling a dependency (libevent) through the vcpkg package manager. Microsoft has now fixed the underlying issue upstream, so Bitcoin Core no longer needs the local override. There is no change to Bitcoin Core's runtime code, consensus rules, wallet handling, or network behavior.

This is a build-system fix for people who compile Bitcoin's dependency Qt on a Mac but intend to run it on Windows. It swaps a wrong variable (host_os) for the correct one (build_os) and turns off two Apple-specific version checks that do not apply when the final target is Windows. There is no indication this changes runtime behavior or fixes a security vulnerability.

This commit only changes Bitcoin Core's internal test and benchmark code. It replaces an older way of faking the system clock during tests (SetMockTime) with a newer helper object (NodeClockContext). No production code is touched, so this cannot affect real users, wallets, or the live network.