AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

Merge PR 'Document that P2PKH weight assumes compressed public keys' (#5329)

Public commit record

What the developer wrote

Authored by Matt Corallo

81/100 · Strong
Merge PR 'Document that P2PKH weight assumes compressed public keys' (#5329)

from bot/5198-bound-p2pkh-input-weight-for-unc-45b6a6 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5329
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change only adds a documentation comment explaining that a helper function for creating old-style P2PKH Bitcoin outputs assumes the public key is compressed (33 bytes). The actual code behavior is unchanged; the patch simply warns callers not to use this helper for uncompressed (65-byte) public keys because the resulting transaction fee estimate would be too low. There is no code fix or behavior change.

Recommended action

No immediate action required. Developers using this API should ensure they only pass compressed public keys when relying on the returned satisfaction_weight for fee estimation. Consider adding a runtime check or separate constructor for uncompressed keys if misuse is a concern.

Security signals we found

01

Documentation-only change with no code logic modification

02

Clarifies existing assumption about compressed public keys in P2PKH input weight estimation

03

No patch to behavior; potential underestimation of transaction weight remains if callers misuse the API

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 2/15
Confidence 9/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.