Update changelog and remove manually_accept references
What the developer wrote
Authored by elnosh
Update changelog and remove manually_accept references
What changed, and why it matters
This is a small documentation and test cleanup commit. It removes leftover references to a 'manually_accept_inbound_channels' configuration option from two test files and a pending changelog entry. There is no code behavior change and no security fix or vulnerability present in the diff.
No security action needed. This is a non-functional cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit updates two Rust test files to stop constructing a manually_accept_config that is no longer needed, passing None instead. It also edits a pending changelog file to remove wording about manually_accept_inbound_channels being false/true and instead describes the general accept_inbound_channel() API for V2 channels. No functional code is modified.
Changed components
lightning/src/ln/async_signer_tests.rslightning/src/ln/priv_short_conf_tests.rspending_changelog/3137-accept-dual-funding-without-contributing.txtInspect captured patch +4 / −9
diff --git a/lightning/src/ln/async_signer_tests.rs b/lightning/src/ln/async_signer_tests.rs
index 7d28a13..04bca52 100644
--- a/lightning/src/ln/async_signer_tests.rs
+++ b/lightning/src/ln/async_signer_tests.rs
@@ -372,11 +372,9 @@ fn test_funding_signed_0conf() {
fn do_test_funding_signed_0conf(signer_ops: Vec<SignerOp>) {
// Simulate acquiring the signature for `funding_signed` asynchronously for a zero-conf channel.
- let mut manually_accept_config = test_default_channel_config();
-
let chanmon_cfgs = create_chanmon_cfgs(2);
let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
- let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(manually_accept_config)]);
+ let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
let node_a_id = nodes[0].node.get_our_node_id();
let node_b_id = nodes[1].node.get_our_node_id();
diff --git a/lightning/src/ln/priv_short_conf_tests.rs b/lightning/src/ln/priv_short_conf_tests.rs
index 9d30d74..a5ccac7 100644
--- a/lightning/src/ln/priv_short_conf_tests.rs
+++ b/lightning/src/ln/priv_short_conf_tests.rs
@@ -1396,9 +1396,7 @@ fn test_connect_before_funding() {
let chanmon_cfgs = create_chanmon_cfgs(2);
let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
- let mut manually_accept_conf = test_default_channel_config();
-
- let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, Some(manually_accept_conf)]);
+ let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
let node_a_id = nodes[0].node.get_our_node_id();
let node_b_id = nodes[1].node.get_our_node_id();
diff --git a/pending_changelog/3137-accept-dual-funding-without-contributing.txt b/pending_changelog/3137-accept-dual-funding-without-contributing.txt
index 9ea8de2..5e1d0de 100644
--- a/pending_changelog/3137-accept-dual-funding-without-contributing.txt
+++ b/pending_changelog/3137-accept-dual-funding-without-contributing.txt
@@ -7,9 +7,8 @@
differentiate between an inbound request for a dual-funded (V2) or non-dual-funded (V1) channel to be
opened, with value being either of the enum variants `InboundChannelFunds::DualFunded` and
`InboundChannelFunds::PushMsat(u64)` corresponding to V2 and V1 channel open requests respectively.
- * If `manually_accept_inbound_channels` is false, then V2 channels will be accepted automatically; the
- same behaviour as V1 channels. Otherwise, `ChannelManager::accept_inbound_channel()` can also be used
- to manually accept an inbound V2 channel.
+ * Similar to V1 channels, `ChannelManager::accept_inbound_channel()` can also be used
+ to accept an inbound V2 channel.
* 0conf dual-funded channels are not supported.
* RBF of dual-funded channel funding transactions is not supported.
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.