AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 64 Bitcoin

Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)

Public commit record

What the developer wrote

Authored by Matt Corallo

81/100 · Strong
Merge PR 'Refuse channel_ready while the initial funding_signed is pending' (#5612)

from auto-pr-bot/bot/268-channel_ready-before-async-fundi-11838c into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5612
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update fixes a corner case in the Lightning Dev Kit where a node could get confused if it received a 'channel_ready' message while still waiting for its own signer to produce the first commitment signature. The patch makes the node reject such premature messages and close the channel safely, preventing the counterparty's commitment point from advancing underneath an unsigned initial commitment.

Recommended action

Review and merge the patch; ensure async signer deployments run a version containing this fix. No immediate external advisory action is indicated beyond normal upgrade tracking.

Security signals we found

01

State-machine confusion between funding_signed and channel_ready in async signer flow

02

Premature channel_ready could advance counterparty_next_commitment_point before initial commitment is signed

03

Patch closes channel rather than allowing inconsistent commitment state

04

Regression test added for the async signer scenario

Risk score

Why this scored 64/100

Our methodology →
Potential impact 22/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.