AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 52 Bitcoin

Merge PR 'Ignore duplicate announcement_signatures' (#5529)

Public commit record

What the developer wrote

Authored by Matt Corallo

81/100 · Strong
Merge PR 'Ignore duplicate announcement_signatures' (#5529)

from auto-pr-bot/bot/207-bound-channel-handler-gossip-que-30dc42 into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5529
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change prevents a Lightning node from repeatedly broadcasting the same channel announcement if a peer keeps replaying a specific protocol message (announcement_signatures). Before the fix, a malicious or buggy peer could make the node generate and flood fresh channel_announcement broadcasts, wasting bandwidth and gossip buffer space across the network. The patch adds a flag so only the first processed announcement_signatures triggers a broadcast, with one deliberate exception after a node restart to preserve reliability.

Recommended action

Treat as a low-to-moderate hardening fix. Reviewers should confirm the flag is reset in all relevant channel state transitions (reconnect, closure, force-close) and consider whether persistence is desirable to also suppress the post-restart replay window.

Security signals we found

01

gossip amplification / bandwidth exhaustion via replayed protocol message

02

state tracking added to deduplicate announcement_signatures handling

03

ChannelError::Ignore used to drop duplicate instead of failing channel

04

new regression test describes counterparty replay scenario and mitigation

Risk score

Why this scored 52/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.