Add a quick TODO about merging cp- and locally-initiated splices
What the developer wrote
Authored by Matt Corallo
Add a quick TODO about merging cp- and locally-initiated splices
What changed, and why it matters
This commit only adds a code comment (a TODO note) suggesting future work on combining two types of channel funding updates. It changes no program logic, no data handling, and no security behavior. There is nothing here that could directly cause a bug or be exploited.
No action needed; this is a documentation-only TODO comment. Treat as normal code maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff inserts a single TODO comment in lightning/src/ln/channel.rs inside the interactive-tx/splicing path. It does not modify any statements, conditions, state machines, cryptographic operations, or memory handling. The comment merely records an idea to later merge counterparty-initiated and locally-initiated splice flows when a quiescent_action is already set. No security defect is introduced or fixed by this change.
Changed components
lightning/src/ln/channel.rsInspect captured patch +5 / −0
diff --git a/lightning/src/ln/channel.rs b/lightning/src/ln/channel.rs
index 1b0fdf0..12d3b53 100644
--- a/lightning/src/ln/channel.rs
+++ b/lightning/src/ln/channel.rs
@@ -11153,6 +11153,11 @@ where
})?;
debug_assert!(interactive_tx_constructor.take_initiator_first_message().is_none());
+ // TODO(splicing): if quiescent_action is set, integrate what the user wants to do into the
+ // counterparty-initiated splice. For always-on nodes this probably isn't a useful
+ // optimization, but for often-offline nodes it may be, as we may connect and immediately
+ // go into splicing from both sides.
+
let funding_pubkey = splice_funding.get_holder_pubkeys().funding_pubkey;
self.pending_splice = Some(PendingSplice {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.