Use zero splice min-depth in zero-conf splice reorg test
What changed, and why it matters
This commit only fixes a test that was failing because of a recent unrelated change. It does not change any production code or fix a security issue. The test now explicitly sets two new configuration knobs to zero so the test scenario behaves as originally intended.
No security action required. This is a test-only fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies a single Rust test, do_test_zero_conf_splice_stays_locked_when_unconfirmed, in lightning/src/ln/splicing_tests.rs. It sets channel_config.inbound_splice_min_depth = 0 and channel_config.outbound_splice_min_depth = 0 so the test’s zero-conf splice still sends splice_locked immediately after signing, matching the behavior expected by the test. The production behavior that introduced default min-depth values of 6 was already present; this change only aligns the test with that behavior.
Changed components
lightning/src/ln/splicing_tests.rsInspect captured patch +2 / −0
### lightning/src/ln/splicing_tests.rs
@@ -15192,6 +15192,8 @@ fn do_test_zero_conf_splice_stays_locked_when_unconfirmed(reorg_via_block_discon
let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
let mut config = test_default_channel_config();
config.channel_handshake_limits.trust_own_funding_0conf = true;
+ config.channel_config.inbound_splice_min_depth = 0;
+ config.channel_config.outbound_splice_min_depth = 0;
let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[Some(config.clone()), Some(config)]);
let nodes = create_network(2, &node_cfgs, &node_chanmgrs);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.