Bump transaction sync dev dependencies
What the developer wrote
Authored by Elias Rohrer
Bump transaction sync dev dependencies
What changed, and why it matters
This commit only updates test-only development dependencies and adjusts the corresponding test import paths. It does not change any production code, network behavior, or cryptographic logic, so it has no security relevance for users of the library.
No security action required; this is a routine test dependency update. Reviewers may verify the new dev dependencies build and tests pass on non-Windows platforms.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch bumps dev-dependencies in lightning-transaction-sync/Cargo.toml from electrsd 0.36.0/corepc-node 0.10.0 to electrsd 0.38/bitcoind 0.38, and updates integration_tests.rs to import BitcoinD, Conf, and downloaded_exe_path from the new bitcoind crate instead of electrsd::corepc_node. These are only used in integration tests under [target.’cfg(not(target_os = “windows”))’.dev-dependencies]. No runtime or consensus-critical code is modified.
Changed components
lightning-transaction-sync/tests/integration_tests.rslightning-transaction-sync/Cargo.toml dev-dependenciesInspect captured patch +6 / −6
diff --git a/lightning-transaction-sync/Cargo.toml b/lightning-transaction-sync/Cargo.toml
index 2c991cd..d504cd2 100644
--- a/lightning-transaction-sync/Cargo.toml
+++ b/lightning-transaction-sync/Cargo.toml
@@ -45,8 +45,8 @@ lightning = { version = "0.3.0", path = "../lightning", default-features = false
tokio = { version = "1.35.0", features = ["macros"] }
[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
-electrsd = { version = "0.36.0", default-features = false, features = ["legacy"] }
-corepc-node = { version = "0.10.0", default-features = false, features = ["28_0"] }
+electrsd = { version = "0.38", default-features = false, features = ["legacy"] }
+bitcoind = { version = "0.38", default-features = false, features = ["28_1"] }
[lints.rust.unexpected_cfgs]
level = "forbid"
diff --git a/lightning-transaction-sync/tests/integration_tests.rs b/lightning-transaction-sync/tests/integration_tests.rs
index 07b190a..a5b303f 100644
--- a/lightning-transaction-sync/tests/integration_tests.rs
+++ b/lightning-transaction-sync/tests/integration_tests.rs
@@ -18,8 +18,8 @@ use bitcoin::constants::genesis_block;
use bitcoin::network::Network;
use bitcoin::{Amount, BlockHash, Txid};
-use electrsd::corepc_node::Node as BitcoinD;
-use electrsd::{corepc_node, ElectrsD};
+use bitcoind::BitcoinD;
+use electrsd::ElectrsD;
use std::collections::{HashMap, HashSet};
use std::env;
@@ -28,10 +28,10 @@ use std::time::Duration;
pub fn setup_bitcoind_and_electrsd() -> (BitcoinD, ElectrsD) {
let bitcoind_exe =
- env::var("BITCOIND_EXE").ok().or_else(|| corepc_node::downloaded_exe_path().ok()).expect(
+ env::var("BITCOIND_EXE").ok().or_else(|| bitcoind::downloaded_exe_path().ok()).expect(
"you need to provide an env var BITCOIND_EXE or specify a bitcoind version feature",
);
- let mut bitcoind_conf = corepc_node::Conf::default();
+ let mut bitcoind_conf = bitcoind::Conf::default();
bitcoind_conf.network = "regtest";
let bitcoind = BitcoinD::with_conf(bitcoind_exe, &bitcoind_conf).unwrap();
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.