AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 59 Bitcoin

Merge PR 'Drop accepted closing_signed state on peer disconnection' (#5532)

Public commit record

What the developer wrote

Authored by Matt Corallo

81/100 · Strong
Merge PR 'Drop accepted closing_signed state on peer disconnection' (#5532)

from auto-pr-bot/bot/223-preserve-accepted-closing-signat-87d4ef into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5532
Reviewed-by: Matt Corallo <matt@noreply.git.rust-bitcoin.org>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a state-handling bug during Lightning channel close negotiations. If a user's signing device was slow or offline and the peer disconnected in the middle, the node could later combine an old accepted fee with a freshly proposed fee, potentially broadcasting an unintended closing transaction. The fix clears the stale 'closing_signed' state when the peer reconnects, forcing the negotiation to restart cleanly.

Recommended action

Review and merge if not already merged; backport to maintained release branches; consider audit of other async-signer pending states for similar reconnect cleanup gaps.

Security signals we found

01

State desynchronization across disconnect/reconnect in async signing path

02

Potential broadcast of closing tx with stale accepted fee

03

Missing reset of pending signer state on peer reconnection

04

Regression test added for reconnect-while-signer-blocked scenario

Risk score

Why this scored 59/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.