Apply MSRV dependency pins in the tor-connect CI job
What changed, and why it matters
This change is a build-system fix for the project's continuous integration (CI) testing. The tor-connect test job was not applying the project's minimum-supported Rust version (MSRV) dependency pins, which could cause CI test failures when newer dependency versions require newer Rust features. It is not a security patch for the Lightning protocol or library code.
No security action required. Treat as a normal CI reliability improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/workflows/build.yml and .forgejo/workflows/build.yml to source ci/ci-tests-common.sh before running the tor-connect cargo test job. This ensures the MSRV dependency pins (versions of crates compatible with Rust 1.75) are applied, preventing spurious CI failures. There is no change to application code, cryptography, networking logic, or any user-facing behavior.
Changed components
.github/workflows/build.yml.forgejo/workflows/build.ymlInspect captured patch +2 / −0
### .forgejo/workflows/build.yml
@@ -405,6 +405,7 @@ jobs:
if ! grep -q "Bootstrapped 100%" "$TOR_DATA/tor.log"; then
echo "tor failed to bootstrap within timeout:"; cat "$TOR_DATA/tor.log"; exit 1
fi
+ source ci/ci-tests-common.sh
TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio
notify-failure:
### .github/workflows/build.yml
@@ -348,6 +348,7 @@ jobs:
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
- name: Test tor connections using lightning-net-tokio
run: |
+ source ci/ci-tests-common.sh
TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio
notify-failure:Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.