AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Bitcoin

Merge PR 'Don't panic on splice txs confirming with empty witnesses' (#5536)

Public commit record

What the developer wrote

Authored by Matt Corallo

81/100 · Strong
Merge PR 'Don't panic on splice txs confirming with empty witnesses' (#5536)

from 2026-11-funding-splice-panic into main

Reviewed-on: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5536
Reviewed-by: jkczyz <jkczyz@noreply.git.rust-bitcoin.org>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a crash (panic) in the Lightning Dev Kit's channel handling code. Previously, the code assumed that any outbound funding transaction was built by the user, and it would panic if the transaction had an empty witness. Splice transactions are also outbound but are built internally, so the old assumption was wrong. The fix adds a check to only panic for user-built funding transactions, and instead return a normal processing error for internally-built splice transactions that don't match expectations.

Recommended action

Review whether the empty-witness check should still trigger a force-close or other defensive action for splice transactions, rather than silently allowing confirmation. Confirm that the new `is_user_built_funding` condition correctly covers all non-user-built outbound funding cases. Consider adding regression tests for splice transactions confirming with empty witnesses.

Security signals we found

01

Denial-of-service vector: unhandled panic on splice transaction confirmation

02

Incorrect invariant: `is_outbound()` assumed to mean user-built funding transaction

03

Crash-to-error conversion: panic replaced with graceful closure for splice paths

04

Witness validation bypass concern: empty witness no longer panics for splice txs

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.