← Watch feed
Explicitly state rust toolchain in forgejo actions
Public commit record
73/100 · Adequate
What the developer wrote
Authored by Matt Corallo
Explicitly state rust toolchain in forgejo actions
Forgejo doesn't expand env/matrix arguments in the names it prints
for steps in actions, so we have to be explicit. We also have a lot
of jobs where we really don't need an env indirection for two
lines that reference it.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
What changed, and why it matters
This commit is a cosmetic cleanup of CI workflow files. It replaces environment variables like TOOLCHAIN with the literal Rust version names (e.g., 'stable', 'beta', '1.75') in step titles and commands so that Forgejo's CI logs display meaningful names. No code behavior changes, no security fix or vulnerability introduced.
Recommended action
No security action needed. This is a routine CI readability/maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .forgejo/workflows/build.yml, .forgejo/workflows/check_commits.yml, and .forgejo/workflows/ci-build.yml. It removes env-level TOOLCHAIN definitions and inlines the toolchain values into step names and rustup default commands. In ci-build.yml, a matrix-driven job simply renames the install step to ‘Select Rust toolchain’. The effective toolchain selections remain identical, and no executable code, dependencies, or permissions are altered.
Changed components
.forgejo/workflows/build.yml.forgejo/workflows/check_commits.yml.forgejo/workflows/ci-build.ymlInspect captured patch +23 / −41
diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml
index fcc80d7..1278a38 100644
--- a/.forgejo/workflows/build.yml
+++ b/.forgejo/workflows/build.yml
@@ -147,14 +147,12 @@ jobs:
benchmark:
runs-on: debian-trixie
- env:
- TOOLCHAIN: stable
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust stable toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default stable
- name: Cache routing graph snapshot
id: cache-graph
uses: https://data.forgejo.org/actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
@@ -211,16 +209,14 @@ jobs:
check_release:
runs-on: debian-trixie
- env:
- TOOLCHAIN: stable
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
with:
fetch-depth: 0
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust stable toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default stable
- name: Run cargo check for release build.
run: |
cargo check --release
@@ -239,33 +235,29 @@ jobs:
check_docs:
runs-on: debian-trixie
- env:
- # While docs.rs builds using a nightly compiler (and we use some nightly features),
- # nightly ends up randomly breaking builds occasionally, so we instead use beta
- # and set RUSTC_BOOTSTRAP in check-docsrs.sh
- TOOLCHAIN: beta
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
with:
fetch-depth: 0
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ # While docs.rs builds using a nightly compiler (and we use some nightly features),
+ # nightly ends up randomly breaking builds occasionally, so we instead use beta
+ # and set RUSTC_BOOTSTRAP in check-docsrs.sh
+ - name: Install Rust beta toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default beta
- name: Simulate docs.rs build
run: ci/check-docsrs.sh
fuzz_sanity:
runs-on: debian-trixie
- env:
- TOOLCHAIN: 1.75
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust 1.75 toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
- - name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
+ rustup default 1.75
+ - name: Sanity check fuzz targets on Rust 1.75
run: |
cd fuzz
RUSTFLAGS="--cfg=fuzzing --cfg=secp256k1_fuzz --cfg=hashes_fuzz --cfg=chacha20_poly1305_fuzz" cargo test --quiet --color always --lib -j8
@@ -274,14 +266,12 @@ jobs:
fuzz:
runs-on: debian-trixie
- env:
- TOOLCHAIN: 1.75
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust 1.75 toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default 1.75
- name: Clone fuzzing corpus
run: git clone --depth=1 https://github.com/lightningdevkit/ldk-fuzzing-corpus.git fuzz/ldk-fuzzing-corpus
- name: Symlink corpus into hfuzz_workspace
@@ -350,14 +340,12 @@ jobs:
linting:
runs-on: debian-trixie
- env:
- TOOLCHAIN: stable
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust stable toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default stable
- name: Install clippy
run: |
rustup component add clippy
@@ -371,14 +359,12 @@ jobs:
rustfmt:
runs-on: debian-trixie
- env:
- TOOLCHAIN: 1.75.0
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust 1.75 toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default 1.75
- name: Install rustfmt
run: |
rustup component add rustfmt
@@ -390,14 +376,12 @@ jobs:
run: cd fuzz && cargo fmt --check
tor-connect:
runs-on: debian-trixie
- env:
- TOOLCHAIN: 1.75.0
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust 1.75 toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default 1.75
- name: Test tor connections using lightning-net-tokio
run: |
set -eu
diff --git a/.forgejo/workflows/check_commits.yml b/.forgejo/workflows/check_commits.yml
index 8502bc2..4778bd5 100644
--- a/.forgejo/workflows/check_commits.yml
+++ b/.forgejo/workflows/check_commits.yml
@@ -12,16 +12,14 @@ concurrency:
jobs:
check_commits:
runs-on: debian-trixie
- env:
- TOOLCHAIN: stable
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
with:
fetch-depth: 0
- - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+ - name: Install Rust stable toolchain
run: |
- rustup default ${{ env.TOOLCHAIN }}
+ rustup default stable
- name: Fetch full tree and rebase on upstream
run: |
git remote add upstream https://git.rust-bitcoin.org/lightningdevkit/rust-lightning
diff --git a/.forgejo/workflows/ci-build.yml b/.forgejo/workflows/ci-build.yml
index 5cf45de..d9a0329 100644
--- a/.forgejo/workflows/ci-build.yml
+++ b/.forgejo/workflows/ci-build.yml
@@ -28,7 +28,7 @@ jobs:
steps:
- name: Checkout source code
uses: https://data.forgejo.org/actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- - name: Install Rust ${{ matrix.toolchain }} toolchain
+ - name: Select Rust toolchain
run: |
rustup default ${{ matrix.toolchain }}
- name: Use rust-lld linker on Windows
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.