Drop unused `LSPS1OnchainPayment` type
What the developer wrote
Authored by Elias Rohrer
Drop unused `LSPS1OnchainPayment` type
What changed, and why it matters
This commit simply removes an unused data structure called LSPS1OnchainPayment from the rust-lightning codebase. There is no functional code change, no bug fix, and no security impact. It is a routine cleanup that deletes 12 lines of dead code.
No action required. This is a benign dead-code removal.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the LSPS1OnchainPayment struct from lightning-liquidity/src/lsps1/msgs.rs. The struct was not referenced elsewhere and had no associated logic. Removal is a non-functional refactor with no runtime or security effect.
Changed components
lightning-liquidity/src/lsps1/msgs.rsInspect captured patch +0 / −12
diff --git a/lightning-liquidity/src/lsps1/msgs.rs b/lightning-liquidity/src/lsps1/msgs.rs
index eae9568..6021b65 100644
--- a/lightning-liquidity/src/lsps1/msgs.rs
+++ b/lightning-liquidity/src/lsps1/msgs.rs
@@ -323,18 +323,6 @@ impl_writeable_tlv_based_enum!(LSPS1PaymentState,
(4, Refunded) => {}
);
-/// Details regarding a detected on-chain payment.
-#[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
-pub struct LSPS1OnchainPayment {
- /// The outpoint of the payment.
- pub outpoint: String,
- /// The amount of satoshi paid.
- #[serde(with = "string_amount")]
- pub sat: u64,
- /// Indicates if the LSP regards the transaction as sufficiently confirmed.
- pub confirmed: bool,
-}
-
/// Details regarding the state of an ordered channel.
#[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
pub struct LSPS1ChannelInfo {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.