AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 51 Bitcoin

bip39: fail if the callers requested language is not found

Public commit record

What the developer wrote

Authored by Jon Griffiths

50/100 · Thin
bip39: fail if the callers requested language is not found

Don't silently fall back to English.
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a behavior in the BIP39 (mnemonic seed phrase) code where, if a caller asked for a language that wasn't supported, the library would quietly give them the English wordlist instead of reporting an error. The patch makes the function return an error when the requested language is missing, and only default to English when no language is explicitly requested. This prevents silent mismatches between what the caller expects and what they get.

Recommended action

Review downstream callers of `bip39_get_wordlist()` to ensure they handle `WALLY_EINVAL` correctly and are not passing invalid language strings that previously worked due to silent fallback. Consider adding tests for unknown language handling.

Security signals we found

01

Silent fallback to default language could cause language/cross-check mismatches

02

Behavioral change from permissive fallback to explicit failure

03

Potential downstream impact if callers previously passed invalid language strings and relied on English fallback

04

No explicit security framing in commit message or diff

Risk score

Why this scored 51/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.