tx: add add tx_input_is_issuance/tx_is_input_issuance to determine issuance inputs
What changed, and why it matters
This commit adds two new helper functions that let callers ask whether a transaction input is an 'issuance' input on the Elements sidechain. It is a straightforward feature addition: it exposes existing internal data through a new API, mirroring an already-existing 'pegin' helper. There is no bug fix, no change to parsing rules, and no security-sensitive logic.
No security action required; review as normal feature/API addition.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch introduces wally_tx_input_is_issuance() and wally_tx_is_input_issuance(), plus language bindings (Java, Python ctypes tests, WASM JS/TS exports). The C implementation refactors wally_tx_input_is_pegin() into a shared elements_input_get_feature() helper that checks a feature flag on a valid Elements tx input, then uses it for both pegin and issuance. No memory handling, parsing, or cryptographic code is changed.
Changed components
src/transaction.cinclude/wally_transaction_members.hJava/SWIG bindingsWASM bindingsPython test utilitiesInspect captured patch +42 / −5
### include/wally_transaction_members.h
@@ -92,6 +92,7 @@ WALLY_CORE_API int wally_tx_get_num_outputs(const struct wally_tx *tx_in, size_t
/* Transaction Inputs */
+WALLY_CORE_API int wally_tx_input_is_issuance(const struct wally_tx_input *tx_in, size_t *written);
WALLY_CORE_API int wally_tx_input_is_pegin(const struct wally_tx_input *tx_in, size_t *written);
/**
@@ -131,6 +132,7 @@ WALLY_CORE_API int wally_tx_get_input_issuance_amount_rangeproof(const struct wa
WALLY_CORE_API int wally_tx_get_input_issuance_amount_rangeproof_len(const struct wally_tx *tx_in, size_t index, size_t *written);
WALLY_CORE_API int wally_tx_get_input_inflation_keys_rangeproof(const struct wally_tx *tx_in, size_t index, unsigned char *bytes_out, size_t len, size_t *written);
WALLY_CORE_API int wally_tx_get_input_inflation_keys_rangeproof_len(const struct wally_tx *tx_in, size_t index, size_t *written);
+WALLY_CORE_API int wally_tx_is_input_issuance(const struct wally_tx *tx_in, size_t index, size_t *written);
WALLY_CORE_API int wally_tx_is_input_pegin(const struct wally_tx *tx_in, size_t index, size_t *written);
WALLY_CORE_API int wally_tx_set_input_blinding_nonce(const struct wally_tx *tx_in, size_t index, const unsigned char *blinding_nonce, size_t blinding_nonce_len);
### src/swig_java/jni_elements_extra.java_in
@@ -261,13 +261,21 @@
return tx_elements_input_init(jarg1, jarg2, jarg3, jarg4, null, null, null, null, null, null, null, null);
}
+ public final static boolean tx_input_is_issuance(final Object tx_input) {
+ return _tx_input_is_issuance(tx_input) != 0;
+ }
+
public final static boolean tx_input_is_pegin(final Object tx_input) {
return _tx_input_is_pegin(tx_input) != 0;
}
// TODO: Remove this wrapper in favour of tx_input_is_pegin
public final static boolean tx_elements_input_is_pegin(final Object tx_input) {
- return tx_input_is_pegin(tx_input);
+ return _tx_input_is_pegin(tx_input) != 0;
+ }
+
+ public final static boolean tx_is_input_issuance(final Object tx, final long index) {
+ return _tx_is_input_issuance(tx, index) != 0;
}
public final static boolean tx_is_input_pegin(final Object tx, final long index) {
### src/swig_java/swig.i
@@ -1029,6 +1029,8 @@ static jobjectArray create_jstringArray(JNIEnv *jenv, char **p, size_t len) {
%returns_uint64(wally_tx_confidential_value_to_satoshi);
%returns_struct(wally_tx_elements_input_init_alloc, wally_tx_input);
%rename("tx_elements_input_init") wally_tx_elements_input_init_alloc;
+%rename("_tx_input_is_issuance") wally_tx_input_is_issuance;
+%returns_size_t(_tx_elements_input_is_issuance);
%rename("_tx_input_is_pegin") wally_tx_input_is_pegin;
%returns_size_t(_tx_elements_input_is_pegin);
%returns_void__(wally_tx_elements_input_issuance_set);
@@ -1062,6 +1064,8 @@ static jobjectArray create_jstringArray(JNIEnv *jenv, char **p, size_t len) {
%rename("_tx_get_input_inflation_keys_rangeproof") wally_tx_get_input_inflation_keys_rangeproof;
%returns_size_t(_tx_get_input_inflation_keys_rangeproof);
%returns_size_t(wally_tx_get_input_inflation_keys_rangeproof_len);
+%rename("_tx_is_input_issuance") wally_tx_is_input_issuance;
+%returns_size_t(_tx_is_input_issuance);
%rename("_tx_is_input_pegin") wally_tx_is_input_pegin;
%returns_size_t(_tx_is_input_pegin);
%rename("_tx_get_input_script") wally_tx_get_input_script;
### src/test/util.py
@@ -1039,6 +1039,7 @@ class wally_psbt(Structure):
('wally_tx_input_get_witness', c_int, [POINTER(wally_tx_input), c_size_t, c_void_p, c_size_t, c_size_t_p]),
('wally_tx_input_get_witness_len', c_int, [POINTER(wally_tx_input), c_size_t, c_size_t_p]),
('wally_tx_input_get_witness_num_items', c_int, [POINTER(wally_tx_input), c_size_t_p]),
+ ('wally_tx_input_is_issuance', c_int, [POINTER(wally_tx_input), c_size_t_p]),
('wally_tx_input_is_pegin', c_int, [POINTER(wally_tx_input), c_size_t_p]),
('wally_tx_input_set_blinding_nonce', c_int, [POINTER(wally_tx_input), c_void_p, c_size_t]),
('wally_tx_input_set_entropy', c_int, [POINTER(wally_tx_input), c_void_p, c_size_t]),
@@ -1051,6 +1052,7 @@ class wally_psbt(Structure):
('wally_tx_input_set_sequence', c_int, [POINTER(wally_tx_input), c_uint32]),
('wally_tx_input_set_txhash', c_int, [POINTER(wally_tx_input), c_void_p, c_size_t]),
('wally_tx_input_set_witness', c_int, [POINTER(wally_tx_input), POINTER(wally_tx_witness_stack)]),
+ ('wally_tx_is_input_issuance', c_int, [POINTER(wally_tx), c_size_t, c_size_t_p]),
('wally_tx_is_input_pegin', c_int, [POINTER(wally_tx), c_size_t, c_size_t_p]),
('wally_tx_output_get_asset', c_int, [POINTER(wally_tx_output), c_void_p, c_size_t]),
('wally_tx_output_get_asset_len', c_int, [POINTER(wally_tx_output), c_size_t_p]),
### src/transaction.c
@@ -2650,27 +2650,37 @@ int wally_tx_is_elements(const struct wally_tx *tx, size_t *written)
return WALLY_OK;
}
-int wally_tx_input_is_pegin(const struct wally_tx_input *tx_in, size_t *written)
+static int elements_input_get_feature(const struct wally_tx_input *tx_in,
+ size_t *written, uint32_t feature)
{
if (written)
*written = 0;
if (!tx_in || !written)
return WALLY_EINVAL;
- if (is_valid_elements_tx_input(tx_in) &&
- (tx_in->features & WALLY_TX_IS_PEGIN))
+ if (is_valid_elements_tx_input(tx_in) && (tx_in->features & feature))
*written = 1;
else
*written = 0;
return WALLY_OK;
}
+int wally_tx_input_is_issuance(const struct wally_tx_input *tx_in, size_t *written)
+{
+ return elements_input_get_feature(tx_in, written, WALLY_TX_IS_ISSUANCE);
+}
+
+int wally_tx_input_is_pegin(const struct wally_tx_input *tx_in, size_t *written)
+{
+ return elements_input_get_feature(tx_in, written, WALLY_TX_IS_PEGIN);
+}
+
/* TODO: Remove this deprecated call in favour of wally_tx_input_is_pegin */
int wally_tx_elements_input_is_pegin(const struct wally_tx_input *tx_in,
size_t *written)
{
- return wally_tx_input_is_pegin(tx_in, written);
+ return elements_input_get_feature(tx_in, written, WALLY_TX_IS_PEGIN);
}
int wally_tx_is_coinbase(const struct wally_tx *tx, size_t *written)
@@ -3296,6 +3306,11 @@ TX_GET_I_ELEMENTS(input, inflation_keys_rangeproof_len)
TX_GET_I_ELEMENTS(input, issuance_amount_len)
TX_GET_I_ELEMENTS(input, issuance_amount_rangeproof_len)
+int wally_tx_is_input_issuance(const struct wally_tx *tx, size_t index, size_t *written)
+{
+ return wally_tx_input_is_issuance(tx_get_input(tx, index), written);
+}
+
int wally_tx_is_input_pegin(const struct wally_tx *tx, size_t index, size_t *written)
{
return wally_tx_input_is_pegin(tx_get_input(tx, index), written);
### src/wasm_package/src/functions.js
@@ -735,6 +735,7 @@ export const tx_input_get_txhash = wrap('wally_tx_input_get_txhash', [T.OpaqueRe
export const tx_input_get_witness_len = wrap('wally_tx_input_get_witness_len', [T.OpaqueRef, T.Int32, T.DestPtr(T.Int32)]);
export const tx_input_get_witness_num_items = wrap('wally_tx_input_get_witness_num_items', [T.OpaqueRef, T.DestPtr(T.Int32)]);
export const tx_input_init = wrap('wally_tx_input_init_alloc', [T.Bytes, T.Int32, T.Int32, T.Bytes, T.OpaqueRef, T.DestPtrPtr(T.OpaqueRef)]);
+export const tx_input_is_issuance = wrap('wally_tx_input_is_issuance', [T.OpaqueRef, T.DestPtr(T.Int32)]);
export const tx_input_is_pegin = wrap('wally_tx_input_is_pegin', [T.OpaqueRef, T.DestPtr(T.Int32)]);
export const tx_input_set_blinding_nonce = wrap('wally_tx_input_set_blinding_nonce', [T.OpaqueRef, T.Bytes]);
export const tx_input_set_entropy = wrap('wally_tx_input_set_entropy', [T.OpaqueRef, T.Bytes]);
@@ -749,6 +750,7 @@ export const tx_input_set_txhash = wrap('wally_tx_input_set_txhash', [T.OpaqueRe
export const tx_input_set_witness = wrap('wally_tx_input_set_witness', [T.OpaqueRef, T.OpaqueRef]);
export const tx_is_coinbase = wrap('wally_tx_is_coinbase', [T.OpaqueRef, T.DestPtr(T.Int32)]);
export const tx_is_elements = wrap('wally_tx_is_elements', [T.OpaqueRef, T.DestPtr(T.Int32)]);
+export const tx_is_input_issuance = wrap('wally_tx_is_input_issuance', [T.OpaqueRef, T.Int32, T.DestPtr(T.Int32)]);
export const tx_is_input_pegin = wrap('wally_tx_is_input_pegin', [T.OpaqueRef, T.Int32, T.DestPtr(T.Int32)]);
export const tx_output_clone = wrap('wally_tx_output_clone_alloc', [T.OpaqueRef, T.DestPtrPtr(T.OpaqueRef)]);
export const tx_output_clone_noalloc = wrap('wally_tx_output_clone', [T.OpaqueRef, T.OpaqueRef]);
### src/wasm_package/src/index.d.ts
@@ -695,6 +695,7 @@ export function tx_input_get_txhash(tx_input_in: Ref_wally_tx_input): Buffer;
export function tx_input_get_witness_len(tx_input_in: Ref_wally_tx_input, index: number): number;
export function tx_input_get_witness_num_items(tx_input_in: Ref_wally_tx_input): number;
export function tx_input_init(txhash: Buffer|Uint8Array|null, utxo_index: number, sequence: number, script: Buffer|Uint8Array|null, witness: Ref_wally_tx_witness_stack): Ref_wally_tx_input;
+export function tx_input_is_issuance(tx_in: Ref_wally_tx_input): number;
export function tx_input_is_pegin(tx_in: Ref_wally_tx_input): number;
export function tx_input_set_blinding_nonce(tx_input_in: Ref_wally_tx_input, blinding_nonce: Buffer|Uint8Array|null): void;
export function tx_input_set_entropy(tx_input_in: Ref_wally_tx_input, entropy: Buffer|Uint8Array|null): void;
@@ -709,6 +710,7 @@ export function tx_input_set_txhash(tx_input: Ref_wally_tx_input, txhash: Buffer
export function tx_input_set_witness(tx_input: Ref_wally_tx_input, witness: Ref_wally_tx_witness_stack): void;
export function tx_is_coinbase(tx: Ref_wally_tx): number;
export function tx_is_elements(tx: Ref_wally_tx): number;
+export function tx_is_input_issuance(tx_in: Ref_wally_tx, index: number): number;
export function tx_is_input_pegin(tx_in: Ref_wally_tx, index: number): number;
export function tx_output_clone(tx_output_in: Ref_wally_tx_output): Ref_wally_tx_output;
export function tx_output_clone_noalloc(tx_output_in: Ref_wally_tx_output, output: Ref_wally_tx_output): void;
### tools/wasm_exports.sh
@@ -462,6 +462,7 @@ EXPORTED_FUNCTIONS="['_malloc','_free','_bip32_key_free' \
,'_wally_tx_input_get_witness_len' \
,'_wally_tx_input_get_witness_num_items' \
,'_wally_tx_input_init_alloc' \
+,'_wally_tx_input_is_issuance' \
,'_wally_tx_input_is_pegin' \
,'_wally_tx_input_set_index' \
,'_wally_tx_input_set_script' \
@@ -845,6 +846,7 @@ if [ -z "$DISABLE_ELEMENTS" ]; then
,'_wally_tx_input_set_issuance_amount' \
,'_wally_tx_input_set_issuance_amount_rangeproof' \
,'_wally_tx_is_elements' \
+,'_wally_tx_is_input_issuance' \
,'_wally_tx_is_input_pegin' \
,'_wally_tx_output_get_asset' \
,'_wally_tx_output_get_asset_len' \Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.