psbt: allow unknowns (global, input and output) to have empty values.
What changed, and why it matters
This commit fixes a bug in how the library reads partially-signed Bitcoin transactions (PSBTs). Previously, if a PSBT contained an unknown extra field with an empty value, the library would store a dangling pointer to a zero-length buffer instead of a proper empty value. This could lead to crashes or memory corruption when the PSBT is later processed. The fix ensures empty unknown values are stored as NULL. A test case with an empty unknown output field was added.
Treat as a low-to-moderate memory-safety fix. Users parsing untrusted PSBTs should upgrade. Review whether similar zero-length buffer handling exists elsewhere in pull_varlength_buff() callers. No CVE or advisory is referenced in the commit; consider requesting one if crash/corruption is reproducible from untrusted input.
Security signals we found
Use of potentially dangling pointer for zero-length buffer
Memory-safety bug in PSBT deserialization
Addition of regression test for malformed/edge-case PSBT input
Acknowledgement of external reporter (@bitcoisas)
Evidence from the diff
In src/psbt.c, pull_unknown_key_value() previously called pull_varlength_buff() to obtain key/val pointers and lengths, then passed val directly to map_add() even when val_len was zero. pull_varlength_buff() can return a non-NULL pointer for a zero-length buffer (pointing past the end of the input), which map_add() would then store and later dereference. The patch changes the value argument to val_len ? val : NULL, so zero-length unknown values are stored as NULL. Test vectors for a PSBT containing an unknown output key 0xf0 with an empty value were added to src/ctest/psbts.h and src/data/psbt.json.
Changed components
src/psbt.cPSBT/PSET parsing (unknown global/input/output key-value maps)map_add() consumers of unknown key-value entriesInspect captured patch +9 / −2
### src/ctest/psbts.h
@@ -696,5 +696,8 @@ static const struct psbt_test valid_psbts[] =
/* PSET w/ UTXO and Witness UTXO */
{"cHNldP8BAgQCAAAAAQMEAAAAAAEEAQEBBQEDAfsEAgAAAAABAKICAAAAAAHH6k+xEgicvmA3NdivY741Mkb1NOcXWr0NNl6hrR/WbgAAAEAA/////wIBIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIBAAAAAlQLx/QAFgAUTwXL7rzz4++YOM52QVixAcDETlwBIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIBAAAAAAAAHAwAAAAAAAABAUIBIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIBAAAAAlQLx/QAFgAUTwXL7rzz4++YOM52QVixAcDETlwBDiBzQYOL5jKoCOgksiRTvw0zfNZ+6QwsBsCZRoqc3PHoygEPBAIAAAABEAT9////ACICAt/pWo4sGJOHmHcQ8znTQCNWAZbCdkdGx3JaRfNNtbr6EAm9XegAAACAAQAAgEgAAIABAwjMugi/AQAAAAEEFgAUK4O/jgxELlCP5V61uOh6JJRLmncH/ARwc2V0AiAjD09dS3xvqEWAbuT2dxNFnhtp6OYPzuLklAx6DV3hsgf8BHBzZXQIBAAAAAAAAQMIAPkClQAAAAABBBYAFI0krONpRve47GLGy+HUYYTd9bvNB/wEcHNldAIgIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIH/ARwc2V0CAQAAAAAAAEDCCgUAAAAAAAAAQQAB/wEcHNldAIgIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIH/ARwc2V0CAQAAAAAAA==", true, true},
+
+ /* PSBT w/ empty unknown output 0xf0 */
+ {"cHNidP8BADwCAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AQAAAAAAAAAAAAAAAAAAAAHwAAA=", false, true},
};
### src/data/psbt.json
@@ -990,6 +990,10 @@
"comment": "PSET w/ UTXO and Witness UTXO",
"psbt": "cHNldP8BAgQCAAAAAQMEAAAAAAEEAQEBBQEDAfsEAgAAAAABAKICAAAAAAHH6k+xEgicvmA3NdivY741Mkb1NOcXWr0NNl6hrR/WbgAAAEAA/////wIBIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIBAAAAAlQLx/QAFgAUTwXL7rzz4++YOM52QVixAcDETlwBIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIBAAAAAAAAHAwAAAAAAAABAUIBIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIBAAAAAlQLx/QAFgAUTwXL7rzz4++YOM52QVixAcDETlwBDiBzQYOL5jKoCOgksiRTvw0zfNZ+6QwsBsCZRoqc3PHoygEPBAIAAAABEAT9////ACICAt/pWo4sGJOHmHcQ8znTQCNWAZbCdkdGx3JaRfNNtbr6EAm9XegAAACAAQAAgEgAAIABAwjMugi/AQAAAAEEFgAUK4O/jgxELlCP5V61uOh6JJRLmncH/ARwc2V0AiAjD09dS3xvqEWAbuT2dxNFnhtp6OYPzuLklAx6DV3hsgf8BHBzZXQIBAAAAAAAAQMIAPkClQAAAAABBBYAFI0krONpRve47GLGy+HUYYTd9bvNB/wEcHNldAIgIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIH/ARwc2V0CAQAAAAAAAEDCCgUAAAAAAAAAQQAB/wEcHNldAIgIw9PXUt8b6hFgG7k9ncTRZ4baejmD87i5JQMeg1d4bIH/ARwc2V0CAQAAAAAAA==",
"is_pset": true
+ },
+ {
+ "comment": "PSBT w/ empty unknown output 0xf0 ",
+ "psbt": "cHNidP8BADwCAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/////AQAAAAAAAAAAAAAAAAAAAAHwAAA="
}
],
"creator": [
### src/psbt.c
@@ -2258,8 +2258,8 @@ static int pull_unknown_key_value(const unsigned char **cursor, size_t *max,
pull_varlength_buff(cursor, max, &key, &key_len);
pull_varlength_buff(cursor, max, &val, &val_len);
-
- return map_add(unknowns, key, key_len, val, val_len, false, false);
+ return map_add(unknowns, key, key_len, val_len ? val : NULL, val_len,
+ false, false);
}
static uint64_t pull_field_type(const unsigned char **cursor, size_t *max,Why this scored 40/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.