build: remove abandoned msvc-dev-cmd from window wheel build
What changed, and why it matters
This commit swaps one way of setting up Microsoft's C++ compiler on Windows in the project's automated wheel-building workflow. It replaces a third-party GitHub Action (msvc-dev-cmd) with a direct call to a Microsoft-provided batch file on the runner. There is no code change that affects the library's behavior, its cryptography, or how it handles user input.
No security action needed. Reviewers may want to confirm the hard-coded path matches the GitHub-hosted Windows runner image and that the workflow still succeeds on Windows jobs.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is in .github/workflows/wheels.yml. The step that previously used ilammy/msvc-dev-cmd@v1.13.0 now runs ‘call “C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat”’ in a cmd shell. This is a build-infrastructure maintenance change: the action was described as ‘abandoned’ in the commit title, so the maintainer switched to the built-in Visual Studio environment script. No source code, build scripts producing artifacts, or cryptographic operations were modified.
Changed components
.github/workflows/wheels.ymlInspect captured patch +2 / −1
diff --git a/.github/workflows/wheels.yml b/.github/workflows/wheels.yml
index 76f6068..2b83a3c 100644
--- a/.github/workflows/wheels.yml
+++ b/.github/workflows/wheels.yml
@@ -33,7 +33,8 @@ jobs:
- name: Install MSVC
if: runner.os == 'Windows'
- uses: ilammy/msvc-dev-cmd@v1.13.0
+ shell: cmd
+ run: call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
- name: Install qemu aarch64
if: runner.os == 'Linux'
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.