AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

tx: prevent pre-bip144 serialization on elements, share arg checks

Public commit record

What the developer wrote

Authored by Jon Griffiths

73/100 · Adequate
tx: prevent pre-bip144 serialization on elements, share arg checks

Ignore the pre-bip144 flag rather than erroring, to make it easier when
coding for both networks.

Share the arg checks so the length functions return consistent values.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit tightens and unifies how transaction serialization arguments are checked in libwally-core. It prevents a caller from accidentally producing ambiguous pre-BIP144 transaction formats on Elements-based networks, and makes the length-calculation and byte-output functions agree on what inputs are valid. The change is defensive hardening rather than a clear-cut fix for an active vulnerability.

Recommended action

Review downstream callers that pass WALLY_TX_FLAG_PRE_BIP144 on Elements to ensure the new silently-cleared behavior does not break assumptions. Consider adding explicit regression tests for zero-input and pre-BIP144 serialization paths on both Bitcoin and Elements networks.

Security signals we found

01

Inconsistent argument validation between length and serialization functions

02

Behavior change for Elements: pre-BIP144 flag is now ignored rather than honored

03

Defensive unification of transaction serialization checks

04

Potential for ambiguous zero-input transaction encoding on non-Elements networks

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 6/15
Affected reach 7/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.