AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 22 Bitcoin

tx: allow getting the weight and vsize of partial transactions

Public commit record

What the developer wrote

Authored by odudex

73/100 · Adequate
tx: allow getting the weight and vsize of partial transactions

'tx: prevent pre-bip144 serialization on elements, share arg checks'
applies the serialization checks when computing tx lengths, so
wally_tx_get_weight and wally_tx_get_vsize, which take no flags, fail for
txs without inputs or outputs, e.g. when estimating fees while building a
tx. Apply the serialization checks only when getting the serialized length.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a bug where two helper functions for calculating transaction size/weight would incorrectly reject transactions that were still being built (for example, when a wallet is estimating fees before all inputs and outputs are added). The fix narrows where a strict serialization check is applied, so size estimates work on partial transactions again. There is no indication this is a security vulnerability or that it can be exploited.

Recommended action

Treat as a routine functional bugfix, not a security issue. Reviewers may want to confirm that tx_get_length() still enforces the serialization restrictions for actual serialization, which the diff shows it does by adding tx_check_args() there.

Security signals we found

01

Behavior change in argument validation path

02

Relaxation of a previously added strict check

03

No memory safety, cryptographic, or authorization changes visible

04

No disclosure language or CVE references present

Risk score

Why this scored 22/100

Our methodology →
Potential impact 5/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 5/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.