onion_message: fix forwarding, blinding was renamed path_key followup 130af597600364d235e97ca46c2eca59d25ef4ef
What the developer wrote
Authored by Sander van Grieken
onion_message: fix forwarding, blinding was renamed path_key
followup 130af597600364d235e97ca46c2eca59d25ef4ef
What changed, and why it matters
This is a one-line bug fix in Electrum's Lightning onion message forwarding code. The developer renamed a parameter from 'blinding' to 'path_key' when sending an onward onion message. The change aligns the code with a prior commit that renamed related concepts, and prevents the outgoing message from carrying the wrong/obsolete field name, which could cause forwarding to fail or behave incorrectly.
Review the prior rename commit 130af597600364d235e97ca46c2eca59d25ef4ef to confirm all 'blinding' references were updated consistently. Test onion message forwarding against a peer that expects 'path_key'. Consider whether any other message types or serialization paths still use the old field name.
Security signals we found
Protocol field name mismatch in forwarded Lightning onion message
Follow-up rename fix suggesting prior incomplete refactor
Potential forwarding failure or interoperability issue if wrong field is sent
Evidence from the diff
In electrum/onion_message.py, OnionMessageManager.handle_onion_message forwards an onion message to the next peer by calling next_peer.send_message(‘onion_message’, …). The keyword argument was ‘blinding=blinding’ and is changed to ‘path_key=blinding’. The commit message states this is a follow-up to 130af597600364d235e97ca46c2eca59d25ef4ef where ‘blinding’ was renamed to ‘path_key’. The fix ensures the forwarded onion message uses the correct protocol field name for the per-hop blinding point/path key.
Changed components
electrum/onion_message.pyOnionMessageManager.handle_onion_messageLightning onion message forwardingInspect captured patch +1 / −1
diff --git a/electrum/onion_message.py b/electrum/onion_message.py
index fcb1c14..ffb4306 100644
--- a/electrum/onion_message.py
+++ b/electrum/onion_message.py
@@ -476,7 +476,7 @@ class OnionMessageManager(Logger):
next_peer.send_message(
"onion_message",
- blinding=blinding,
+ path_key=blinding,
len=len(onion_packet_b),
onion_message_packet=onion_packet_b
)
Why this scored 42/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.