AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 47 Bitcoin

Merge pull request #11060 from f321x/make_unsigned_tx_copy_base_tx

Public commit record

What the developer wrote

Authored by ThomasV

73/100 · Adequate
Merge pull request #11060 from f321x/make_unsigned_tx_copy_base_tx

wallet: make_unsigned_transaction: don't mutate base_tx
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a bug where Electrum's wallet software would accidentally modify a transaction object supplied by the caller when creating a new unsigned transaction. The fix makes a private copy before stripping signatures, preventing unintended changes to the caller's original transaction. This is a defensive correctness fix rather than a clear-cut remote exploit, but it could prevent subtle wallet behavior bugs or UI inconsistencies.

Recommended action

Treat as a low-to-moderate bug fix. Review callers of `make_unsigned_transaction()` to confirm no other code paths relied on the mutation side effect. No urgent security response appears warranted absent evidence of exploitability.

Security signals we found

01

Mutation of caller-supplied object without documentation or copy

02

Signature removal on shared transaction object could affect downstream wallet state

03

Defensive deep-copy fix in transaction construction path

Risk score

Why this scored 47/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 10/15
Affected reach 8/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.