What the developer wrote
Authored by Sander van Grieken
qml: wizard styling, password dialog styling
What changed, and why it matters
This commit is purely a user-interface styling update for Electrum's QML (mobile-style) screens. It changes how password prompts and wallet setup wizards look—moving labels into placeholder text, adjusting margins, and making buttons a consistent touch-friendly height. There is no change to security logic, cryptography, or how passwords/seeds are handled.
No security action needed; this is a routine UI styling change. Reviewers may verify visually that the password dialog still enforces the same minimum-length and confirmation matching rules (unchanged in the diff).
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies three QML files: PasswordDialog.qml, WCConfirmSeed.qml, and Wizard.qml. Changes are cosmetic: replacing standalone Labels with placeholderText on PasswordField controls, wrapping the OK button in a DialogButtonContainer, adding top/bottom margins, setting a preferred button height of constants.fingerWidth, and adding a backgroundColor/compact flag to an info text area. No backend logic, validation rules, or cryptographic operations are altered.
Changed components
electrum/gui/qml/components/PasswordDialog.qmlelectrum/gui/qml/components/wizard/WCConfirmSeed.qmlelectrum/gui/qml/components/wizard/Wizard.qmlInspect captured patch +22 / −22
diff --git a/electrum/gui/qml/components/PasswordDialog.qml b/electrum/gui/qml/components/PasswordDialog.qml
index 550f00b..9f8c0bf 100644
--- a/electrum/gui/qml/components/PasswordDialog.qml
+++ b/electrum/gui/qml/components/PasswordDialog.qml
@@ -39,32 +39,23 @@ ElDialog {
text: infotext
Layout.bottomMargin: constants.paddingMedium
Layout.fillWidth: true
- }
-
- Label {
- Layout.fillWidth: true
- text: qsTr('Password')
- color: Material.accentColor
+ backgroundColor: constants.darkerDialogBackground
+ compact: true
}
PasswordField {
id: pw_1
- Layout.leftMargin: constants.paddingXLarge
- }
-
- Label {
- Layout.fillWidth: true
- text: qsTr('Password (again)')
- visible: confirmPassword
- color: Material.accentColor
+ Layout.bottomMargin: constants.paddingSmall
+ placeholderText: qsTr('Password')
}
PasswordField {
id: pw_2
- Layout.leftMargin: constants.paddingXLarge
+ Layout.bottomMargin: constants.paddingSmall
visible: confirmPassword
showReveal: false
echoMode: pw_1.echoMode
+ placeholderText: qsTr('Password (again)')
}
RowLayout {
@@ -82,7 +73,7 @@ ElDialog {
}
PasswordStrengthIndicator {
- Layout.fillWidth: true
+ Layout.preferredWidth: passworddialog.width / 2
password: pw_1.text
}
}
@@ -98,13 +89,17 @@ ElDialog {
}
}
- FlatButton {
+ DialogButtonContainer {
Layout.fillWidth: true
- text: qsTr("Ok")
- icon.source: '../../icons/confirmed.png'
- enabled: confirmPassword ? pw_1.text.length >= 6 && pw_1.text == pw_2.text : true
- onClicked: {
- passwordEntered(pw_1.text)
+
+ FlatButton {
+ Layout.fillWidth: true
+ text: qsTr("Ok")
+ icon.source: '../../icons/confirmed.png'
+ enabled: confirmPassword ? pw_1.text.length >= 6 && pw_1.text == pw_2.text : true
+ onClicked: {
+ passwordEntered(pw_1.text)
+ }
}
}
}
diff --git a/electrum/gui/qml/components/wizard/WCConfirmSeed.qml b/electrum/gui/qml/components/wizard/WCConfirmSeed.qml
index eb239c6..5aebaf0 100644
--- a/electrum/gui/qml/components/wizard/WCConfirmSeed.qml
+++ b/electrum/gui/qml/components/wizard/WCConfirmSeed.qml
@@ -43,6 +43,7 @@ WizardComponent {
SeedTextArea {
id: confirm
Layout.fillWidth: true
+ Layout.topMargin: constants.paddingSmall
placeholderText: qsTr('Enter your seed')
onTextChanged: checkValid()
}
diff --git a/electrum/gui/qml/components/wizard/Wizard.qml b/electrum/gui/qml/components/wizard/Wizard.qml
index 36860db..e231dc5 100644
--- a/electrum/gui/qml/components/wizard/Wizard.qml
+++ b/electrum/gui/qml/components/wizard/Wizard.qml
@@ -165,6 +165,7 @@ ElDialog {
FlatButton {
Layout.fillWidth: true
Layout.preferredWidth: 1
+ Layout.preferredHeight: constants.fingerWidth
visible: pages.currentIndex == 0
text: qsTr("Cancel")
onClicked: wizard.doReject()
@@ -172,6 +173,7 @@ ElDialog {
FlatButton {
Layout.fillWidth: true
Layout.preferredWidth: 1
+ Layout.preferredHeight: constants.fingerWidth
visible: pages.currentIndex > 0
text: qsTr('Back')
onClicked: pages.prev()
@@ -179,6 +181,7 @@ ElDialog {
FlatButton {
Layout.fillWidth: true
Layout.preferredWidth: 1
+ Layout.preferredHeight: constants.fingerWidth
text: qsTr("Next")
visible: !pages.lastpage
enabled: pages.pagevalid
@@ -188,6 +191,7 @@ ElDialog {
id: finishButton
Layout.fillWidth: true
Layout.preferredWidth: 1
+ Layout.preferredHeight: constants.fingerWidth
text: qsTr("Finish")
visible: pages.lastpage
enabled: pages.pagevalid
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.