What the developer wrote
Authored by f321x
qml: shorten max brightnes preference string
Shorten the max brightness preference string so it fits in a single line
and disable it if the system is not on Android.
What changed, and why it matters
This commit is a minor user-interface tweak for the Electrum mobile app. It shortens the label for a 'max brightness when showing QR codes' setting and disables that setting on non-Android systems because the feature only works on Android. There is no security issue here.
No security action needed. This is a benign UI/UX fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change touches electrum/gui/qml/components/Preferences.qml. It adds enabled: AppController.isAndroid() to the row containing the setMaxBrightnessOnQrDisplay switch, shortens the label text, and makes the initial checked state depend on Config.setMaxBrightnessOnQrDisplay && AppController.isAndroid(). This prevents a non-functional Android-only preference from appearing active on other platforms and improves label fit.
Changed components
electrum/gui/qml/components/Preferences.qmlInspect captured patch +3 / −2
diff --git a/electrum/gui/qml/components/Preferences.qml b/electrum/gui/qml/components/Preferences.qml
index c65fee7..8595840 100644
--- a/electrum/gui/qml/components/Preferences.qml
+++ b/electrum/gui/qml/components/Preferences.qml
@@ -197,6 +197,7 @@ Pane {
Layout.columnSpan: 2
Layout.fillWidth: true
spacing: 0
+ enabled: AppController.isAndroid()
Switch {
id: setMaxBrightnessOnQrDisplay
onCheckedChanged: {
@@ -206,7 +207,7 @@ Pane {
}
Label {
Layout.fillWidth: true
- text: qsTr('Set display to max brightness when displaying QR codes')
+ text: qsTr('Increase brightness when displaying QR codes')
wrapMode: Text.Wrap
}
}
@@ -505,7 +506,7 @@ Pane {
useTrampolineRouting.checked = !Config.useGossip
enableDebugLogs.checked = Config.enableDebugLogs
disableScreenshots.checked = !Config.alwaysAllowScreenshots && AppController.isAndroid()
- setMaxBrightnessOnQrDisplay.checked = Config.setMaxBrightnessOnQrDisplay
+ setMaxBrightnessOnQrDisplay.checked = Config.setMaxBrightnessOnQrDisplay && AppController.isAndroid()
useRecoverableChannels.checked = Config.useRecoverableChannels
syncLabels.checked = AppController.isPluginEnabled('labels')
psbtNostr.checked = AppController.isPluginEnabled('psbt_nostr')
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.