What the developer wrote
Authored by f321x
qt: update tabs on exit of SettingsDialog
Update the tabs after the SettingsDialog gets closed, some values might
have to be updated according to the new configuration.
What changed, and why it matters
This is a minor user-interface fix. After closing the Settings dialog, Electrum's main window now refreshes its tabs so that displayed information (for example, whether a Lightning payment can be sent) reflects any changed settings. There is no security issue here.
No security action needed. Treat as a normal UI improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit adds an else-branch in the SettingsDialog close handler. If no restart is required, it calls self.refresh_tabs() so that tab contents are synchronized with the new configuration. The change is purely UI refresh logic and does not touch cryptography, networking, wallet handling, or input validation.
Changed components
electrum/gui/qt/main_window.pyInspect captured patch +4 / −0
diff --git a/electrum/gui/qt/main_window.py b/electrum/gui/qt/main_window.py
index f7c1ec9..4144884 100644
--- a/electrum/gui/qt/main_window.py
+++ b/electrum/gui/qt/main_window.py
@@ -2720,6 +2720,10 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger, QtEventListener):
run_hook('close_settings_dialog')
if d.need_restart:
self.show_warning(_('Please restart Electrum to activate the new GUI settings'), title=_('Success'))
+ else:
+ # Some values might need to be updated if settings have changed.
+ # For example 'Can send' in the lightning tab will change if the fees config is changed.
+ self.refresh_tabs()
def _show_closing_warnings(self) -> bool:
"""Show any closing warnings and return True if the user chose to quit anyway."""
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.