qml: ReceiveDetailsDialog use proper ButtonContainer
What the developer wrote
Authored by Sander van Grieken
qml: ReceiveDetailsDialog use proper ButtonContainer
What changed, and why it matters
This commit is a minor user-interface layout fix in Electrum's QML (mobile-style) GUI. It replaces a generic grid container with a dedicated 'ButtonContainer' for the 'Onchain' and 'Lightning' buttons in the receive-payment details dialog. There is no security-relevant change visible in the diff.
No security action required. Treat as a normal UI/layout maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch changes ReceiveDetailsDialog.qml from using a GridLayout with two columns to a ButtonContainer with fillWidth and preferredWidth set on each FlatButton. The button logic, enabled states, icons, click handlers, and surrounding dialog code are unchanged. This is a UI consistency/layout refactor only.
Changed components
electrum/gui/qml/components/ReceiveDetailsDialog.qmlInspect captured patch +4 / −3
diff --git a/electrum/gui/qml/components/ReceiveDetailsDialog.qml b/electrum/gui/qml/components/ReceiveDetailsDialog.qml
index ab00091..c29df76 100644
--- a/electrum/gui/qml/components/ReceiveDetailsDialog.qml
+++ b/electrum/gui/qml/components/ReceiveDetailsDialog.qml
@@ -95,18 +95,19 @@ ElDialog {
}
}
- GridLayout {
- width: parent.width
- columns: 2
+ ButtonContainer {
+ Layout.fillWidth: true
FlatButton {
Layout.fillWidth: true
+ Layout.preferredWidth: 1
text: qsTr('Onchain')
icon.source: '../../icons/bitcoin.png'
onClicked: { dialog.isLightning = false; doAccept() }
}
FlatButton {
Layout.fillWidth: true
+ Layout.preferredWidth: 1
enabled: Daemon.currentWallet.isLightning && (Daemon.currentWallet.lightningCanReceive.satsInt
> amountBtc.textAsSats.satsInt || Daemon.currentWallet.canGetZeroconfChannel)
text: qsTr('Lightning')
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.