What the developer wrote
Authored by f321x
qml: add default topPadding to ElTextArea
I noticed all ElTextAreas seem to look better with some topPadding,
so it makes more sense to add it as default to ElTextArea.
Followup to https://github.com/spesmilo/electrum/pull/10579
What changed, and why it matters
This commit is a purely cosmetic user-interface tweak. It moves a padding setting from one specific dialog into a shared text-area component so all text areas look consistent. There is no security relevance.
No security action needed; this is a routine UI polish change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change removes an explicit topPadding: constants.paddingLarge from a NostrConfigDialog.qml ElTextArea instance and instead sets that value as the default inside the reusable ElTextArea.qml control. It is a UI layout refactor with no functional, cryptographic, or security behavior changes.
Changed components
electrum/gui/qml/components/NostrConfigDialog.qmlelectrum/gui/qml/components/controls/ElTextArea.qmlInspect captured patch +1 / −1
diff --git a/electrum/gui/qml/components/NostrConfigDialog.qml b/electrum/gui/qml/components/NostrConfigDialog.qml
index 0eb6cfd..384555f 100644
--- a/electrum/gui/qml/components/NostrConfigDialog.qml
+++ b/electrum/gui/qml/components/NostrConfigDialog.qml
@@ -74,7 +74,6 @@ ElDialog {
Layout.fillWidth: true
Layout.fillHeight: true
font.family: FixedFont
- topPadding: constants.paddingLarge
wrapMode: TextEdit.WrapAnywhere
onTextChanged: valid = verify(text)
inputMethodHints: Qt.ImhSensitiveData | Qt.ImhNoPredictiveText | Qt.ImhNoAutoUppercase
diff --git a/electrum/gui/qml/components/controls/ElTextArea.qml b/electrum/gui/qml/components/controls/ElTextArea.qml
index e161979..f3c55d3 100644
--- a/electrum/gui/qml/components/controls/ElTextArea.qml
+++ b/electrum/gui/qml/components/controls/ElTextArea.qml
@@ -49,6 +49,7 @@ Flickable {
width: root.width
height: Math.max(root.height, edit.height + topPadding + bottomPadding)
padding: constants.paddingXSmall
+ topPadding: constants.paddingLarge
TextArea {
id: edit
width: parent.width
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.