What the developer wrote
Authored by Sander van Grieken
qml: add missing button containers
What changed, and why it matters
This commit is a cosmetic UI layout fix for the Electrum mobile/desktop QML interface. It wraps several dialog buttons in a 'DialogButtonContainer' component and adjusts spacing. There is no indication it fixes a security vulnerability, changes access controls, or alters how money or secrets are handled.
No security action required; treat as a normal UI/layout maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies three QML dialog components (CloseChannelDialog, LnurlPayRequestDialog, LnurlWithdrawRequestDialog) to wrap FlatButton elements inside a DialogButtonContainer and sets one container’s spacing to 0. The buttons’ text, icons, enabled states, and onClicked handlers remain functionally identical. No logic, validation, cryptography, or network behavior is changed.
Changed components
electrum/gui/qml/components/CloseChannelDialog.qmlelectrum/gui/qml/components/LnurlPayRequestDialog.qmlelectrum/gui/qml/components/LnurlWithdrawRequestDialog.qmlInspect captured patch +35 / −24
diff --git a/electrum/gui/qml/components/CloseChannelDialog.qml b/electrum/gui/qml/components/CloseChannelDialog.qml
index 1862ad7..aafb51e 100644
--- a/electrum/gui/qml/components/CloseChannelDialog.qml
+++ b/electrum/gui/qml/components/CloseChannelDialog.qml
@@ -156,17 +156,21 @@ ElDialog {
}
}
- FlatButton {
+ DialogButtonContainer {
Layout.columnSpan: 2
Layout.fillWidth: true
- text: qsTr('Close channel')
- icon.source: '../../icons/closebutton.png'
- enabled: !channeldetails.isClosing
- onClicked: {
- if (closetypegroup.checkedButton.closetype == 'local_force') {
- showBackupThenClose()
- } else {
- doCloseChannel()
+
+ FlatButton {
+ Layout.fillWidth: true
+ text: qsTr('Close channel')
+ icon.source: '../../icons/closebutton.png'
+ enabled: !channeldetails.isClosing
+ onClicked: {
+ if (closetypegroup.checkedButton.closetype == 'local_force') {
+ showBackupThenClose()
+ } else {
+ doCloseChannel()
+ }
}
}
}
diff --git a/electrum/gui/qml/components/LnurlPayRequestDialog.qml b/electrum/gui/qml/components/LnurlPayRequestDialog.qml
index 64f4545..195eea3 100644
--- a/electrum/gui/qml/components/LnurlPayRequestDialog.qml
+++ b/electrum/gui/qml/components/LnurlPayRequestDialog.qml
@@ -129,15 +129,18 @@ ElDialog {
}
}
- FlatButton {
+ DialogButtonContainer {
Layout.topMargin: constants.paddingLarge
Layout.fillWidth: true
- text: qsTr('Pay...')
- icon.source: '../../icons/confirmed.png'
- enabled: valid
- onClicked: {
- invoiceParser.lnurlGetInvoice(comment.text)
- dialog.close()
+ FlatButton {
+ Layout.fillWidth: true
+ text: qsTr('Pay...')
+ icon.source: '../../icons/confirmed.png'
+ enabled: valid
+ onClicked: {
+ invoiceParser.lnurlGetInvoice(comment.text)
+ dialog.close()
+ }
}
}
}
diff --git a/electrum/gui/qml/components/LnurlWithdrawRequestDialog.qml b/electrum/gui/qml/components/LnurlWithdrawRequestDialog.qml
index 02a9be4..4e047e5 100644
--- a/electrum/gui/qml/components/LnurlWithdrawRequestDialog.qml
+++ b/electrum/gui/qml/components/LnurlWithdrawRequestDialog.qml
@@ -50,6 +50,7 @@ ElDialog {
ColumnLayout {
width: parent.width
+ spacing: 0
GridLayout {
id: rootLayout
@@ -160,16 +161,19 @@ ElDialog {
}
}
- FlatButton {
+ DialogButtonContainer {
Layout.topMargin: constants.paddingLarge
Layout.fillWidth: true
- text: qsTr('Withdraw...')
- icon.source: '../../icons/confirmed.png'
- enabled: valid && !requestDetails.busy
- onClicked: {
- var satsAmount = amountBtc.textAsSats.satsInt;
- requestDetails.lnurlRequestWithdrawal(satsAmount);
- dialog.close();
+ FlatButton {
+ Layout.fillWidth: true
+ text: qsTr('Withdraw...')
+ icon.source: '../../icons/confirmed.png'
+ enabled: valid && !requestDetails.busy
+ onClicked: {
+ var satsAmount = amountBtc.textAsSats.satsInt;
+ requestDetails.lnurlRequestWithdrawal(satsAmount);
+ dialog.close();
+ }
}
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.