AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 59 Bitcoin

Merge pull request #11051 from accumulator/keystore_enable_disable_fixes

Public commit record

What the developer wrote

Authored by Felix

58/100 · Thin
Merge pull request #11051 from accumulator/keystore_enable_disable_fixes

Keystore enable disable fixes
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes several bugs in Electrum's feature that lets users temporarily disable or re-enable a wallet's keystore (the part that holds the private signing key). The changes prevent users from accidentally locking themselves out of Lightning funds, stop unrelated seeds from being accepted when re-enabling a keystore, ensure disabled seed material is actually removed from the wallet file, and fix password/encryption handling when only the keystore (not the whole wallet file) was protected. These are reliability and safety fixes rather than a remote-exploitable vulnerability, but mishandling of private key material and Lightning funds has real security consequences.

Recommended action

Users running affected Electrum versions should upgrade to a release containing this commit. Developers should review the new `lightning_needs_keystore()` logic and the encryption state transitions in `enable_keystore`/`disable_keystore` for completeness, and consider whether additional UI warnings are needed before users disable a keystore.

Security signals we found

01

Prevents loss of access to Lightning funds by blocking keystore disable while channels/swaps need signing

02

Prevents acceptance of a mismatched seed/device when re-enabling a keystore

03

Prevents replacing a non-watching-only keystore, which could destroy seed backup state

04

Ensures disabled seed/xprv material is removed from disk via forced storage consolidation

05

Corrects keystore encryption flag handling to avoid inconsistent password/encryption state

06

Adds GUI wiring fix so the correct target keystore is enabled

Risk score

Why this scored 59/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.