Update BOLT quotes for channel open flow. The TLV `channel_type` is now mandatory. The code was correct but the quote was not.
What changed, and why it matters
This commit only fixes whitespace formatting in a comment that quotes the BOLT protocol specification. No actual code behavior changed. The surrounding C code that sets the channel_type value was already correct and is untouched.
No action needed; this is a non-functional documentation/comment-formatting change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adjusts indentation of a BOLT #2 quote block inside openingd/openingd.c. The actual assignment open_tlvs->channel_type = state->channel_type->features; remains identical. The commit message confirms the code was already correct and only the quote needed updating. There is no functional change, no security boundary crossed, and no vulnerability introduced or fixed.
Changed components
openingd/openingd.c (comment only)Inspect captured patch +6 / −6
diff --git a/openingd/openingd.c b/openingd/openingd.c
index 52e50572..ac9752a2 100644
--- a/openingd/openingd.c
+++ b/openingd/openingd.c
@@ -332,12 +332,12 @@ static u8 *funder_channel_start(struct state *state, u8 channel_flags,
= state->upfront_shutdown_script[LOCAL];
/* BOLT #2:
- * - MUST set `channel_type`:
- * - MUST set it to a defined type representing the type it wants.
- * - MUST use the smallest bitmap possible to represent the channel
- * type.
- * - SHOULD NOT set it to a type containing a feature which was not
- * negotiated.
+ * - MUST set `channel_type`:
+ * - MUST set it to a defined type representing the type it wants.
+ * - MUST use the smallest bitmap possible to represent the channel
+ * type.
+ * - SHOULD NOT set it to a type containing a feature which was not
+ * negotiated.
*/
open_tlvs->channel_type = state->channel_type->features;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.