CommitWatch RSS
NG
← Developer activityStrong match

Níckolas Goline

Public commit activity attributed with strong match confidence. This page describes observable work, not personal trustworthiness.

40 commits1 monitored projects6 candidates0 high-risk analyses
Project constellation

Where the commits appear

Amber nodes are monitored by CommitWatch. Gray nodes are sampled from authenticated GitHub public commit search and may not represent complete contribution history.

Monitored External sample
Projects connected to Níckolas GolineA visual map of monitored and externally discovered repositories.NGdeveloper40Core Lightning
Monitored evidence

CommitWatch projects

Core LightningElements Project40 commits6 candidates0 high risk
External discovery

Other public projects

No external sample loaded yet.

A verified GitHub handle is needed before external discovery.
Analyzed activity

Recent published watches

Message quality and risk characterize commits, never the person.

Informational 15 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: fix test_low_fd_limit failing on RLIM_INFINITY platforms

This commit fixes a test that was failing on macOS and other systems where the operating system reports no practical upper bound on the number of open files (called RLIM_INFINITY). The test was passing values larger than a 32-bit unsigned …

ae53e877by Níckolas Goline+11−22 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: reject a channel that reuses an existing funding outpoint

This change prevents a peer from accidentally or maliciously opening a second Lightning channel using the exact same Bitcoin transaction output as an existing channel. Because channel IDs are derived from that funding output, reusing it wo…

channel ID collision / duplicate identifierfunding outpoint reusestate confusion between distinct channels
7def3af0by Níckolas Goline+26−03 files
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

connectd: handle an already-connected subd gracefully

This change fixes a crash in the part of Core Lightning that handles peer connections. Previously, if the same internal connection was unexpectedly set up twice, the program would abort with an assertion failure. Now it logs a debug messag…

Assertion replaced with defensive error handlingPotential denial-of-service crash vector removedDuplicate peer/subd connection now logged and dropped
c7a013c8by Níckolas Goline+10−11 file
No security note in commit
Open full analysis →Source commit ↗
Low 47 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

ecdh_hsmd: ensure HSM fd is blocking on setup

This commit fixes a bug where a special internal communication channel (file descriptor) used by Core Lightning could accidentally be left in non-blocking mode on macOS under heavy load. When that happened, a part of the program expecting …

Crash/DoS condition in connectd/channeld due to unexpected EAGAIN on synchronous HSM readInherited O_NONBLOCK on SCM_RIGHTS-passed socketpair fd on macOSDefensive hardening: explicit blocking-mode enforcement on setup
f40be192by Níckolas Goline+3−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 25 AI analysisMessage 85 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

connectd: set IPV6_V6ONLY=1 on IPv6 sockets for consistent dual-stack behaviour

This commit fixes a network setup bug in Core Lightning's connection daemon. On some operating systems (macOS, Fedora, Arch, and default Linux kernels), an IPv6 'listen on all addresses' socket was also covering IPv4, which prevented a sep…

Denial-of-service availability fix: on affected systems, the node could not listen on IPv4 when configured for wildcard IPv4+IPv6Memory leak fix in connectd error pathNo evidence of malicious intent in the diff
730e5881by Níckolas Goline+21−32 files
No security note in commit
Open full analysis →Source commit ↗
Low 43 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: accept OP_RETURN closer_scriptpubkey in simple-close check

This commit fixes a bug in Core Lightning's experimental simple-close feature. When two Lightning nodes tried to close a channel cooperatively using the new 'simple close' protocol, one peer was allowed by the specification to burn its own…

Denial of service / unwanted force-close: a spec-compliant peer could cause the local node to force-close a channel, incurring on-chain fees and delays.Funds not stolen: the OP_RETURN output is unspendable, so accepting it cannot redirect funds to an attacker.Value-zero check prevents burning real funds: the patch enforces AMOUNT_SAT(0) on the OP_RETURN output.
9b6a80fcby Níckolas Goline+356−52 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: fix flaky test_simple_close_delay_broadcast mempool race

This commit fixes a flaky automated test in Core Lightning. The test was sometimes failing because it mined a Bitcoin block immediately after seeing a log message that said a transaction was being broadcast. That log appears when Core Ligh…

5ae0705fby Níckolas Goline+7−41 file
No security note in commit
Open full analysis →Source commit ↗
Low 47 AI analysisMessage 76 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

ccan: update ccan to fe99a8e0

This commit updates an internal sorting library used by Core Lightning. The old sorting code could call a comparison function with the exact same item twice when sorting arrays where every element is equal. The commit replaces that old cod…

Old quicksort fallback called comparator with identical pointers on all-equal arraysComparator contract violation: pointer identity no longer implies distinct elementsSorting routine replaced with glibc mergesort+heapsort to avoid self-comparisons
cb07b8cbby Níckolas Goline+479−2474 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 100 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

ci: reduce sanitizer/valgrind worker count to avoid runner OOM

This change only adjusts the project's automated testing setup. It reduces the number of parallel test workers in two CI jobs to stop GitHub's hosted test machines from running out of memory, and adds logging to confirm the cause if they s…

0da8fa28by Níckolas Goline+16−21 file
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

connectd/tests: fix test_announce_and_connect_via_dns on macOS

This commit is a test-only fix for macOS. It skips a test that fails because macOS lacks a specific local hostname entry, and it adds a code comment explaining a networking flag. There is no security issue or vulnerability here.

40f2ce6aby Níckolas Goline+6−02 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 72 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

test: add run-close_tx to validate simple-close transaction functionality

This commit only adds a new unit test file and updates the build Makefile to compile it. It does not change any production code, so it cannot introduce a runtime security vulnerability by itself. The test exercises the existing create_simp…

281ad119by Níckolas Goline+297−02 files
No security note in commit
Open full analysis →Source commit ↗
Low 35 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

simpleclosed.c: add heuristic to delay our tx broadcast if our amount is less AND our fee is less than our peer's amount and fee in case of a reboot the tx will be broadcast as usual.

This commit adds a one-hour delay before Core Lightning broadcasts a mutual channel-close transaction when the local node has the smaller payout and proposed a lower fee than its peer. The goal is to let the peer's higher-fee transaction w…

Race-condition mitigation in mutual-close broadcast after reconnect/rebootHeuristic delay to avoid redundant competing close transactionsNew wire message field delay_broadcast
da67bf84by Níckolas Goline+110−64 files
No security note in commit
Open full analysis →Source commit ↗
Low 35 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

closingd: add `lightning_simpleclosed` for `option_simple_close`

This commit adds a new sub-program (lightning_simpleclosed) to Core Lightning that implements a new, simpler way for two Lightning nodes to agree on closing a payment channel together. It is a feature addition, not a documented security fi…

New subdaemon handling channel-close funds and signaturesSignature validation on closing_complete / closing_sig via check_tx_sigFee sanity checks against local/remote balances
9f2f4350by Níckolas Goline+841−65 files
No security note in commit
Open full analysis →Source commit ↗
Low 33 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

channeld: reject `closing_complete` and `closing_sig` with a clear error

This change makes a Lightning node respond with a clear warning error if a peer sends certain closing-related messages at the wrong time, instead of silently following the default 'unknown message' path. It is a hardening fix that prevents…

Explicit rejection of protocol messages that should not occur in this daemon statePrevents silent handling of closing_complete/closing_sig inside channeldUses peer_failed_warn to disconnect with a descriptive error
e081eb3eby Níckolas Goline+7−21 file
No security note in commit
Open full analysis →Source commit ↗
Low 37 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: wire up `option_simple_close` master-side handling

This commit turns on a new experimental Lightning feature called 'simple close' (BOLT2 option_simple_close). It adds the master-side code that starts a new subdaemon, validates mutual-close transactions, stores them, and broadcasts them in…

New subdaemon introduced with HSM signing permission for closing transactionsValidation added for mutual close transaction inputs and output scriptsRemote signature verification before storing close transaction
ce119cd2by Níckolas Goline+332−57 files
No security note in commit
Open full analysis →Source commit ↗
Informational 12 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

common/close_tx: add `create_simple_close_tx()` for `option_simple_close`

This commit adds a new helper function that builds a specific kind of Bitcoin closing transaction used by the Core Lightning node software when two channel peers agree on a simpler cooperative close. It follows the BOLT 3 specification, se…

New feature code, not a patch of existing vulnerable codeFollows explicit BOLT 3 specification for option_simple_closeUses standard nSequence 0xFFFFFFFD RBF signalling
e362c3bbby Níckolas Goline+112−02 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

common: add `OPT_SIMPLE_CLOSE` feature bit (60/61)

This commit adds a new experimental Lightning protocol feature called 'simple close' (feature bits 60/61). It is purely a feature flag and configuration plumbing change: it reserves the feature bit, registers a command-line option, and upd…

ff9e556cby Níckolas Goline+748−61414 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 91 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: `add option_simple_close` integration tests

This commit only adds new automated tests for an upcoming Lightning protocol feature called option_simple_close. It does not change any production code. Most of the new tests are explicitly marked as expected to fail (xfail) because the fe…

7640ab6bby Níckolas Goline+243−01 file
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 50 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

makefile: update: update-ccan

This commit changes a single line in the build Makefile. It updates the 'update-ccan' recipe so that when the project copies code from the CCAN library, it records the exact Git commit hash instead of a Git tag-based version string. This i…

77c47f5bby Níckolas Goline+1−11 file
No security note in commit
Open full analysis →Source commit ↗
Informational 23 AI analysisMessage 60 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

ccan: update ccan to efd48386

This commit updates a bundled helper library (ccan) and fixes a small but meaningful networking bug in its event loop. Previously, when a socket reported an error, the code always assumed the generic error 'bad file descriptor' (EBADF). No…

Error-handling path changed from a hardcoded generic errno to a real socket error retrieved via getsockopt(SO_ERROR)Cross-platform macOS/Linux behavior divergence in poll(2) error reporting for connect() failuresPotential for downstream logic to behave differently now that ECONNREFUSED (or other real errors) is propagated instead of EBADF
2003dca7by Níckolas Goline+14−32 files
No security note in commit
Open full analysis →Source commit ↗
Wrong identity?Names can collide and public author strings can be misleading.Contact commitwatch@karma-x.io →