Update outdated BOLT quotes common/bolt11.c: Some BOLT quotes had changed slightly. run-bolt11.c: A test was updated to reflect nomenclature changes (from `signature recovery` to `public-key recovery`).
What the developer wrote
Authored by Níckolas Goline
Update outdated BOLT quotes
common/bolt11.c: Some BOLT quotes had changed slightly.
run-bolt11.c: A test was updated to reflect nomenclature changes (from `signature recovery` to `public-key recovery`).
What changed, and why it matters
This commit only changes wording: it renames an internal error message from 'signature recovery failed' to 'public-key recovery failed' to match updated BOLT specification terminology. No program logic, cryptography, or behavior changes.
No security action needed; this is a documentation/terminology alignment change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates a user-visible error string and its corresponding unit-test assertion in common/bolt11.c and common/test/run-bolt11.c. The underlying secp256k1_ecdsa_recover call and all surrounding decode logic are untouched.
Changed components
common/bolt11.ccommon/test/run-bolt11.cInspect captured patch +2 / −2
diff --git a/common/bolt11.c b/common/bolt11.c
index bc851ed..e4d8630 100644
--- a/common/bolt11.c
+++ b/common/bolt11.c
@@ -1045,7 +1045,7 @@ struct bolt11 *bolt11_decode(const tal_t *ctx, const char *str,
&sig,
(const u8 *)&hash))
return decode_fail(b11, fail,
- "signature recovery failed");
+ "public-key recovery failed");
node_id_from_pubkey(&b11->receiver_id, &k);
} else {
struct pubkey k;
diff --git a/common/test/run-bolt11.c b/common/test/run-bolt11.c
index a3c4c3a..7caf2ed 100644
--- a/common/test/run-bolt11.c
+++ b/common/test/run-bolt11.c
@@ -874,7 +874,7 @@ int main(int argc, char *argv[])
* > lnbc2500u1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdq5xysxxatsyp3k7enxv4jsxqzpusp5zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zygs9qrsgqwgt7mcn5yqw3yx0w94pswkpq6j9uh6xfqqqtsk4tnarugeektd4hg5975x9am52rz4qskukxdmjemg92vvqz8nvmsye63r5ykel43pgz7zq0g2
*/
assert(!bolt11_decode(tmpctx, "lnbc2500u1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdq5xysxxatsyp3k7enxv4jsxqzpusp5zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zygs9qrsgqwgt7mcn5yqw3yx0w94pswkpq6j9uh6xfqqqtsk4tnarugeektd4hg5975x9am52rz4qskukxdmjemg92vvqz8nvmsye63r5ykel43pgz7zq0g2", NULL, NULL, NULL, &fail));
- assert(streq(fail, "signature recovery failed"));
+ assert(streq(fail, "public-key recovery failed"));
/* BOLT #11:
* > ### String is too short.
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.