Update tests after changing deadline from `blockheight + 12` to `blockheight + 72` blocks.
What the developer wrote
Authored by Níckolas Goline
Update tests after changing deadline from `blockheight + 12` to `blockheight + 72` blocks.
Added 60 blocks to all tests that relied on this parameter in order to fix them. i.e. 12 -> 72, 13 -> 73, etc...
What changed, and why it matters
This commit only updates test numbers to match a previously made code change that extended a timeout/deadline from 12 blocks to 72 blocks. It does not change any production code, so it cannot directly affect real users or introduce a security vulnerability.
No security action needed. Review the separate commit that changed the production deadline from 12 to 72 blocks if assessing security relevance of that behavior change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/test_wallet.py, adjusting hard-coded block counts (15→75, 20→90, 74 stays 74, comment 12→72) so the test expectations align with a new 72-block deadline. No implementation logic is changed. The actual deadline change happened elsewhere and is not shown in this commit.
Changed components
tests/test_wallet.pyInspect captured patch +3 / −3
diff --git a/tests/test_wallet.py b/tests/test_wallet.py
index 651eb0e5..893e55e1 100644
--- a/tests/test_wallet.py
+++ b/tests/test_wallet.py
@@ -2648,11 +2648,11 @@ def test_unspend_during_reorg(node_factory, bitcoind):
blockheight, txindex, _ = scid.split('x')
# Use mainnet settings for rescan.
- l3 = node_factory.get_node(options={'rescan': 15})
+ l3 = node_factory.get_node(options={'rescan': 75})
l3.connect(l2)
mine_funding_to_announce(bitcoind, [l1, l2, l3])
- bitcoind.generate_block(20)
+ bitcoind.generate_block(90)
sync_blockheight(bitcoind, [l3])
wait_for(lambda: len(l3.rpc.listchannels()['channels']) == 2)
@@ -2665,7 +2665,7 @@ def test_unspend_during_reorg(node_factory, bitcoind):
bitcoind.generate_block(74, wait_for_mempool=1)
wait_for(lambda: len(l3.rpc.listchannels()['channels']) == 2)
- # In one fell swoop it goes through dying, to dead (12 blocks)
+ # In one fell swoop it goes through dying, to dead (72 blocks)
l3.daemon.wait_for_log(f"Adding block {spentheight}")
l3.daemon.wait_for_log(f"gossipd: channel {scid} closing soon due to the funding outpoint being spent")
l3.daemon.wait_for_log(f"gossipd: Deleting channel {scid} due to the funding outpoint being spent")
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.