ci: fix configure docker action inputs
What the developer wrote
Authored by will
ci: fix configure docker action inputs
The options used were wrong in two ways: firstly they were not enforced
as a "choice" (i.e. invalid input valudes could be provided without
error) and one of the options was listed as `gh` when we passed it as
`gha` from ci.yml.
"Fix" this by removing the choice altogether but sanity-testing the
input value against an expected list using a GHA "warning" to notify of
unknown inputs.
What changed, and why it matters
This is a minor fix to a GitHub Actions helper used in Bitcoin Core's continuous integration (CI). The action had a typo in one of its allowed options ('gh' instead of 'gha') and did not actually enforce the list of allowed values. The patch removes the broken option list and instead prints a warning if an unexpected value is provided. It is a workflow-quality fix, not a security patch for Bitcoin's code or network.
No security action required. Treat as a normal CI maintenance commit. Reviewers may optionally verify that ci.yml passes 'gha' and that the warning text is useful for debugging misconfigurations.
Security signals we found
No security-relevant code changed
CI/GitHub Actions metadata-only change
Input validation added as warning, not enforcement
No cryptographic, consensus, networking, or wallet changes
Evidence from the diff
The commit changes .github/actions/configure-docker/action.yml. Previously the cache-provider input declared ‘options:’ with values ‘gh’ and ‘cirrus’, but GitHub Actions composite actions do not enforce options, and the caller (ci.yml) passes ‘gha’, which was not in the declared list. The patch deletes the options block and adds a bash step that case-matches the input against ‘gha|cirrus’, emitting an Actions warning for anything else. No runtime logic of the Bitcoin node is changed.
Changed components
.github/actions/configure-docker/action.ymlInspect captured patch +12 / −3
diff --git a/.github/actions/configure-docker/action.yml b/.github/actions/configure-docker/action.yml
index 8c2ecd06..814f2dd1 100644
--- a/.github/actions/configure-docker/action.yml
+++ b/.github/actions/configure-docker/action.yml
@@ -4,12 +4,21 @@ inputs:
cache-provider:
description: 'gha or cirrus cache provider'
required: true
- options:
- - gh
- - cirrus
runs:
using: 'composite'
steps:
+ - name: Check inputs
+ shell: bash
+ run: |
+ # We expect only gha or cirrus as inputs to cache-provider
+ case "${{ inputs.cache-provider }}" in
+ gha|cirrus)
+ ;;
+ *)
+ echo "::warning title=Unknown input to configure docker action::Provided value was ${{ inputs.cache-provider }}"
+ ;;
+ esac
+
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.