Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
68/100 average clarity
702Strong · 80–100
1135Adequate · 60–79
582Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
This is a routine code cleanup in a Bitcoin library. It renames a simple data container from KeySource to KeyOrigin and gives it named fields (fingerprint and path) instead of numbered tuple slots (.0 and .1). The serialized format is inte…
This change is a routine internal cleanup: the key_expression crate stops depending directly on the secp256k1 cryptography library and instead uses a re-export provided by another internal crate called crypto. No user-facing behavior, type…
This is a small Cargo.toml fix in a Rust Bitcoin subcrate. When the optional 'serde' feature was enabled on the key_expression crate alone, it did not also enable serde on the network crate. That meant a type called NetworkKind could not b…
This is a routine update to a GitHub Actions helper used in automated testing workflows. It bumps the version of taiki-e/install-action, which downloads and installs Rust developer tools during CI runs. There is no change to the actual Bit…
This is a routine update to a GitHub Actions helper used only in automated security-scanning workflows. The new version adds minor improvements, including respecting proxy settings and verifying downloaded files with checksums. It does not…
Dependency bump of a third-party GitHub Action used in CI onlyUpstream release notes mention generic security improvements (checksum verification, npm install defaults, NO_PROXY)No CVE, advisory, or vendor security disclosure is present in the commit or supplied references
This commit removes automatic serde (serialization/deserialization) code generation from several Rust Bitcoin library crates and replaces it with hand-written implementations. The stated goal is to reduce dependencies and make the code eas…
Manual serde implementations replace derived ones, increasing the surface area for serialization-format bugsNo validation logic changes are visible in the diffNo mention of security fixes, CVEs, or vulnerability reports in commit message or PR description
This commit updates the project's automated Rust compiler version from 1.99.1 to 1.100.0 and adjusts a CI cache cleanup script to match a new directory layout used by Cargo 1.100. It is purely an infrastructure/maintenance change to keep a…
This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of interna…
CI guardrail added to prevent private dependency leaks into stable crate public APIsTool bump enables detection of re-exported private dependenciesNo source-code vulnerability is patched
This is a minor internal code cleanup in the Rust Bitcoin library. It changes how two functions (Xpriv::decode and Xpub::decode) build their error messages when an input is the wrong length. The behavior is the same before and after; only …
This is a routine API cleanup, not a security fix. The change removes one way of naming a Bitcoin unit ('MicroBitcoin' / 'uBTC') and keeps the equivalent 'bits' form. Any code that previously used the old name will fail to compile or fail …
No security signal: public API deprecation and enum variant removalNo memory safety, cryptographic, or consensus code modifiedError message change is informational only
This commit is a code cleanup and feature-gating refactor for the rust-bitcoin library's key_expression crate. It makes more BIP32 (Bitcoin wallet key derivation) types available when the 'alloc' memory allocator feature is disabled, and s…
Refactor of error types and parsing paths for Xpriv/Xpub base58 decodingSwitch from unbounded base58 decode to fixed-size array decode (78 bytes)Removal of explicit length-check error path in favor of decoder-reported length error
This change only adds `#[cfg_attr(miri, ignore)]` annotations to a handful of slow unit tests so they are skipped when run under Miri, a Rust interpreter used for detecting undefined behavior. It does not change any production code, consen…
This commit only updates version numbers in package configuration files (Cargo.toml) for internal dependencies so that all crates in the project require the same minimum versions of shared libraries. There are no code changes, no bug fixes…
This is a routine update to a GitHub Actions helper used in automated testing workflows. It changes which version of a third-party tool-installer action is used, but only for installing the cargo-mutants testing tool. There is no indicatio…
This commit updates the version of a helper tool called cargo-binstall used in two automated GitHub workflows. The change only affects internal build/CI tooling and does not alter the rust-bitcoin library code that users install or run. Th…
This is a routine update by Dependabot to the GitHub CodeQL upload-sarif action used in a scheduled security scanning workflow. It changes one pinned commit hash to a newer version of the same action. There is no indication this introduces…
This commit is a minor code cleanup in the Rust Bitcoin library. It changes how an error message is built when decoding BIP32 extended keys, switching from one nested construction style to two chained calls. The actual behavior and returne…
This commit fixes a bug in how optional Bitcoin amount and fee-rate values are read from JSON when those fields are inside a flattened struct and the value is null. Previously, the code would error out because it did not handle a special s…
Deserialization failure in optional numeric types under serde flattenMissing serde visitor method (visit_unit) causing runtime errorsRegression test added for null handling in flattened structs
This is a routine dependency update by Dependabot, bumping the version of a GitHub-provided action used to upload security scan results. There is no indication of a security vulnerability in the project itself or in this change.
This is a routine automated update by Dependabot that changes the version of a GitHub Action used to install Rust tools in two CI workflows. There is no indication of a security issue in the commit itself, and no verified security referenc…
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6992: primitives: Correct and clarify docsby Andrew Poelstra · 73db3a0a · Oct 14, 2026 · 16 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6992: primitives: Correct and clarify docs
8097bdaa1e9b92714f85d7f4f15b4e255021c242 primitives: Remove stale unstable note from README (Jamil Lambert, PhD) e9041b039c220fc64113b37a8788cf78537dae84 primitives: Document crate features and MSRV (Jamil Lambert, PhD) fa84c3fc7221ae97eb0b78e1eec02081108656b4 primitives: Capitalize Merkle in docs (Jamil Lambert, PhD) c9430965f58a6cb4f284e8ca1f3bdb519f89d9c7 primitives: Use BIP-XXXX notation (Jamil Lambert, PhD) bb760210458976ef9c3a8293a62720c7536c6afa primitives: Use standard CVE notation (Jamil Lambert, PhD) b7bcfac4d704e75c68906e537e5475168f78a1f9 primitives: Use third person in rustdoc summaries (Jamil Lambert, PhD) 04956357bbaeb025c8fc099b020f7a5998a57b9e primitives: Format witness docs consistently (Jamil Lambert, PhD) ccbf616a2e74efd2e348c270b791ca15df59d9fa primitives: Tidy script docs (Jamil Lambert, PhD) 7a2f58bef437f603042de081d59d011d0ac7fce8 primitives: Document decoder validity checks (Jamil Lambert, PhD) df7cc438ab6fbf012bcb9ab03b693f96aa3f79a7 primitives: Fix incorrect witness docs (Jamil Lambert, PhD) 5eb34b691c7b61a233c7e104902b1bf5d5a60910 primitives: Fix outdated transaction docs (Jamil Lambert, PhD) 548eb1381ded056531881e4da56d49776c11a684 primitives: Fix incorrect block validation docs (Jamil Lambert, PhD) 6a7a5a396783e20706bc34ad36740132bdb2dcf3 primitives: Fix incorrect script docs (Jamil Lambert, PhD) 8d2dae13cdb99a156a6d2348a9523e3ac215124e primitives: Fix incorrect opcode docs (Jamil Lambert, PhD)
Pull request description:
The primitives docs misdescribe some opcodes and witness behavior, overstate what block validation checks, and omit decoder rejection rules.
Correct the opcode descriptions against Bitcoin Core and the remaining claims against the implementation. Document crate features and MSRV, and align wording with project conventions.
Docs only changes.
ACKs for top commit: apoelstra: ACK 8097bdaa1e9b92714f85d7f4f15b4e255021c242; successfully ran local tests tcharding: ACK 8097bdaa1e9b92714f85d7f4f15b4e255021c242
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a documentation-only pull request for the rust-bitcoin primitives crate. It corrects and clarifies comments, README text, and rustdoc descriptions. No executable code, logic, or behavior was changed. The changes improve accuracy of descriptions about block validation, transaction decoding rules, opcodes, and witness behavior, but they do not alter how the software runs or fix any vulnerability.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6980: chacha20: Add 8 block processing on x86 with AVX2by Andrew Poelstra · 9df7fdea · Oct 13, 2026 · 2 filesMessage 100 · StrongInformational 17Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6980: chacha20: Add 8 block processing on x86 with AVX2
3440ac87a2e171e51f792f76918a9803fa8f4c48 chacha20: Add 8 block processing on x86 with AVX2 (rustaceanrob)
Pull request description:
This adds 8 block processing via the 256 bit registers supported by AVX2. Unlike SSE2 or Neon, AVX2 is detected during runtime. The steps are identical to the other SIMD files, except over 8 blocks rather than 4. Because of the `target_feature` flag, the unsafe annotation had to move to the function definition. I opted out of `cpu-features` because `no-std` users can compile with the AVX2 flag if SSE2 isn't enough. That seems like a very niche usecase to add an additional dependency considering this is primarily used in P2P contexts.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit adds a faster way to run the ChaCha20 encryption routine on modern Intel/AMD processors that support AVX2 instructions. It does not fix a bug and is not described as a security patch. The change is a performance optimization that processes 8 blocks at once instead of 4, with a runtime CPU-feature check so it only runs on compatible hardware. There is no indication in the commit or supplied references that this resolves a known vulnerability.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7034: build(deps): bump taiki-e/install-action from 2.85.8 to 2.85.12by Andrew Poelstra · 7641b3d1 · Oct 13, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7034: build(deps): bump taiki-e/install-action from 2.85.8 to 2.85.12
9f7802e98dfd18a4d35307fa231963d6632e2e51 build(deps): bump taiki-e/install-action from 2.85.8 to 2.85.12 (dependabot[bot])
Pull request description:
Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.85.8 to 2.85.12. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p> <blockquote> <h2>2.85.12</h2> <ul> <li> <p>Update <code>zola@latest</code> to 0.23.3.</p> </li> <li> <p>Update <code>wasm-tools@latest</code> to 1.256.0.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.2.10.</p> </li> <li> <p>Update <code>syft@latest</code> to 1.51.0.</p> </li> <li> <p>Update <code>prek@latest</code> to 0.4.13.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.8.4.</p> </li> <li> <p>Update <code>editorconfig-checker@latest</code> to 3.11.1.</p> </li> <li> <p>Update <code>cargo-tarpaulin@latest</code> to 0.37.1.</p> </li> <li> <p>Update <code>cargo-rdme@latest</code> to 2.2.1.</p> </li> <li> <p>Update <code>biome@latest</code> to 2.5.8.</p> </li> </ul> <h2>2.85.11</h2> <ul> <li> <p>Update <code>zola@latest</code> to 0.23.2.</p> </li> <li> <p>Update <code>wasm-bindgen@latest</code> to 0.2.127.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.12.3.</p> </li> <li> <p>Update <code>osv-scanner@latest</code> to 2.5.0.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.8.3.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 1.112.0.</p> </li> <li> <p>Update <code>editorconfig-checker@latest</code> to 3.10.0.</p> </li> </ul> <h2>2.85.10</h2> <ul> <li> <p>Update <code>uv@latest</code> to 0.12.2.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.2.7.</p> </li> <li> <p>Update <code>cosign@latest</code> to 3.1.3.</p> </li> <li> <p>Update <code>coreutils@latest</code> to 0.10.0.</p> </li> <li> <p>Update <code>cargo-rdme@latest</code> to 2.2.0.</p> </li> <li> <p>Update <code>cargo-crap@latest</code> to 0.4.3.</p> </li> </ul> <h2>2.85.9</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md">taiki-e/install-action's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes to this project will be documented in this file.</p> <p>This project adheres to <a href="https://semver.org">Semantic Versioning</a>.</p> <!-- raw HTML omitted --> <h2>[Unreleased]</h2> <h2>[2.87.27] - 2026-10-09</h2> <ul> <li> <p>Update <code>vacuum@latest</code> to 0.32.0.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.12.24.</p> </li> <li> <p>Update <code>typos@latest</code> to 1.51.1.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.7.3.</p> </li> <li> <p>Update <code>syft@latest</code> to 1.54.1.</p> </li> <li> <p>Update <code>release-plz@latest</code> to 0.3.170.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.10.4.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 2.11.1.</p> </li> <li> <p>Update <code>hyperfine@latest</code> to 2.0.0.</p> </li> <li> <p>Update <code>dprint@latest</code> to 0.61.1.</p> </li> <li> <p>Update <code>cargo-nextest@latest</code> to 0.9.148.</p> </li> <li> <p>Update <code>cargo-neat@latest</code> to 0.6.0.</p> </li> <li> <p>Update <code>cargo-binstall@latest</code> to 1.25.2.</p> </li> </ul> <h2>[2.87.26] - 2026-10-06</h2> <ul> <li> <p>Update <code>tombi@latest</code> to 1.7.2.</p> </li> <li> <p>Update <code>prek@latest</code> to 0.5.5.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.10.3.</p> </li> <li> <p>Update <code>kache@latest</code> to 1.0.0.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/taiki-e/install-action/commit/b20dedce73af6905cdc30d6611090c9b67557c8d"><code>b20dedc</code></a> Release 2.85.12</li> <li><a href="https://github.com/taiki-e/install-action/commit/952d13c8bb10d7e37f96fa2c8131338550a62663"><code>952d13c</code></a> ci: Skip cargo-rdme on x86_64 macOS</li> <li><a href="https://github.com/taiki-e/install-action/commit/c8724e7258d0b8f8188a94aec0c00ae9da81edd7"><code>c8724e7</code></a> Update <code>zola@latest</code> to 0.23.3</li> <li><a href="https://github.com/taiki-e/install-action/commit/1e2851961856b8e59aa67309dcdeb9fd45a60d51"><code>1e28519</code></a> Update <code>wasm-tools@latest</code> to 1.256.0</li> <li><a href="https://github.com/taiki-e/install-action/commit/16f665d1bb4999982189aa73d32553092c80f123"><code>16f665d</code></a> Update <code>tombi@latest</code> to 1.2.10</li> <li><a href="https://github.com/taiki-e/install-action/commit/25e38b2b350c9e2addea1001edc5b1f1b78063ed"><code>25e38b2</code></a> Update <code>syft@latest</code> to 1.51.0</li> <li><a href="https://github.com/taiki-e/install-action/commit/0f7e9596044f5db8a5ae0c0b7496f88f904d3685"><code>0f7e959</code></a> Update <code>prek@latest</code> to 0.4.13</li> <li><a href="https://github.com/taiki-e/install-action/commit/e6f5eae5835582e8aba218eae90439a2635f4db5"><code>e6f5eae</code></a> Update <code>mise@latest</code> to 2026.8.4</li> <li><a href="https://github.com/taiki-e/install-action/commit/d2b89fd558f00d5f5ee0f1809698cd002c9bd096"><code>d2b89fd</code></a> Update kingfisher manifest</li> <li><a href="https://github.com/taiki-e/install-action/commit/ac9692ffa4e50d3b54c0d5a10733aa529f6228d6"><code>ac9692f</code></a> Update <code>editorconfig-checker@latest</code> to 3.11.1</li> <li>Additional commits viewable in <a href="https://github.com/taiki-e/install-action/compare/cb33e69fad06166ca28a42b2575e4dadabf62ee8...b20dedce73af6905cdc30d6611090c9b67557c8d">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: apoelstra: ACK 9f7802e98dfd18a4d35307fa231963d6632e2e51; successfully ran local tests satsfy: ACK 9f7802e98dfd18a4d35307fa231963d6632e2e51
This is a routine Dependabot update that changes the version of a third-party GitHub Action used only in automated testing workflows. The action installs developer tools like cargo-mutants. There is no change to the actual Bitcoin library code, no user-facing behavior change, and no security issue described in the commit or its references.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7011: Use Returns headings only for complex return docsby Andrew Poelstra · ebc7dda3 · Oct 12, 2026 · 15 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7011: Use Returns headings only for complex return docs
Docs use `# Returns` headings inconsistently. Some return values that need several sentences or paragraphs and have no heading, while others that fit in a few words do.
Add `# Returns` headings where the return value needs a longer description, and replace headings on simple return docs with a single "Returns …" sentence.
Closes #7006
ACKs for top commit: satsfy: ACK 4959bf7e69eeb5ac7488402d0a95c8484517736c apoelstra: ACK 4959bf7e69eeb5ac7488402d0a95c8484517736c; successfully ran local tests tcharding: ACK 4959bf7e69eeb5ac7488402d0a95c8484517736c
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes documentation comments in Rust source files. It standardizes when to use '# Returns' headings versus simple 'Returns ...' sentences. No code behavior was altered, so there is no security impact.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7009: primitives: Fix hash serde invalid length error messageby Andrew Poelstra · 7e142bdb · Oct 11, 2026 · 1 fileMessage 91 · StrongInformational 20Details
Deserializing a hash from bytes of the wrong length gives "expected N", instead of the value of N in the error message.
Pass the visitor itself so the error uses `expecting()`, and includes the expected number of bytes.
Add a test that checks the error message contains the expected length.
ACKs for top commit: Kixunil: ACK b7b29a82ae0f2e51249174107c7fbc6cb150e0e2 apoelstra: ACK b7b29a82ae0f2e51249174107c7fbc6cb150e0e2; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit fixes only the wording of an error message shown when someone tries to deserialize a Bitcoin hash from the wrong number of bytes. It does not change any security behavior, validation, or data handling; it only makes the error message include the expected length (e.g., '32') instead of the placeholder text 'N'.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7008: primitives: Improve unit testsby Andrew Poelstra · f90bd5b5 · Oct 10, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7008: primitives: Improve unit tests
63a578061b8167d2238f4d58f611a10551a06744 primitives: Remove redundant alloc gates in tests (Jamil Lambert, PhD) 4aff57b93625a91766647ec2f4ea59cfeaab6e34 primitives: Fix typo in OutPoint serde test names (Jamil Lambert, PhD) 1520aba850184e11324f3a999e89996beb2c10ed primitives: Test lower hex for all hash types (Jamil Lambert, PhD) 9302d14aecc86204159e859c57ebcc071e59be17 primitives: Test as_byte_array for all hash types (Jamil Lambert, PhD) f835b0e9d5879a1ce73e7e6d07cc5465b48fc075 primitives: Rename witness test module to tests (Jamil Lambert, PhD) d3a0d0edc99d55b1da1eab8aabced5e870321adb primitives: Simplify Merkle root test assertions (Jamil Lambert, PhD) 3a71e1cf7ca0593c50c5eafea108f3cba43d90aa primitives: Remove duplicate Merkle root test code (Jamil Lambert, PhD)
Pull request description:
Several unit tests are inconsistent with the rest of the crate, hard to follow or could be improved:
- `merkle_root_batched` tests against a pasted copy of the default Merkle root code, replace it with `assert_roots_match` cases that test against the real code. - Some Merkle tests use `is_some`/`unwrap` with messages that repeat the test name, compare the option directly. - The witness test module is called `test` not `tests` like the others. - The hash byte array macro only checks `as_byte_array` when given an extra argument that is then ignored, always check it. - The lower hex tests miss `Txid` and `Wtxid`. - Two test names misspell "roundtrips" - Items are gated on `alloc` inside test modules that only exist with `alloc`.
Fix each of these in its own commit. Test changes only.
ACKs for top commit: apoelstra: ACK 63a578061b8167d2238f4d58f611a10551a06744; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only improves and cleans up unit tests in the rust-bitcoin library. It renames misspelled test functions, removes unnecessary feature gates, adds missing test cases for hash types, simplifies Merkle root test assertions, and renames a test module for consistency. There are no changes to production code, so this does not fix or introduce any security vulnerability.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7007: primitives: Add track_caller to panicking functionsby Andrew Poelstra · 0ef79473 · Oct 10, 2026 · 3 filesMessage 91 · StrongInformational 21Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7007: primitives: Add track_caller to panicking functions
Policy is to use `#[track_caller]` on functions that panic on invalid arguments. `ScriptBuf::reserve` and `reserve_exact` document a panic but don't have the attribute, and `with_capacity` has the same panic undocumented. `Witness` stores each element's offset as a `u32`, so `from_slice` and `push` panic, undocumented, if an element would start more than `u32::MAX` bytes in.
Remove two stale comments.
Add the attribute and document the panics.
Part of #5518
ACKs for top commit: Kixunil: ACK 83ff3989a412984114917e7cb278665b89a761d4 apoelstra: ACK 83ff3989a412984114917e7cb278665b89a761d4; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This change is a code-quality and documentation improvement, not a security fix. It adds Rust's #[track_caller] attribute to several functions that can panic when given extremely large inputs, and documents those panic conditions. The panics themselves already existed; the patch only makes error messages more accurate and documents behavior. There is no vulnerability being fixed.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7012: units: add track_caller to panic opsby Andrew Poelstra · 4369bd34 · Oct 10, 2026 · 6 filesMessage 100 · StrongInformational 19Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7012: units: add track_caller to panic ops
48fac6da7f6d4186083496cec217eee17ac06124 units: add track_caller to panic ops (satsfy (Renato Britto)) 9a6cbd9a33b16726e482931fbe4bbf7a603aebd6 units: propagate fn attrs in op macro (satsfy (Renato Britto))
Pull request description:
Part of https://github.com/rust-bitcoin/rust-bitcoin/issues/5518
Policy is to use `#[track_caller]` on functions that panic on invalid arguments. In units, there is arithmetic on block heights, weights, fee rates, etc. A panic links code inside units instead of at the caller mistake. The macro now copies fn attributes onto the impls it generates, so that `&a - &b` also links properly.
ACKs for top commit: apoelstra: ACK 48fac6da7f6d4186083496cec217eee17ac06124; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This change adds Rust's #[track_caller] annotation to arithmetic operations in the rust-bitcoin 'units' crate that can panic on invalid input (for example, subtracting a larger number from a smaller one). This annotation does not change whether or when panics happen; it only improves the quality of panic error messages by pointing to the caller's code instead of deep inside the library. It is a debugging/diagnostics improvement, not a security fix.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7001: units: fix serialization of optional amountsby Andrew Poelstra · 6585c779 · Oct 9, 2026 · 3 filesMessage 91 · StrongLow 48Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7001: units: fix serialization of optional amounts
cfa43314a5616e920201cb1c0d40403cff27a155 units: check Optional amount round trip with bincode (jrakibi) 4b4208ceaf5396b85bfb40e6ae8730e5b0b1a19d units: fix serialization of optional amounts (jrakibi)
Pull request description:
Serializing/deserializing an optional amount using `as_btc::opt` or `as_str::opt` does not round trip with bincode.
The issue is in serialization: we directly serialize the inner value instead of `Some` variant. So deserialization can fail or return incorrect value.
The first commit fixes the issue by using `serialize_some`, and updates serde_bincode to include the two missing bytes that encode `Some` (for unsigned_opt_as_btc and signed_opt_as_btc)
The second commit adds tests.
Found while auditing `units` crate with Codex. This may already be tracked in Loupe. I don’t have access to check.
ACKs for top commit: Abeeujah: ACK cfa43314a5616e920201cb1c0d40403cff27a155 apoelstra: ACK cfa43314a5616e920201cb1c0d40403cff27a155; successfully ran local tests; great catch!
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit fixes a bug in how optional Bitcoin amounts are serialized when using certain compact binary formats (like bincode). The code was writing the raw inner value for a Some(amount) instead of properly marking it as 'Some'. This could cause deserialization to fail or produce wrong values when round-tripping optional amounts. The fix changes the serializer to use the standard 'serialize_some' method and adds tests to confirm round-tripping now works.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7003: Fix creusot cache by running on push to `master`by Andrew Poelstra · bc026dc2 · Oct 9, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7003: Fix creusot cache by running on push to `master`
8f9a6dec87f84c5b125b144b8d6144d8437af5cb Fix creusot cache by running on push to `master` (Martin Habovstiak)
Pull request description:
According to the [documentation], PRs don't get to share their cache for security reasons which severely limits its usefulness to us. They can however restore the cache of the base branch which solves the issue but to have any cache on base branch we have to run Creusot on push.
This commit enables the cache on pushes to `master`. It is expected that this will require a full re-build but all subsequent builds which do not modify the dependencies should get faster.
Adding P-high label because not having this wastes a lot of time on every PR and fills our cache storage.
ACKs for top commit: apoelstra: ACK 8f9a6dec87f84c5b125b144b8d6144d8437af5cb; successfully ran local tests jamillambert: ACK 8f9a6dec87f84c5b125b144b8d6144d8437af5cb
This change simply tells GitHub to run the Creusot verification workflow whenever code is pushed to the master branch, in addition to running it on pull requests. The goal is to populate a build cache for the master branch so that future pull requests can reuse it and run faster. There is no change to the actual Bitcoin library code, no bug fix, and no security patch.
AI review queuedFix creusot cache by running on push to `master`by Martin Habovstiak · 8f9a6dec · Oct 8, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · Martin Habovstiak
Fix creusot cache by running on push to `master`
According to the [documentation], PRs don't get to share their cache for security reasons which severely limits its usefulness to us. They can however restore the cache of the base branch which solves the issue but to have any cache on base branch we have to run Creusot on push.
This commit enables the cache on pushes to `master`. It is expected that this will require a full re-build but all subsequent builds which do not modify the dependencies should get faster.
This commit changes the project's automated GitHub workflow so that a verification tool called Creusot also runs whenever code is pushed to the main 'master' branch. The only goal is to make the workflow's build cache work better for pull requests. There is no change to the actual Bitcoin library code, no bug fix, and no security vulnerability being addressed.
AI review queuedunits: fix serialization of optional amountsby jrakibi · 4b4208ce · Oct 8, 2026 · 2 filesMessage 80 · StrongModerate 50Details
Commit message · jrakibi
units: fix serialization of optional amounts
Optional amounts do not round trip with bincode because we directly serialize the inner value instead of `Some` variant. Deserialization can therefore fail or return incorrect values.
Use serialize_some in as_btc::opt and as_str::opt.
Also update serde_bincode to include the two missing bytes that encode `Some` (for unsigned_opt_as_btc and signed_opt_as_btc)
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 50/100
This commit fixes a bug in how optional Bitcoin amounts are serialized when using the bincode format. Previously, an optional amount like `Some(1 BTC)` was written as just the raw number/string, without the marker that says "this value is present." That meant when reading it back, the code could misinterpret the data or fail. The fix uses the standard `serialize_some` method so the `Some` wrapper is preserved. The test data file was also updated to include the two missing bytes that represent `Some`.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6983: build(deps): bump taiki-e/install-action from 2.85.4 to 2.85.8by Andrew Poelstra · 435caf98 · Oct 6, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6983: build(deps): bump taiki-e/install-action from 2.85.4 to 2.85.8
56216e18cb2861dd07d4fd00b49b093038e60d2d build(deps): bump taiki-e/install-action from 2.85.4 to 2.85.8 (dependabot[bot])
Pull request description:
Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.85.4 to 2.85.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p> <blockquote> <h2>2.85.8</h2> <ul> <li> <p>Update <code>zizmor@latest</code> to 1.29.0.</p> </li> <li> <p>Update <code>typos@latest</code> to 1.49.0.</p> </li> <li> <p>Update <code>trivy@latest</code> to 0.73.0.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.2.6.</p> </li> <li> <p>Update <code>prek@latest</code> to 0.4.12.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.8.1.</p> </li> <li> <p>Update <code>convco@latest</code> to 0.7.1.</p> </li> <li> <p>Update <code>cargo-semver-checks@latest</code> to 0.50.0.</p> </li> <li> <p>Update <code>cargo-crap@latest</code> to 0.4.1.</p> </li> </ul> <h2>2.85.7</h2> <ul> <li> <p>Update <code>wasmtime@latest</code> to 47.0.3.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.12.1.</p> </li> <li> <p>Update <code>rclone@latest</code> to 1.75.0.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 1.110.0.</p> </li> </ul> <h2>2.85.6</h2> <ul> <li> <p>Update <code>wasm-tools@latest</code> to 1.255.0.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.2.5.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.7.18.</p> </li> <li> <p>Update <code>cargo-neat@latest</code> to 0.5.3.</p> </li> <li> <p>Update <code>cargo-crap@latest</code> to 0.4.0.</p> </li> </ul> <h2>2.85.5</h2> <ul> <li> <p>Update <code>uv@latest</code> to 0.12.0.</p> </li> <li> <p>Update <code>syft@latest</code> to 1.50.0.</p> </li> <li> <p>Update <code>sccache@latest</code> to 0.17.0.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.7.16.</p> </li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md">taiki-e/install-action's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes to this project will be documented in this file.</p> <p>This project adheres to <a href="https://semver.org">Semantic Versioning</a>.</p> <!-- raw HTML omitted --> <h2>[Unreleased]</h2> <h2>[2.87.24] - 2026-10-04</h2> <ul> <li> <p>Update <code>wasmtime@latest</code> to 49.0.2.</p> </li> <li> <p>Update <code>dprint@latest</code> to 0.59.0.</p> </li> <li> <p>Update <code>cargo-leptos@latest</code> to 0.3.11.</p> </li> <li> <p>Update <code>cargo-insta@latest</code> to 1.49.0.</p> </li> <li> <p>Update <code>cargo-binstall@latest</code> to 1.25.0.</p> </li> </ul> <h2>[2.87.23] - 2026-10-03</h2> <ul> <li> <p>Update <code>wasm-tools@latest</code> to 1.261.0.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.12.22.</p> </li> <li> <p>Update <code>trivy@latest</code> to 0.75.0.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.7.1.</p> </li> <li> <p>Update <code>protoc-gen-connect-openapi@latest</code> to 0.28.0.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.10.0.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 2.9.1.</p> </li> <li> <p>Update <code>kache@latest</code> to 0.28.1.</p> </li> <li> <p>Update <code>espup@latest</code> to 0.18.0.</p> </li> <li> <p>Update <code>dprint@latest</code> to 0.58.0.</p> </li> <li> <p>Update <code>cargo-crap@latest</code> to 0.6.1.</p> </li> <li> <p>Update <code>cargo-auditable@latest</code> to 0.7.7.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/taiki-e/install-action/commit/cb33e69fad06166ca28a42b2575e4dadabf62ee8"><code>cb33e69</code></a> Release 2.85.8</li> <li><a href="https://github.com/taiki-e/install-action/commit/205431a517a990dfa58a0f22a02abd8cbef31c11"><code>205431a</code></a> Update <code>zizmor@latest</code> to 1.29.0</li> <li><a href="https://github.com/taiki-e/install-action/commit/e734f91b32f269a08deefc4ceb37d4aa4747a26b"><code>e734f91</code></a> Update wild manifest</li> <li><a href="https://github.com/taiki-e/install-action/commit/2596ecb10ea03dec655fc75e41a3b0f4dad7bc42"><code>2596ecb</code></a> Update <code>typos@latest</code> to 1.49.0</li> <li><a href="https://github.com/taiki-e/install-action/commit/a44271eb2d867e7b1cf13602d4e4f0a93eec2f5e"><code>a44271e</code></a> Update <code>trivy@latest</code> to 0.73.0</li> <li><a href="https://github.com/taiki-e/install-action/commit/9b100e5f66ebcc3ef6c9e7380611a923118c93bd"><code>9b100e5</code></a> Update <code>tombi@latest</code> to 1.2.6</li> <li><a href="https://github.com/taiki-e/install-action/commit/f28498427840d9dc2242c579fe43460aad78fb48"><code>f284984</code></a> Update <code>prek@latest</code> to 0.4.12</li> <li><a href="https://github.com/taiki-e/install-action/commit/3b86746a2ded65050e00646b310ebba2a15bdaf6"><code>3b86746</code></a> Update <code>mise@latest</code> to 2026.8.1</li> <li><a href="https://github.com/taiki-e/install-action/commit/9287d185066eec8a77c1f11905ac9727db063430"><code>9287d18</code></a> Update just manifest</li> <li><a href="https://github.com/taiki-e/install-action/commit/32702bef0f7f8c45b9b179686f51a0f2739378c3"><code>32702be</code></a> Update <code>convco@latest</code> to 0.7.1</li> <li>Additional commits viewable in <a href="https://github.com/taiki-e/install-action/compare/065d6a08a14e61e89fb0a4c10eecdbdef39c7d8e...cb33e69fad06166ca28a42b2575e4dadabf62ee8">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: apoelstra: ACK 56216e18cb2861dd07d4fd00b49b093038e60d2d; successfully ran local tests
This is a routine update by Dependabot to the version of a third-party GitHub Action used only in internal testing workflows. It does not change the project's actual Bitcoin library code, nor does it alter how user funds or data are handled. There is no indication this update fixes a security problem in the project itself.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6984: build(deps): bump github/codeql-action/upload-sarif from 4.37.3 to 4.37.6by Andrew Poelstra · de4dae2c · Oct 5, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6984: build(deps): bump github/codeql-action/upload-sarif from 4.37.3 to 4.37.6
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.37.3 to 4.37.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/upload-sarif's releases</a>.</em></p> <blockquote> <h2>v4.37.6</h2> <ul> <li>Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to <code>.github/codeql-config.yml</code> to align it with the suggested path that is used elsewhere. <a href="https://redirect.github.com/github/codeql-action/pull/4070">#4070</a></li> </ul> <h2>v4.37.5</h2> <ul> <li>Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the <code>init</code> Action instead of falling back to downloading the bundle before extracting it. <a href="https://redirect.github.com/github/codeql-action/pull/4061">#4061</a></li> </ul> <h2>v4.37.4</h2> <ul> <li>This version of the CodeQL Action adds support for the <code>tools</code> input for the <code>codeql-action/init</code> step to be specified using a <code>github-codeql-tools</code> <a href="https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization">repository property</a>. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to <code>toolcache</code> to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for <code>tools</code> in the workflow definition always takes precedence unless the value of the repository property starts with <code>!</code>. <a href="https://redirect.github.com/github/codeql-action/pull/4037">#4037</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.2">2.26.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4051">#4051</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/upload-sarif's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>4.38.2 - 24 Sept 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li> </ul> <h2>4.38.1 - 18 Sept 2026</h2> <ul> <li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li> </ul> <h2>4.38.0 - 09 Sept 2026</h2> <ul> <li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li> <li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li> </ul> <h2>4.37.9 - 26 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li> </ul> <h2>4.37.8 - 21 Aug 2026</h2> <p>No user facing changes.</p> <h2>4.37.7 - 13 Aug 2026</h2> <ul> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li> </ul> <h2>4.37.6 - 04 Aug 2026</h2> <ul> <li>Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to <code>.github/codeql-config.yml</code> to align it with the suggested path that is used elsewhere. <a href="https://redirect.github.com/github/codeql-action/pull/4070">#4070</a></li> </ul> <h2>4.37.5 - 03 Aug 2026</h2> <ul> <li>Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the <code>init</code> Action instead of falling back to downloading the bundle before extracting it. <a href="https://redirect.github.com/github/codeql-action/pull/4061">#4061</a></li> </ul> <h2>4.37.4 - 29 Jul 2026</h2> <ul> <li>This version of the CodeQL Action adds support for the <code>tools</code> input for the <code>codeql-action/init</code> step to be specified using a <code>github-codeql-tools</code> <a href="https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization">repository property</a>. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to <code>toolcache</code> to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for <code>tools</code> in the workflow definition always takes precedence unless the value of the repository property starts with <code>!</code>. <a href="https://redirect.github.com/github/codeql-action/pull/4037">#4037</a></li> <li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.2">2.26.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4051">#4051</a></li> </ul> <h2>4.37.3 - 22 Jul 2026</h2> <p>No user facing changes.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/5595ccaf912efad79be6eef63a5619ff05969be3"><code>5595cca</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4071">#4071</a> from github/update-v4.37.6-6a9359a1b</li> <li><a href="https://github.com/github/codeql-action/commit/ec9c75796a7f2cee5af0c5ffa0b81dc3bb58754b"><code>ec9c757</code></a> Add change note for PR 4070</li> <li><a href="https://github.com/github/codeql-action/commit/45c8742e17cbd668814137f95e605d925b8722a2"><code>45c8742</code></a> Update changelog for v4.37.6</li> <li><a href="https://github.com/github/codeql-action/commit/6a9359a1bd054c53cae7bb737bd8d796cfbf3014"><code>6a9359a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4070">#4070</a> from github/mbg/remote-address/change-file-default</li> <li><a href="https://github.com/github/codeql-action/commit/065cdc0394d424981db720df63ebc570e41b775f"><code>065cdc0</code></a> Change <code>DEFAULT_CONFIG_FILE_NAME</code></li> <li><a href="https://github.com/github/codeql-action/commit/f99dd5aeee9cf92e92d0c700cb0aa7afd7bbf431"><code>f99dd5a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4066">#4066</a> from github/dependabot/npm_and_yarn/js-yaml-5.2.2</li> <li><a href="https://github.com/github/codeql-action/commit/1804b211a343d69a6584d26fb3a68a8fe6ca39d4"><code>1804b21</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4068">#4068</a> from github/mergeback/v4.37.5-to-main-d1ba80a1</li> <li><a href="https://github.com/github/codeql-action/commit/3020a2f46286abb1704269b22ada83bd0e81c64f"><code>3020a2f</code></a> Rebuild</li> <li><a href="https://github.com/github/codeql-action/commit/93c3a5a40b7affbf8ea6a480767ed0db8e8d3c5c"><code>93c3a5a</code></a> Update changelog and version after v4.37.5</li> <li><a href="https://github.com/github/codeql-action/commit/d1ba80a13dd99fba24a470575428917156a28b43"><code>d1ba80a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4067">#4067</a> from github/update-v4.37.5-1cd4d01d5</li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81...5595ccaf912efad79be6eef63a5619ff05969be3">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: apoelstra: ACK d64049909130d66f25378926e263339094c1ee68; successfully ran local tests
This is a routine update to a GitHub Actions workflow that uploads security scan results. It bumps the version of GitHub's official CodeQL upload-sarif action from 4.37.3 to 4.37.6. The change only affects internal CI automation and does not alter the rust-bitcoin library code, its dependencies, or any software that users run.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6985: build(deps): bump dtolnay/rust-toolchain from 02cb101ec7c40f2c49e1d9714d64511d8e1b74de to 7e38f4b43b4db5c8dd498af069a4f6196df1d067by Andrew Poelstra · cff0520c · Oct 5, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6985: build(deps): bump dtolnay/rust-toolchain from 02cb101ec7c40f2c49e1d9714d64511d8e1b74de to 7e38f4b43b4db5c8dd498af069a4f6196df1d067
Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from 02cb101ec7c40f2c49e1d9714d64511d8e1b74de to 7e38f4b43b4db5c8dd498af069a4f6196df1d067. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/rust-toolchain/commit/7e38f4b43b4db5c8dd498af069a4f6196df1d067"><code>7e38f4b</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/rust-toolchain/issues/186">#186</a> from WaterWhisperer/feat/retry-install</li> <li><a href="https://github.com/dtolnay/rust-toolchain/commit/7645b072e70aa7a5ee7bb3e38735e66b822d8321"><code>7645b07</code></a> Retry release-server checksum failures</li> <li>See full diff in <a href="https://github.com/dtolnay/rust-toolchain/compare/02cb101ec7c40f2c49e1d9714d64511d8e1b74de...7e38f4b43b4db5c8dd498af069a4f6196df1d067">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: apoelstra: ACK ca2862297f98c78ae357e5dca46a26e90de855a3; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit is a routine update by Dependabot to the version of a GitHub Action used in the project's automated workflows. It only changes which copy of the 'dtolnay/rust-toolchain' helper is referenced in CI configuration files. There is no change to the actual Rust Bitcoin library code, no user-facing behavior change, and no security issue visible in the diff.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6971: units: Fix typosby Andrew Poelstra · 76d514ee · Oct 5, 2026 · 5 filesMessage 91 · StrongInformational 15Details
ACKs for top commit: Abeeujah: ACK 15413ce9ff6d63fdd4b7c94d7bd1829ddc9b0f20 apoelstra: ACK 15413ce9ff6d63fdd4b7c94d7bd1829ddc9b0f20; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only fixes spelling mistakes in comments and documentation strings. No program logic, calculations, or security behavior was changed.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6972: units: Use third person in rustdoc summariesby Andrew Poelstra · ce47c719 · Oct 5, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6972: units: Use third person in rustdoc summaries
e93332ab6f539eb5a843c23e7662c0ea9fd6ecd6 units: Use third person in rustdoc summaries (Jamil Lambert, PhD)
Pull request description:
The policy is for rustdoc summaries to be in third person, but a few are in imperative.
Change them to third person.
ACKs for top commit: Abeeujah: ACK e93332ab6f539eb5a843c23e7662c0ea9fd6ecd6 apoelstra: ACK e93332ab6f539eb5a843c23e7662c0ea9fd6ecd6; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only fixes the grammar of code documentation comments, changing phrases like 'Construct' to 'Constructs' and 'Attempt' to 'Attempts' in three source files. It does not change any actual program logic, function behavior, or security properties.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6920: primitives: Bound aggregate size and weight while decodingby Andrew Poelstra · 4a40980a · Oct 4, 2026 · 4 filesMessage 91 · StrongHigh 79Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6920: primitives: Bound aggregate size and weight while decoding
The streaming `WitnessDecoder`, `TransactionDecoder` and `BlockDecoder` each bound their individual fields but never the aggregate they retain, so an untrusted reader can be fed many individually legal fields that together far exceed any valid Bitcoin object and exhaust memory.
Reject a `Witness` whose combined serialized element size exceeds the 4 MB block-weight bound, and reject a `Transaction` or `Block` whose `Weight` exceeds the maximum block weight. Add regression tests for each.
ACKs for top commit: apoelstra: ACK f08650da5a538330445471b0c297145579b26164; successfully ran local tests tcharding: ACK f08650da5a538330445471b0c297145579b26164
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 79/100
This update fixes a memory-exhaustion risk in the rust-bitcoin library's streaming decoders for Bitcoin blocks, transactions, and witness data. Previously, an attacker could send many individually legal pieces of data that, when added together, created an impossibly large Bitcoin object, causing the receiving program to use excessive memory and possibly crash. The patch now rejects blocks, transactions, and witness stacks whose total size or weight exceeds Bitcoin's 4 MB block-weight limit during decoding, before all the data is fully loaded into memory. It also adds tests proving the new limits work.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6949: Manual nightly rustfmt (2026-09-27)by Andrew Poelstra · f6e33d78 · Oct 2, 2026 · 9 filesMessage 91 · StrongInformational 15Details
b9b241377dff148e10a66d6876cb310487916580 Run the formatter (Tobin C. Harding) 8dc70dd876bb44072e8eae8d8b439888852a3640 primitives: Don't format array (Tobin C. Harding)
Note the formatter is run with the listed toolchain but the manifest is not changed. This is to mimic #6944. I don't know where the bot is getting that toolchain from.
Patch 1 skips the offending code from review of 6944.
ACKs for top commit: apoelstra: ACK b9b241377dff148e10a66d6876cb310487916580; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is purely a code formatting cleanup. It adjusts whitespace, line breaks, import order, and adds a single #[rustfmt::skip] annotation so an automated formatter does not reformat a test data array. There are no functional code changes and no security implications.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6954: units: serialize unsigned amounts as u64by Andrew Poelstra · 295c9d8a · Oct 1, 2026 · 2 filesMessage 100 · StrongModerate 62Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6954: units: serialize unsigned amounts as u64
256ad0137832ac2bbbfb4053f570675fb1c72003 units: test amount varint serde round-trip (satsfy (Renato Britto)) ce1e998db1290a1d8da83d1a4c4a1393b41dd983 units: serialize unsigned amounts as u64 (satsfy (Renato Britto))
Pull request description:
A follow up of https://github.com/rust-bitcoin/rust-bitcoin/pull/6061#issuecomment-5751334257
`deserialize()` hinted u64 for unsigned amounts, but `serialize()` only ever wrote i64, so the two sides disagreed on the encoding. As a result, 100 sats became 200 sats in varint serialization format formats like postcard.
This state came about because we wanted serde errors to show each type's real range, and unsigned amounts to use a u64 hint so deserializers wouldn't be confused because the old errors complained about i64 first and only then about the real range, so users hit two failures. An unsigned amount should hint u64.
The problem is that, in varint formats like postcard, every amount reads back doubled. The zigzag encoding formula is `zigzag(n) = (n << 1) ^ (n >> 63)` for integer n in 64 bit representation. When n>0, (n>>63) is 0 and (n<<1) becomes n*2, so the number gets doubled on encoding, and then read as the doubled number directly on decoding. Also Amount::MAX fails because values ]10.5M,21M] BTC get doubled, surpassing the total bitcoin cap, then when range check looks at it on decoder, it rejects the input.
Serialization output format has changed, now matches the hint, and the `as_sat` token tests expect U64 for unsigned amounts.
ACKs for top commit: apoelstra: ACK 256ad0137832ac2bbbfb4053f570675fb1c72003; successfully ran local tests tcharding: ACK 256ad0137832ac2bbbfb4053f570675fb1c72003 Kixunil: ACK 256ad0137832ac2bbbfb4053f570675fb1c72003
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit fixes a mismatch in how unsigned Bitcoin amounts were serialized versus deserialized when using certain compact binary formats. Previously, an unsigned amount (like 100 satoshis) was written as a signed number, which caused formats such as postcard/bincode with varint encoding to silently double the value on read-back and to reject very large amounts near the Bitcoin supply cap. The fix makes serialization use the same unsigned 64-bit hint that deserialization already expected, so round-trips now produce the same value.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6947: build(deps): bump cargo-bins/cargo-binstall from 1.21.0 to 1.21.1by Andrew Poelstra · c1be49cb · Sep 30, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6947: build(deps): bump cargo-bins/cargo-binstall from 1.21.0 to 1.21.1
7d6cf2c9098e233bc50be845641a7bf8127a6a75 build(deps): bump cargo-bins/cargo-binstall from 1.21.0 to 1.21.1 (dependabot[bot])
Pull request description:
Bumps [cargo-bins/cargo-binstall](https://github.com/cargo-bins/cargo-binstall) from 1.21.0 to 1.21.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/cargo-bins/cargo-binstall/releases">cargo-bins/cargo-binstall's releases</a>.</em></p> <blockquote> <h2>v1.21.1</h2> <p><em>Binstall is a tool to fetch and install Rust-based executables as binaries. It aims to be a drop-in replacement for <code>cargo install</code> in most cases. Install it today with <code>cargo install cargo-binstall</code>, from the binaries below, or if you already have it, upgrade with <code>cargo binstall cargo-binstall</code>.</em></p> <h4>In this release:</h4> <ul> <li>Upgrade dependencies</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/cargo-bins/cargo-binstall/commit/e00d2c94cc0067b77737821097a62d91c0301baa"><code>e00d2c9</code></a> release: cargo-binstall v1.21.1 (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2616">#2616</a>)</li> <li><a href="https://github.com/cargo-bins/cargo-binstall/commit/dfefec18f56be1fb7ec8d1f4cfde42c305f29298"><code>dfefec1</code></a> chore: release (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2611">#2611</a>)</li> <li><a href="https://github.com/cargo-bins/cargo-binstall/commit/0bb9e27411a681176032498b17e01c0be66d8efd"><code>0bb9e27</code></a> dep: Upgrade transitive dependencies (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2614">#2614</a>)</li> <li><a href="https://github.com/cargo-bins/cargo-binstall/commit/57726869e28f4038a847ec56e5fdd9142fded110"><code>5772686</code></a> build(deps): bump the deps group across 1 directory with 2 updates (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2612">#2612</a>)</li> <li><a href="https://github.com/cargo-bins/cargo-binstall/commit/bfa50c12a896b5e070cc1aa726ad86875d1e5726"><code>bfa50c1</code></a> dep: Upgrade transitive dependencies (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2609">#2609</a>)</li> <li><a href="https://github.com/cargo-bins/cargo-binstall/commit/579c9db795e670961c988fe26c4c1bbe94de414b"><code>579c9db</code></a> build(deps): bump cargo-bins/release-pr from 2.1.3 to 2.1.4 (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2608">#2608</a>)</li> <li>See full diff in <a href="https://github.com/cargo-bins/cargo-binstall/compare/ead08b90bd7b2e6d81963fb9cf0b7239f66d5db4...e00d2c94cc0067b77737821097a62d91c0301baa">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: satsfy: ACK 7d6cf2c9098e233bc50be845641a7bf8127a6a75 apoelstra: ACK 7d6cf2c9098e233bc50be845641a7bf8127a6a75; successfully ran local tests
This commit updates the version of a helper tool (cargo-binstall) used only inside GitHub Actions automation. It is a routine dependency bump by Dependabot and does not change any code that ships to users. There is no indication of a security fix or vulnerability.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6948: build(deps): bump taiki-e/install-action from 2.83.2 to 2.85.4by Andrew Poelstra · d1431904 · Sep 29, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6948: build(deps): bump taiki-e/install-action from 2.83.2 to 2.85.4
3c06ee7bf1703e38d3c06b3e820ce555966ccc4f build(deps): bump taiki-e/install-action from 2.83.2 to 2.85.4 (dependabot[bot])
Pull request description:
Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.83.2 to 2.85.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p> <blockquote> <h2>2.85.4</h2> <ul> <li> <p>Update <code>uv@latest</code> to 0.11.33.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.7.15.</p> </li> <li> <p>Update <code>biome@latest</code> to 2.5.6.</p> </li> </ul> <h2>2.85.3</h2> <ul> <li> <p>Update <code>xh@latest</code> to 0.26.2.</p> </li> <li> <p>Update <code>ubi@latest</code> to 0.10.0.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.7.14.</p> </li> <li> <p>Update <code>martin@latest</code> to 1.13.0.</p> </li> <li> <p>Update <code>cargo-shear@latest</code> to 1.13.3.</p> </li> <li> <p>Update <code>cargo-binstall@latest</code> to 1.21.1.</p> </li> </ul> <h2>2.85.2</h2> <ul> <li> <p>Update <code>prek@latest</code> to 0.4.11.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.7.13.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 1.109.0.</p> </li> </ul> <h2>2.85.1</h2> <ul> <li> <p>Update <code>vacuum@latest</code> to 0.30.0.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.11.32.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.7.12.</p> </li> <li> <p>Update <code>cyclonedx@latest</code> to 0.33.1.</p> </li> <li> <p>Update <code>cargo-neat@latest</code> to 0.5.2.</p> </li> </ul> <h2>2.85.0</h2> <ul> <li> <p>Support <code>wild</code> (alias: <code>wild-linker</code>). (<a href="https://redirect.github.com/taiki-e/install-action/pull/1949">#1949</a>)</p> </li> <li> <p>Support <code>bpf-linker</code>. (<a href="https://redirect.github.com/taiki-e/install-action/pull/1950">#1950</a>)</p> </li> <li> <p>Support <code>rafn</code>. (<a href="https://redirect.github.com/taiki-e/install-action/pull/1935">#1935</a>, thanks <a href="https://github.com/DarkWanderer"><code>@DarkWanderer</code></a>)</p> </li> <li> <p>Update <code>cargo-neat@latest</code> to 0.5.1.</p> </li> <li> <p>Update <code>zizmor@latest</code> to 1.28.0.</p> </li> <li> <p>Update <code>wasmtime@latest</code> to 47.0.2.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md">taiki-e/install-action's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes to this project will be documented in this file.</p> <p>This project adheres to <a href="https://semver.org">Semantic Versioning</a>.</p> <!-- raw HTML omitted --> <h2>[Unreleased]</h2> <h2>[2.87.21] - 2026-09-26</h2> <ul> <li> <p>Update <code>wasm-bindgen@latest</code> to 0.2.129.</p> </li> <li> <p>Update <code>protoc-gen-connect-openapi@latest</code> to 0.27.3.</p> </li> <li> <p>Update <code>wasmtime@latest</code> to 49.0.1.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.12.19.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.9.13.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 2.7.0.</p> </li> </ul> <h2>[2.87.20] - 2026-09-24</h2> <ul> <li> <p>Update <code>uv@latest</code> to 0.12.18.</p> </li> <li> <p>Update <code>cargo-shear@latest</code> to 1.14.0.</p> </li> </ul> <h2>[2.87.19] - 2026-09-23</h2> <ul> <li> <p>Update <code>wasmtime@latest</code> to 49.0.0.</p> </li> <li> <p>Update <code>cargo-shear@latest</code> to 1.13.5.</p> </li> <li> <p>Update <code>cargo-nextest@latest</code> to 0.9.146.</p> </li> </ul> <h2>[2.87.18] - 2026-09-22</h2> <ul> <li> <p>Update <code>oxfmt@latest</code> to 1.84.0.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.9.12.</p> </li> <li> <p>Update <code>kache@latest</code> to 0.26.3.</p> </li> <li> <p>Update <code>cargo-tarpaulin@latest</code> to 0.37.4.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/taiki-e/install-action/commit/065d6a08a14e61e89fb0a4c10eecdbdef39c7d8e"><code>065d6a0</code></a> Release 2.85.4</li> <li><a href="https://github.com/taiki-e/install-action/commit/971197ad86f8f6f161d7a8d91f1d711c4c21f628"><code>971197a</code></a> Update <code>uv@latest</code> to 0.11.33</li> <li><a href="https://github.com/taiki-e/install-action/commit/3fc72354cdfd0f85327736793faab9b90a6282bb"><code>3fc7235</code></a> Update syft manifest</li> <li><a href="https://github.com/taiki-e/install-action/commit/7e230c19cf947f65a34e4e6f737c5f594c6779ba"><code>7e230c1</code></a> Update sccache manifest</li> <li><a href="https://github.com/taiki-e/install-action/commit/51f77e860854ede202e22ff29a94094601feca62"><code>51f77e8</code></a> Update <code>mise@latest</code> to 2026.7.15</li> <li><a href="https://github.com/taiki-e/install-action/commit/87ddca437422cbc964934ac7b2d8423c1838090a"><code>87ddca4</code></a> Update <code>biome@latest</code> to 2.5.6</li> <li><a href="https://github.com/taiki-e/install-action/commit/18b1216eba7f8039b0f8d131d5473787f0edce68"><code>18b1216</code></a> Release 2.85.3</li> <li><a href="https://github.com/taiki-e/install-action/commit/3a7eb9d7de04335647f871d88d8831485be842be"><code>3a7eb9d</code></a> Update <code>xh@latest</code> to 0.26.2</li> <li><a href="https://github.com/taiki-e/install-action/commit/3d4a0c1c709bc0f907c2a23b1a17cf6296b08298"><code>3d4a0c1</code></a> Update uv manifest</li> <li><a href="https://github.com/taiki-e/install-action/commit/9e4a53cd83bbbd84b17bc14008d4b067b9e99edb"><code>9e4a53c</code></a> Update <code>ubi@latest</code> to 0.10.0</li> <li>Additional commits viewable in <a href="https://github.com/taiki-e/install-action/compare/43aecc8d72668fbcfe75c31400bc4f890f1c5853...065d6a08a14e61e89fb0a4c10eecdbdef39c7d8e">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: satsfy: ACK 3c06ee7bf1703e38d3c06b3e820ce555966ccc4f apoelstra: ACK 3c06ee7bf1703e38d3c06b3e820ce555966ccc4f; successfully ran local tests
This is a routine update by Dependabot to the version of a third-party GitHub Action used in the project's automated testing workflows. The change only affects internal continuous integration (CI) scripts, not the actual Bitcoin library code that users install. There is no indication of a security issue in the commit or supplied references.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6915: primitives: Fix `Witness` handling of oversized itemsby Andrew Poelstra · e1ed5884 · Sep 27, 2026 · 3 filesMessage 91 · StrongHigh 71Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6915: primitives: Fix `Witness` handling of oversized items
8caa5f364f2e31894090eb6911a6e796c7519784 primitives: Test coinbase witness count validated (Jamil Lambert, PhD) b8b78386dc47d434ca24e650007846362ad746b7 primitives: Check coinbase witness count (Jamil Lambert, PhD) e6068218a02f9ae469d2881eb431be1f6ae45de9 primitives: Test wtxid with oversized elements (Jamil Lambert, PhD) fa8c510647aa3ae0c9f8a9acfc4f0df3df7f86c2 primitives: Hash the full witness encoding (Jamil Lambert, PhD) 822d6e01fbbf502d9867a20b0bafed180163106d primitives: Test oversized Witness equality (Jamil Lambert, PhD) 2b2fea885c73ef35757b847d67fafeeed3be7e39 primitives: Fix oversized Witness slice equality (Jamil Lambert, PhD) 4a5855bce5ee5fcbe0ab3d89323dd699d81b911b primitives: Test Witness::size for oversized item (Jamil Lambert, PhD) c529e02377930cad43c980a33258052983b3da6e primitives: Fix Witness::size oversized item (Jamil Lambert, PhD)
Pull request description:
`Witness::iter` stops before an item larger than it will decode, but `Witness::len` still counts it. Consumers that trusted the iterator then mishandled a `Witness` holding such an item: `size` undercounted its bytes, slice equality reported it equal to a different one-element stack, and the `wtxid` dropped it. The coinbase commitment check also collected the whole `Witness` before testing its length.
Compute `size` from the stored serialized length, compare witnesses through their iterators, hash the full `Witness` encoding into the `wtxid`, and check the coinbase witness length before reading it.
ACKs for top commit: apoelstra: ACK 8caa5f364f2e31894090eb6911a6e796c7519784; successfully ran local tests tcharding: ACK 8caa5f364f2e31894090eb6911a6e796c7519784 satsfy: tACK 8caa5f364f2e31894090eb6911a6e796c7519784
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 71/100
This commit fixes a bug in how the Rust Bitcoin library counts and compares transaction witness data when a witness contains an oversized item. Previously, several functions relied on an iterator that silently skips oversized items, causing the reported size to be too small, equality checks to wrongly treat different witnesses as equal, and transaction witness IDs (wtxid) to ignore the oversized data. The patch makes these operations use the full stored witness encoding instead. It also fixes a coinbase block validation check so it rejects multi-item coinbase witnesses in constant time rather than collecting and possibly truncating them.
div_by_fee_rate_ceil used to_sat_per_kwu_ceil() as the divisor, collapsing FeeRate from sat/MvB precision down to sat/kwu before dividing. This rounds the divisor up, which potentially produces a weight too small to cover the fee budget.
Switch to to_sat_per_mvb() at full precision in u128, matching the recent fix applied to div_by_fee_rate_floor in #6884.
ACKs for top commit: tcharding: ACK 75e087f15d314b892c1d80a961e989a91615acd2 apoelstra: ACK 75e087f15d314b892c1d80a961e989a91615acd2; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 48/100
This commit fixes a rounding bug in how the rust-bitcoin library calculates the minimum transaction weight needed to pay a given fee at a given fee rate. The old code rounded the fee rate up too early, which could produce a weight slightly smaller than actually required. In practice, that means a wallet relying on this function might think a transaction meets its fee target when it actually falls a tiny bit short. The fix performs the division at full precision, matching a similar recent fix for the floor-division variant.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6909: build(deps): bump actions/labeler from 6.2.0 to 7.0.0by Andrew Poelstra · 4ed7c068 · Sep 21, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6909: build(deps): bump actions/labeler from 6.2.0 to 7.0.0
f6c31cbd78e1142d2454ec3fe7979b755c56e12e build(deps): bump actions/labeler from 6.2.0 to 7.0.0 (dependabot[bot])
Pull request description:
Bumps [actions/labeler](https://github.com/actions/labeler) from 6.2.0 to 7.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p> <blockquote> <h2>v7.0.0</h2> <h2>What's Changed</h2> <h3>Enhancements:</h3> <ul> <li>Migrate to ESM and update dependencies by <a href="https://github.com/chiranjib-swain"><code>@chiranjib-swain</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/949">actions/labeler#949</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v6...v7.0.0">https://github.com/actions/labeler/compare/v6...v7.0.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/labeler/commit/bf12e9b00b37c5c0ca2b87b79b2daf7891dbda13"><code>bf12e9b</code></a> feat: migrate to ESM and update dependencies (<a href="https://redirect.github.com/actions/labeler/issues/949">#949</a>)</li> <li>See full diff in <a href="https://github.com/actions/labeler/compare/b8dd2d9be0f68b860e7dae5dae7d772984eacd6d...bf12e9b00b37c5c0ca2b87b79b2daf7891dbda13">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: apoelstra: ACK f6c31cbd78e1142d2454ec3fe7979b755c56e12e; successfully ran local tests satsfy: ACK f6c31cbd78e1142d2454ec3fe7979b755c56e12e
This commit updates a GitHub Actions automation tool (actions/labeler) used to automatically tag pull requests with labels. It is a routine dependency version bump from 6.2.0 to 7.0.0, with no indication of a security fix or vulnerability. The change only affects internal project workflow automation and does not touch the rust-bitcoin library code that users install.