RB
← All projectsRust Bitcoin

rust-bitcoin

Rust library for Bitcoin data structures, serialization, consensus encoding, and scripts.

BitcoinCryptographic librariesNormal
Repository coverage

2070 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

459security candidates448second-pass queue999AI analyses
188commits · 30 days
404commits · 60 days
1283commits · 180 days
2064commits · 365 days
Backfill bands
Aug 5 → Feb 6787 seen32 candidatesComplete
Feb 6 → Jun 6878 seen53 candidatesComplete
Jun 6 → Jul 6211 seen15 candidatesComplete
Jul 6 → Aug 5184 seen2 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

64/100 average clarity
311Strong · 80–100
1054Adequate · 60–79
555Thin · 40–59
150Opaque · 0–39
20security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Mitchell Bagot640192345068
Tobin C. Harding40965154063
jrakibi944963068
Nick Johnson1892099059
Andrew Poelstra512035075
Jamil Lambert, PhD1141849061
Fmt Bot311421045
Trevor Arjeski111111069
Shing Him Ng31724056
Ismail Daif22612050
satsfy (Renato Britto)17611066
Martin Habovstiak27511069
Analysis record

Published AI watches

Last scanned 30 minutes ago

Informational 15 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6671: units: reword docs from height to count in relative locktime

This commit only changes documentation comments and variable names in the rust-bitcoin library. It rewords references to 'block height' as 'block count' for relative locktime, because a relative locktime measures elapsed blocks since a coi…

6ea4ff92by Andrew Poelstra+20−172 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6670: ci: fix labeller permissions

This is a routine GitHub Actions workflow fix. The change gives the automated PR labeler workflow permission to download artifacts and explicitly tells the GitHub CLI which repository to act on. It does not change the Bitcoin library code,…

CI workflow permission fixNo source code changesNo cryptographic or consensus changes
276e0a61by Andrew Poelstra+5−01 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6657: Release tracking PR: `base58ck 0.5.0`

This commit is a routine version bump for the base58ck crate from 0.4.0 to 0.5.0. It only updates version numbers in package manifests, lock files, and adds a changelog entry. There are no code changes and no security relevance.

9deb5de1by Andrew Poelstra+22−168 files
No security note in commit
Informational 21 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6440: base58: Introduce `decode_check_to_array` for alloc-less decoding

This commit is a routine feature addition to the rust-bitcoin base58 crate. It adds a new no-allocator function to decode short base58-check strings into fixed-size byte arrays, and renames the existing error type while keeping a deprecate…

No security-relevant bug fix is described in the commit message or diff.New decoding path uses a fixed 128-byte scratch buffer (`ArrayVec`) and rejects oversized inputs.Checksum verification and invalid-character handling are preserved from the existing alloc implementation.
c5fd1832by Andrew Poelstra+330−775 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6646: hashes: add several methods to `Midstate` and release 1.2.0

This commit is a routine feature release for the bitcoin_hashes crate. It adds new public methods and a constant to the SHA-256 Midstate type so developers can compute SHA-256 midstates in const contexts. There is no indication of a securi…

0f68fcb3by Andrew Poelstra+157−4210 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

units: reword docs to block count in relative locktime

This commit only rewords documentation comments and variable names in the codebase. It changes references from 'block height' to 'block count' for relative lock times, which is a terminology correction with no functional code changes. Ther…

8867fe2eby satsfy (Renato Britto)+20−172 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6667: Make the `WitnessesEncoder` private

This commit makes a small internal helper type called WitnessesEncoder private. It was previously exported as public API but is only used inside the transaction encoder. The change removes it from the public API surface and moves the code …

07d91f7fby Andrew Poelstra+54−1324 files
No security note in commit
Informational 12 AI analysisMessage 75 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

ci: fix labeller permissions

This commit adjusts a GitHub Actions workflow that automatically labels pull requests based on CI results. It adds a built-in repository token, tells the artifact download step to merge single-file artifacts, and explicitly sets the reposi…

Workflow-only change with no library code modificationsUses the default GITHUB_TOKEN rather than a custom secretRuns in workflow_run context, which already has elevated repository access by design
715f2bd6by Nick Johnson+5−01 file
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6661: units: Remove `From<u16>` from `NumberOfBlocks`

This is a routine API cleanup, not a security fix. The developers removed a shortcut that let programmers create a 'number of blocks' value directly from any u16 number, replacing it with an existing named constructor called from_height. T…

ed5f1b68by Andrew Poelstra+18−358 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6668: Scrub the transaction encoding logic

This commit is a pure code reorganization (refactor) in the rust-bitcoin library. It moves transaction encoding and decoding definitions around within a single file so the code follows the project's preferred layout. No logic, behavior, or…

c5588ba5by Andrew Poelstra+57−571 file
No security note in commit
Informational 18 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6662: build(deps): bump actions/checkout from 6.0.2 to 6.0.3

This commit is a routine update to the GitHub Actions checkout tool used by the project's automated workflows. It changes the pinned version from 6.0.2 to 6.0.3 across many workflow files. The newer version fixes minor bugs related to SHA-…

Dependency bump of actions/checkout to a patch releaseUpstream fixes for SHA-256 repository checkout and merge commit regexAll affected workflows already disable persisted credentials
f7d364cdby Andrew Poelstra+29−2915 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6663: build(deps): bump taiki-e/install-action from 2.79.12 to 2.81.4

This is a routine Dependabot update that bumps the version of a third-party GitHub Action used only in automated testing workflows. The change does not touch the project's actual Bitcoin library code, and there is no indication it fixes or…

5c92c0b0by Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Update the API text files

This commit only updates two generated API text files that list the public surface of the Rust crate. It removes entries for a `WitnessesEncoder` type, reflecting that the type is no longer part of the public API. There is no source code c…

9c391145by Tobin C. Harding+0−782 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Scrub the transaction encoding logic

This commit is a pure code reorganization: it moves existing transaction encoding and decoding definitions around within a single file so they follow the project's preferred layout. No logic was changed, no security bug was fixed, and no n…

80dcef15by Tobin C. Harding+57−571 file
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Make the WitnessesEncoder private

This commit simply hides an internal helper type called WitnessesEncoder from public view. It is a routine API-cleanup change with no security relevance visible in the code or commit message.

b37accc3by Tobin C. Harding+54−542 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

release bitcoin_hashes 1.2.0

This commit is a routine version bump for the bitcoin_hashes library from version 1.1.0 to 1.2.0. It only updates lock files, the package version number, and the changelog. There is no code change and no security relevance visible in the c…

8899dfd2by Andrew Poelstra+27−224 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump astral-sh/setup-uv from 8.1.0 to 8.2.0

This is a routine automated update by Dependabot that changes the pinned version of a GitHub Action used to install the 'uv' Python tool in two workflow files. The new commit hash corresponds to the legitimate 8.2.0 release of astral-sh/se…

1c438632by dependabot[bot]+2−22 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump github/codeql-action/upload-sarif

This is a routine automated update by Dependabot that changes the pinned version of a GitHub-provided security scanning helper used in a workflow. It does not modify the project's actual Bitcoin library code, its cryptographic logic, or an…

5293bee4by dependabot[bot]+1−11 file
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump taiki-e/install-action from 2.79.12 to 2.81.4

This is a routine Dependabot update that bumps a GitHub Actions helper used in automated testing workflows from version 2.79.12 to 2.81.4. It only changes which version of the action is invoked during CI runs; it does not modify the Rust B…

eb9544f9by dependabot[bot]+2−22 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump actions/checkout from 6.0.2 to 6.0.3

This is a routine automated update by Dependabot that bumps the GitHub Actions 'actions/checkout' dependency from version 6.0.2 to 6.0.3 across all project workflow files. It only changes pinned commit hashes and version comments for the a…

Routine patch-level dependency bumpNo changes to permissions, inputs, or workflow logicpersist-credentials: false already present on all checkout steps
ae935fadby dependabot[bot]+29−2915 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedrefactor: remove redundant clones in bitcoin crateby Klaklax · 4649e5cf · Oct 24, 2025 · 3 filesMessage 62 · AdequateInformational 15Details
Commit message · Klaklax

refactor: remove redundant clones in bitcoin crate

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a minor code cleanup that removes unnecessary copy operations (clones) inside test code only. It does not change any production behavior and has no security relevance.

AI review queuedAdd transaction decode round trip testby Jamil Lambert, PhD · 9f79146f · Oct 23, 2025 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · Jamil Lambert, PhD

Add transaction decode round trip test

There is a mutant in push_bytes.

Add a transaction encode/decode round trip test to kill it.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new test that encodes a Bitcoin transaction and decodes it again to make sure the result matches the original. It does not change any production code, fix a bug, or introduce a security issue. The commit message mentions a 'mutant in push_bytes,' which is testing jargon for a surviving fake code change during mutation testing, not a real vulnerability.

AI review queuedAdd decode segwit testby Jamil Lambert, PhD · 29cb875e · Oct 23, 2025 · 1 fileMessage 61 · AdequateInformational 12Details
Commit message · Jamil Lambert, PhD

Add decode segwit test

There is a mutant in <impl Decoder for TransactionDecoder>::push_bytes.

Add a test that decoding a transaction with 1 input but no witnesses
for any input errors.

61/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds a new test case. It does not change any production code. The test checks that decoding a SegWit-formatted transaction with no witness data correctly produces an error. There is no fix or behavior change in the actual decoder.

AI review queuedRemove unused comments on TransactionExt trait implementationby Mitchell Bagot · 43ae5fa9 · Oct 23, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Mitchell Bagot

Remove unused comments on TransactionExt trait implementation

Comments applied to function implementations of traits do not render
in compiled Rust documentation. The TransactionExt trait implementation
for Transaction includes two such comments that duplicate similar
warnings present in the trait definition.

This patch removes the useless comments above the functions
total_size and base_size in the TransactionExt implementation of
Transaction.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only removes two short documentation comments from a Rust trait implementation. The actual code behavior is unchanged. There is no security relevance.

AI review queuedMove encode_to_hash_engine to hashes from consensus_encodingby Mitchell Bagot · 1a3dfbe5 · Oct 22, 2025 · 8 filesMessage 85 · StrongInformational 18Details
Commit message · Mitchell Bagot

Move encode_to_hash_engine to hashes from consensus_encoding

The encode_to_hash_engine function created a dependency on hashes from
consensus_encoding. Since consensus_encoding is moving to 1.0, it is
best to remove the dependency on the pre-1.0 hashes crate.

This patch moves the encode_to_hash_engine function to the hashes
crate, and reverses the dependency so that hashes now depends on
consensus_encoding instead of vice-versa.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 18/100

This is a routine internal code reorganization. A helper function that feeds encoded data into a hash calculation was moved from one Rust crate to another, and the dependency direction between those two crates was reversed. The actual logic of the function did not change, and there is no indication this fixes or introduces a security bug.

AI review queued2025-10-19 automated rustfmt nightlyby Fmt Bot · 24e7124a · Oct 19, 2025 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Fmt Bot

2025-10-19 automated rustfmt nightly

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is an automated code-formatting commit from rustfmt. It only changes whitespace, line breaks, and brace style in two source files. No program logic, behavior, or security properties were changed.

AI review queuedconsensus_encoding: add more encode/decode testsby Nick Johnson · 6fadad68 · Oct 18, 2025 · 2 filesMessage 78 · AdequateInformational 15Details
Commit message · Nick Johnson

consensus_encoding: add more encode/decode tests

A bunch of corner cases and boundary condition tests. Some of these
boundary cases are not actually part of the explicit contract, but we
would want to know if the behavior changed since it is exposed to the
caller.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new unit tests for encoding and decoding routines in the rust-bitcoin consensus_encoding crate. It does not change any production code, fix bugs, or alter behavior. The tests cover corner cases such as zero-length arrays, empty slices, boundary values for compact-size integers, and state transitions in combined encoders/decoders.

AI review queuedRemove doc_auto_cfgby Tobin C. Harding · 3f332405 · Oct 17, 2025 · 11 filesMessage 33 · OpaqueInformational 15Details
Commit message · Tobin C. Harding

Remove doc_auto_cfg

This was removed in recent nightly and is breaking all the docs builds
when we try and publish crates.

33/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Provides an explanatory body! Too few words to establish purpose
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes a Rust compiler feature flag called doc_auto_cfg from 11 library files. The feature was removed in recent nightly Rust compilers and was causing documentation builds to fail when publishing crates. It is purely a build/documentation compatibility fix with no effect on the actual Bitcoin code or its security.

AI review queuedAdd fuzz targets for consensus_encoding crateby Nick Johnson · ecadab6c · Oct 17, 2025 · 7 filesMessage 78 · AdequateInformational 15Details
Commit message · Nick Johnson

Add fuzz targets for consensus_encoding crate

The four new targets focus on the decoding half of the exposed API. This
is the half which deals with consuming bytes from unknown sources.
Encoding on the other hand probably wouldn't benefit much from fuzzing
since all bytes are known before the operation.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidenceparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new fuzz testing targets for the consensus_encoding crate. Fuzz testing is an automated quality-assurance technique that feeds random or crafted inputs to code to find crashes or unexpected behavior. The commit does not change any production library code, so it cannot by itself introduce a security vulnerability or fix one.

AI review queuedunits: Bump version to 1.0.0-rc.1by Tobin C. Harding · cf10e50d · Oct 17, 2025 · 7 filesMessage 68 · AdequateInformational 15Details
Commit message · Tobin C. Harding

units: Bump version to 1.0.0-rc.1

In preparation for release bump the version, update the 1.0.0
changelog, and update the lock files.

While we are at it add an explicit version number to the dependency in
`p2p`, `bitcoin`, and `primitives`.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit is a routine release preparation: it bumps the version number of the `bitcoin-units` crate from 1.0.0-rc.0 to 1.0.0-rc.1, updates the two lock files, adds an explicit version requirement to the dependency declarations in three other crates, and moves a couple of changelog entries under the new release heading. There are no code changes, no bug fixes, and no security-relevant behavior changes in the diff.

AI review queuedchore: clarify TODO comment in Cargo.tomlby Ethfan · 33a3f957 · Oct 16, 2025 · 1 fileMessage 37 · OpaqueInformational 15Details
Commit message · Ethfan

chore: clarify TODO comment in Cargo.toml

37/100 · OpaqueMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only rewords a code-comment in a configuration file. It changes 'TODO' to 'TODO: Consider enabling this lint.' There is no code change, no behavior change, and no security relevance.

AI review queuedUpdate transaction.rsby sashaodessa · 7890935d · Oct 16, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · sashaodessa

Update transaction.rs

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes two spelling mistakes in code comments ('coversion' to 'conversion'). No program logic, behavior, or security properties were changed.

AI review queuedfix typoby Forostovec · 46506337 · Oct 15, 2025 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · Forostovec

fix typo

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit corrects a single-word typo in a documentation comment. The comment for the Decodable trait incorrectly said 'encoded' and now correctly says 'decoded'. No code behavior changes.

AI review queuedUpdate API text filesby Tobin C. Harding · fcfaafcb · Oct 15, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Tobin C. Harding

Update API text files

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates a generated text file that records the project's public API surface. It changes the documented return type of several encoder helper methods from 'optional byte slice' to 'byte slice'. No actual source code, logic, or behavior changed, so there is no security issue in this commit itself.

AI review queuedconsensus_encoding: composite error typesby Nick Johnson · 9f93c901 · Oct 14, 2025 · 6 filesMessage 58 · ThinInformational 17Details
Commit message · Nick Johnson

consensus_encoding: composite error types

Ditch the complexity of the From implementation mapping for decoder
errors and just have predefined composites for 2,3,4, and 6.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit is a routine internal refactoring of how composite decoders report errors in the rust-bitcoin library. It replaces a generic error-mapping scheme with fixed error types for decoders that combine 2, 3, 4, or 6 sub-decoders. There is no indication this fixes a security bug or changes how data is parsed; it only changes the shape of error values returned when parsing fails.

AI review queuedAdd documentation for panics during size calculationsby Shing Him Ng · c3e1bdc1 · Oct 14, 2025 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Shing Him Ng

Add documentation for panics during size calculations

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds documentation comments explaining that certain size-calculation functions can panic if an arithmetic overflow occurs. It does not change any actual code behavior, fix a bug, or introduce new functionality. There is no security-relevant code change.

AI review queuedRemove stale comment in transaction decodingby Tobin C. Harding · fa480cbb · Oct 14, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Tobin C. Harding

Remove stale comment in transaction decoding

This comment is stale now that we remove the old transition stuff.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only removes two lines of stale explanatory comment from transaction decoding code. No code behavior changes, no security relevance.

AI review queuedchore: fix typosby Galoretka · 94498e07 · Oct 14, 2025 · 3 filesMessage 40 · ThinInformational 15Details
Commit message · Galoretka

chore: fix typos

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes spelling mistakes in comments and documentation strings. No code behavior was changed, so it has no security impact.

AI review queuedconsensus_encoding: remove Transitioning stateby Nick Johnson · 144adfce · Oct 13, 2025 · 1 fileMessage 58 · ThinInformational 11Details
Commit message · Nick Johnson

consensus_encoding: remove Transitioning state

Simplify the Decoder2State by dropping the unnecessary Transitioning
variant. We can just use the Errored variant and not change the state
of the Decoder2 if the first decoder fails while transitioning to the
second.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 11/100

This is a small internal code cleanup in a Rust Bitcoin library. It removes an unused 'Transitioning' state from a two-stage data decoder and simplifies how the decoder switches from its first stage to its second stage. There is no indication this fixes a security vulnerability or changes observable behavior for users.

AI review queuedprimitives: fix TransactionDecoder::end to not panic on early calls to endby Andrew Poelstra · 93db1e0d · Oct 13, 2025 · 1 fileMessage 83 · StrongLow 47Details
Commit message · Andrew Poelstra

primitives: fix TransactionDecoder::end to not panic on early calls to end

If the data stream ends early we shouldn't panic. This is not a programmer
error. It indicates that we ran out of data.

This one has observable changes. Unit test in next commit.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 47/100

This commit fixes a panic (sudden crash) in the Rust Bitcoin library's transaction decoder. Previously, if a caller tried to finish decoding a Bitcoin transaction before all its data had been received, the program would crash with a panic. Now it returns a normal error instead, which is safer and easier for applications to handle gracefully.

AI review queuedprimitives: renamed TransactionDecoderError::Transitioning to Erroredby Andrew Poelstra · e86a56c6 · Oct 13, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Andrew Poelstra

primitives: renamed TransactionDecoderError::Transitioning to Errored

Search-and-replace the error variant name, and update all the panic
conditions that are triggered by it. From a user point of view this
state does not represent "transitioning". It represents that we
called end() on a sub-decoder and that call yielded an error,
leaving us with no meaningful state.

The docs for Decoder::end and Decoder::current_chunk say that after
returning the initial error we are allowed to panic; update the panic
message to say that this is what we're doing. (We also have a panic
in read_limit, which we are not allowed to do, so replace that with
a dummy value return.)

No observable behavior changes except that some panic messages change.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple internal rename and documentation cleanup. It renames a temporary error state inside a Bitcoin transaction decoder from 'Transitioning' to 'Errored' and updates the panic messages to be clearer. It also removes one panic that shouldn't have been there and replaces it with a safe dummy value. There are no observable behavior changes for users.

AI review queuedprimitives: add unit test for incomplete transaction decodingby Andrew Poelstra · 27fbdf9b · Oct 13, 2025 · 1 fileMessage 60 · AdequateInformational 12Details
Commit message · Andrew Poelstra

primitives: add unit test for incomplete transaction decoding

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds a new unit test that checks how the library handles incomplete Bitcoin transaction data. It does not change any production code, fix a bug, or introduce a security feature. The test verifies that decoding truncated transaction bytes correctly produces an error rather than a valid transaction.

AI review queuedprimitives: remove a bunch of panics from Transaction::decoderby Andrew Poelstra · 681af667 · Oct 13, 2025 · 1 fileMessage 85 · StrongInformational 13Details
Commit message · Andrew Poelstra

primitives: remove a bunch of panics from Transaction::decoder

The state machine logic in TransactionDecoder is a bit frustrating. We
need to obtain a mutable reference to the current sub-decoder to attempt
to feed data to it. If this fails, we then need to move the sub-decoder,
attempt to end() it, then replace it if this succeeds. (And the replacement
uses the return value from end() so we can't reorder this.)

Having the end() between the move and replacement means we need a dummy
Transitioning state, and having a mutable borrow before the move means
we need some borrowck trickery.

This commit separates the mutable-borrow logic from the move logic to
avoid the trickery. It retains the Transitioning dummy state which I can't
find a way to avoid.

Refactor only; no observable behavior changes.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 13/100

This commit is a code cleanup inside the Bitcoin transaction decoder. It removes helper functions that could panic if called in the wrong state and rewrites the decoder's main loop to avoid needing those helpers. The author explicitly states this is a refactor with no observable behavior changes, and the diff supports that reading: the same state machine, transitions, and error paths remain, just reorganized.

AI review queuedprimitives: fix doc comment for OutPointEncoderby sashass1315 · 46b4c7f3 · Oct 13, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · sashass1315

primitives: fix doc comment for OutPointEncoder

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes a single incorrect word in a documentation comment. The comment previously said the encoder was for one type (TxOut) when it actually encodes a different type (OutPoint). No code behavior changed, and there is no security impact.

AI review queuedprimitives: Implement decodersby Tobin C. Harding · 39bf86be · Oct 11, 2025 · 14 filesMessage 35 · OpaqueLow 28Details
Commit message · Tobin C. Harding

primitives: Implement decoders

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit adds new code to read (decode) Bitcoin data formats such as block headers, transactions, transaction inputs/outputs, and witness data in the rust-bitcoin library. It is a large feature addition rather than a clear security fix. The new decoders include length-limit checks and reject obviously invalid formats, but because this is brand-new parsing code, any mistakes could become memory-safety or denial-of-service issues in downstream Bitcoin software. There is no evidence in the commit message or diff that the authors are fixing a known vulnerability.