RB
← All projectsRust Bitcoin

rust-bitcoin

Rust library for Bitcoin data structures, serialization, consensus encoding, and scripts.

BitcoinCryptographic librariesNormal
Repository coverage

2084 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

461security candidates452second-pass queue2076AI analyses
183commits · 30 days
396commits · 60 days
1293commits · 180 days
2064commits · 365 days
Backfill bands
Aug 5 → Feb 6787 seen32 candidatesComplete
Feb 6 → Jun 6878 seen53 candidatesComplete
Jun 6 → Jul 6211 seen15 candidatesComplete
Jul 6 → Aug 5184 seen2 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

64/100 average clarity
318Strong · 80–100
1058Adequate · 60–79
557Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Mitchell Bagot643192641068
Tobin C. Harding41366410063
jrakibi944994068
Andrew Poelstra582155077
Nick Johnson18920189059
Jamil Lambert, PhD11418114061
Fmt Bot311431045
Trevor Arjeski111111069
Shing Him Ng31731056
Ismail Daif22622050
satsfy (Renato Britto)17617066
Martin Habovstiak27527069
Analysis record

Published AI watches

Last scanned 32 minutes ago

Informational 20 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6678: units: Add `Weight::to_vb_*` functions, deprecating `to_vbytes_*`

This is a routine API cleanup in a Rust Bitcoin library. It adds new method names (to_vb_floor, to_vb_ceil) for converting transaction 'weight' to 'virtual bytes' and marks the old names (to_vbytes_floor, to_vbytes_ceil) as deprecated. The…

7f614781by Andrew Poelstra+30−86 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6597: Release tracking PR: `crypto 0.3.0`

This commit is a routine release-tracking merge. It only bumps version numbers (bitcoin-crypto to 0.3.0 and bitcoin-primitives to 0.103.1), updates dependency version requirements, refreshes lock files, and adds changelog entries. There ar…

1fddd49eby Andrew Poelstra+34−1210 files
No security note in commit
Informational 15 AI analysisMessage 28 · Opaque
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Update API files

This commit only updates generated API listing files (text snapshots of public functions) to reflect a newly added public function, `to_consensus_u32`, on the `CompactTarget` type. It does not change any source code, logic, or behavior, an…

a75c53c8by Mitchell Bagot+6−03 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6675: units: Remove unnecessary track_caller

This commit removes two Rust compiler hints (`#[track_caller]`) from helper functions that simply return a value or call a user-provided fallback. These functions never panic, so the hints were unnecessary and had no security effect. The c…

ce894f36by Andrew Poelstra+0−21 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6644: primitives: Add serde impls for `WitnessVersion`

This commit adds standard serialization/deserialization support for the WitnessVersion type when the optional serde feature is enabled. It is a routine feature addition with no security relevance visible in the code or commit message.

4981faa7by Andrew Poelstra+50−02 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6671: units: reword docs from height to count in relative locktime

This commit only changes documentation comments and variable names in the rust-bitcoin library. It rewords references to 'block height' as 'block count' for relative locktime, because a relative locktime measures elapsed blocks since a coi…

6ea4ff92by Andrew Poelstra+20−172 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6670: ci: fix labeller permissions

This is a routine GitHub Actions workflow fix. The change gives the automated PR labeler workflow permission to download artifacts and explicitly tells the GitHub CLI which repository to act on. It does not change the Bitcoin library code,…

CI workflow permission fixNo source code changesNo cryptographic or consensus changes
276e0a61by Andrew Poelstra+5−01 file
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6657: Release tracking PR: `base58ck 0.5.0`

This commit is a routine version bump for the base58ck crate from 0.4.0 to 0.5.0. It only updates version numbers in package manifests, lock files, and adds a changelog entry. There are no code changes and no security relevance.

9deb5de1by Andrew Poelstra+22−168 files
No security note in commit
Informational 21 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6440: base58: Introduce `decode_check_to_array` for alloc-less decoding

This commit is a routine feature addition to the rust-bitcoin base58 crate. It adds a new no-allocator function to decode short base58-check strings into fixed-size byte arrays, and renames the existing error type while keeping a deprecate…

No security-relevant bug fix is described in the commit message or diff.New decoding path uses a fixed 128-byte scratch buffer (`ArrayVec`) and rejects oversized inputs.Checksum verification and invalid-character handling are preserved from the existing alloc implementation.
c5fd1832by Andrew Poelstra+330−775 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6646: hashes: add several methods to `Midstate` and release 1.2.0

This commit is a routine feature release for the bitcoin_hashes crate. It adds new public methods and a constant to the SHA-256 Midstate type so developers can compute SHA-256 midstates in const contexts. There is no indication of a securi…

0f68fcb3by Andrew Poelstra+157−4210 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

units: reword docs to block count in relative locktime

This commit only rewords documentation comments and variable names in the codebase. It changes references from 'block height' to 'block count' for relative lock times, which is a terminology correction with no functional code changes. Ther…

8867fe2eby satsfy (Renato Britto)+20−172 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6667: Make the `WitnessesEncoder` private

This commit makes a small internal helper type called WitnessesEncoder private. It was previously exported as public API but is only used inside the transaction encoder. The change removes it from the public API surface and moves the code …

07d91f7fby Andrew Poelstra+54−1324 files
No security note in commit
Informational 12 AI analysisMessage 75 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

ci: fix labeller permissions

This commit adjusts a GitHub Actions workflow that automatically labels pull requests based on CI results. It adds a built-in repository token, tells the artifact download step to merge single-file artifacts, and explicitly sets the reposi…

Workflow-only change with no library code modificationsUses the default GITHUB_TOKEN rather than a custom secretRuns in workflow_run context, which already has elevated repository access by design
715f2bd6by Nick Johnson+5−01 file
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6661: units: Remove `From<u16>` from `NumberOfBlocks`

This is a routine API cleanup, not a security fix. The developers removed a shortcut that let programmers create a 'number of blocks' value directly from any u16 number, replacing it with an existing named constructor called from_height. T…

ed5f1b68by Andrew Poelstra+18−358 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6668: Scrub the transaction encoding logic

This commit is a pure code reorganization (refactor) in the rust-bitcoin library. It moves transaction encoding and decoding definitions around within a single file so the code follows the project's preferred layout. No logic, behavior, or…

c5588ba5by Andrew Poelstra+57−571 file
No security note in commit
Informational 18 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6662: build(deps): bump actions/checkout from 6.0.2 to 6.0.3

This commit is a routine update to the GitHub Actions checkout tool used by the project's automated workflows. It changes the pinned version from 6.0.2 to 6.0.3 across many workflow files. The newer version fixes minor bugs related to SHA-…

Dependency bump of actions/checkout to a patch releaseUpstream fixes for SHA-256 repository checkout and merge commit regexAll affected workflows already disable persisted credentials
f7d364cdby Andrew Poelstra+29−2915 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#6663: build(deps): bump taiki-e/install-action from 2.79.12 to 2.81.4

This is a routine Dependabot update that bumps the version of a third-party GitHub Action used only in automated testing workflows. The change does not touch the project's actual Bitcoin library code, and there is no indication it fixes or…

5c92c0b0by Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Update the API text files

This commit only updates two generated API text files that list the public surface of the Rust crate. It removes entries for a `WitnessesEncoder` type, reflecting that the type is no longer part of the public API. There is no source code c…

9c391145by Tobin C. Harding+0−782 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Scrub the transaction encoding logic

This commit is a pure code reorganization: it moves existing transaction encoding and decoding definitions around within a single file so they follow the project's preferred layout. No logic was changed, no security bug was fixed, and no n…

80dcef15by Tobin C. Harding+57−571 file
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Make the WitnessesEncoder private

This commit simply hides an internal helper type called WitnessesEncoder from public view. It is a routine API-cleanup change with no security relevance visible in the code or commit message.

b37accc3by Tobin C. Harding+54−542 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMove `FilterHash`, `FilterHeader` to `p2p`by rustaceanrob · f7281ff3 · Dec 10, 2025 · 6 filesMessage 86 · StrongInformational 18Details
Commit message · rustaceanrob

Move `FilterHash`, `FilterHeader` to `p2p`

These types are defined in
[BIP-157](https://github.com/bitcoin/bips/blob/master/bip-0157.mediawiki#specification).

Defining these types within `p2p` is appropriate, as these are used for
wire messages. By doing this move 1. no other crates would depend on
`bip158` 2. we are adhering to the policy that a crate with a release
that matches the BIP must implement only that BIP. As part of this move,
a single test `assert` is removed, but this was testing a method that
didn't make much sense in the first place. If a user wants to get a
filter header, they should use the filter hash and filter header
directly.

86/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 18/100

This commit is a routine code reorganization: it moves two related data types, FilterHash and FilterHeader, from the main bitcoin crate into the p2p crate because they are used in peer-to-peer network messages. It also removes one test assertion that checked a now-removed helper method. There is no security fix or vulnerability here.

Lower-priorityRelease tracking PR: `primitives v1.0.0-rc.1`by Tobin C. Harding · e66eea51 · Dec 9, 2025 · 8 filesMessage 68 · AdequateInformational 15Details
Commit message · Tobin C. Harding

Release tracking PR: `primitives v1.0.0-rc.1`

Do another RC round. Remembering to remove all the TBDs.

(Note I did not check if anything needs to go in the changelog.)

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a routine release-tracking change. It bumps the version number of the `bitcoin-primitives` crate from `1.0.0-rc.0` to `1.0.0-rc.1` in lock files and dependency manifests, and replaces placeholder "TBD" strings in deprecation notices with actual version numbers. There are no functional code changes and no security implications.

Lower-prioritybitcoin: Remove call to deprecated functionby Tobin C. Harding · 52749bf2 · Dec 9, 2025 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · Tobin C. Harding

bitcoin: Remove call to deprecated function

We are calling a deprecated function provided `primitives`, as part of
the `primitives` release first remove the call and use the new
non-deprecated function.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a routine code cleanup in an example file. A developer replaced one function call with another that does the same thing, because the old function name is being retired. There is no security issue here.

Lower-priorityprimitives: Remove deprecated type from API testby Tobin C. Harding · 64c92980 · Dec 9, 2025 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · Tobin C. Harding

primitives: Remove deprecated type from API test

Use the new type name and stop using the deprecated one.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a one-line change in a test file that swaps a deprecated type name for its newer replacement. It has no security relevance: it does not alter production code, cryptographic logic, parsing, network handling, or any behavior visible to users of the library.

Security candidatePin all RC dependenciesby Tobin C. Harding · 55a00aeb · Dec 9, 2025 · 5 filesMessage 63 · AdequateInformational 15Details
Commit message · Tobin C. Harding

Pin all RC dependencies

Me had trouble because of automatic resolution of RC depencies by
`cargo`. So now we want to pin to a specific version using the
"=X.Y.Z.rc.x" syntax. Do so for all dependencies that are currently in
an RC cycle.

63/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
access control
AI analysis · Informational 15/100

This commit changes version constraints for several in-development (release candidate) internal dependencies so Cargo will use an exact version rather than automatically picking a newer release candidate. It is a build/maintenance change to prevent unexpected dependency resolution, not a fix for a security vulnerability.

AI review queuedCreate empty `bip158` crateby rustaceanrob · 47fe9ceb · Dec 9, 2025 · 9 filesMessage 66 · AdequateInformational 15Details
Commit message · rustaceanrob

Create empty `bip158` crate

As part of discussion #5331, `bitcoin` and `p2p` should not depend on
each other and should instead mutually depend on `primitives`, `hashes`,
etc. BIP-158 is the last remaining dependency from `bitcoin` in `p2p`.
It is not a peer-to-peer specification, but it is not an essential
module of `bitcoin` either. IMO the best option for this module is to
release it as a crate.

Blaming the module shows it hasn't changed architecturally in many
years. A new crate would allow us to revisit some of the design choices.
Particularly the heavy use of generics, dependency on `io` that could be
replaced by `consensus_encoding`, and perhaps an opportunity to benchmark
and improve performance.

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit creates a brand-new, empty placeholder crate named `bitcoin-bip158` inside the rust-bitcoin workspace. It adds no executable code, no network functionality, no cryptographic operations, and no changes to existing crates. It is purely a project-structure refactor in preparation for later moving BIP-158 filter code out of the main `bitcoin` crate.

Lower-priorityfeat: Address::p2aby Christian Lewe · 81429803 · Dec 8, 2025 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · Christian Lewe

feat: Address::p2a

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds a small, public helper function to create a new type of Bitcoin address called 'pay-to-anchor' (P2A). It is a pure feature addition with no visible bug fix or security-related change. There is no indication of a vulnerability being patched.

Lower-priorityRelease tracking PR: `units v1.0.0-rc.3`by Tobin C. Harding · 41a97343 · Dec 7, 2025 · 7 filesMessage 68 · AdequateInformational 15Details
Commit message · Tobin C. Harding

Release tracking PR: `units v1.0.0-rc.3`

Do another RC round. Added changelog entry for the `Amount` string
value separator PR.

Bumped version and updated crates that depend on `units` to use it.

Updated lock files.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a routine release-tracking commit. It bumps the version number of the `bitcoin-units` crate from `1.0.0-rc.2` to `1.0.0-rc.3`, updates other crates in the same project to depend on the new version, refreshes lock files, and adds a changelog note that a recent pull request now allows underscores as separators in `Amount` values (for example, writing 1_000_000 instead of 1000000). There are no code changes in this commit itself.

AI review queuedunits: Set TBD in deprecate attributeby Tobin C. Harding · d19605cb · Dec 7, 2025 · 7 filesMessage 60 · AdequateInformational 15Details
Commit message · Tobin C. Harding

units: Set TBD in deprecate attribute

Set deprecation version. Note that this deprecated code is only going
to exist until the do the non-RC i.e., `v1.0.0`.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fills in placeholder version numbers in deprecation warnings. It does not change any program behavior, fix any bug, or introduce any security issue. It is a routine documentation/metadata cleanup.

Security candidateunits: Pin RC dependencyby Tobin C. Harding · 3b70bdaf · Dec 7, 2025 · 1 fileMessage 71 · AdequateInformational 19Details
Commit message · Tobin C. Harding

units: Pin RC dependency

So that any subsequent RC releases of `consensus-encoding` don't
inadvertently break the build (like #5358) pin the `encoding`
dependency to an exact version.

71/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
access control
AI analysis · Informational 19/100

This commit changes a single version requirement in a Rust package file so that a pre-release dependency is pinned to an exact version rather than allowing newer release-candidate versions. It is a build-stability fix, not a security patch. There is no code change that fixes a vulnerability or changes runtime behavior.

Lower-priorityunits: Remove deprecated calls in absolute locktime codeby Tobin C. Harding · 4abc454e · Dec 7, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Tobin C. Harding

units: Remove deprecated calls in absolute locktime code

Use the newer non-deprecated API.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a routine code cleanup inside test code only. It swaps deprecated function calls for newer, non-deprecated equivalents in a Rust unit test file. There is no change to production behavior, no bug fix, and no security relevance visible in the commit.

Lower-priorityunits: Stop using deprecated typesby Tobin C. Harding · e8f11003 · Dec 7, 2025 · 3 filesMessage 70 · AdequateInformational 15Details
Commit message · Tobin C. Harding

units: Stop using deprecated types

Use the new non-deprecated types instead. Including removing the
deprecated types from the API tests.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit is a routine cleanup that swaps deprecated type names for their newer replacements in test files only. It does not change any production code, behavior, or security properties.

Lower-priorityinternals: Add changelog for 0.4.1 releaseby Tobin C. Harding · 6df4240f · Dec 7, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Tobin C. Harding

internals: Add changelog for 0.4.1 release

We omitted the changelog during release, create one now.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds a missing changelog entry for a previously released version of an internal Rust library. It documents two routine maintenance items: raising the minimum supported Rust version and adding a dependency. There is no code change and no security relevance.

AI review queuedinternals: Bump version to 0.4.2by Tobin C. Harding · fb65b565 · Dec 7, 2025 · 5 filesMessage 80 · StrongInformational 15Details
Commit message · Tobin C. Harding

internals: Bump version to 0.4.2

In preparation for releasing `bitcoin 0.33.0-rc.0` we need do a point
release of `internals` because we move a macro out of `bitcoin` and
over to `internals`. No other crate uses the macro so far so we only
update the `bitcoin` dependency on `internals` leaving the other
crates as they are.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit is a routine version bump for an internal helper crate. It only changes version numbers in package files and a changelog entry. There is no code change, no bug fix, and no security issue visible in the diff.

Security candidatehashes: silence new `unused-assignments` clippy lintby Andrew Poelstra · 710d644f · Dec 7, 2025 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · Andrew Poelstra

hashes: silence new `unused-assignments` clippy lint

In our `round!` macro invocation for the implementation for sha256 and
sha512 we do an assignment of a variable `$w` which is fed into the next
round. On the last round, this assignment is unused, which makes clippy
unhappy on recent nightlies.

Fix this so we can update our nightly compiler.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit is a code-quality cleanup, not a security fix. It adds a `let _ = w[15];` line in two SHA hashing implementation files solely to silence a new Rust clippy lint about an unused assignment inside a macro on the final round of SHA-256 and SHA-512. The generated machine code and behavior are unchanged.

Lower-priorityunits: add `too_many_lines` clippy whitelist to `parse_signed_to_satoshi`by Andrew Poelstra · 84c554f2 · Dec 7, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Andrew Poelstra

units: add `too_many_lines` clippy whitelist to `parse_signed_to_satoshi`

After the format bot runs, this function (which is currently just below
the max line threshold) tips over, meaning that our format PRs are not
passing CI.

Possibly this function should be split up, but I don't think so. It's
split up into a few logical sections which are isolated from each other
but which wouldn't benefit from the even-further-separation that would
happen if we added extra functions.

Anyway we can debate that in a separate issue if people want. For now we
need the format job to pass CI, since it's a 700+ line diff already and
growing every week.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit adds a single annotation telling the Rust linter (clippy) to ignore a 'function is too long' warning on an internal helper function. It does not change any executable code, behavior, or data handling. There is no security relevance.

Lower-priorityAdd generic Sub/AddAssign impl over NumOpResultby Mitchell Bagot · 456aad19 · Dec 7, 2025 · 5 filesMessage 68 · AdequateInformational 15Details
Commit message · Mitchell Bagot

Add generic Sub/AddAssign impl over NumOpResult

Currently, we have an internal macro impl_(sub|add)_assign to implement
Sub/AddAssign for a type with itself, or a ref of itself. Since many
ops on units types yield NumOpResult<T> wrappers, it's convenient for
users to provide AddAssign and SubAssign over those wrappers for types
that already provide Sub/AddAssign.

Add generic implementation of Sub/AddAssign over NumOpResult<T> for
types in units that implement Sub/AddAssign on the base type.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit adds convenience Rust traits (+= and -= operators) for a wrapper type called NumOpResult. It does not fix a bug or change existing behavior; it only makes it easier to add or subtract values that are already wrapped in a NumOpResult. There is no security relevance in the change itself.

Lower-priorityAdd Sub/AddAssign impl for NumOpResult<Amount/SignedAmount>by Mitchell Bagot · d9288ba4 · Dec 7, 2025 · 5 filesMessage 85 · StrongInformational 18Details
Commit message · Mitchell Bagot

Add Sub/AddAssign impl for NumOpResult<Amount/SignedAmount>

Currently, Amount and SignedAmount implement Add and Sub. In order to
allow for += and -= usage, SubAssign and AddAssign must be implemented.
Since Add and Sub on Amount/SignedAmount yield NumOpResults, we can
only implement Sub/AddAssign on the NumOpResult wrappers.

Add macros to implement Sub/AddAssign on NumOpResult wrappers of types
without a direct Sub/AddAssign implementation. Implement Sub/AddAssign
for Amount/SignedAmount NumOpResult wrappers.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 18/100

This commit adds convenience operators (+= and -=) for a special result wrapper around Bitcoin amount types. It does not change how amounts are validated or how overflow is handled; it only lets programmers write `res += amount` instead of `res = res + amount`. There is no security bug visible in the change.

Lower-priorityMove generic impls of NumOpResult<T>by Mitchell Bagot · 209bb7cf · Dec 7, 2025 · 2 filesMessage 80 · StrongInformational 15Details
Commit message · Mitchell Bagot

Move generic impls of NumOpResult<T>

The generic impls should live in the same file as the type instead of
nested in the `amount` module because they are not specific to `amount`.

Internal, no logic change.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit simply moves existing Rust code from one file to another without changing what the code does. It is described by the project as an internal cleanup with no logic change, and the diff confirms that the implementations were copied verbatim.

Lower-priorityp2p: add consensus_encoding to v1 network messageby Nick Johnson · 46719232 · Dec 6, 2025 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Nick Johnson

p2p: add consensus_encoding to v1 network message

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds a new way to encode and decode Bitcoin peer-to-peer (P2P) network messages in the rust-bitcoin library. It is a feature/refactoring change that introduces a new 'consensus_encoding' implementation for v1 network messages, replacing the old serialization approach in an example program. There is no indication this fixes a security bug or introduces a vulnerability.

AI review queuedp2p: remove io::Error from exposed APIby Nick Johnson · 213b85ba · Dec 6, 2025 · 1 fileMessage 60 · AdequateInformational 19Details
Commit message · Nick Johnson

p2p: remove io::Error from exposed API

Part of the process to break the p2p package's dependency on the old io
package.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 19/100

This commit refactors how Bitcoin peer-to-peer address errors are reported. It replaces a generic input/output error type with a new, more specific error type for addresses that cannot be routed over normal internet connections (Tor, I2P, CJDNS). This is a routine API cleanup, not a fix for an active security vulnerability. The change is part of a larger effort to reduce internal package dependencies.

Lower-priorityp2p: add FeeFilter wrapper with consensus_encodingby Nick Johnson · 6d95f4ee · Dec 6, 2025 · 4 filesMessage 50 · ThinInformational 21Details
Commit message · Nick Johnson

p2p: add FeeFilter wrapper with consensus_encoding

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 21/100

This commit refactors how the Bitcoin P2P 'feefilter' message is encoded and decoded. It introduces a dedicated FeeFilter wrapper type and uses a new consensus-encoding crate. The change is primarily a code-quality and API-consistency improvement; it does not appear to fix a known security bug, but it does slightly harden handling of malformed fee-filter values by centralizing the logic.

Lower-priorityp2p: add consensus_encoding impls to CommandStringby Nick Johnson · 4c249f76 · Dec 6, 2025 · 1 fileMessage 50 · ThinInformational 17Details
Commit message · Nick Johnson

p2p: add consensus_encoding impls to CommandString

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 17/100

This commit adds new encoding and decoding logic for Bitcoin P2P network command strings (the 12-byte labels on messages like 'version' or 'ping'). The decoder trims trailing zero padding and checks that the remaining bytes are plain ASCII before converting them to a Rust string. The conversion uses an 'unchecked' UTF-8 function, but only after an ASCII check, so it is safe in itself. The change is a routine protocol implementation addition; there is no disclosed security bug or fix.

AI review queuedMove `bip152` to `p2p`by rustaceanrob · e242dd61 · Dec 6, 2025 · 6 filesMessage 59 · ThinInformational 15Details
Commit message · rustaceanrob

Move `bip152` to `p2p`

Replaces #5333 and #5365 by manually implementing `hex` traits for the
`ShortId` type. `FromStr` is omitted as I can't think of a logical use
of that method in this context. To make any sense of a string short ID
one needs the nonce and siphash keys.

This module is only relevant between two peers relaying blocks over the
peer to peer network.

59/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine code reorganization: it moves the BIP-152 compact block module from the main `bitcoin` crate into the `p2p` crate, where it is more logically located. It also replaces an auto-derived hex formatting trait with a manual implementation for one small type. There is no security fix or behavior change visible in the diff.

AI review queuedRemove alloc feature gate for MerkleNodeby Mitchell Bagot · cc0da4ca · Dec 5, 2025 · 6 filesMessage 68 · AdequateInformational 18Details
Commit message · Mitchell Bagot

Remove alloc feature gate for MerkleNode

With the introduction of pop() to ArrayVec, the
MerkleNode::calculate_root logic can be implemented using ArrayVec
instead of alloc::vec::Vec. This allows for use of the functionality
without the alloc feature, albeit with an upper iterator length bound
of 32768 (exclusive) items.

Introduce ArrayVec bounded variation to MerkleNode::calculate_root,
and remove alloc feature gate from MerkleNode.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit refactors how Bitcoin Merkle roots are calculated so the code works even when the optional 'alloc' memory allocator feature is disabled. It replaces a growable vector with a fixed-size 15-slot array, which limits the no-alloc path to at most 32,767 transaction IDs. The change is a feature-portability improvement, not a security fix, and it explicitly returns None when the no-alloc limit is exceeded rather than overflowing or corrupting state.