units: add `too_many_lines` clippy whitelist to `parse_signed_to_satoshi`
What the developer wrote
Authored by Andrew Poelstra
units: add `too_many_lines` clippy whitelist to `parse_signed_to_satoshi`
After the format bot runs, this function (which is currently just below
the max line threshold) tips over, meaning that our format PRs are not
passing CI.
Possibly this function should be split up, but I don't think so. It's
split up into a few logical sections which are isolated from each other
but which wouldn't benefit from the even-further-separation that would
happen if we added extra functions.
Anyway we can debate that in a separate issue if people want. For now we
need the format job to pass CI, since it's a 700+ line diff already and
growing every week.
What changed, and why it matters
This commit adds a single annotation telling the Rust linter (clippy) to ignore a 'function is too long' warning on an internal helper function. It does not change any executable code, behavior, or data handling. There is no security relevance.
No action needed; the change is not security-related.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds #[allow(clippy::too_many_lines)] to parse_signed_to_satoshi in units/src/amount/mod.rs. This is purely a lint-suppression change to keep automated formatting pull requests passing CI. No logic, parsing rules, bounds checks, or error handling were modified.
Changed components
units/src/amount/mod.rsInspect captured patch +1 / −0
diff --git a/units/src/amount/mod.rs b/units/src/amount/mod.rs
index f1778391..e640e6f3 100644
--- a/units/src/amount/mod.rs
+++ b/units/src/amount/mod.rs
@@ -209,6 +209,7 @@ const INPUT_STRING_LEN_LIMIT: usize = 50;
/// [`bool`] indicator for a negative amount.
///
/// The `bool` is only needed to distinguish -0 from 0.
+#[allow(clippy::too_many_lines)]
fn parse_signed_to_satoshi(
mut s: &str,
denom: Denomination,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.