RB
← All projectsRust Bitcoin

rust-bitcoin

Rust library for Bitcoin data structures, serialization, consensus encoding, and scripts.

BitcoinCryptographic librariesNormal
Repository coverage

2570 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

612security candidates555second-pass queue2330AI analyses
153commits · 30 days
279commits · 60 days
977commits · 180 days
2058commits · 365 days
Backfill bands
Aug 5 → Feb 6787 seen32 candidatesComplete
Feb 6 → Jun 6878 seen53 candidatesComplete
Jun 6 → Jul 6211 seen15 candidatesComplete
Jul 6 → Aug 5184 seen2 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

68/100 average clarity
702Strong · 80–100
1135Adequate · 60–79
582Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Andrew Poelstra407139251391
Mitchell Bagot659200654068
Tobin C. Harding42167411063
jrakibi1015096069
satsfy (Renato Britto)652235065
Nick Johnson19621190060
Jamil Lambert, PhD12619117062
Fmt Bot351532045
Trevor Arjeski111111069
Shing Him Ng31731056
Martin Habovstiak31629069
Ismail Daif22622050
Analysis record

Published AI watches

Last scanned 2 minutes ago

Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7220: refactor(bip32)!: replace KeySource with KeyOrigin

This is a routine code cleanup in a Bitcoin library. It renames a simple data container from KeySource to KeyOrigin and gives it named fields (fingerprint and path) instead of numbered tuple slots (.0 and .1). The serialized format is inte…

6bb507b2by Andrew Poelstra+84−33 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7204: key-expression: Get secp256k1 from the crypto dep

This change is a routine internal cleanup: the key_expression crate stops depending directly on the secp256k1 cryptography library and instead uses a re-export provided by another internal crate called crypto. No user-facing behavior, type…

d193efc5by Andrew Poelstra+7−107 files
No security note in commit
Informational 17 AI analysisMessage 68 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Forward serde feature to network

This is a small Cargo.toml fix in a Rust Bitcoin subcrate. When the optional 'serde' feature was enabled on the key_expression crate alone, it did not also enable serde on the network crate. That meant a type called NetworkKind could not b…

806f1e1fby bytescape30+1−11 file
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7223: build(deps): bump taiki-e/install-action from 2.87.9 to 2.87.13

This is a routine update to a GitHub Actions helper used in automated testing workflows. It bumps the version of taiki-e/install-action, which downloads and installs Rust developer tools during CI runs. There is no change to the actual Bit…

c8ee144aby Andrew Poelstra+2−22 files
No security note in commit
Informational 20 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7224: build(deps): bump astral-sh/setup-uv from 10.0.1 to 10.1.0

This is a routine update to a GitHub Actions helper used only in automated security-scanning workflows. The new version adds minor improvements, including respecting proxy settings and verifying downloaded files with checksums. It does not…

Dependency bump of a third-party GitHub Action used in CI onlyUpstream release notes mention generic security improvements (checksum verification, npm install defaults, NO_PROXY)No CVE, advisory, or vendor security disclosure is present in the commit or supplied references
7bc9d696by Andrew Poelstra+2−22 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7105: Remove derived serde impls for types in stabilising crates

This commit removes automatic serde (serialization/deserialization) code generation from several Rust Bitcoin library crates and replaces it with hand-written implementations. The stated goal is to reduce dependencies and make the code eas…

Manual serde implementations replace derived ones, increasing the surface area for serialization-format bugsNo validation logic changes are visible in the diffNo mention of security fixes, CVEs, or vulnerability reports in commit message or PR description
9eeb7774by Andrew Poelstra+219−4110 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7205: Manual update to rustc stable (to 1.100.0)

This commit updates the project's automated Rust compiler version from 1.99.1 to 1.100.0 and adjusts a CI cache cleanup script to match a new directory layout used by Cargo 1.100. It is purely an infrastructure/maintenance change to keep a…

44e6f0caby Andrew Poelstra+8−22 files
No security note in commit
Informational 18 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7197: ci: bump rbmt to 0.5.5 and fail API job on private dep leak

This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of interna…

CI guardrail added to prevent private dependency leaks into stable crate public APIsTool bump enables detection of re-exported private dependenciesNo source-code vulnerability is patched
be14c72eby Andrew Poelstra+7−12 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7185: Refactor/bip32 flatten error constructors

This is a minor internal code cleanup in the Rust Bitcoin library. It changes how two functions (Xpriv::decode and Xpub::decode) build their error messages when an input is the wrong length. The behavior is the same before and after; only …

271f662aby Andrew Poelstra+8−61 file
No security note in commit
Informational 24 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7167: units: remove `Denomination::MicroBitcoin`

This is a routine API cleanup, not a security fix. The change removes one way of naming a Bitcoin unit ('MicroBitcoin' / 'uBTC') and keeps the equivalent 'bits' form. Any code that previously used the old name will fail to compile or fail …

No security signal: public API deprecation and enum variant removalNo memory safety, cryptographic, or consensus code modifiedError message change is informational only
d0602195by Andrew Poelstra+53−403 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7127: key_expression: Reduce `alloc` gating to minimal types

This commit is a code cleanup and feature-gating refactor for the rust-bitcoin library's key_expression crate. It makes more BIP32 (Bitcoin wallet key derivation) types available when the 'alloc' memory allocator feature is disabled, and s…

Refactor of error types and parsing paths for Xpriv/Xpub base58 decodingSwitch from unbounded base58 decode to fixed-size array decode (78 bytes)Removal of explicit length-check error path in favor of decoder-reported length error
c3d27d5dby Andrew Poelstra+60−823 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7039: primitives: Fix daily Miri cron failures with measured test gating

This change only adds `#[cfg_attr(miri, ignore)]` annotations to a handful of slow unit tests so they are skipped when run under Miri, a Rust interpreter used for detecting undefined behavior. It does not change any production code, consen…

1dc09077by Andrew Poelstra+6−03 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7182: Update local dependencies

This commit only updates version numbers in package configuration files (Cargo.toml) for internal dependencies so that all crates in the project require the same minimum versions of shared libraries. There are no code changes, no bug fixes…

06f41225by Andrew Poelstra+7−75 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7179: build(deps): bump taiki-e/install-action from 2.87.4 to 2.87.9

This is a routine update to a GitHub Actions helper used in automated testing workflows. It changes which version of a third-party tool-installer action is used, but only for installing the cargo-mutants testing tool. There is no indicatio…

4fda66b5by Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7180: build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This commit updates the version of a helper tool called cargo-binstall used in two automated GitHub workflows. The change only affects internal build/CI tooling and does not alter the rust-bitcoin library code that users install or run. Th…

53eae24dby Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7181: build(deps): bump github/codeql-action/upload-sarif from 4.37.9 to 4.38.0

This is a routine update by Dependabot to the GitHub CodeQL upload-sarif action used in a scheduled security scanning workflow. It changes one pinned commit hash to a newer version of the same action. There is no indication this introduces…

4bb555f0by Andrew Poelstra+1−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Flatten BIP32 decode error construction

This commit is a minor code cleanup in the Rust Bitcoin library. It changes how an error message is built when decoding BIP32 extended keys, switching from one nested construction style to two chained calls. The actual behavior and returne…

c31c11e0by Adewale Ijalana+8−61 file
No security note in commit
Low 36 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7168: units: add `visit_units` in optional serde visitors

This commit fixes a bug in how optional Bitcoin amount and fee-rate values are read from JSON when those fields are inside a flattened struct and the value is null. Previously, the code would error out because it did not handle a special s…

Deserialization failure in optional numeric types under serde flattenMissing serde visitor method (visit_unit) causing runtime errorsRegression test added for null handling in flattened structs
47340d2fby Andrew Poelstra+79−03 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump github/codeql-action/upload-sarif

This is a routine dependency update by Dependabot, bumping the version of a GitHub-provided action used to upload security scan results. There is no indication of a security vulnerability in the project itself or in this change.

fe755619by dependabot[bot]+1−11 file
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This is a routine automated update by Dependabot that changes the version of a GitHub Action used to install Rust tools in two CI workflows. There is no indication of a security issue in the commit itself, and no verified security referenc…

2ccb0029by dependabot[bot]+2−22 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge rust-bitcoin/rust-bitcoin#7013: Manual weekly update to rustc (to nightly-2026-10-03) on masterby Andrew Poelstra · 8922579c · Oct 9, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7013: Manual weekly update to rustc (to nightly-2026-10-03) on master

c774e9ec2340feaaec10c89f24cdf6f89b0d293e taproot_primitives: add missing docs backtics (satsfy (Renato Britto))
730ffdd309a92dd51fde2e2eaffb5d0d4ad8d476 Automated update to rustc nightly-2026-10-03 (Update Nightly Rustc Bot)

Pull request description:

Supersedes https://github.com/rust-bitcoin/rust-bitcoin/pull/6979

Needed a doc backtics fix for lint.


ACKs for top commit:
apoelstra:
ACK c774e9ec2340feaaec10c89f24cdf6f89b0d293e; successfully ran local tests


Tree-SHA512: f2784be8e699c362d48c7d9dd764c424a7aeefa983e4a96895abaa1050b155f59d6fee899a766bd89f25125aaeb07fab72dfe4851f9a4f3a831f5b9d2017d376

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine weekly update of the Rust compiler version used by the project, plus three tiny documentation fixes that add correct backtick formatting around type names. There is no change to program logic, no bug fix, and no security relevance.

AI review queuedMerge rust-bitcoin/rust-bitcoin#7001: units: fix serialization of optional amountsby Andrew Poelstra · 6585c779 · Oct 9, 2026 · 3 filesMessage 91 · StrongLow 48Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7001: units: fix serialization of optional amounts

cfa43314a5616e920201cb1c0d40403cff27a155 units: check Optional amount round trip with bincode (jrakibi)
4b4208ceaf5396b85bfb40e6ae8730e5b0b1a19d units: fix serialization of optional amounts (jrakibi)

Pull request description:

Serializing/deserializing an optional amount using `as_btc::opt` or `as_str::opt` does not round trip with bincode.

The issue is in serialization: we directly serialize the inner value instead of `Some` variant. So deserialization can fail or return incorrect value.

The first commit fixes the issue by using `serialize_some`, and updates serde_bincode to include the two missing bytes that encode `Some` (for unsigned_opt_as_btc and signed_opt_as_btc)

The second commit adds tests.

Found while auditing `units` crate with Codex. This may already be tracked in Loupe. I don’t have access to check.


ACKs for top commit:
Abeeujah:
ACK cfa43314a5616e920201cb1c0d40403cff27a155
apoelstra:
ACK cfa43314a5616e920201cb1c0d40403cff27a155; successfully ran local tests; great catch!


Tree-SHA512: 2309b34bd20ca0dad8a9090e2da67ac5bb078eed89180f4125dc62527ee0c222a7f414015f198e9c7e69b12e8b9b7ea6c3205e98d175b65598d2a74da5eab893

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 48/100

This commit fixes a bug in how optional Bitcoin amounts are serialized when using certain compact binary formats (like bincode). The code was writing the raw inner value for a Some(amount) instead of properly marking it as 'Some'. This could cause deserialization to fail or produce wrong values when round-tripping optional amounts. The fix changes the serializer to use the standard 'serialize_some' method and adds tests to confirm round-tripping now works.

AI review queuedMerge rust-bitcoin/rust-bitcoin#7003: Fix creusot cache by running on push to `master`by Andrew Poelstra · bc026dc2 · Oct 9, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7003: Fix creusot cache by running on push to `master`

8f9a6dec87f84c5b125b144b8d6144d8437af5cb Fix creusot cache by running on push to `master` (Martin Habovstiak)

Pull request description:

According to the [documentation], PRs don't get to share their cache for security reasons which severely limits its usefulness to us. They can however restore the cache of the base branch which solves the issue but to have any cache on base branch we have to run Creusot on push.

This commit enables the cache on pushes to `master`. It is expected that this will require a full re-build but all subsequent builds which do not modify the dependencies should get faster.

[documentation]: https://docs.github.com/en/actions/reference/workflows-and-actions/dependency-caching#restrictions-for-accessing-a-cache

Adding P-high label because not having this wastes a lot of time on every PR and fills our cache storage.


ACKs for top commit:
apoelstra:
ACK 8f9a6dec87f84c5b125b144b8d6144d8437af5cb; successfully ran local tests
jamillambert:
ACK 8f9a6dec87f84c5b125b144b8d6144d8437af5cb


Tree-SHA512: e7bc82bd71d8e5f8851aa247b051b745301f43f7aa7fdd1e58dbf944849d4722e045eb538502136fccb7d18c522cd177c10b29c32cea05c90c5a65824c4dcc7f

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This change simply tells GitHub to run the Creusot verification workflow whenever code is pushed to the master branch, in addition to running it on pull requests. The goal is to populate a build cache for the master branch so that future pull requests can reuse it and run faster. There is no change to the actual Bitcoin library code, no bug fix, and no security patch.

Security candidateMerge rust-bitcoin/rust-bitcoin#7000: internals: add track_caller to U256 opsby Andrew Poelstra · 0870db2e · Oct 9, 2026 · 2 filesMessage 86 · StrongInformational 20Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7000: internals: add track_caller to U256 ops

276712155d4467198fa7797afbd530467a8ea2e3 internals: add track_caller to U256 ops (satsfy (Renato Britto))

Pull request description:

Part of https://github.com/rust-bitcoin/rust-bitcoin/issues/5518#issuecomment-5981738769

In debug builds, internals Add, Sub and Mul on U256 panic on overflow, Div and Rem panic on a zero divisor.

The panics linked code inside internals instead of at the caller's mistake, and the policy document asks for `track_caller` on functions that panic on invalid arguments.


ACKs for top commit:
Kixunil:
ACK 276712155d4467198fa7797afbd530467a8ea2e3


Tree-SHA512: b6186db89f26113194b03da248301d0b34d4684b7e54ffff21abcc37fb417df45a7e194b52f55836dc922fb50cadaf155140b5cb693a940068e4f7ac69334ef3

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Informational 20/100

This change adds Rust's #[track_caller] attribute to several internal math and array helper functions. It does not fix a bug or change any calculation; it only improves panic error messages so that if an overflow or division-by-zero happens in testing, the error points to the caller's code rather than deep inside the library. There is no security vulnerability being patched.

Security candidateMerge rust-bitcoin/rust-bitcoin#6998: Fix regtest parameters to match Bitcoin Coreby Andrew Poelstra · 621a3900 · Oct 9, 2026 · 1 fileMessage 91 · StrongInformational 19Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6998: Fix regtest parameters to match Bitcoin Core

8c0930daac175ef912c533186c2108e1d5d0da67 params: Align regtest values with Bitcoin Core (moisesPomilio)

Pull request description:

Updates the regtest parameters to match Bitcoin Core's current regtest configuration.

* Sets BIP34, BIP65, and BIP66 activation heights to 1.
* Changes the regtest difficulty adjustment timespan from 2 weeks to 1 day.

Fixes #6997


ACKs for top commit:
apoelstra:
ACK 8c0930daac175ef912c533186c2108e1d5d0da67; successfully ran local tests


Tree-SHA512: 0f8b2635e4f903facc94dcae268ffa3927bcef11711a7385ccb0be0e4d0f159039d1ee5d0c4b5ccf2c92301c98a75d629b9b9814d5daae0ae55f0c7fe1c74138

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
proof-of-work or emission validationmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit updates the built-in 'regtest' network parameters in the rust-bitcoin library so they match Bitcoin Core's current regtest defaults. Regtest is a private test network used only for local development and automated testing, not for real money. The changes make several Bitcoin protocol rules active from block 1 and shorten the difficulty adjustment window from two weeks to one day. There is no indication this fixes a security vulnerability; it is a compatibility/maintenance fix.

Security candidateMerge rust-bitcoin/rust-bitcoin#6934: Release tracking PR: `internals 0.8.0`by Andrew Poelstra · 3c20d042 · Oct 8, 2026 · 20 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6934: Release tracking PR: `internals 0.8.0`

915c04b327bfd345e9e932da26f4d74f860274a7 internals: Bump version to 0.8.0 (Tobin C. Harding)

Pull request description:

In preparation for release add a changelog entry, bump the version number, and update the lockfiles.


ACKs for top commit:
apoelstra:
ACK 915c04b327bfd345e9e932da26f4d74f860274a7; successfully ran local tests


Tree-SHA512: afdb2f835757f30bc88524d79810f9e27b437dad522ed56fa0190bfccd0bfccc39778d255c131c086c7105b8d65620ac22a6398992aa82a9987c9ccc87a6707c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a routine release-tracking merge that bumps the version of the `bitcoin-internals` crate from 0.7.0 to 0.8.0 and updates all dependent crates' version requirements and lockfiles. It does not contain any code changes, bug fixes, or security patches itself. The changelog notes that other pull requests included in this release address items such as sanitizing serde size hints and fixing work/target conversions, but those changes are not part of this merge commit's diff.

Security candidatetaproot_primitives: add missing docs backticsby satsfy (Renato Britto) · c774e9ec · Oct 8, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · satsfy (Renato Britto)

taproot_primitives: add missing docs backtics

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only fixes documentation formatting by adding Rustdoc backtick link syntax to comments. It changes no executable code, no APIs, and no behavior. There is no security relevance.

Security candidateMerge rust-bitcoin/rust-bitcoin#6963: Clean up Pedantic Clippy Lintsby Andrew Poelstra · 82d60e08 · Oct 8, 2026 · 21 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6963: Clean up Pedantic Clippy Lints

38de85291f7b17e909590407b8d9510d4e374b91 bitcoin: Fix pedantic clippy lints (Abeeujah)
463a5c1f13c86281445fbfa8314e41aac9946816 addresses: Use Option::map_or for `rfind` (Abeeujah)
a86f9029c889741bbfb9671f872cb7287afffbfb p2p: Use Option Combinators (Abeeujah)
74c132c866f614a4aa10edf1ae4a91e613d0c480 primitives: Fix pedantic clippy lints (Abeeujah)
c61c04fc892432fcfabbff0ee04aa5e2c01b3f13 clippy: Use Option combinators (Abeeujah)
c1e940cd4c629406d4e116fc8de01d3f3097f07a Drop deprecated from_iter_instead_of_collect lint (Abeeujah)

Pull request description:

This PR does a sweep across all crates where fixing the triggered clippy lints would provide some value.


ACKs for top commit:
apoelstra:
ACK 38de85291f7b17e909590407b8d9510d4e374b91; successfully ran local tests


Tree-SHA512: d4ce61575a00d6fc4faabfa9a4b7517f7b85067bde38e2cf04cced6eead88c3ed7f6a9b657b408bf5601f80b0bc63695be32b23cc9fcd62c0917b255bd829378

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a routine code-cleanup pull request that fixes style warnings reported by the Clippy linter. It replaces verbose match/if-let blocks with shorter Option combinators, removes an obsolete lint rule, and uses explicit integer conversion helpers. There is no security bug being fixed and no behavior change intended.

AI review queuedFix creusot cache by running on push to `master`by Martin Habovstiak · 8f9a6dec · Oct 8, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · Martin Habovstiak

Fix creusot cache by running on push to `master`

According to the [documentation], PRs don't get to share their cache for
security reasons which severely limits its usefulness to us. They can
however restore the cache of the base branch which solves the issue but
to have any cache on base branch we have to run Creusot on push.

This commit enables the cache on pushes to `master`. It is expected that
this will require a full re-build but all subsequent builds which do not
modify the dependencies should get faster.

[documentation]: https://docs.github.com/en/actions/reference/workflows-and-actions/dependency-caching#restrictions-for-accessing-a-cache

81/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit changes the project's automated GitHub workflow so that a verification tool called Creusot also runs whenever code is pushed to the main 'master' branch. The only goal is to make the workflow's build cache work better for pull requests. There is no change to the actual Bitcoin library code, no bug fix, and no security vulnerability being addressed.

AI review queuedunits: fix serialization of optional amountsby jrakibi · 4b4208ce · Oct 8, 2026 · 2 filesMessage 80 · StrongModerate 50Details
Commit message · jrakibi

units: fix serialization of optional amounts

Optional amounts do not round trip with bincode because we
directly serialize the inner value instead of `Some` variant.
Deserialization can therefore fail or return incorrect values.

Use serialize_some in as_btc::opt and as_str::opt.

Also update serde_bincode to include the two missing bytes that
encode `Some` (for unsigned_opt_as_btc and signed_opt_as_btc)

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 50/100

This commit fixes a bug in how optional Bitcoin amounts are serialized when using the bincode format. Previously, an optional amount like `Some(1 BTC)` was written as just the raw number/string, without the marker that says "this value is present." That meant when reading it back, the code could misinterpret the data or fail. The fix uses the standard `serialize_some` method so the `Some` wrapper is preserved. The test data file was also updated to include the two missing bytes that represent `Some`.

Security candidateMerge rust-bitcoin/rust-bitcoin#6989: units: drop PartialOrd and Ord from CompactTargetby Andrew Poelstra · 7074bfe1 · Oct 7, 2026 · 3 filesMessage 91 · StrongLow 28Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6989: units: drop PartialOrd and Ord from CompactTarget

78c5fce5a3c46509157637681c0b333143e119bf units: drop PartialOrd and Ord from CompactTarget (satsfy (Renato Britto))
9162fe34bfe5816ac893ef8d691e0aaf83b06d05 primitives: implement lexicographic Header Ord (satsfy (Renato Britto))

Pull request description:

Close https://github.com/rust-bitcoin/rust-bitcoin/issues/2758
See discussion on https://github.com/rust-bitcoin/rust-bitcoin/pull/2754#issuecomment-2102736580

Conversion between `CompactTarget` and `Target` is lossy both ways. A derived order on the underlying `u32` does not correspond to which target is actually harder. The policy doc says to consider carefully before deriving `PartialOrd` or `Ord` on types where the comparison has no semantic meaning, and this is one instance of. `block::Header` and p2p `HeaderAndShortIds` contain a `CompactTarget`, they get derive removed.

About equality, it stays on the consensus encoded `u32` and that is ok. Simplified the docs for it.

The issue also suggests `ArbitraryOrd` but we removed that some time ago, so nothing takes its place and its up to the user to convert their `CompactTargets` to compare.

Note that the issue and discussion is somewhat old (2024), but it still seems just as relevant, so I jumped directly to PR.


ACKs for top commit:
tcharding:
ACK 78c5fce5a3c46509157637681c0b333143e119bf
apoelstra:
ACK 78c5fce5a3c46509157637681c0b333143e119bf; successfully ran local tests


Tree-SHA512: f7fac55887e1f4ad4c98f6ce12c099b0997b73bace9504a63ad7661ca7e38ee8916444e8488d7be6e8b0b44e1f414259bd5c9e80b058b49d8da00e7777369bd9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
consensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Low 28/100

This change removes automatic numeric ordering from a Bitcoin type called CompactTarget because its underlying u32 value does not reliably reflect which mining target is actually harder. It also replaces the derived ordering of block headers with a clear byte-by-byte (lexicographic) ordering based on how headers are serialized. The patch is a correctness and API-safety improvement rather than a fix for an active exploit, but it prevents future bugs where code might accidentally sort or compare CompactTarget values as if the raw number meant 'harder' or 'easier'.

Security candidateunits: add track_caller to panic opsby satsfy (Renato Britto) · 48fac6da · Oct 7, 2026 · 6 filesMessage 73 · AdequateInformational 19Details
Commit message · satsfy (Renato Britto)

units: add track_caller to panic ops

Arithmetic on block heights, weights, fee rates and work
panics on overflow, weight division on zero. The panic
linked code inside units instead of at the caller.

std puts track_caller on its integer ops too.

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Informational 19/100

This commit adds Rust's #[track_caller] attribute to arithmetic operations in the units crate. This is a debugging/quality-of-life improvement: when an operation panics (for example, adding two numbers that overflow), the error message will now point to the caller's code instead of deep inside the library. It does not change when panics happen, what values are computed, or fix any security vulnerability. It simply makes crash reports more useful for developers.

Security candidateinternals: add track_caller to U256 opsby satsfy (Renato Britto) · 27671215 · Oct 7, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · satsfy (Renato Britto)

internals: add track_caller to U256 ops

Add, Sub and Mul panic on overflow in debug builds, Div and
Rem on a zero divisor. Our policy asks for using
track_caller on functions that panic on invalid arguments.

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Informational 15/100

This commit only adds Rust's #[track_caller] annotation to internal functions that already could panic in debug builds. It does not change any behavior, fix a bug, or introduce a vulnerability. It merely improves the quality of panic messages by pointing callers to the right location in source code.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6983: build(deps): bump taiki-e/install-action from 2.85.4 to 2.85.8by Andrew Poelstra · 435caf98 · Oct 6, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6983: build(deps): bump taiki-e/install-action from 2.85.4 to 2.85.8

56216e18cb2861dd07d4fd00b49b093038e60d2d build(deps): bump taiki-e/install-action from 2.85.4 to 2.85.8 (dependabot[bot])

Pull request description:

Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.85.4 to 2.85.8.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p>
<blockquote>
<h2>2.85.8</h2>
<ul>
<li>
<p>Update <code>zizmor@latest</code> to 1.29.0.</p>
</li>
<li>
<p>Update <code>typos@latest</code> to 1.49.0.</p>
</li>
<li>
<p>Update <code>trivy@latest</code> to 0.73.0.</p>
</li>
<li>
<p>Update <code>tombi@latest</code> to 1.2.6.</p>
</li>
<li>
<p>Update <code>prek@latest</code> to 0.4.12.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.8.1.</p>
</li>
<li>
<p>Update <code>convco@latest</code> to 0.7.1.</p>
</li>
<li>
<p>Update <code>cargo-semver-checks@latest</code> to 0.50.0.</p>
</li>
<li>
<p>Update <code>cargo-crap@latest</code> to 0.4.1.</p>
</li>
</ul>
<h2>2.85.7</h2>
<ul>
<li>
<p>Update <code>wasmtime@latest</code> to 47.0.3.</p>
</li>
<li>
<p>Update <code>uv@latest</code> to 0.12.1.</p>
</li>
<li>
<p>Update <code>rclone@latest</code> to 1.75.0.</p>
</li>
<li>
<p>Update <code>kingfisher@latest</code> to 1.110.0.</p>
</li>
</ul>
<h2>2.85.6</h2>
<ul>
<li>
<p>Update <code>wasm-tools@latest</code> to 1.255.0.</p>
</li>
<li>
<p>Update <code>tombi@latest</code> to 1.2.5.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.7.18.</p>
</li>
<li>
<p>Update <code>cargo-neat@latest</code> to 0.5.3.</p>
</li>
<li>
<p>Update <code>cargo-crap@latest</code> to 0.4.0.</p>
</li>
</ul>
<h2>2.85.5</h2>
<ul>
<li>
<p>Update <code>uv@latest</code> to 0.12.0.</p>
</li>
<li>
<p>Update <code>syft@latest</code> to 1.50.0.</p>
</li>
<li>
<p>Update <code>sccache@latest</code> to 0.17.0.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.7.16.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md">taiki-e/install-action's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file.</p>
<p>This project adheres to <a href="https://semver.org">Semantic Versioning</a>.</p>
<!-- raw HTML omitted -->
<h2>[Unreleased]</h2>
<h2>[2.87.24] - 2026-10-04</h2>
<ul>
<li>
<p>Update <code>wasmtime@latest</code> to 49.0.2.</p>
</li>
<li>
<p>Update <code>dprint@latest</code> to 0.59.0.</p>
</li>
<li>
<p>Update <code>cargo-leptos@latest</code> to 0.3.11.</p>
</li>
<li>
<p>Update <code>cargo-insta@latest</code> to 1.49.0.</p>
</li>
<li>
<p>Update <code>cargo-binstall@latest</code> to 1.25.0.</p>
</li>
</ul>
<h2>[2.87.23] - 2026-10-03</h2>
<ul>
<li>
<p>Update <code>wasm-tools@latest</code> to 1.261.0.</p>
</li>
<li>
<p>Update <code>uv@latest</code> to 0.12.22.</p>
</li>
<li>
<p>Update <code>trivy@latest</code> to 0.75.0.</p>
</li>
<li>
<p>Update <code>tombi@latest</code> to 1.7.1.</p>
</li>
<li>
<p>Update <code>protoc-gen-connect-openapi@latest</code> to 0.28.0.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.10.0.</p>
</li>
<li>
<p>Update <code>kingfisher@latest</code> to 2.9.1.</p>
</li>
<li>
<p>Update <code>kache@latest</code> to 0.28.1.</p>
</li>
<li>
<p>Update <code>espup@latest</code> to 0.18.0.</p>
</li>
<li>
<p>Update <code>dprint@latest</code> to 0.58.0.</p>
</li>
<li>
<p>Update <code>cargo-crap@latest</code> to 0.6.1.</p>
</li>
<li>
<p>Update <code>cargo-auditable@latest</code> to 0.7.7.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/taiki-e/install-action/commit/cb33e69fad06166ca28a42b2575e4dadabf62ee8"><code>cb33e69</code></a> Release 2.85.8</li>
<li><a href="https://github.com/taiki-e/install-action/commit/205431a517a990dfa58a0f22a02abd8cbef31c11"><code>205431a</code></a> Update <code>zizmor@latest</code> to 1.29.0</li>
<li><a href="https://github.com/taiki-e/install-action/commit/e734f91b32f269a08deefc4ceb37d4aa4747a26b"><code>e734f91</code></a> Update wild manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/2596ecb10ea03dec655fc75e41a3b0f4dad7bc42"><code>2596ecb</code></a> Update <code>typos@latest</code> to 1.49.0</li>
<li><a href="https://github.com/taiki-e/install-action/commit/a44271eb2d867e7b1cf13602d4e4f0a93eec2f5e"><code>a44271e</code></a> Update <code>trivy@latest</code> to 0.73.0</li>
<li><a href="https://github.com/taiki-e/install-action/commit/9b100e5f66ebcc3ef6c9e7380611a923118c93bd"><code>9b100e5</code></a> Update <code>tombi@latest</code> to 1.2.6</li>
<li><a href="https://github.com/taiki-e/install-action/commit/f28498427840d9dc2242c579fe43460aad78fb48"><code>f284984</code></a> Update <code>prek@latest</code> to 0.4.12</li>
<li><a href="https://github.com/taiki-e/install-action/commit/3b86746a2ded65050e00646b310ebba2a15bdaf6"><code>3b86746</code></a> Update <code>mise@latest</code> to 2026.8.1</li>
<li><a href="https://github.com/taiki-e/install-action/commit/9287d185066eec8a77c1f11905ac9727db063430"><code>9287d18</code></a> Update just manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/32702bef0f7f8c45b9b179686f51a0f2739378c3"><code>32702be</code></a> Update <code>convco@latest</code> to 0.7.1</li>
<li>Additional commits viewable in <a href="https://github.com/taiki-e/install-action/compare/065d6a08a14e61e89fb0a4c10eecdbdef39c7d8e...cb33e69fad06166ca28a42b2575e4dadabf62ee8">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=taiki-e/install-action&package-manager=github_actions&previous-version=2.85.4&new-version=2.85.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
apoelstra:
ACK 56216e18cb2861dd07d4fd00b49b093038e60d2d; successfully ran local tests


Tree-SHA512: f561554e8c7740d8180abb62e0899c891c2da21e97942c6ba23b846daec1b82e91e3cc1f35cce14d49b45bec0eadc3295523cc2ecb61af1f898d33cdf6864dbe

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountautomated dependency-update discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This is a routine update by Dependabot to the version of a third-party GitHub Action used only in internal testing workflows. It does not change the project's actual Bitcoin library code, nor does it alter how user funds or data are handled. There is no indication this update fixes a security problem in the project itself.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6984: build(deps): bump github/codeql-action/upload-sarif from 4.37.3 to 4.37.6by Andrew Poelstra · de4dae2c · Oct 5, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6984: build(deps): bump github/codeql-action/upload-sarif from 4.37.3 to 4.37.6

d64049909130d66f25378926e263339094c1ee68 build(deps): bump github/codeql-action/upload-sarif (dependabot[bot])

Pull request description:

Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.37.3 to 4.37.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action/upload-sarif's releases</a>.</em></p>
<blockquote>
<h2>v4.37.6</h2>
<ul>
<li>Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to <code>.github/codeql-config.yml</code> to align it with the suggested path that is used elsewhere. <a href="https://redirect.github.com/github/codeql-action/pull/4070">#4070</a></li>
</ul>
<h2>v4.37.5</h2>
<ul>
<li>Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the <code>init</code> Action instead of falling back to downloading the bundle before extracting it. <a href="https://redirect.github.com/github/codeql-action/pull/4061">#4061</a></li>
</ul>
<h2>v4.37.4</h2>
<ul>
<li>This version of the CodeQL Action adds support for the <code>tools</code> input for the <code>codeql-action/init</code> step to be specified using a <code>github-codeql-tools</code> <a href="https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization">repository property</a>. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to <code>toolcache</code> to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for <code>tools</code> in the workflow definition always takes precedence unless the value of the repository property starts with <code>!</code>. <a href="https://redirect.github.com/github/codeql-action/pull/4037">#4037</a></li>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.2">2.26.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4051">#4051</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action/upload-sarif's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>4.38.2 - 24 Sept 2026</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.1">2.27.1</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4160">#4160</a></li>
</ul>
<h2>4.38.1 - 18 Sept 2026</h2>
<ul>
<li>The CodeQL Action now has experimental support for CodeQL releases for which per-language bundles are available. Per-language bundles support analysis for a single language and are therefore smaller than the combined bundles that allow analysis for all supported languages. As a result, per-language bundles take up less space on disk and are faster to download. We expect to roll this change out to everyone in the coming weeks. <a href="https://redirect.github.com/github/codeql-action/pull/4146">#4146</a></li>
</ul>
<h2>4.38.0 - 09 Sept 2026</h2>
<ul>
<li>On GitHub-hosted runners, the CodeQL Action now deletes unused CodeQL bundles from the toolcache before downloading a different bundle, which frees up disk space for the analysis. We expect to roll this change out to everyone in September. <a href="https://redirect.github.com/github/codeql-action/pull/4124">#4124</a></li>
<li>The CodeQL Action now supports CodeQL releases that are compatible with Linux Arm64 and downloads the native <code>linux-arm64</code> CodeQL bundle when available. <a href="https://redirect.github.com/github/codeql-action/pull/4072">#4072</a></li>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.27.0">2.27.0</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4129">#4129</a></li>
</ul>
<h2>4.37.9 - 26 Aug 2026</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.4">2.26.4</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4106">#4106</a></li>
</ul>
<h2>4.37.8 - 21 Aug 2026</h2>
<p>No user facing changes.</p>
<h2>4.37.7 - 13 Aug 2026</h2>
<ul>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.3">2.26.3</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4085">#4085</a></li>
</ul>
<h2>4.37.6 - 04 Aug 2026</h2>
<ul>
<li>Changed the default filepath for the new remote file address format that was introduced in CodeQL Action 4.37.0 / 3.37.0 to <code>.github/codeql-config.yml</code> to align it with the suggested path that is used elsewhere. <a href="https://redirect.github.com/github/codeql-action/pull/4070">#4070</a></li>
</ul>
<h2>4.37.5 - 03 Aug 2026</h2>
<ul>
<li>Fixed a bug where a network error while streaming the download of the CodeQL bundle could terminate the <code>init</code> Action instead of falling back to downloading the bundle before extracting it. <a href="https://redirect.github.com/github/codeql-action/pull/4061">#4061</a></li>
</ul>
<h2>4.37.4 - 29 Jul 2026</h2>
<ul>
<li>This version of the CodeQL Action adds support for the <code>tools</code> input for the <code>codeql-action/init</code> step to be specified using a <code>github-codeql-tools</code> <a href="https://docs.github.com/en/organizations/managing-organization-settings/managing-custom-properties-for-repositories-in-your-organization">repository property</a>. This feature will gradually be rolled out following the release of this version. Once rolled out, this allows for the CodeQL CLI version that is used in GitHub-managed workflows, such as Default Setup, to be set to a custom value. For example, customers who run into issues with rate limits when a new CodeQL CLI version is released can set the value to <code>toolcache</code> to always use the CodeQL CLI version that is available in the runner toolcache. For Advanced Setup workflows, the value provided for <code>tools</code> in the workflow definition always takes precedence unless the value of the repository property starts with <code>!</code>. <a href="https://redirect.github.com/github/codeql-action/pull/4037">#4037</a></li>
<li>Update default CodeQL bundle version to <a href="https://github.com/github/codeql-action/releases/tag/codeql-bundle-v2.26.2">2.26.2</a>. <a href="https://redirect.github.com/github/codeql-action/pull/4051">#4051</a></li>
</ul>
<h2>4.37.3 - 22 Jul 2026</h2>
<p>No user facing changes.</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/5595ccaf912efad79be6eef63a5619ff05969be3"><code>5595cca</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4071">#4071</a> from github/update-v4.37.6-6a9359a1b</li>
<li><a href="https://github.com/github/codeql-action/commit/ec9c75796a7f2cee5af0c5ffa0b81dc3bb58754b"><code>ec9c757</code></a> Add change note for PR 4070</li>
<li><a href="https://github.com/github/codeql-action/commit/45c8742e17cbd668814137f95e605d925b8722a2"><code>45c8742</code></a> Update changelog for v4.37.6</li>
<li><a href="https://github.com/github/codeql-action/commit/6a9359a1bd054c53cae7bb737bd8d796cfbf3014"><code>6a9359a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4070">#4070</a> from github/mbg/remote-address/change-file-default</li>
<li><a href="https://github.com/github/codeql-action/commit/065cdc0394d424981db720df63ebc570e41b775f"><code>065cdc0</code></a> Change <code>DEFAULT_CONFIG_FILE_NAME</code></li>
<li><a href="https://github.com/github/codeql-action/commit/f99dd5aeee9cf92e92d0c700cb0aa7afd7bbf431"><code>f99dd5a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4066">#4066</a> from github/dependabot/npm_and_yarn/js-yaml-5.2.2</li>
<li><a href="https://github.com/github/codeql-action/commit/1804b211a343d69a6584d26fb3a68a8fe6ca39d4"><code>1804b21</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4068">#4068</a> from github/mergeback/v4.37.5-to-main-d1ba80a1</li>
<li><a href="https://github.com/github/codeql-action/commit/3020a2f46286abb1704269b22ada83bd0e81c64f"><code>3020a2f</code></a> Rebuild</li>
<li><a href="https://github.com/github/codeql-action/commit/93c3a5a40b7affbf8ea6a480767ed0db8e8d3c5c"><code>93c3a5a</code></a> Update changelog and version after v4.37.5</li>
<li><a href="https://github.com/github/codeql-action/commit/d1ba80a13dd99fba24a470575428917156a28b43"><code>d1ba80a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/4067">#4067</a> from github/update-v4.37.5-1cd4d01d5</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81...5595ccaf912efad79be6eef63a5619ff05969be3">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action/upload-sarif&package-manager=github_actions&previous-version=4.37.3&new-version=4.37.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
apoelstra:
ACK d64049909130d66f25378926e263339094c1ee68; successfully ran local tests


Tree-SHA512: b759f790294d426a22cfe9017f2b5b176e70d5e96dd5aab4194d9232fd47dc30bda040cded4de17839dfdfa6c1e9fcd6427b2dc730c9052ad4b63fc63555d564

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountautomated dependency-update discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This is a routine update to a GitHub Actions workflow that uploads security scan results. It bumps the version of GitHub's official CodeQL upload-sarif action from 4.37.3 to 4.37.6. The change only affects internal CI automation and does not alter the rust-bitcoin library code, its dependencies, or any software that users run.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6985: build(deps): bump dtolnay/rust-toolchain from 02cb101ec7c40f2c49e1d9714d64511d8e1b74de to 7e38f4b43b4db5c8dd498af069a4f6196df1d067by Andrew Poelstra · cff0520c · Oct 5, 2026 · 4 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6985: build(deps): bump dtolnay/rust-toolchain from 02cb101ec7c40f2c49e1d9714d64511d8e1b74de to 7e38f4b43b4db5c8dd498af069a4f6196df1d067

ca2862297f98c78ae357e5dca46a26e90de855a3 build(deps): bump dtolnay/rust-toolchain (dependabot[bot])

Pull request description:

Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from 02cb101ec7c40f2c49e1d9714d64511d8e1b74de to 7e38f4b43b4db5c8dd498af069a4f6196df1d067.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dtolnay/rust-toolchain/commit/7e38f4b43b4db5c8dd498af069a4f6196df1d067"><code>7e38f4b</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/rust-toolchain/issues/186">#186</a> from WaterWhisperer/feat/retry-install</li>
<li><a href="https://github.com/dtolnay/rust-toolchain/commit/7645b072e70aa7a5ee7bb3e38735e66b822d8321"><code>7645b07</code></a> Retry release-server checksum failures</li>
<li>See full diff in <a href="https://github.com/dtolnay/rust-toolchain/compare/02cb101ec7c40f2c49e1d9714d64511d8e1b74de...7e38f4b43b4db5c8dd498af069a4f6196df1d067">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
apoelstra:
ACK ca2862297f98c78ae357e5dca46a26e90de855a3; successfully ran local tests


Tree-SHA512: 7d8bcb370de20f7b67471960aafd15799abc1ae78041a2ebf3fa5b5f31e0e4f866e964fe5561084f1ca5148b09e547c846dd9b47af91abd0ff526fa00a300ba5

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountautomated dependency-update discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit is a routine update by Dependabot to the version of a GitHub Action used in the project's automated workflows. It only changes which copy of the 'dtolnay/rust-toolchain' helper is referenced in CI configuration files. There is no change to the actual Rust Bitcoin library code, no user-facing behavior change, and no security issue visible in the diff.

Security candidateMerge rust-bitcoin/rust-bitcoin#6976: Fixed Typo Errors to enhance readability within the codebaseby Andrew Poelstra · 1f17f0eb · Oct 5, 2026 · 5 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6976: Fixed Typo Errors to enhance readability within the codebase

59360d8d0ae497c4dd50fbcf572acace402b5f95 fixed more typo errors to further enhance readbility within the codebase (Jaydbrown)

Pull request description:

In learning and reading the codebase, i noticed some typo errors which affected my reading and decided to fix it so future readers don't suffer the same plight.

This changes cover typo in modules accross
- Bitcoin; pow.rs file,
- p2p; message-compact-blocks.rs file,
- ChaCha-Poly; Neon.rs file.

and alot others.


ACKs for top commit:
Abeeujah:
ACK 59360d8d0ae497c4dd50fbcf572acace402b5f95
Kixunil:
ACK 59360d8d0ae497c4dd50fbcf572acace402b5f95
apoelstra:
ACK 59360d8d0ae497c4dd50fbcf572acace402b5f95; successfully ran local tests


Tree-SHA512: daf98eab209cc4b7bc8ab47106cc3dd00ced01cca82566baaf095ab1ff17d8a8c228141a7c7ee9c0d90338637764239552b3e08c45b05cde598b763ac9b9e84b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit fixes five spelling mistakes in comments and documentation across the rust-bitcoin codebase. None of the changes alter program logic, data handling, or behavior. They only improve readability of text that is ignored by the compiler.

Security candidateMerge rust-bitcoin/rust-bitcoin#6973: units: Document the encoding featureby Andrew Poelstra · 7fa8b884 · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6973: units: Document the encoding feature

f9f9d76d52ccf517042757e140be8cc88e32003c units: Document the encoding feature (Jamil Lambert, PhD)

Pull request description:

The crate docs list the optional features but omit `encoding`, which pulls in `bitcoin-consensus-encoding` and adds the encoder and decoder types.

Add it to the list.


ACKs for top commit:
Abeeujah:
ACK f9f9d76d52ccf517042757e140be8cc88e32003c
apoelstra:
ACK f9f9d76d52ccf517042757e140be8cc88e32003c; successfully ran local tests


Tree-SHA512: 72b211f7a772c8287172102e73e1527b534167c8fa7e0066cb3ff36345cdfd0fbb11b8c1c26fdab87ec5f039714e7710206e8b59629d0ee7637dccc9d3e03ed7

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
consensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit is a documentation-only change. It adds a missing entry to the crate's feature list in the source-code documentation, describing the optional `encoding` feature. There is no code change, no behavior change, and no security impact.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6971: units: Fix typosby Andrew Poelstra · 76d514ee · Oct 5, 2026 · 5 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6971: units: Fix typos

15413ce9ff6d63fdd4b7c94d7bd1829ddc9b0f20 units: Fix typos (Jamil Lambert, PhD)

Pull request description:

Fix typos found by: Claude Opus 5.5


ACKs for top commit:
Abeeujah:
ACK 15413ce9ff6d63fdd4b7c94d7bd1829ddc9b0f20
apoelstra:
ACK 15413ce9ff6d63fdd4b7c94d7bd1829ddc9b0f20; successfully ran local tests


Tree-SHA512: ad1393e1b14fd67d22eac771f03d6e231f78a31055e68de6ebd45fb626fd069d8f64e2c6861b3324c1e92e9660b76d664c75cbd1deccbeca8ec94b3308f1f0c2

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes spelling mistakes in comments and documentation strings. No program logic, calculations, or security behavior was changed.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6972: units: Use third person in rustdoc summariesby Andrew Poelstra · ce47c719 · Oct 5, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6972: units: Use third person in rustdoc summaries

e93332ab6f539eb5a843c23e7662c0ea9fd6ecd6 units: Use third person in rustdoc summaries (Jamil Lambert, PhD)

Pull request description:

The policy is for rustdoc summaries to be in third person, but a few are in imperative.

Change them to third person.


ACKs for top commit:
Abeeujah:
ACK e93332ab6f539eb5a843c23e7662c0ea9fd6ecd6
apoelstra:
ACK e93332ab6f539eb5a843c23e7662c0ea9fd6ecd6; successfully ran local tests


Tree-SHA512: 38e8e9ca9c2665e57a2010563881c8b017e816aad843ec1d4da524d7d86ce54464aa72d63c99b384372831886700aabdb20851e63bdbc7314cc29a2432331c81

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes the grammar of code documentation comments, changing phrases like 'Construct' to 'Constructs' and 'Attempt' to 'Attempts' in three source files. It does not change any actual program logic, function behavior, or security properties.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6920: primitives: Bound aggregate size and weight while decodingby Andrew Poelstra · 4a40980a · Oct 4, 2026 · 4 filesMessage 91 · StrongHigh 79Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6920: primitives: Bound aggregate size and weight while decoding

f08650da5a538330445471b0c297145579b26164 primitives: Test over-weight Block rejected (Jamil Lambert, PhD)
ed3c6ba1578e21ca40b7662efdbf34f3666d67cc primitives: Reject over-weight Block (Jamil Lambert, PhD)
9880a744f461c3054e0a6cbf9d9181350c9171e3 primitives: Test over-weight Transaction rejected (Jamil Lambert, PhD)
dd6dbfbc905f757e4065c81726d4e234d28146a6 primitives: Reject over-weight Transaction (Jamil Lambert, PhD)
b59fbee3b753f1dfc3f02190db11960b530de859 primitives: Test over size limit Witness rejected (Jamil Lambert, PhD)
cd4818dd8bc24166b362a2f9191c7e48d5e95814 primitives: Reject over size limit Witness (Jamil Lambert, PhD)

Pull request description:

The streaming `WitnessDecoder`, `TransactionDecoder` and `BlockDecoder` each bound their individual fields but never the aggregate they retain, so an untrusted reader can be fed many individually legal fields that together far exceed any valid Bitcoin object and exhaust memory.

Reject a `Witness` whose combined serialized element size exceeds the 4 MB block-weight bound, and reject a `Transaction` or `Block` whose `Weight` exceeds the maximum block weight. Add regression tests for each.

Closes project-loupe/audit-rust-bitcoin#85
Closes project-loupe/audit-rust-bitcoin#188
Closes project-loupe/audit-rust-bitcoin#199


ACKs for top commit:
apoelstra:
ACK f08650da5a538330445471b0c297145579b26164; successfully ran local tests
tcharding:
ACK f08650da5a538330445471b0c297145579b26164


Tree-SHA512: 0143010d52692f4eeb221b732943a9295ce037f6d0071339d22a58f7b1c39061549e5a5e6ec7e6d487586e6c2cdc1d24ba3bb4422dab9e2bbed8c06f65b3b184

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 79/100

This update fixes a memory-exhaustion risk in the rust-bitcoin library's streaming decoders for Bitcoin blocks, transactions, and witness data. Previously, an attacker could send many individually legal pieces of data that, when added together, created an impossibly large Bitcoin object, causing the receiving program to use excessive memory and possibly crash. The patch now rejects blocks, transactions, and witness stacks whose total size or weight exceeds Bitcoin's 4 MB block-weight limit during decoding, before all the data is fully loaded into memory. It also adds tests proving the new limits work.

Security candidateMerge rust-bitcoin/rust-bitcoin#6958: primitives: Use txid for coinbase ntxidby Andrew Poelstra · b09ad77e · Oct 2, 2026 · 2 filesMessage 96 · StrongLow 49Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6958: primitives: Use txid for coinbase ntxid

adb2c69e089be1a330feb35390440e1e8a819a6d primitives: Test coinbase ntxid behavior (Jamil Lambert, PhD)
542317a55591b10a25ca3628149b86b9a5111bcc primitives: Keep coinbase script_sig in ntxid (Jamil Lambert, PhD)

Pull request description:

A coinbase `script_sig` is not a signature and can contain a BIP-34 height commitment. Clearing it can give distinct coinbases the same `ntxid`.

Use the `txid` as the `ntxid` for coinbase transactions. Existing stores keyed by coinbase `ntxid` must recompute those keys. Like `txid`, the new `ntxid` do not distinguish identical historical coinbases.

Closes project-loupe/audit-rust-bitcoin#157


ACKs for top commit:
apoelstra:
ACK adb2c69e089be1a330feb35390440e1e8a819a6d; successfully ran local tests
tcharding:
ACK adb2c69e089be1a330feb35390440e1e8a819a6d


Tree-SHA512: 6f3d4fcb30ae5d92dcc73292a6fb16b97f4abc4a9e32b417353fdb108e3cb3de7e232752abe12b944782063d934674c680bec28b8cdac8a9f0f2aa424f729cb8

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryproof-of-work or emission validationsigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 49/100

This change fixes how a secondary transaction identifier called 'ntxid' is calculated for coinbase transactions (the special first transaction in each Bitcoin block). Previously, the code treated the coinbase's script_sig like a normal signature and cleared it when computing ntxid. Because coinbase script_sig actually contains required block-height data, two different valid coinbases could end up with the same ntxid. The fix makes coinbase ntxid equal to the regular txid, so distinct coinbases stay distinct. Any database or index that used the old coinbase ntxid as a key would need to recompute those keys.

Security candidateprimitives: implement lexicographic Header Ordby satsfy (Renato Britto) · 9162fe34 · Oct 2, 2026 · 1 fileMessage 60 · AdequateInformational 18Details
Commit message · satsfy (Renato Britto)

primitives: implement lexicographic Header Ord

Order is lexicographic over the consensus serialization.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
consensus or confidential-proof validation
AI analysis · Informational 18/100

This commit changes how Bitcoin block headers are sorted in the rust-bitcoin library. Previously, Rust's automatic ordering compared fields one by one in memory. Now, ordering is explicitly defined to match the byte-for-byte order of the header when serialized to the Bitcoin network format. This is a correctness/consistency improvement, not a security fix. There is no indication it addresses a vulnerability or was triggered by a security report.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6949: Manual nightly rustfmt (2026-09-27)by Andrew Poelstra · f6e33d78 · Oct 2, 2026 · 9 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6949: Manual nightly rustfmt (2026-09-27)

b9b241377dff148e10a66d6876cb310487916580 Run the formatter (Tobin C. Harding)
8dc70dd876bb44072e8eae8d8b439888852a3640 primitives: Don't format array (Tobin C. Harding)

Pull request description:

Replaces https://github.com/rust-bitcoin/rust-bitcoin/pull/6944

Note the formatter is run with the listed toolchain but the manifest is not changed. This is to mimic #6944. I don't know where the bot is getting that toolchain from.

Patch 1 skips the offending code from review of 6944.


ACKs for top commit:
apoelstra:
ACK b9b241377dff148e10a66d6876cb310487916580; successfully ran local tests


Tree-SHA512: 1a01499b80c81c06afa375df82b377c4735210868f09b53a9494be6c96dab5a0b918ec39118b05b697be00c5d1c5b1b34536ed44b81f9a9629a302edef960c73

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is purely a code formatting cleanup. It adjusts whitespace, line breaks, import order, and adds a single #[rustfmt::skip] annotation so an automated formatter does not reformat a test data array. There are no functional code changes and no security implications.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6954: units: serialize unsigned amounts as u64by Andrew Poelstra · 295c9d8a · Oct 1, 2026 · 2 filesMessage 100 · StrongModerate 62Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6954: units: serialize unsigned amounts as u64

256ad0137832ac2bbbfb4053f570675fb1c72003 units: test amount varint serde round-trip (satsfy (Renato Britto))
ce1e998db1290a1d8da83d1a4c4a1393b41dd983 units: serialize unsigned amounts as u64 (satsfy (Renato Britto))

Pull request description:

A follow up of https://github.com/rust-bitcoin/rust-bitcoin/pull/6061#issuecomment-5751334257

`deserialize()` hinted u64 for unsigned amounts, but `serialize()` only ever wrote i64, so the two sides disagreed on the encoding. As a result, 100 sats became 200 sats in varint serialization format formats like postcard.

This state came about because we wanted serde errors to show each type's real range, and unsigned amounts to use a u64 hint so deserializers wouldn't be confused because the old errors complained about i64 first and only then about the real range, so users hit two failures. An unsigned amount should hint u64.

The problem is that, in varint formats like postcard, every amount reads back doubled. The zigzag encoding formula is `zigzag(n) = (n << 1) ^ (n >> 63)` for integer n in 64 bit representation. When n>0, (n>>63) is 0 and (n<<1) becomes n*2, so the number gets doubled on encoding, and then read as the doubled number directly on decoding. Also Amount::MAX fails because values ]10.5M,21M] BTC get doubled, surpassing the total bitcoin cap, then when range check looks at it on decoder, it rejects the input.

Serialization output format has changed, now matches the hint, and the `as_sat` token tests expect U64 for unsigned amounts.


ACKs for top commit:
apoelstra:
ACK 256ad0137832ac2bbbfb4053f570675fb1c72003; successfully ran local tests
tcharding:
ACK 256ad0137832ac2bbbfb4053f570675fb1c72003
Kixunil:
ACK 256ad0137832ac2bbbfb4053f570675fb1c72003


Tree-SHA512: 9c6ff0c7fac4ed2f6f356eba0f59cc903eb6adc89382b343ceae79fbbff2e26268ea8c77c62cd2c9447f543dfc08bb060ad2eb943771e8af361585123af9a053

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Moderate 62/100

This commit fixes a mismatch in how unsigned Bitcoin amounts were serialized versus deserialized when using certain compact binary formats. Previously, an unsigned amount (like 100 satoshis) was written as a signed number, which caused formats such as postcard/bincode with varint encoding to silently double the value on read-back and to reject very large amounts near the Bitcoin supply cap. The fix makes serialization use the same unsigned 64-bit hint that deserialization already expected, so round-trips now produce the same value.