RB
← All projectsRust Bitcoin

rust-bitcoin

Rust library for Bitcoin data structures, serialization, consensus encoding, and scripts.

BitcoinCryptographic librariesNormal
Repository coverage

2570 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

612security candidates555second-pass queue2330AI analyses
153commits · 30 days
279commits · 60 days
977commits · 180 days
2058commits · 365 days
Backfill bands
Aug 5 → Feb 6787 seen32 candidatesComplete
Feb 6 → Jun 6878 seen53 candidatesComplete
Jun 6 → Jul 6211 seen15 candidatesComplete
Jul 6 → Aug 5184 seen2 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

68/100 average clarity
702Strong · 80–100
1135Adequate · 60–79
582Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Andrew Poelstra407139251391
Mitchell Bagot659200654068
Tobin C. Harding42167411063
jrakibi1015096069
satsfy (Renato Britto)652235065
Nick Johnson19621190060
Jamil Lambert, PhD12619117062
Fmt Bot351532045
Trevor Arjeski111111069
Shing Him Ng31731056
Martin Habovstiak31629069
Ismail Daif22622050
Analysis record

Published AI watches

Last scanned 55 minutes ago

Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7220: refactor(bip32)!: replace KeySource with KeyOrigin

This is a routine code cleanup in a Bitcoin library. It renames a simple data container from KeySource to KeyOrigin and gives it named fields (fingerprint and path) instead of numbered tuple slots (.0 and .1). The serialized format is inte…

6bb507b2by Andrew Poelstra+84−33 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7204: key-expression: Get secp256k1 from the crypto dep

This change is a routine internal cleanup: the key_expression crate stops depending directly on the secp256k1 cryptography library and instead uses a re-export provided by another internal crate called crypto. No user-facing behavior, type…

d193efc5by Andrew Poelstra+7−107 files
No security note in commit
Informational 17 AI analysisMessage 68 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Forward serde feature to network

This is a small Cargo.toml fix in a Rust Bitcoin subcrate. When the optional 'serde' feature was enabled on the key_expression crate alone, it did not also enable serde on the network crate. That meant a type called NetworkKind could not b…

806f1e1fby bytescape30+1−11 file
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7223: build(deps): bump taiki-e/install-action from 2.87.9 to 2.87.13

This is a routine update to a GitHub Actions helper used in automated testing workflows. It bumps the version of taiki-e/install-action, which downloads and installs Rust developer tools during CI runs. There is no change to the actual Bit…

c8ee144aby Andrew Poelstra+2−22 files
No security note in commit
Informational 20 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7224: build(deps): bump astral-sh/setup-uv from 10.0.1 to 10.1.0

This is a routine update to a GitHub Actions helper used only in automated security-scanning workflows. The new version adds minor improvements, including respecting proxy settings and verifying downloaded files with checksums. It does not…

Dependency bump of a third-party GitHub Action used in CI onlyUpstream release notes mention generic security improvements (checksum verification, npm install defaults, NO_PROXY)No CVE, advisory, or vendor security disclosure is present in the commit or supplied references
7bc9d696by Andrew Poelstra+2−22 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7105: Remove derived serde impls for types in stabilising crates

This commit removes automatic serde (serialization/deserialization) code generation from several Rust Bitcoin library crates and replaces it with hand-written implementations. The stated goal is to reduce dependencies and make the code eas…

Manual serde implementations replace derived ones, increasing the surface area for serialization-format bugsNo validation logic changes are visible in the diffNo mention of security fixes, CVEs, or vulnerability reports in commit message or PR description
9eeb7774by Andrew Poelstra+219−4110 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7205: Manual update to rustc stable (to 1.100.0)

This commit updates the project's automated Rust compiler version from 1.99.1 to 1.100.0 and adjusts a CI cache cleanup script to match a new directory layout used by Cargo 1.100. It is purely an infrastructure/maintenance change to keep a…

44e6f0caby Andrew Poelstra+8−22 files
No security note in commit
Informational 18 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7197: ci: bump rbmt to 0.5.5 and fail API job on private dep leak

This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of interna…

CI guardrail added to prevent private dependency leaks into stable crate public APIsTool bump enables detection of re-exported private dependenciesNo source-code vulnerability is patched
be14c72eby Andrew Poelstra+7−12 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7185: Refactor/bip32 flatten error constructors

This is a minor internal code cleanup in the Rust Bitcoin library. It changes how two functions (Xpriv::decode and Xpub::decode) build their error messages when an input is the wrong length. The behavior is the same before and after; only …

271f662aby Andrew Poelstra+8−61 file
No security note in commit
Informational 24 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7167: units: remove `Denomination::MicroBitcoin`

This is a routine API cleanup, not a security fix. The change removes one way of naming a Bitcoin unit ('MicroBitcoin' / 'uBTC') and keeps the equivalent 'bits' form. Any code that previously used the old name will fail to compile or fail …

No security signal: public API deprecation and enum variant removalNo memory safety, cryptographic, or consensus code modifiedError message change is informational only
d0602195by Andrew Poelstra+53−403 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7127: key_expression: Reduce `alloc` gating to minimal types

This commit is a code cleanup and feature-gating refactor for the rust-bitcoin library's key_expression crate. It makes more BIP32 (Bitcoin wallet key derivation) types available when the 'alloc' memory allocator feature is disabled, and s…

Refactor of error types and parsing paths for Xpriv/Xpub base58 decodingSwitch from unbounded base58 decode to fixed-size array decode (78 bytes)Removal of explicit length-check error path in favor of decoder-reported length error
c3d27d5dby Andrew Poelstra+60−823 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7039: primitives: Fix daily Miri cron failures with measured test gating

This change only adds `#[cfg_attr(miri, ignore)]` annotations to a handful of slow unit tests so they are skipped when run under Miri, a Rust interpreter used for detecting undefined behavior. It does not change any production code, consen…

1dc09077by Andrew Poelstra+6−03 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7182: Update local dependencies

This commit only updates version numbers in package configuration files (Cargo.toml) for internal dependencies so that all crates in the project require the same minimum versions of shared libraries. There are no code changes, no bug fixes…

06f41225by Andrew Poelstra+7−75 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7179: build(deps): bump taiki-e/install-action from 2.87.4 to 2.87.9

This is a routine update to a GitHub Actions helper used in automated testing workflows. It changes which version of a third-party tool-installer action is used, but only for installing the cargo-mutants testing tool. There is no indicatio…

4fda66b5by Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7180: build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This commit updates the version of a helper tool called cargo-binstall used in two automated GitHub workflows. The change only affects internal build/CI tooling and does not alter the rust-bitcoin library code that users install or run. Th…

53eae24dby Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7181: build(deps): bump github/codeql-action/upload-sarif from 4.37.9 to 4.38.0

This is a routine update by Dependabot to the GitHub CodeQL upload-sarif action used in a scheduled security scanning workflow. It changes one pinned commit hash to a newer version of the same action. There is no indication this introduces…

4bb555f0by Andrew Poelstra+1−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Flatten BIP32 decode error construction

This commit is a minor code cleanup in the Rust Bitcoin library. It changes how an error message is built when decoding BIP32 extended keys, switching from one nested construction style to two chained calls. The actual behavior and returne…

c31c11e0by Adewale Ijalana+8−61 file
No security note in commit
Low 36 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7168: units: add `visit_units` in optional serde visitors

This commit fixes a bug in how optional Bitcoin amount and fee-rate values are read from JSON when those fields are inside a flattened struct and the value is null. Previously, the code would error out because it did not handle a special s…

Deserialization failure in optional numeric types under serde flattenMissing serde visitor method (visit_unit) causing runtime errorsRegression test added for null handling in flattened structs
47340d2fby Andrew Poelstra+79−03 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump github/codeql-action/upload-sarif

This is a routine dependency update by Dependabot, bumping the version of a GitHub-provided action used to upload security scan results. There is no indication of a security vulnerability in the project itself or in this change.

fe755619by dependabot[bot]+1−11 file
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This is a routine automated update by Dependabot that changes the version of a GitHub Action used to install Rust tools in two CI workflows. There is no indication of a security issue in the commit itself, and no verified security referenc…

2ccb0029by dependabot[bot]+2−22 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#7118: primitives: Cover ScriptCode in the API testby Andrew Poelstra · 831cae43 · Oct 29, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7118: primitives: Cover ScriptCode in the API test

42e806e8beb7e99a11a6a658f9e08a6a6df282a4 primitives: Cover ScriptCode in the API test (Jamil Lambert, PhD)

Pull request description:

`ScriptCode` and `ScriptCodeTag` were added after the API test was written and are missing from the trait, Debug, Default and re-export checks that every other script type goes through. The boxed `SignetBlockScript` and the two script size constants were also missing.

Add them.

Assisted-by: Claude Opus 5.5


ACKs for top commit:
Abeeujah:
ACK 42e806e8beb7e99a11a6a658f9e08a6a6df282a4
tcharding:
ACK 42e806e8beb7e99a11a6a658f9e08a6a6df282a4
apoelstra:
ACK 42e806e8beb7e99a11a6a658f9e08a6a6df282a4; successfully ran local tests


Tree-SHA512: 2acc55c1fc0618231a377157a330da8c2a3bf32ae00b1888176e0c1d967d66f6298b6edcd2390878916eebbf2030def00ccdd6b4c404f7aeb84582a484ffcc2a

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge rust-bitcoin/rust-bitcoin#7112: units: remove `Amount::MAX_MONEY`by Andrew Poelstra · dafa5b06 · Oct 29, 2026 · 6 filesMessage 100 · StrongInformational 20Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7112: units: remove `Amount::MAX_MONEY`

71641e87aa0d7d9604d8ec920ba2aa3e3d5e2b93 units: remove Amount::MAX_MONEY (satsfy (Renato Britto))

Pull request description:

Now is the last call to judge the matter before units 1.0: In [#3693](https://github.com/rust-bitcoin/rust-bitcoin/pull/3693) we decided to keep both `MAX` and `MAX_MONEY` as synonyms. In [#4164](https://github.com/rust-bitcoin/rust-bitcoin/pull/4164#discussion_r1979441438) it was argued that `MAX` is the proper rusty name for it, something I agree. All these discussions ended at March 2025.

It seems like we are hedging between looking like core and looking rustonic on the `Amount::MAX` and `Amount::MAX_MONEY` issue.

I think we should just kill `MAX_MONEY` because:
1. DRY principle
2. Why are we afraid of looking different from core?
3. We can remove now and add later, but not easily later past 1.0.
4. We have `Weight::MAX`, `Sequence::MAX`, `SignedAmount::MAX`, `FeeRate::MAX`...
5. It just looks bad.


ACKs for top commit:
Kixunil:
ACK 71641e87aa0d7d9604d8ec920ba2aa3e3d5e2b93
apoelstra:
ACK 71641e87aa0d7d9604d8ec920ba2aa3e3d5e2b93; successfully ran local tests


Tree-SHA512: cdb3185b727392d72beb3201fac3d738800414458be41884a487bb7d293871f6643f1e716913354cda4e32aa7d6ef194f6d0ea9de90ad1cc4210953a85946d6c

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit is a routine API cleanup: it removes the duplicate constant name `Amount::MAX_MONEY` and keeps `Amount::MAX` as the single name for the maximum Bitcoin amount. The numeric value (21 million BTC) and all safety checks stay exactly the same. It is not a security fix and does not change how the library protects against invalid amounts.

Lower-priorityunits: Bump version to 0.7.0by Tobin C. Harding · a8dc545c · Oct 28, 2026 · 9 filesMessage 68 · AdequateTriage 0Details
Commit message · Tobin C. Harding

units: Bump version to 0.7.0

In preparation for the last last RC release bump the version, add a
changelog, and update the lock files.

Upgrade all repo users.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7072: script: accept small int pushes in redeem_scriptby Andrew Poelstra · 7eb95ea5 · Oct 28, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7072: script: accept small int pushes in redeem_script

c065042f1665924ba6022baeb59ff1d4667131ce script: test redeem_script after small int push (Nuem.dev)
43ae219ab4ab19479f605e751c09a71d75e5bd81 script: accept small int pushes in redeem_script (Nuem.dev)

Pull request description:

ScriptSigExt::redeem_script returns None for a scriptSig like OP_1 <redeem script>, even though that is a valid push-only P2SH scriptSig.
The check required every instruction to be a data push, but the iterator yields OP_1..OP_16 and OP_1NEGATE as Op, so they were rejected. Core (and BIP-16) treat any opcode up to OP_16 as a push, and is_push_only in the same file already follows that rule. A spend like OP_1 <redeem script>, picking the IF branch of the redeem script, hit this.
This switches redeem_script to call is_push_only. I added a test for OP_1 <redeem script>, plus a check that a non-push opcode still gives None. The test fails without the change. All bitcoin lib tests pass.


ACKs for top commit:
Abeeujah:
ACK c065042f1665924ba6022baeb59ff1d4667131ce
apoelstra:
ACK c065042f1665924ba6022baeb59ff1d4667131ce; successfully ran local tests


Tree-SHA512: 193096cfec9be5f71afd0a4ab1cf185a5e79aa4ca5d19683940901bbfdebc7a6d96e7f24248db9497fda74d8941061cc5a2d87c92f1c7d5446dedf61ea723c83

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#7119: Use SegWit consistently in docs and commentsby Andrew Poelstra · 3b2ce682 · Oct 28, 2026 · 15 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7119: Use SegWit consistently in docs and comments

308092ef0202212bed7b679a7d91ad35dd1adddb Use SegWit consistently in docs and comments (Jamil Lambert, PhD)

Pull request description:

The codebase mostly writes SegWit but a number of docs, comments and test messages still use Segwit or segwit.

Capitalize the remaining prose occurrences. Identifiers and changelogs are left alone, as are the lines in `transaction.rs` and the tapscript type docs that are already changed by open PRs.

Assisted-by: Claude Opus 5.5


ACKs for top commit:
apoelstra:
ACK 308092ef0202212bed7b679a7d91ad35dd1adddb; successfully ran local tests


Tree-SHA512: 413f366296187df400d56d7b723df40f9d58776eac35b06cc157d70295b282155fa79a1a2ced4a9cfd4526b5592f2d5c98615dd814d04c1f5f99684f6cb41b92

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only fixes capitalization of the term 'SegWit' in documentation, comments, and test messages across the rust-bitcoin codebase. No code behavior changes, no security fix or vulnerability introduced.

Lower-priorityprimitives: Remove unneeded allow(deprecated)by Jamil Lambert, PhD · aa63020f · Oct 28, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Jamil Lambert, PhD

primitives: Remove unneeded allow(deprecated)

`PushBytesBuf::push` has had `#[allow(deprecated)]` since it was added
in bcd95fa03, but nothing it calls, `check_limit` or `Vec::push`, has
ever been deprecated. The attribute only hides future warnings.

Remove it.

Assisted-by: Claude Opus 5.5

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityprimitives: Add missing blank linesby Jamil Lambert, PhD · 3cb4f669 · Oct 28, 2026 · 2 filesMessage 60 · AdequateTriage 0Details
Commit message · Jamil Lambert, PhD

primitives: Add missing blank lines

Add the blank lines missing between two items.

Assisted-by: Claude Opus 5.5

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI review queuedprimitives: Tidy doc wordingby Jamil Lambert, PhD · b0243999 · Oct 28, 2026 · 3 filesMessage 58 · ThinInformational 15Details
Commit message · Jamil Lambert, PhD

primitives: Tidy doc wording

Add the missing article to the script hash docs, describe
`OutPointDecoderError` the same way as the other decoder errors, and use
the third person for `cast_to_usize_if_valid`.

Assisted-by: Claude Opus 5.5

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only fixes minor grammar and wording in code documentation comments. It adds missing articles like 'the', standardizes how an error type is described, and changes a verb to third person. There are no code behavior changes, no bug fixes, and no security implications.

Lower-priorityprimitives: Remove stale note about old atomicsby Jamil Lambert, PhD · 7376de3f · Oct 28, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Jamil Lambert, PhD

primitives: Remove stale note about old atomics

The note dates from when the impl was also built on toolchains too old
for `target_has_atomic`. That fallback is long gone, the impl is simply
gated on the cfg, so the note is misleading.

Assisted-by: Claude Opus 5.5

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityprimitives: Fix Witness::from_slice panics docsby Jamil Lambert, PhD · 72ee0e66 · Oct 28, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Jamil Lambert, PhD

primitives: Fix Witness::from_slice panics docs

The panics section was split into a sentence and a fragment, and
"bytes slices" was a typo.

NB. The above "fragment" reason, which is an odd way of describing how
the second sentence doesn't start correctly, was the LLM. I still think
the change is better though.

Assisted-by: Claude Opus 5.5

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityprimitives: Add missing full stops to docsby Jamil Lambert, PhD · 6cf1d9b5 · Oct 28, 2026 · 3 filesMessage 68 · AdequateTriage 0Details
Commit message · Jamil Lambert, PhD

primitives: Add missing full stops to docs

Also correct missing backticks and a rogue capital letter on the same
line as the missing full stop.

Assisted-by: Claude Opus 5.5

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Security candidateMerge rust-bitcoin/rust-bitcoin#7114: bitcoin: move annex and code_separator_pos to the endby Andrew Poelstra · f127ba2a · Oct 28, 2026 · 2 filesMessage 81 · StrongInformational 19Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7114: bitcoin: move annex and code_separator_pos to the end

f7d04a79cbff0c6fdd377ba08c90a21b77382c36 bitcoin: move annex and code_separator_pos to the end (jrakibi)

Pull request description:

These arguments are uncommon, so we can put them at the end of the argument list. This will give existing callers clearer compiler error messages when upgrading.

Closes #7109


ACKs for top commit:
Kixunil:
ACK f7d04a79cbff0c6fdd377ba08c90a21b77382c36
Abeeujah:
ACK f7d04a79cbff0c6fdd377ba08c90a21b77382c36


Tree-SHA512: 79ccef326c5804cd6809df2e1ad278b8a33ce43dddf5c0bcf4b412e3260686f0d93152ce9293ef1bba8c984d9774e578b86a3305fb0777523ae3c0383b3b73c1

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This change simply reorders the arguments of two Bitcoin Taproot signature hash functions so that rarely-used optional parameters appear at the end. It is a developer-experience improvement and does not change any security behavior.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#7113: bitcoin: Remove `annex` support noteby Andrew Poelstra · c658f514 · Oct 28, 2026 · 1 fileMessage 93 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7113: bitcoin: Remove `annex` support note

0b6b1d518bb39d5dbad18c30b913ba65cc2a5dc2 bitcoin: Remove `annex` support note (jrakibi)

Pull request description:

The Taproot sighash API already supports annex data, but the documentation still says the library does not support it.

Remove the note to avoid confusion.


ACKs for top commit:
Kixunil:
ACK 0b6b1d518bb39d5dbad18c30b913ba65cc2a5dc2


Tree-SHA512: 8bf3a6b832b3d9608169d7c7b97d1ab2e4970d3b16b4a7a828eaafcd2183e1511823f7d6a7b1de1335deec80787a077bd120ddaee116114c1078e2d3755347a5

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7095: block: Go over docs with a fine toothcombby Andrew Poelstra · e52dd007 · Oct 28, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7095: block: Go over docs with a fine toothcomb

3b273b78442f008a58d6af107452df4775e2a12a Use small b for block (Tobin C. Harding)
5fda7893301d26c4126320fd7933b580c3cd895a primitives: Add full stops in block module (Tobin C. Harding)
6aa86a4d9fff4ee799a00ba55fcdb4f91436f93d primitives: Improve rustdoc compute_mekle_root call sits (Tobin C. Harding)
30db4c32757407904be553d6e26151bb8eb3f633 primitives: Fix rustdoc column width in block module (Tobin C. Harding)

Pull request description:

We are on the final push in `primitives`. Go over the docs in `block`.


ACKs for top commit:
apoelstra:
ACK 3b273b78442f008a58d6af107452df4775e2a12a; successfully ran local tests
Kixunil:
ACK 3b273b78442f008a58d6af107452df4775e2a12a


Tree-SHA512: 1023f2c7b741b6183fc980573ff2034ee2ba0e566787b77c88fcbba018f8c51a4fddc188e8cdb25182696ecefd87eed675a09f6aa9b85c96ccc45022dcaeb514

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidatebitcoin: move annex and code_separator_pos to the endby jrakibi · f7d04a79 · Oct 28, 2026 · 2 filesMessage 73 · AdequateInformational 20Details
Commit message · jrakibi

bitcoin: move annex and code_separator_pos to the end

These arguments are uncommon, so we can put them at the end of the
argument list. This will give existing callers clearer compiler error
messages when upgrading.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 20/100

This commit simply reorders the arguments of two Bitcoin Taproot sighash functions so that less commonly used parameters (annex and code_separator_pos) appear at the end of the argument list. It is a developer-experience/API cleanup change, not a security fix. There is no change to the underlying cryptographic logic, transaction parsing, or signature validation.

Security candidateMerge rust-bitcoin/rust-bitcoin#7111: units: remove unused fee_rate serde OverflowErrorby Andrew Poelstra · 130ed631 · Oct 28, 2026 · 2 filesMessage 91 · StrongInformational 19Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7111: units: remove unused fee_rate serde OverflowError

bc0b5a3ec3a6c650864cfd6a345131b90f60c678 units: remove unused fee_rate serde OverflowError (satsfy (Renato Britto))

Pull request description:

`from_sat` constructors became infallible on [this commit](https://github.com/rust-bitcoin/rust-bitcoin/commit/0ff8d82193ef562c1aedabe98a6283d09f803c0c), and this is now useless. I just dropped and nothing broke, that error was never constructed.


ACKs for top commit:
apoelstra:
ACK bc0b5a3ec3a6c650864cfd6a345131b90f60c678; successfully ran local tests
Kixunil:
ACK bc0b5a3ec3a6c650864cfd6a345131b90f60c678
Abeeujah:
ACK bc0b5a3ec3a6c650864cfd6a345131b90f60c678


Tree-SHA512: c15ef6438b0192d68f3164a878f62b3f1917004976d2ced218f0b1e8c5ce4ef5c67cf81a581bb62864613a6a8d235e969fd1ec873ac6cf28f96ca77651130517

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Informational 19/100

This commit removes an unused error type called OverflowError from the fee_rate serde module. The error was no longer needed because the underlying constructor became unable to fail. It is a straightforward cleanup with no security impact.

Lower-prioritybitcoin: Remove `annex` support noteby jrakibi · 0b6b1d51 · Oct 28, 2026 · 1 fileMessage 80 · StrongTriage 0Details
Commit message · jrakibi

bitcoin: Remove `annex` support note

The Taproot sighash API already supports annex data,
but the documentation still says the library does not support it.

Remove the note to avoid confusion.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7099: bitcoin: fix stale `ScriptLeaf`by Andrew Poelstra · 2a9dd966 · Oct 27, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7099: bitcoin: fix stale `ScriptLeaf`

96b0955d0c58c54319c861e51a12ad129ae38bd1 bitcoin: fix stale ScriptLeaf (jrakibi)

Pull request description:

In https://github.com/rust-bitcoin/rust-bitcoin/commit/74022baa44d7efbe3e0ffc58126dc7dfc9b42344, we renamed `ScriptLeaf` to `LeafNode` but forgot to update some comments that still refer to `ScriptLeaf`.


ACKs for top commit:
Abeeujah:
ACK 96b0955d0c58c54319c861e51a12ad129ae38bd1
apoelstra:
ACK 96b0955d0c58c54319c861e51a12ad129ae38bd1; successfully ran local tests
Kixunil:
ACK 96b0955d0c58c54319c861e51a12ad129ae38bd1


Tree-SHA512: 6c9766295bb73f8c93299b55062fd101a64dc5480ccbbd0da66eaa44e27c80826c0fd66bb19e96c1aa9b2add1c589ae62eed72bc35d1968eda9eb6e9bdf99b48

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7076: Automated weekly update to rustc (to nightly-2026-10-24) on masterby Andrew Poelstra · 9d285df2 · Oct 27, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7076: Automated weekly update to rustc (to nightly-2026-10-24) on master

9ac9c4f95aceb064c7c7c522ca930347d2ca0d59 Automated update to rustc nightly-2026-10-24 (Update Nightly Rustc Bot)

Pull request description:

Automated update to Cargo.toml workspace metadata by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action


ACKs for top commit:
satsfy:
ACK 9ac9c4f95aceb064c7c7c522ca930347d2ca0d59
tcharding:
ACK 9ac9c4f95aceb064c7c7c522ca930347d2ca0d59


Tree-SHA512: 337377b63c2ddb2f0a673711e8bcb931e6a2baa2b5691de442c530d9abe57c978073b6dde8680c2ba2c836db580b7c5680fc93bcb9a8dcbf348320ea291282d4

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7110: units: rename Sequence height block countby Andrew Poelstra · 43a2891e · Oct 27, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7110: units: rename Sequence height block count

997ea44aaf3418045a9b479fdf230c5255eac258 units: rename Sequence height block count (satsfy (Renato Britto))

Pull request description:

Last call for a possibility to change this potentially confusing naming schema. It is a logical extension of the naming schema we adopted by calling the type `NumberOfBlocks`. The goal of this PR is to rectify intentions, I'll drop it on the first maintainer NACK.


ACKs for top commit:
apoelstra:
ACK 997ea44aaf3418045a9b479fdf230c5255eac258; successfully ran local tests; yeah, I think this is a significant clarification and helps users keep track of relative vs absolute timelocks
Abeeujah:
ACK 997ea44aaf3418045a9b479fdf230c5255eac258


Tree-SHA512: 0c7b0fe6fb74bafb190055fbe39b1e9d9b7ab7cf2796751219515e9b7c16198e696eb49eca413ec7cf229ae85446c38ecd8817f06109b8032a7b2ea34d4b4745

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7107: units: remove deprecated functionsby Andrew Poelstra · 43de579b · Oct 27, 2026 · 3 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7107: units: remove deprecated functions

7ce6832c82c03fb90289424d0be099523a9b0600 units: remove deprecated functions (satsfy (Renato Britto))

Pull request description:

Stable crates do not need to carry deprecated code and we decided in https://github.com/rust-bitcoin/rust-bitcoin/issues/6310#issuecomment-6254674821 to not deprecate things. So we can remove this already, be consistent and be done with it.


ACKs for top commit:
apoelstra:
ACK 7ce6832c82c03fb90289424d0be099523a9b0600; successfully ran local tests
tcharding:
ACK 7ce6832c82c03fb90289424d0be099523a9b0600
Kixunil:
ACK 7ce6832c82c03fb90289424d0be099523a9b0600
Abeeujah:
ACK 7ce6832c82c03fb90289424d0be099523a9b0600


Tree-SHA512: c5a26fb415ab7faaf05f3861bcdbbf17224a5f6d031ab3a3c53f31e5716bd03192a75b1d2379c60752cecdd9815c542c23148ab7d2ce5f68191d04990d7e2dd9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedunits: remove Amount::MAX_MONEYby satsfy (Renato Britto) · 71641e87 · Oct 27, 2026 · 6 filesMessage 70 · AdequateInformational 19Details
Commit message · satsfy (Renato Britto)

units: remove Amount::MAX_MONEY

We are hedging between looking like core and looking
rustonic on the Amount::MAX and Amount::MAX_MONEY. I think
we should just kill MAX_MONEY because:
1. DRY principle
2. Why are we afraid of looking different from core?
3. We can remove now and add later, but not easily later.
4. We have Weight::MAX, Sequence::MAX...
5. It just looks bad

This commit also makes `MAX_MONEY` only a doc alias to `MAX`

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This is a routine code cleanup in the rust-bitcoin library. It removes a duplicate constant named MAX_MONEY and replaces all uses with an existing identical constant named MAX. The actual numeric limit (21 million bitcoin) and all safety checks stay exactly the same. There is no security bug being fixed here.

Security candidateunits: remove unused fee_rate serde OverflowErrorby satsfy (Renato Britto) · bc0b5a3e · Oct 27, 2026 · 2 filesMessage 60 · AdequateInformational 18Details
Commit message · satsfy (Renato Britto)

units: remove unused fee_rate serde OverflowError

from_sat constructors became infallible and this is now
useless.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
memory safety
AI analysis · Informational 18/100

This commit simply deletes an unused error type called OverflowError from the fee rate serialization code. It is a cleanup change with no security impact. The type became unnecessary because the underlying constructors can no longer fail.

Lower-priorityunits: rename Sequence height block countby satsfy (Renato Britto) · 997ea44a · Oct 27, 2026 · 2 filesMessage 60 · AdequateTriage 0Details
Commit message · satsfy (Renato Britto)

units: rename Sequence height block count

A logical extension of the naming schema we adopted by
calling the type `NumberOfBlocks`

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7082: primitives: Add reason to must_use on into_boxed_scriptby Andrew Poelstra · ada22668 · Oct 27, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#7082: primitives: Add reason to must_use on into_boxed_script

a5756e685708620c4e2245c62282ded7d70a8c4b primitives: Add reason to must_use on into_boxed_script (PeterXMR)

Pull request description:

`ScriptBuf::into_boxed_script` is the special case Kixunil pointed out in https://github.com/rust-bitcoin/rust-bitcoin/pull/3704#issuecomment-2616380607: when the capacity is larger than the length, the conversion reallocates to shrink the buffer. Ignoring the result throws that work away. This adds a reason string to its `#[must_use]` saying so.

Nothing else needed changing:

- `Box<Script>::into_script_buf` doesn't allocate (`Box<[u8]>` to `Vec<u8>` is free), so its bare `#[must_use]` stays.
- `impl From<ScriptBuf> for Box<Script>` takes the same reallocating path, but `#[must_use]` on a trait impl method has no effect.

Fixes #3963

This patch was written with the assistance of an LLM (Claude Opus 5.5) and reviewed by me.


ACKs for top commit:
Kixunil:
ACK a5756e685708620c4e2245c62282ded7d70a8c4b
apoelstra:
ACK a5756e685708620c4e2245c62282ded7d70a8c4b; successfully ran local tests


Tree-SHA512: e8f37a3cf2cafac3284b6afdb8203d644bc791949cbc2a617ac039375e4f51885485acb39fb5687d384f573206f99681e20793d02b6ef98c9654090d166cc01f

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount