rust-bitcoin

p2p: calculate v1 checksum on original payload

A differential fuzz test found a malformed v1 message which *passed*
its checksum validation due to the checksum being calculated on a
re-encoded payload instead of the raw payload bytes. Due to wiggle room
in the p2p spec, re-encoded payloads can differ from the raw bytes which
results in a different checksum.

This change calculates the checksum on the fly agianst the raw payload
bytes to avoid the ambiguity.

p2p: Add `sendtxrcncl` to network messages

`sendtxrcncl` has not been assigned a v2 shortID.

ref: https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L920

p2p: Add erlay message module

Although full erlay support has not been implemented, Bitcoin Core nodes
can still advertise support for erlay as a configuration option. We
should support decoding this message.

The version is private as anything besides version one is nonsense.

ref: https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L3736

fuzz: Add `hashes_arbitrary_json` target

fuzz: Fix `hashes_json` roundtrip check

hashes: Add `Arbitrary` impl for `Hmac`

Use collect_seq when serializing Vec<T>

Prefer `collect_seq` implementation over the serialize_seq and the
manual loop `serialize_element` call to serialize all elements in
the vector.

fuzz: Remove allocations in roundtrip targets

The roundtrip fuzz targets rely on functions in lib.rs that decode,
encode and decode again. In this process, a Vec allocation is made
as an intermediate step to hold the encoded object. Since the encoded
data is ignored, this allocation can instead be replaced by a direct
push of the encoder chunks into the decoder.

Replace Vec allocation with direct writes from encoder to decoder in
roundtrip fuzz targets.

Replace as_inner accessor on XOnlyPublicKey with to_inner

Access to the inner types for the key wrappers should be uniform.
Specifically, for the public Copy types, inner access should be by
value. To achieve this XOnlyPublicKey::as_inner must be removed.

Remove XOnlyPublicKey::as_inner.

Make to_inner on public key types pub(super)

The to_inner function was introduced as a stop-gap to eliminate the
public access to inner secp types on the public key types. Now that
the key types have been adjusted such that inner access is no longer
needed outside of crypto, these conversion methods can be made private.

Make to_inner on all public key types pub(super).

hashes: capitalize hash algorithm names

hashes: Fix doc typos

- Add missing full stop
- Capitalize first words in doc comments

taproot-primitives: Remove crypto dep

Move from_key_and_merkle_root to extension trait

The from_key_and_merkle_root method on the TapTweakHash type is the
only part of the taproot-primitives crate that causes a dependency on
the crypto crate. By moving this back to bitcoin, we can remove the
dependency on crypto, allows these types to stabilise in primitives
without waiting on crypto to stabilise.

Move from_key_and_merkle_root to new extension trait TapTweakHashExt in
bitcoin.

hashes: Add commented out dyn compatible test

C-OBJECT is about object safety. None of the `hashes` traits are
object safe. Add a commented out test so I (and no-one else) has to
look at this again.

hashes: Remove unnecessary clone

No need to clone. The `State` struct is `Copy` because all fields are
`Copy` (I _think_).

We could remove the local var all together but what ever.

hashes: Grab point release changelogs

Two trivial changelogs were missing, grab them.

p2p: Remove `bitcoin` dependency

`hex` is brought in from `primitives` as it is an unconditional
dependency. `arbitrary` is brought in from `primitives` as opposed to
`bitcoin`. `primitives` and `encoding` need `alloc`. One doc line is updated.

Use stacked attributes over #[cfg(all(...))]

Per our policy, feature gates should use stacked attributes instead
of #[cfg(all(...))]. Presumably due to changes at the same time as
this policy was introduced, there remain a few uses of the old style
in primitives.

Move deserialize tests to primitives

In bitcoin, there are various tests that only have a dependency on
bitcoin due to the deserialize/serialize functions on the old encoding
traits. Changing these to use consensus_encoding allows them to be
trivially moved to primitives.

Fix lint errors

In the process of moving the tests in the previous commit, the stricter
lint requirements for the leaf crates has introduced some lint errors
that should be fixed.

Move tests to upstream crates

Test cases for Outpoint, Version, CompactTarget and Sequence have been
left in bitcoin even following their moves to primitives and units. In
order to keep tests close to the corresponding types, the tests should
be moved to the upstream leaf crates.

Move tests to units and primitives alongside their corresponding types.

bitcoin: Remove duplicate exact_size_iterator

The exact_size_iterator test for Witness exists in primitives. A near
identical test has also been left behind in bitcoin. Since tests in
upstream crates are preferred to those in downstream, the test in
bitcoin can be removed.

Remove exact_sized_iterator test from bitcoin::witness tests.

Move network tests to network crate

During the smashing of the network crate, most tests were moved to the
network crate, leaving an empty unit tests module. To complete this
move, this empty unit tests module should be removed and the final
test file network.rs moved to the network crate.

Move network.rs test file to network crate.
Remove empty unit tests module in bitcoin::network.

Add errors to doc comment in from_hex of array_newtype

The impl_array_newtype_stringify macro needs to be used across crates,
including those with stricter lint requirements. To this end, all
public methods introduced by the macro must include an errors section
in the doc comment.

Add errors to doc comment of from_hex function in
impl_array_newtype_stringify macro.