What the developer wrote
Authored by Mitchell Bagot
p2p: Remove uses of ToU64
Outside of bitcoin, ToU64 is only used in a single place in p2p. This
can trivially be replaced by a u64::from call, as a u32 will always be
smaller than a u64.
Remove the only use of ToU64 from p2p.
What changed, and why it matters
This is a small internal cleanup change in the rust-bitcoin library's peer-to-peer networking code. It replaces one use of a helper trait called ToU64 with a direct Rust built-in conversion (u64::from). The behavior is identical because a u32 value always fits safely into a u64. There is no security issue here.
No action needed. This is a non-security refactoring change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes the only use of the internals::ToU64 trait in p2p/src/merkle_tree.rs and replaces self.num_transactions.to_u64() with u64::from(self.num_transactions). Since num_transactions is a u32, this conversion is lossless and semantically equivalent. The change reduces dependency surface but does not alter validation logic, bounds checking, or error handling.
Changed components
p2p/src/merkle_tree.rsInspect captured patch +1 / −2
diff --git a/p2p/src/merkle_tree.rs b/p2p/src/merkle_tree.rs
index 242d2ade..4221d15a 100644
--- a/p2p/src/merkle_tree.rs
+++ b/p2p/src/merkle_tree.rs
@@ -18,7 +18,6 @@ use encoding::{
ArrayDecoder, ArrayEncoder, ByteVecDecoder, CompactSizeEncoder, Decoder2, Decoder3, Encoder2,
Encoder3, EncoderStatus, SliceEncoder, VecDecoder,
};
-use internals::ToU64 as _;
use primitives::block::{self, Block, Checked, Header, HeaderDecoder, HeaderEncoder};
use primitives::merkle_tree::TxMerkleNode;
use primitives::transaction::{Transaction, Txid};
@@ -279,7 +278,7 @@ impl PartialMerkleTree {
return Err(MerkleBlockError::NoTransactions);
};
// check for excessively high numbers of transactions
- if self.num_transactions.to_u64() > Weight::MAX_BLOCK / Weight::MIN_TRANSACTION {
+ if u64::from(self.num_transactions) > Weight::MAX_BLOCK / Weight::MIN_TRANSACTION {
return Err(MerkleBlockError::TooManyTransactions);
}
// there can never be more hashes provided than one for every txid
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.