RB
← All projectsRust Bitcoin

rust-bitcoin

Rust library for Bitcoin data structures, serialization, consensus encoding, and scripts.

BitcoinCryptographic librariesNormal
Repository coverage

2570 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

612security candidates555second-pass queue2330AI analyses
153commits · 30 days
279commits · 60 days
975commits · 180 days
2058commits · 365 days
Backfill bands
Aug 5 → Feb 6787 seen32 candidatesComplete
Feb 6 → Jun 6878 seen53 candidatesComplete
Jun 6 → Jul 6211 seen15 candidatesComplete
Jul 6 → Aug 5184 seen2 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

68/100 average clarity
702Strong · 80–100
1135Adequate · 60–79
582Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Andrew Poelstra407139251391
Mitchell Bagot659200654068
Tobin C. Harding42167411063
jrakibi1015096069
satsfy (Renato Britto)652235065
Nick Johnson19621190060
Jamil Lambert, PhD12619117062
Fmt Bot351532045
Trevor Arjeski111111069
Shing Him Ng31731056
Martin Habovstiak31629069
Ismail Daif22622050
Analysis record

Published AI watches

Last scanned 38 minutes ago

Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7220: refactor(bip32)!: replace KeySource with KeyOrigin

This is a routine code cleanup in a Bitcoin library. It renames a simple data container from KeySource to KeyOrigin and gives it named fields (fingerprint and path) instead of numbered tuple slots (.0 and .1). The serialized format is inte…

6bb507b2by Andrew Poelstra+84−33 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7204: key-expression: Get secp256k1 from the crypto dep

This change is a routine internal cleanup: the key_expression crate stops depending directly on the secp256k1 cryptography library and instead uses a re-export provided by another internal crate called crypto. No user-facing behavior, type…

d193efc5by Andrew Poelstra+7−107 files
No security note in commit
Informational 17 AI analysisMessage 68 · Adequate
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Forward serde feature to network

This is a small Cargo.toml fix in a Rust Bitcoin subcrate. When the optional 'serde' feature was enabled on the key_expression crate alone, it did not also enable serde on the network crate. That meant a type called NetworkKind could not b…

806f1e1fby bytescape30+1−11 file
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7223: build(deps): bump taiki-e/install-action from 2.87.9 to 2.87.13

This is a routine update to a GitHub Actions helper used in automated testing workflows. It bumps the version of taiki-e/install-action, which downloads and installs Rust developer tools during CI runs. There is no change to the actual Bit…

c8ee144aby Andrew Poelstra+2−22 files
No security note in commit
Informational 20 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7224: build(deps): bump astral-sh/setup-uv from 10.0.1 to 10.1.0

This is a routine update to a GitHub Actions helper used only in automated security-scanning workflows. The new version adds minor improvements, including respecting proxy settings and verifying downloaded files with checksums. It does not…

Dependency bump of a third-party GitHub Action used in CI onlyUpstream release notes mention generic security improvements (checksum verification, npm install defaults, NO_PROXY)No CVE, advisory, or vendor security disclosure is present in the commit or supplied references
7bc9d696by Andrew Poelstra+2−22 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7105: Remove derived serde impls for types in stabilising crates

This commit removes automatic serde (serialization/deserialization) code generation from several Rust Bitcoin library crates and replaces it with hand-written implementations. The stated goal is to reduce dependencies and make the code eas…

Manual serde implementations replace derived ones, increasing the surface area for serialization-format bugsNo validation logic changes are visible in the diffNo mention of security fixes, CVEs, or vulnerability reports in commit message or PR description
9eeb7774by Andrew Poelstra+219−4110 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7205: Manual update to rustc stable (to 1.100.0)

This commit updates the project's automated Rust compiler version from 1.99.1 to 1.100.0 and adjusts a CI cache cleanup script to match a new directory layout used by Cargo 1.100. It is purely an infrastructure/maintenance change to keep a…

44e6f0caby Andrew Poelstra+8−22 files
No security note in commit
Informational 18 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7197: ci: bump rbmt to 0.5.5 and fail API job on private dep leak

This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of interna…

CI guardrail added to prevent private dependency leaks into stable crate public APIsTool bump enables detection of re-exported private dependenciesNo source-code vulnerability is patched
be14c72eby Andrew Poelstra+7−12 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7185: Refactor/bip32 flatten error constructors

This is a minor internal code cleanup in the Rust Bitcoin library. It changes how two functions (Xpriv::decode and Xpub::decode) build their error messages when an input is the wrong length. The behavior is the same before and after; only …

271f662aby Andrew Poelstra+8−61 file
No security note in commit
Informational 24 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7167: units: remove `Denomination::MicroBitcoin`

This is a routine API cleanup, not a security fix. The change removes one way of naming a Bitcoin unit ('MicroBitcoin' / 'uBTC') and keeps the equivalent 'bits' form. Any code that previously used the old name will fail to compile or fail …

No security signal: public API deprecation and enum variant removalNo memory safety, cryptographic, or consensus code modifiedError message change is informational only
d0602195by Andrew Poelstra+53−403 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7127: key_expression: Reduce `alloc` gating to minimal types

This commit is a code cleanup and feature-gating refactor for the rust-bitcoin library's key_expression crate. It makes more BIP32 (Bitcoin wallet key derivation) types available when the 'alloc' memory allocator feature is disabled, and s…

Refactor of error types and parsing paths for Xpriv/Xpub base58 decodingSwitch from unbounded base58 decode to fixed-size array decode (78 bytes)Removal of explicit length-check error path in favor of decoder-reported length error
c3d27d5dby Andrew Poelstra+60−823 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7039: primitives: Fix daily Miri cron failures with measured test gating

This change only adds `#[cfg_attr(miri, ignore)]` annotations to a handful of slow unit tests so they are skipped when run under Miri, a Rust interpreter used for detecting undefined behavior. It does not change any production code, consen…

1dc09077by Andrew Poelstra+6−03 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7182: Update local dependencies

This commit only updates version numbers in package configuration files (Cargo.toml) for internal dependencies so that all crates in the project require the same minimum versions of shared libraries. There are no code changes, no bug fixes…

06f41225by Andrew Poelstra+7−75 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7179: build(deps): bump taiki-e/install-action from 2.87.4 to 2.87.9

This is a routine update to a GitHub Actions helper used in automated testing workflows. It changes which version of a third-party tool-installer action is used, but only for installing the cargo-mutants testing tool. There is no indicatio…

4fda66b5by Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7180: build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This commit updates the version of a helper tool called cargo-binstall used in two automated GitHub workflows. The change only affects internal build/CI tooling and does not alter the rust-bitcoin library code that users install or run. Th…

53eae24dby Andrew Poelstra+2−22 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7181: build(deps): bump github/codeql-action/upload-sarif from 4.37.9 to 4.38.0

This is a routine update by Dependabot to the GitHub CodeQL upload-sarif action used in a scheduled security scanning workflow. It changes one pinned commit hash to a newer version of the same action. There is no indication this introduces…

4bb555f0by Andrew Poelstra+1−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

key_expression: Flatten BIP32 decode error construction

This commit is a minor code cleanup in the Rust Bitcoin library. It changes how an error message is built when decoding BIP32 extended keys, switching from one nested construction style to two chained calls. The actual behavior and returne…

c31c11e0by Adewale Ijalana+8−61 file
No security note in commit
Low 36 AI analysisMessage 100 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

Merge rust-bitcoin/rust-bitcoin#7168: units: add `visit_units` in optional serde visitors

This commit fixes a bug in how optional Bitcoin amount and fee-rate values are read from JSON when those fields are inside a flattened struct and the value is null. Previously, the code would error out because it did not handle a special s…

Deserialization failure in optional numeric types under serde flattenMissing serde visitor method (visit_unit) causing runtime errorsRegression test added for null handling in flattened structs
47340d2fby Andrew Poelstra+79−03 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump github/codeql-action/upload-sarif

This is a routine dependency update by Dependabot, bumping the version of a GitHub-provided action used to upload security scan results. There is no indication of a security vulnerability in the project itself or in this change.

fe755619by dependabot[bot]+1−11 file
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
RB Rust Bitcoinrust-bitcoin BitcoinCryptographic libraries

build(deps): bump cargo-bins/cargo-binstall from 1.22.0 to 1.23.0

This is a routine automated update by Dependabot that changes the version of a GitHub Action used to install Rust tools in two CI workflows. There is no indication of a security issue in the commit itself, and no verified security referenc…

2ccb0029by dependabot[bot]+2−22 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6949: Manual nightly rustfmt (2026-09-27)by Andrew Poelstra · f6e33d78 · Oct 2, 2026 · 9 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6949: Manual nightly rustfmt (2026-09-27)

b9b241377dff148e10a66d6876cb310487916580 Run the formatter (Tobin C. Harding)
8dc70dd876bb44072e8eae8d8b439888852a3640 primitives: Don't format array (Tobin C. Harding)

Pull request description:

Replaces https://github.com/rust-bitcoin/rust-bitcoin/pull/6944

Note the formatter is run with the listed toolchain but the manifest is not changed. This is to mimic #6944. I don't know where the bot is getting that toolchain from.

Patch 1 skips the offending code from review of 6944.


ACKs for top commit:
apoelstra:
ACK b9b241377dff148e10a66d6876cb310487916580; successfully ran local tests


Tree-SHA512: 1a01499b80c81c06afa375df82b377c4735210868f09b53a9494be6c96dab5a0b918ec39118b05b697be00c5d1c5b1b34536ed44b81f9a9629a302edef960c73

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is purely a code formatting cleanup. It adjusts whitespace, line breaks, import order, and adds a single #[rustfmt::skip] annotation so an automated formatter does not reformat a test data array. There are no functional code changes and no security implications.

Lower-priorityAutomated update to rustc stable-1.99.0by Update Stable Rustc Bot · 2e31c4e4 · Oct 2, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Update Stable Rustc Bot

Automated update to rustc stable-1.99.0

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityMerge rust-bitcoin/rust-bitcoin#6962: units: rename leftover instances of `height`by Andrew Poelstra · 60fd09fc · Oct 2, 2026 · 2 filesMessage 100 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6962: units: rename leftover instances of `height`

51e15ae054c6f68b63261672816f5b216188fdc8 units: rename leftover instances of `height` (satsfy (Renato Britto))

Pull request description:

A follow up of https://github.com/rust-bitcoin/rust-bitcoin/pull/6689

That PR renamed the relative locktime fns from height to count, since a relative lock counts blocks since the UTXO confirmed rather than a chain height. But Display sometimes printed `block-height 10` and `IncompatibleHeightError` still said "lock-by-height", so this brings the user facing text in line with the module docs.

Note that `is_satisfied_by_height` and its errors keep the names because their arguments are real chain heights (`BlockHeight`), matching `is_satisfied_by_time` taking `BlockMtp`.


ACKs for top commit:
apoelstra:
ACK 51e15ae054c6f68b63261672816f5b216188fdc8; successfully ran local tests
Abeeujah:
ACK 51e15ae054c6f68b63261672816f5b216188fdc8


Tree-SHA512: bb45b8ad6d35a4899c7081a64fe137cbd18ed1fccd97ec08d9d3eb55a5bbbddfc9aba997f1c4f799e63751ea2a2a289699be6add7889eeb7fb883a6e24207064

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#6957: primitives: Reject P2SH-wrapped SegWit v1+ programsby Andrew Poelstra · 55b2396a · Oct 2, 2026 · 11 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6957: primitives: Reject P2SH-wrapped SegWit v1+ programs

3babf0bbe9373759ee18d32170705a2584f25936 Test P2SH hashing rejects SegWit v1+ programs (Jamil Lambert, PhD)
e715d8553fbc07ac1fbdb5d595108946a56b46bc Reject SegWit v1+ programs when hashing for P2SH (Jamil Lambert, PhD)

Pull request description:

`ScriptHash::from_script` and the APIs built on it hashed any `ScriptPubKey` or redeem script, including SegWit v1+ witness programs. A P2SH output wrapping such a program is not encumbered by it, so anyone can spend it.

Reject witness versions 1 to 16 with a new `RedeemScriptError`, which wraps the existing `RedeemScriptSizeError`. This changes the error type of `ScriptHash::from_script`, `Script::script_hash`, the `TryFrom` impls for `ScriptHash`, `Address::p2sh` and `to_p2sh`.

Add a regression test.

Closes project-loupe/audit-rust-bitcoin#59


ACKs for top commit:
apoelstra:
ACK 3babf0bbe9373759ee18d32170705a2584f25936; successfully ran local tests
tcharding:
ACK 3babf0bbe9373759ee18d32170705a2584f25936


Tree-SHA512: 094bfb9f1e64b1b1458df2ae72121c08e3bbe886064c5c07759bfac647613ba30ead7ff413f7248e3540073fbc1debbe6a1f94040f8f89e8c9821699b246615c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Lower-priorityunits: rename leftover instances of `height`by satsfy (Renato Britto) · 51e15ae0 · Oct 1, 2026 · 2 filesMessage 45 · ThinTriage 0Details
Commit message · satsfy (Renato Britto)

units: rename leftover instances of `height`

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityMerge rust-bitcoin/rust-bitcoin#6953: ci: cache cargo-rbmt binaryby Andrew Poelstra · e92635af · Oct 1, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6953: ci: cache cargo-rbmt binary

bfa8b758541c294206f67a9dd7c19d0d2a236a67 ci: cache cargo-rbmt binary (satsfy (Renato Britto))

Pull request description:

Part of #6951

Every job using setup-rbmt builds cargo-rbmt from source. Without a cache, that is about 33s each. We can just save the binary and load it on installation instead.

So we are cutting 7.5 minutes from CI run (aggregate among multiple runners, currently master is at 93 minutes total, so we expect 85.5 total mins. The longest job, msrv test, is our major bottleneck and gets 35s saved)


ACKs for top commit:
Kixunil:
ACK bfa8b758541c294206f67a9dd7c19d0d2a236a67
apoelstra:
ACK bfa8b758541c294206f67a9dd7c19d0d2a236a67; successfully ran local tests


Tree-SHA512: 92063a9d87862d6ecc54ca7250bd2baa3a1e905431bc26abbb7ce8bc11ca3a88b5bc2b3d9dd97b2c1599546688e06cbd48b62523be5dcc49859857846aa78421

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
AI review queuedMerge rust-bitcoin/rust-bitcoin#6954: units: serialize unsigned amounts as u64by Andrew Poelstra · 295c9d8a · Oct 1, 2026 · 2 filesMessage 100 · StrongModerate 62Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6954: units: serialize unsigned amounts as u64

256ad0137832ac2bbbfb4053f570675fb1c72003 units: test amount varint serde round-trip (satsfy (Renato Britto))
ce1e998db1290a1d8da83d1a4c4a1393b41dd983 units: serialize unsigned amounts as u64 (satsfy (Renato Britto))

Pull request description:

A follow up of https://github.com/rust-bitcoin/rust-bitcoin/pull/6061#issuecomment-5751334257

`deserialize()` hinted u64 for unsigned amounts, but `serialize()` only ever wrote i64, so the two sides disagreed on the encoding. As a result, 100 sats became 200 sats in varint serialization format formats like postcard.

This state came about because we wanted serde errors to show each type's real range, and unsigned amounts to use a u64 hint so deserializers wouldn't be confused because the old errors complained about i64 first and only then about the real range, so users hit two failures. An unsigned amount should hint u64.

The problem is that, in varint formats like postcard, every amount reads back doubled. The zigzag encoding formula is `zigzag(n) = (n << 1) ^ (n >> 63)` for integer n in 64 bit representation. When n>0, (n>>63) is 0 and (n<<1) becomes n*2, so the number gets doubled on encoding, and then read as the doubled number directly on decoding. Also Amount::MAX fails because values ]10.5M,21M] BTC get doubled, surpassing the total bitcoin cap, then when range check looks at it on decoder, it rejects the input.

Serialization output format has changed, now matches the hint, and the `as_sat` token tests expect U64 for unsigned amounts.


ACKs for top commit:
apoelstra:
ACK 256ad0137832ac2bbbfb4053f570675fb1c72003; successfully ran local tests
tcharding:
ACK 256ad0137832ac2bbbfb4053f570675fb1c72003
Kixunil:
ACK 256ad0137832ac2bbbfb4053f570675fb1c72003


Tree-SHA512: 9c6ff0c7fac4ed2f6f356eba0f59cc903eb6adc89382b343ceae79fbbff2e26268ea8c77c62cd2c9447f543dfc08bb060ad2eb943771e8af361585123af9a053

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Moderate 62/100

This commit fixes a mismatch in how unsigned Bitcoin amounts were serialized versus deserialized when using certain compact binary formats. Previously, an unsigned amount (like 100 satoshis) was written as a signed number, which caused formats such as postcard/bincode with varint encoding to silently double the value on read-back and to reject very large amounts near the Bitcoin supply cap. The fix makes serialization use the same unsigned 64-bit hint that deserialization already expected, so round-trips now produce the same value.

Security candidateMerge rust-bitcoin/rust-bitcoin#6955: key_expression: preserve master-key invariants in Xpub Arbitraryby Andrew Poelstra · 4116ecc6 · Oct 1, 2026 · 1 fileMessage 91 · StrongLow 25Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6955: key_expression: preserve master-key invariants in Xpub Arbitrary

cf90d73d43935a7efea1c92807f46f82cfde17ce key_expression: preserve master-key invariants in Xpub Arbitrary (myetcd)

Pull request description:

`Xpub::arbitrary` samples the parent fingerprint and child number independently of depth. When depth is zero, it can generate a master Xpub that is rejected by `Xpub::decode` after encoding.

Generate depth first and set the parent fingerprint and child number to zero for master keys, matching the existing `Xpriv::arbitrary` implementation. Non-master keys continue to generate both fields from the input.

Add deterministic regression tests for master and non-master Xpubs, including binary encoding/decoding round trips. The master-key regression test fails before the fix.

Validation:
- `cargo test -p bitcoin-key-expression --features arbitrary`
- `cargo test -p bitcoin-key-expression --all-features`
- `cargo test -p bitcoin-key-expression --no-default-features --features alloc,arbitrary`
- `cargo rbmt -p bitcoin-key-expression fmt --check`
- `just lint` — successful, with existing removed-lint and dependency-check warnings.


ACKs for top commit:
apoelstra:
ACK cf90d73d43935a7efea1c92807f46f82cfde17ce; successfully ran local tests


Tree-SHA512: 2df6949bce9202723545b5e767c1f0ae2fb269a3c065cfd678072c6c03aae5977f2b4d9cb0a519e9a985cef1253defa09150370a8fc742a90fa9e81b222f0c89

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencecryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 25/100

This change fixes a bug in test-only code that generates random fake Bitcoin extended public keys (xpubs). Previously, when generating a master xpub (depth 0), the code could pick random values for the parent fingerprint and child number, which violates the BIP32 rule that master keys must have those fields set to zero. That caused some generated xpubs to fail a round-trip encode/decode check. The fix makes depth-zero xpubs always use zero for those two fields, matching how private master keys were already generated. It only affects fuzzing/property tests, not normal wallet operations.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#6952: units: move policy fee rates to `bitcoin::policy`by Andrew Poelstra · 5417b91e · Sep 30, 2026 · 6 filesMessage 100 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6952: units: move policy fee rates to `bitcoin::policy`

239bedd55f42814b2cbc858320263cf5c385e56c units: move policy fee rates to bitcoin::policy (satsfy (Renato Britto))

Pull request description:

Close https://github.com/rust-bitcoin/rust-bitcoin/issues/6935#issuecomment-5847035749

Two units constants were not really constant. `BROADCAST_MIN` and `DUST` follow Bitcoin Core relay policy, which may change at a new Core release. So we moved it to `bitcoin::policy` so that units can remain 1.0 despite any Core policy change.

One healthy side effect is that we manually type fee rates on units and p2p, which mean they are not fragile on Core release too.

To speed up units 1.0, I kept `BROADCAST_MIN` the same value and updated the comment to say `The value matches the default Bitcoin Core policy at the time of library release.`. Which means our constant in `bitcoin` still does not match core. It speeds up approval and merge of this PR for that release, later we update. I'll follow up this PR with that other update which affects the whole policy. Note that I technically resolved https://github.com/rust-bitcoin/rust-bitcoin/issues/6935 by ignoring problem.


ACKs for top commit:
apoelstra:
ACK 239bedd55f42814b2cbc858320263cf5c385e56c; successfully ran local tests


Tree-SHA512: 905f100d879430afb323fdf9df6dd4facce034d5aa549385b5101ed12d8a05b709e4e93ec345b0d940a1a30b2ca6697419b719fc042dc87c0d5240cf5f342cb4

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge rust-bitcoin/rust-bitcoin#6947: build(deps): bump cargo-bins/cargo-binstall from 1.21.0 to 1.21.1by Andrew Poelstra · c1be49cb · Sep 30, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6947: build(deps): bump cargo-bins/cargo-binstall from 1.21.0 to 1.21.1

7d6cf2c9098e233bc50be845641a7bf8127a6a75 build(deps): bump cargo-bins/cargo-binstall from 1.21.0 to 1.21.1 (dependabot[bot])

Pull request description:

Bumps [cargo-bins/cargo-binstall](https://github.com/cargo-bins/cargo-binstall) from 1.21.0 to 1.21.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/cargo-bins/cargo-binstall/releases">cargo-bins/cargo-binstall's releases</a>.</em></p>
<blockquote>
<h2>v1.21.1</h2>
<p><em>Binstall is a tool to fetch and install Rust-based executables as binaries. It aims to be a drop-in replacement for <code>cargo install</code> in most cases. Install it today with <code>cargo install cargo-binstall</code>, from the binaries below, or if you already have it, upgrade with <code>cargo binstall cargo-binstall</code>.</em></p>
<h4>In this release:</h4>
<ul>
<li>Upgrade dependencies</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/e00d2c94cc0067b77737821097a62d91c0301baa"><code>e00d2c9</code></a> release: cargo-binstall v1.21.1 (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2616">#2616</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/dfefec18f56be1fb7ec8d1f4cfde42c305f29298"><code>dfefec1</code></a> chore: release (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2611">#2611</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/0bb9e27411a681176032498b17e01c0be66d8efd"><code>0bb9e27</code></a> dep: Upgrade transitive dependencies (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2614">#2614</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/57726869e28f4038a847ec56e5fdd9142fded110"><code>5772686</code></a> build(deps): bump the deps group across 1 directory with 2 updates (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2612">#2612</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/bfa50c12a896b5e070cc1aa726ad86875d1e5726"><code>bfa50c1</code></a> dep: Upgrade transitive dependencies (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2609">#2609</a>)</li>
<li><a href="https://github.com/cargo-bins/cargo-binstall/commit/579c9db795e670961c988fe26c4c1bbe94de414b"><code>579c9db</code></a> build(deps): bump cargo-bins/release-pr from 2.1.3 to 2.1.4 (<a href="https://redirect.github.com/cargo-bins/cargo-binstall/issues/2608">#2608</a>)</li>
<li>See full diff in <a href="https://github.com/cargo-bins/cargo-binstall/compare/ead08b90bd7b2e6d81963fb9cf0b7239f66d5db4...e00d2c94cc0067b77737821097a62d91c0301baa">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cargo-bins/cargo-binstall&package-manager=github_actions&previous-version=1.21.0&new-version=1.21.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
satsfy:
ACK 7d6cf2c9098e233bc50be845641a7bf8127a6a75
apoelstra:
ACK 7d6cf2c9098e233bc50be845641a7bf8127a6a75; successfully ran local tests


Tree-SHA512: 918d12d43e504777939248d514e8fa98122d3be9756081bf4774a3d2a6192ee80022898b4f0e0b5537ae69867a074f44646a193ad3d21d1e62f0a503ad485007

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountautomated dependency-update discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This commit updates the version of a helper tool (cargo-binstall) used only inside GitHub Actions automation. It is a routine dependency bump by Dependabot and does not change any code that ships to users. There is no indication of a security fix or vulnerability.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#6938: Automated weekly update to rustc (to nightly-2026-09-26) on masterby Andrew Poelstra · 42410e20 · Sep 30, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6938: Automated weekly update to rustc (to nightly-2026-09-26) on master

c48ad69a7d8505207cb901f51493b20133667582 Automated update to rustc nightly-2026-09-26 (Update Nightly Rustc Bot)

Pull request description:

Automated update to Cargo.toml workspace metadata by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action


ACKs for top commit:
tcharding:
ACK c48ad69a7d8505207cb901f51493b20133667582
satsfy:
ACK c48ad69a7d8505207cb901f51493b20133667582


Tree-SHA512: 64daec51fa866c07e76f95d777e0e971d2d2f29c7881dab55c7d45544b0db23f65e91f0b1d7f456404887671d6738af5b2e1a70a7b82bebffc90e1533a97db6b

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#6932: chacha20: Add 4 block processing on SSE2 x86by Andrew Poelstra · b483c220 · Sep 30, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6932: chacha20: Add 4 block processing on SSE2 x86

2920bb4ea438a6773e53d2851c34f089cb52b708 chacha20: Add 4 block processing on SSE2 x86 (rustaceanrob)

Pull request description:

Same as f51bd42ac00da93c5c327ab2318f1d7b642e3efa for x86

We can detect SSE2 at compile time, which is the instruction set I am adding here. The instructions mirror exactly that of neon on aarch64, although the rotate-left methods all follow the same format.

Here are the results:
```
chacha20/apply_keystream/10
time: [117.40 ns 117.43 ns 117.45 ns]
thrpt: [81.196 MiB/s 81.215 MiB/s 81.235 MiB/s]
change:
time: [+0.8223% +0.8584% +0.8960%] (p = 0.00 < 0.05)
thrpt: [−0.8880% −0.8511% −0.8156%]
Change within noise threshold.

chacha20/apply_keystream/1024
time: [926.67 ns 926.81 ns 926.97 ns]
thrpt: [1.0288 GiB/s 1.0290 GiB/s 1.0291 GiB/s]
change:
time: [−46.203% −46.182% −46.160%] (p = 0.00 < 0.05)
thrpt: [+85.736% +85.811% +85.883%]
Performance has improved.

chacha20/apply_keystream/65536
time: [36.687 µs 36.698 µs 36.710 µs]
thrpt: [1.6626 GiB/s 1.6632 GiB/s 1.6637 GiB/s]
change:
time: [−64.574% −64.560% −64.542%] (p = 0.00 < 0.05)
thrpt: [+182.02% +182.17% +182.28%]
Performance has improved.
```

For this patch though, only 4 block processing is implemented. With AVX2 the registers are 256 bits, which would allow for 8 block processing in the same format as the 4 block processing (with 256-bit registers). However, that feature must be detected at runtime (std-only), even though all modern chips will likely have it. I want to leave the decision to add `cpu-features` to this crate for a separate patch.


ACKs for top commit:
apoelstra:
ACK 2920bb4ea438a6773e53d2851c34f089cb52b708; successfully ran local tests


Tree-SHA512: 95f584afd62cf0cec13b75bd141fe46f0cf94af0fe1aef7b9fed4a7e9092be49fbeb95c4c1f46baad6a18311e48a3da75aa92cc08a9b5f4131fbe6231ecfb60b

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#6936: p2p: reject internal-in-IPv6 addresses in addrv2 IPv6 decodeby Andrew Poelstra · c4958533 · Sep 29, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6936: p2p: reject internal-in-IPv6 addresses in addrv2 IPv6 decode

6e31b743f9b8e97df57e251b477c8f32eb8f9e03 p2p: reject internal-in-IPv6 addresses in addrv2 IPv6 decode (usefahmed07)

Pull request description:

Fixes #6924

rust-bitcoin's AddrV2 IPv6 decode didn't reject internal-in-IPv6
addresses (BIP155 NET_INTERNAL, prefix 0xFD6B88C08724), causing a
mismatch with Bitcoin Core's IsRoutable(). This patch adds the missing
check, mirroring the existing OnionCat/IPv4-embedded checks, plus a
new error variant and unit tests.


ACKs for top commit:
apoelstra:
ACK 6e31b743f9b8e97df57e251b477c8f32eb8f9e03; successfully ran local tests


Tree-SHA512: 10c26ddca011575d8309bb533ace20e305bfbb84baf70a7b2df8694e82ca6fc682d41a3c030b59d66afd1142ac922cd12e7a90f52f6fadd84b2a04bcbffc06db

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge rust-bitcoin/rust-bitcoin#6931: units: generate non-boundary values for block wrapper Arbitrary implsby Andrew Poelstra · 7f8b4e34 · Sep 29, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6931: units: generate non-boundary values for block wrapper Arbitrary impls

bf40b36aadc3f49b463e7f333c2124ff7035906f units: generate non-boundary values for block wrapper Arbitrary impls (colinaumaty)

Pull request description:

The `Arbitrary` implementation generated by `impl_u32_wrapper!` selected a value from `0..=2`, but all three possible values were handled as special cases. As a result, the fallback that generated an arbitrary `u32` was unreachable.

Expand the range to `0..=3` so the fallback becomes reachable while preserving the existing special handling for `ZERO`, `MIN`, and `MAX`.

Tests:

- `cargo test -p bitcoin-units --features arbitrary`
- `just lint`


ACKs for top commit:
apoelstra:
ACK bf40b36aadc3f49b463e7f333c2124ff7035906f; successfully ran local tests


Tree-SHA512: 4602c12e05318ce89fae66fedb14860796e462086cb57f3d7fd0414a10719bd8cf9c58f0ad21fb5f6a2ce4705b63361e820d8f2a4bffcc458b8cd4abaca987f2

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#6919: Sanitize serde size hints before allocatingby Andrew Poelstra · 55ddbc0c · Sep 29, 2026 · 5 filesMessage 100 · StrongHigh 70Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6919: Sanitize serde size hints before allocating

f7c0ee459ed33fdade8977392f31bd8793e59d1a primitives: test witness size hint not trusted (satsfy (Renato Britto))
c48822a119e578d7a78ff8a16e6629d56cbec5db primitives: cap witness serde size hint for alloc (satsfy (Renato Britto))
91ff405a6318dac5051ee77c20e555ee7fdf33ff units: test serde size hints not trusted (satsfy (Renato Britto))
d4f03724d3b5fbaf073bf033361a65617f5ad71f units: cap serde size hints before preallocating (satsfy (Renato Britto))
803aff152959368852dd6bfd7f390ad5dff97833 internals: add cautious serde size hint (satsfy (Renato Britto))

Pull request description:

Close https://github.com/project-loupe/audit-rust-bitcoin/issues/11
Close https://github.com/project-loupe/audit-rust-bitcoin/issues/21
Close https://github.com/project-loupe/audit-rust-bitcoin/issues/127
Close https://github.com/project-loupe/audit-rust-bitcoin/issues/202

It was possible to feed massive alloc requests via the size hint of vec deserializers that comes directly from untrusted sources into units and primitives. The deserialized `SeqAccess::size_hint` value fed straight into `Vec::with_capacity`. A few bytes could request a huge allocation before anything was read.

This condition enables panics with a capacity overflow message or process abortions for excessive memory usage in downstream rust-bitcoin users using length prefixed formats (bincode, postcard, CBOR...).

This PR added a shared helper in `internals`, because of the universal applicability and to use both on units or primitives. I reviewed every hint size alloc and only found those primitives and units cases to be eligible for this fix.

Additionally, I found another instance on p2p, same class of bug, but it is out of scope because it is a consensus decoder, not serde.


ACKs for top commit:
apoelstra:
ACK f7c0ee459ed33fdade8977392f31bd8793e59d1a; successfully ran local tests
tcharding:
ACK f7c0ee459ed33fdade8977392f31bd8793e59d1a


Tree-SHA512: e11c71c7a3a12a627a528852cefe5d0469c55bd95fb370a11c688df921ad2af69c6f6b66371c68d756066994d8511673a3d966e6590254c72e104b2803636390

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetydefensive validationconsensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · High 70/100

This commit fixes a denial-of-service weakness in how the library deserializes lists of Bitcoin data (witnesses, amounts, fee rates) from untrusted input. Before the fix, a few bytes of attacker-controlled data could claim a list would contain billions of items, causing the program to reserve a huge block of memory and crash or be killed. The patch caps how much memory is reserved up front, matching a well-known safeguard used by the serde library itself.

Security candidateMerge rust-bitcoin/rust-bitcoin#6945: bitcoin: handle OP_CODESEPARATOR in legacyby Andrew Poelstra · 5b815281 · Sep 29, 2026 · 3 filesMessage 91 · StrongModerate 60Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6945: bitcoin: handle OP_CODESEPARATOR in legacy

47a176520010af123c9890c5a616a822d583b951 bitcoin: restore tests that include OP_CODESEPARATOR (jrakibi)
cc3b772a097b153a48a0ca4b5d61754294facc86 bitcoin: Test legacy script code separator handling (jrakibi)
ebaf3db323afa43e69b65502211bf6c50f886f62 bitcoin: remove OP_CODESEPARATOR from legacy script code (jrakibi)
b2136093daed24b3337ec3720e368d9618c0361a bitcoin: add TODO for using ScriptCode in legacy sighash (jrakibi)
7197ccd1c4f1d6687296ffd73967aa1c3fb1dd90 bitcoin: rename script_pubkey to script_code (jrakibi)

Pull request description:

Currently, we don't support `OP_CODESEPARATOR` when computing legacy sighashes. This PR fixes this by removing them from script code when serializing the sighash.

Commit 1: renames script_pubkey to script_code (see #4136 and commit log for the reasoning).

Commit 3: removes `OP_CODESEPARATOR` instructions in two passes. The first counts them to calculate the script length for the CompactSize prefix.
The second pass removes `OP_CODESEPARATOR` while keeping `0xab` bytes that are part of pushed data unchanged.

The final commit restores all test vectors previously omitted from `legacy_sighash.json`

Closes #4136
Addresses the legacy part of #6808


ACKs for top commit:
tcharding:
ACK 47a176520010af123c9890c5a616a822d583b951
apoelstra:
ACK 47a176520010af123c9890c5a616a822d583b951; successfully ran local tests


Tree-SHA512: fa95c2c22ccdbb7bbf97a260184f10af8fc84d321e559c37c184ba36cb2476ec31728c3fb229d8604ffec69af568f3dc37d2ac8c2de8b1596b6fab05437deba2

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencecryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit fixes how the Rust Bitcoin library calculates old-style (legacy) transaction signatures when the spending script contains a special opcode called OP_CODESEPARATOR. Previously the library did not handle this opcode at all, which could produce signature hashes that disagree with Bitcoin Core and the Bitcoin protocol. The change strips OP_CODESEPARATOR opcodes from the script before hashing, matching Bitcoin Core's behavior. It also restores previously disabled test vectors that include this opcode.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6948: build(deps): bump taiki-e/install-action from 2.83.2 to 2.85.4by Andrew Poelstra · d1431904 · Sep 29, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6948: build(deps): bump taiki-e/install-action from 2.83.2 to 2.85.4

3c06ee7bf1703e38d3c06b3e820ce555966ccc4f build(deps): bump taiki-e/install-action from 2.83.2 to 2.85.4 (dependabot[bot])

Pull request description:

Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.83.2 to 2.85.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p>
<blockquote>
<h2>2.85.4</h2>
<ul>
<li>
<p>Update <code>uv@latest</code> to 0.11.33.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.7.15.</p>
</li>
<li>
<p>Update <code>biome@latest</code> to 2.5.6.</p>
</li>
</ul>
<h2>2.85.3</h2>
<ul>
<li>
<p>Update <code>xh@latest</code> to 0.26.2.</p>
</li>
<li>
<p>Update <code>ubi@latest</code> to 0.10.0.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.7.14.</p>
</li>
<li>
<p>Update <code>martin@latest</code> to 1.13.0.</p>
</li>
<li>
<p>Update <code>cargo-shear@latest</code> to 1.13.3.</p>
</li>
<li>
<p>Update <code>cargo-binstall@latest</code> to 1.21.1.</p>
</li>
</ul>
<h2>2.85.2</h2>
<ul>
<li>
<p>Update <code>prek@latest</code> to 0.4.11.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.7.13.</p>
</li>
<li>
<p>Update <code>kingfisher@latest</code> to 1.109.0.</p>
</li>
</ul>
<h2>2.85.1</h2>
<ul>
<li>
<p>Update <code>vacuum@latest</code> to 0.30.0.</p>
</li>
<li>
<p>Update <code>uv@latest</code> to 0.11.32.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.7.12.</p>
</li>
<li>
<p>Update <code>cyclonedx@latest</code> to 0.33.1.</p>
</li>
<li>
<p>Update <code>cargo-neat@latest</code> to 0.5.2.</p>
</li>
</ul>
<h2>2.85.0</h2>
<ul>
<li>
<p>Support <code>wild</code> (alias: <code>wild-linker</code>). (<a href="https://redirect.github.com/taiki-e/install-action/pull/1949">#1949</a>)</p>
</li>
<li>
<p>Support <code>bpf-linker</code>. (<a href="https://redirect.github.com/taiki-e/install-action/pull/1950">#1950</a>)</p>
</li>
<li>
<p>Support <code>rafn</code>. (<a href="https://redirect.github.com/taiki-e/install-action/pull/1935">#1935</a>, thanks <a href="https://github.com/DarkWanderer"><code>@​DarkWanderer</code></a>)</p>
</li>
<li>
<p>Update <code>cargo-neat@latest</code> to 0.5.1.</p>
</li>
<li>
<p>Update <code>zizmor@latest</code> to 1.28.0.</p>
</li>
<li>
<p>Update <code>wasmtime@latest</code> to 47.0.2.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md">taiki-e/install-action's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file.</p>
<p>This project adheres to <a href="https://semver.org">Semantic Versioning</a>.</p>
<!-- raw HTML omitted -->
<h2>[Unreleased]</h2>
<h2>[2.87.21] - 2026-09-26</h2>
<ul>
<li>
<p>Update <code>wasm-bindgen@latest</code> to 0.2.129.</p>
</li>
<li>
<p>Update <code>protoc-gen-connect-openapi@latest</code> to 0.27.3.</p>
</li>
<li>
<p>Update <code>wasmtime@latest</code> to 49.0.1.</p>
</li>
<li>
<p>Update <code>uv@latest</code> to 0.12.19.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.9.13.</p>
</li>
<li>
<p>Update <code>kingfisher@latest</code> to 2.7.0.</p>
</li>
</ul>
<h2>[2.87.20] - 2026-09-24</h2>
<ul>
<li>
<p>Update <code>uv@latest</code> to 0.12.18.</p>
</li>
<li>
<p>Update <code>cargo-shear@latest</code> to 1.14.0.</p>
</li>
</ul>
<h2>[2.87.19] - 2026-09-23</h2>
<ul>
<li>
<p>Update <code>wasmtime@latest</code> to 49.0.0.</p>
</li>
<li>
<p>Update <code>cargo-shear@latest</code> to 1.13.5.</p>
</li>
<li>
<p>Update <code>cargo-nextest@latest</code> to 0.9.146.</p>
</li>
</ul>
<h2>[2.87.18] - 2026-09-22</h2>
<ul>
<li>
<p>Update <code>oxfmt@latest</code> to 1.84.0.</p>
</li>
<li>
<p>Update <code>mise@latest</code> to 2026.9.12.</p>
</li>
<li>
<p>Update <code>kache@latest</code> to 0.26.3.</p>
</li>
<li>
<p>Update <code>cargo-tarpaulin@latest</code> to 0.37.4.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/taiki-e/install-action/commit/065d6a08a14e61e89fb0a4c10eecdbdef39c7d8e"><code>065d6a0</code></a> Release 2.85.4</li>
<li><a href="https://github.com/taiki-e/install-action/commit/971197ad86f8f6f161d7a8d91f1d711c4c21f628"><code>971197a</code></a> Update <code>uv@latest</code> to 0.11.33</li>
<li><a href="https://github.com/taiki-e/install-action/commit/3fc72354cdfd0f85327736793faab9b90a6282bb"><code>3fc7235</code></a> Update syft manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/7e230c19cf947f65a34e4e6f737c5f594c6779ba"><code>7e230c1</code></a> Update sccache manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/51f77e860854ede202e22ff29a94094601feca62"><code>51f77e8</code></a> Update <code>mise@latest</code> to 2026.7.15</li>
<li><a href="https://github.com/taiki-e/install-action/commit/87ddca437422cbc964934ac7b2d8423c1838090a"><code>87ddca4</code></a> Update <code>biome@latest</code> to 2.5.6</li>
<li><a href="https://github.com/taiki-e/install-action/commit/18b1216eba7f8039b0f8d131d5473787f0edce68"><code>18b1216</code></a> Release 2.85.3</li>
<li><a href="https://github.com/taiki-e/install-action/commit/3a7eb9d7de04335647f871d88d8831485be842be"><code>3a7eb9d</code></a> Update <code>xh@latest</code> to 0.26.2</li>
<li><a href="https://github.com/taiki-e/install-action/commit/3d4a0c1c709bc0f907c2a23b1a17cf6296b08298"><code>3d4a0c1</code></a> Update uv manifest</li>
<li><a href="https://github.com/taiki-e/install-action/commit/9e4a53cd83bbbd84b17bc14008d4b067b9e99edb"><code>9e4a53c</code></a> Update <code>ubi@latest</code> to 0.10.0</li>
<li>Additional commits viewable in <a href="https://github.com/taiki-e/install-action/compare/43aecc8d72668fbcfe75c31400bc4f890f1c5853...065d6a08a14e61e89fb0a4c10eecdbdef39c7d8e">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=taiki-e/install-action&package-manager=github_actions&previous-version=2.83.2&new-version=2.85.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>


ACKs for top commit:
satsfy:
ACK 3c06ee7bf1703e38d3c06b3e820ce555966ccc4f
apoelstra:
ACK 3c06ee7bf1703e38d3c06b3e820ce555966ccc4f; successfully ran local tests


Tree-SHA512: 3218d6331343568c02852aefd6dbbe20a8bc6900bdd03fc7d80ade53290fe65951fb2e3414fb3ce73ef7437cf1fb454721ff88a72d1b316e011398330509efed

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountautomated dependency-update discountmerge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 15/100

This is a routine update by Dependabot to the version of a third-party GitHub Action used in the project's automated testing workflows. The change only affects internal continuous integration (CI) scripts, not the actual Bitcoin library code that users install. There is no indication of a security issue in the commit or supplied references.

Security candidateMerge rust-bitcoin/rust-bitcoin#6946: Fix integer overflow in `get_array`by Andrew Poelstra · c6e80843 · Sep 28, 2026 · 1 fileMessage 100 · StrongLow 33Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6946: Fix integer overflow in `get_array`

56fb1287d8f590f1a739b5b23f0d621efa89dc33 Fix integer overflow in `get_array` (Martin Habovstiak)

Pull request description:

The `get_array` method promised to return `None` in case of out-of-bounds access but internally tried to add caller-controlled values which would result in integer overflow. In case overflow happens the attempted read is certainly out of bounds - goes beyond address space. Therefore this commit treats it as such and fixes it to return `None`.

**This bug was found by creusot.** :tada: :tada: :tada:

Though now that I think about it, it would only cause crashes with debug assertions but ironically, without them it would work fine because the garbage `end` value would make the range invalid causing `get` to return `None.` Still, I believe this fix is better than changing it to `wrapping_add` because it's less confusing for both humans and creusot and there's a good chance the compiler will optimize-out the check.


ACKs for top commit:
apoelstra:
ACK 56fb1287d8f590f1a739b5b23f0d621efa89dc33; successfully ran local tests
tcharding:
ACK 56fb1287d8f590f1a739b5b23f0d621efa89dc33


Tree-SHA512: 970ed2cbbf7a8510854a307ba85929221fefb8b18fe34beed560e116cbe9d111b14150579ee329fdcb97ef0f2da1b8da6bc58e45133f2b1573fa9d7d2f8bd177

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Low 33/100

This commit fixes a small but real bug in a Rust helper that reads fixed-size chunks from a data slice. The helper was supposed to safely return 'nothing' when asked to read past the end of the data, but it accidentally added two numbers together in a way that could overflow. In Rust, that overflow can crash a program in debug builds. In release builds it would not crash, but the code was still doing the wrong thing logically. The fix uses safe arithmetic so the overflow is caught and the helper returns 'nothing' as documented.

Security candidateFix integer overflow in `get_array`by Martin Habovstiak · 56fb1287 · Sep 27, 2026 · 1 fileMessage 73 · AdequateModerate 62Details
Commit message · Martin Habovstiak

Fix integer overflow in `get_array`

The `get_array` method promised to return `None` in case of
out-of-bounds access but internally tried to add caller-controlled
values which would result in integer overflow. In case overflow happens
the attempted read is certainly out of bounds - goes beyond address
space. Therefore this commit treats it as such and fixes it to return
`None`.

This bug was found by creusot.

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Moderate 62/100

This commit fixes a bug in a Rust helper method called `get_array`, which is meant to safely read a fixed-size chunk from a slice and return nothing if the requested range is out of bounds. The bug was that the code added the caller's offset and length together using normal integer addition, which can overflow on large values. In Rust, integer overflow in release builds is defined to wrap around, so a huge offset plus length could produce a small number, making the out-of-bounds check pass incorrectly. The fix uses checked addition so that any overflow is treated as an out-of-bounds request and returns nothing, as the method's contract promises.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6915: primitives: Fix `Witness` handling of oversized itemsby Andrew Poelstra · e1ed5884 · Sep 27, 2026 · 3 filesMessage 91 · StrongHigh 71Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6915: primitives: Fix `Witness` handling of oversized items

8caa5f364f2e31894090eb6911a6e796c7519784 primitives: Test coinbase witness count validated (Jamil Lambert, PhD)
b8b78386dc47d434ca24e650007846362ad746b7 primitives: Check coinbase witness count (Jamil Lambert, PhD)
e6068218a02f9ae469d2881eb431be1f6ae45de9 primitives: Test wtxid with oversized elements (Jamil Lambert, PhD)
fa8c510647aa3ae0c9f8a9acfc4f0df3df7f86c2 primitives: Hash the full witness encoding (Jamil Lambert, PhD)
822d6e01fbbf502d9867a20b0bafed180163106d primitives: Test oversized Witness equality (Jamil Lambert, PhD)
2b2fea885c73ef35757b847d67fafeeed3be7e39 primitives: Fix oversized Witness slice equality (Jamil Lambert, PhD)
4a5855bce5ee5fcbe0ab3d89323dd699d81b911b primitives: Test Witness::size for oversized item (Jamil Lambert, PhD)
c529e02377930cad43c980a33258052983b3da6e primitives: Fix Witness::size oversized item (Jamil Lambert, PhD)

Pull request description:

`Witness::iter` stops before an item larger than it will decode, but `Witness::len` still counts it. Consumers that trusted the iterator then mishandled a `Witness` holding such an item: `size` undercounted its bytes, slice equality reported it equal to a different one-element stack, and the `wtxid` dropped it. The coinbase commitment check also collected the whole `Witness` before testing its length.

Compute `size` from the stored serialized length, compare witnesses through their iterators, hash the full `Witness` encoding into the `wtxid`, and check the coinbase witness length before reading it.

Closes project-loupe/audit-rust-bitcoin#58
Closes project-loupe/audit-rust-bitcoin#70
Closes project-loupe/audit-rust-bitcoin#185
Closes project-loupe/audit-rust-bitcoin#69
Closes project-loupe/audit-rust-bitcoin#184


ACKs for top commit:
apoelstra:
ACK 8caa5f364f2e31894090eb6911a6e796c7519784; successfully ran local tests
tcharding:
ACK 8caa5f364f2e31894090eb6911a6e796c7519784
satsfy:
tACK 8caa5f364f2e31894090eb6911a6e796c7519784


Tree-SHA512: 77aaeff42eac53b37df8b8d55085d1e6a73552dcf07a9c05dfd564ed6bbc144185a904839037f0dd54f8b9231fca69155ff80d0f6d837bf039c05a7183abf732

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 71/100

This commit fixes a bug in how the Rust Bitcoin library counts and compares transaction witness data when a witness contains an oversized item. Previously, several functions relied on an iterator that silently skips oversized items, causing the reported size to be too small, equality checks to wrongly treat different witnesses as equal, and transaction witness IDs (wtxid) to ignore the oversized data. The patch makes these operations use the full stored witness encoding instead. It also fixes a coinbase block validation check so it rejects multi-item coinbase witnesses in constant time rather than collecting and possibly truncating them.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#6923: units: fix work and target conversion for small valuesby Andrew Poelstra · d6455c22 · Sep 26, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6923: units: fix work and target conversion for small values

f9b30863206aec6deb067a31a3dacf4a8107890b units: test work and target convert both ways (satsfy (Renato Britto))
16d9eefa4ea8ed7acc367abbaeb493b42efac0a6 units: compute true inverse in Work::to_target (satsfy (Renato Britto))
aabe9a228d65f9640ac02a648c0bf0fbc7e73eec units: test target one carries half max work (satsfy (Renato Britto))
bea0660020c47f2d904da3c474aec8a21bba4740 units: drop inverse special case for one (satsfy (Renato Britto))
229608b0ee7662ecf41f5adf062a95c770774a9f internals: move U256::inverse into units (satsfy (Renato Britto))

Pull request description:

Closes https://github.com/project-loupe/audit-rust-bitcoin/issues/195

`U256::inverse` computes `2^256 / (target + 1)` ([from core](https://github.com/bitcoin/bitcoin/blob/master/src/chain.cpp#L120-L133)), which is the block proof formula from Bitcoin Core's `GetBitsProof` and not an inverse in a general integer sense. `Target` and `Work` are its only users, so the first commit moves it out of internals into the private `U256Ext` trait in units, next to them.

It also returned the maximum for a target of one, where Core gives `2^255`, and `Work::to_target` reused the same formula, which gets progressively wronger as work gets smaller. The second and fourth commits fix these, each followed by a test that fails without the fix.

The zero target case is left alone on purpose for PR https://github.com/rust-bitcoin/rust-bitcoin/pull/6872

Note: so the math checks out to me, the tests pass, but please review if the manipulations I did make sense.


ACKs for top commit:
tcharding:
ACK f9b30863206aec6deb067a31a3dacf4a8107890b - and in case its not obvious my ack doesn't cover the math :)
apoelstra:
ACK f9b30863206aec6deb067a31a3dacf4a8107890b; successfully ran local tests


Tree-SHA512: f255b600473f3b2890b72919fc33dc09929d042eccb204099137b45d8a69e6af5058f7b66399d51c7a2b9df36a292b98f6b96fda18f4feb703b0a6992e5ff94d

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#6922: Use `try_fold` instead of `fold` in `Sum` implby Andrew Poelstra · 86e4d5da · Sep 25, 2026 · 2 filesMessage 100 · StrongInformational 19Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6922: Use `try_fold` instead of `fold` in `Sum` impl

126de69daec3ad3d5564c7e6444fb482b9594b3b Use `try_fold` instead of `fold` in `Sum` impl (Martin Habovstiak)
1665f9592766177094434209eb23e7dca45789ef Remove over-restrictive bounds from `NumOpResult` (Martin Habovstiak)

Pull request description:

The implementation of `Sum` for the amount types used the `fold` method
on iterator which would uselessly process more amounts even if the
overflow error was already detected and would keep re-checking the tag
set in previous iteration of the loop wasting even more performance.

This commit modifies it to use `try_fold` instead by converting it to
`Result` and back which makes the code much simpler and more performant.
This also adds a new method `from_result` to `NumOpResult` which is a
natural inverse of `into_result` and documents that the number of items
consumed is unspecified in case of overflows - this allows us to
optimize the performance in the future by e.g. using SIMD.

The PR also contains a small API improvement that I noticed.

I plan to rebase my SIMD PR on top of this, opening this separately because I believe this should be easier to review and uncontroversial.


ACKs for top commit:
apoelstra:
ACK 126de69daec3ad3d5564c7e6444fb482b9594b3b; successfully ran local tests
tcharding:
ACK 126de69daec3ad3d5564c7e6444fb482b9594b3b


Tree-SHA512: 98b6338b0a50edac2279f9057b698f6c25193afb8804f336f7bafabaf14fc61810adb19cc7048ef430b85838118c2f6342ccb734f0e088447f802cc815cb904e

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Informational 19/100

This is a code-quality and performance improvement, not a security fix. It changes how the library adds up lists of Bitcoin amounts so that it stops early once an overflow is detected, rather than continuing to process the rest of the list. It also documents that if an overflow happens, the code may not look at every item. The change does not alter the final result returned to callers and does not introduce a known vulnerability.

Security candidateMerge rust-bitcoin/rust-bitcoin#6893: units: Reject malformed amount stringsby Andrew Poelstra · fcb14622 · Sep 25, 2026 · 3 filesMessage 91 · StrongModerate 52Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6893: units: Reject malformed amount strings

87797456b4cdb15ac25c085eb6cfb8b8e49b5a35 units: Test rejection of malformed amount strings (Jamil Lambert)
a05b597f78f5986b5381d22d6870fc7d3f0cf9f6 units: Reject malformed amount strings (Jamil Lambert)

Pull request description:

`parse_signed_to_satoshi` did not require the input to contain a digit and did not validate the position of separator underscores. As a result `.` and `._` parsed as zero, and trailing or decimal-adjacent underscores such as `1_`, `1_.0` and `1._0` parsed as ordinary amounts.

Require at least one digit and only allow underscores between two digits, matching Rust's numeric literal rules. One existing round-trip test relied on the old behaviour and is updated to a valid equivalent with the same value.

Closes project-loupe/audit-rust-bitcoin#86


ACKs for top commit:
tcharding:
ACK 87797456b4cdb15ac25c085eb6cfb8b8e49b5a35
apoelstra:
ACK 87797456b4cdb15ac25c085eb6cfb8b8e49b5a35; successfully ran local tests


Tree-SHA512: 24c3a51fe46ce97646584cbc46979278bcc19491d78e39dca92fa9bf6e7630ca4969057389d64e58dd7e7883f3a7029d8d5ea94da38fc69d9a18e77b28c66762

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controldefensive validationmerge-commit duplicate discount
AI analysis · Moderate 52/100

This update fixes a bug in how the library reads Bitcoin amount strings like '1.5 BTC'. Previously, certain malformed inputs such as '.', '._', '1_', '1_.0', and '1._0' were incorrectly accepted and treated as valid amounts (often zero), instead of being rejected as errors. The fix now requires at least one digit and only allows underscore separators between two digits, matching Rust's numeric literal rules. This prevents silent misinterpretation of invalid amount strings.

AI review queuedMerge rust-bitcoin/rust-bitcoin#6921: units: fix div_by_fee_rate_ceil precisionby Andrew Poelstra · b31212e0 · Sep 24, 2026 · 2 filesMessage 91 · StrongLow 48Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6921: units: fix div_by_fee_rate_ceil precision

75e087f15d314b892c1d80a961e989a91615acd2 units: fix div_by_fee_rate_ceil precision (Nick Johnson)

Pull request description:

div_by_fee_rate_ceil used to_sat_per_kwu_ceil() as the divisor, collapsing FeeRate from sat/MvB precision down to sat/kwu before dividing. This rounds the divisor up, which potentially produces a weight too small to cover the fee budget.

Switch to to_sat_per_mvb() at full precision in u128, matching the recent fix applied to div_by_fee_rate_floor in #6884.


ACKs for top commit:
tcharding:
ACK 75e087f15d314b892c1d80a961e989a91615acd2
apoelstra:
ACK 75e087f15d314b892c1d80a961e989a91615acd2; successfully ran local tests


Tree-SHA512: 1bd8a5079d62afa40c4ccd5da847ee9bf297f3e400da3609c03148441220da137511205ba991b150bc7cc2f3818751e7635e4ed7fa43572c7bfdf8db70b5b790

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit fixes a rounding bug in how the rust-bitcoin library calculates the minimum transaction weight needed to pay a given fee at a given fee rate. The old code rounded the fee rate up too early, which could produce a weight slightly smaller than actually required. In practice, that means a wallet relying on this function might think a transaction meets its fee target when it actually falls a tiny bit short. The fix performs the division at full precision, matching a similar recent fix for the floor-division variant.

Lower-priorityMerge rust-bitcoin/rust-bitcoin#6900: P2p reexport types at rootby Andrew Poelstra · 13571b40 · Sep 24, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra

Merge rust-bitcoin/rust-bitcoin#6900: P2p reexport types at root

1a6c5c0b6096d500097159dbdb036247375a6be9 p2p: Export all common types (Gbolahan Akande)

Pull request description:

This is my proposed fix for #5653.

Users of `bitcoin-p2p-messages` currently have to know which module each
message type lives in, for example `message::NetworkMessage` or
`message_blockdata::Inventory`. This re-exports the public message types at
the crate root so they can be imported directly.

Types from the `address`, `message` and `message_network` modules need the
`std` feature, so their re-exports are gated the same way as the modules.
Nothing is removed and the modules stay public, so this is not a breaking
change. Errors, encoders and decoders are left out of this change. I am happy
to add them if the maintainers prefer.

Tested with `cargo test` with default features and with
`--no-default-features`, and with `cargo rbmt -p p2p lint`.

Closes #5653


ACKs for top commit:
tcharding:
ACK 1a6c5c0b6096d500097159dbdb036247375a6be9
apoelstra:
ACK 1a6c5c0b6096d500097159dbdb036247375a6be9; successfully ran local tests


Tree-SHA512: a894629c07d14440866e4cff998830a3a377fb10c7841300721f2e42035051fee966ac21513ec44d8c8fe944d3618dd0f461d58c4d4ac81aecfac942441c9a7e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount