EP
← All projectsElements Project

libwally-core

Cross-platform wallet primitives for keys, addresses, transactions, PSBT, and Elements.

BitcoinCryptographic librariesSoftware walletsNormal
Repository coverage

154 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

35security candidates39second-pass queue128AI analyses
42commits · 30 days
43commits · 60 days
99commits · 180 days
138commits · 365 days
Backfill bands
Aug 5 → Feb 622 seen3 candidatesComplete
Feb 6 → Jun 652 seen3 candidatesComplete
Jun 6 → Jul 67 seen0 candidatesComplete
Jul 6 → Aug 514 seen1 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

61/100 average clarity
19Strong · 80–100
63Adequate · 60–79
59Thin · 40–59
13Opaque · 0–39
1security candidate with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths12427102158
kkdao444075
odudex514069
Erick Cestari1110100
KY-U111075
Ondřej Češka111050
dependabot[bot]808093
pythcoiner301063
Daniel Newton202055
Greg Sanders101068
Leonardo Comandini101060
longhutianjie101072
Analysis record

Published AI watches

Last scanned 55 minutes ago

Low 40 AI analysisMessage 75 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

psbt: allow unknowns (global, input and output) to have empty values.

This commit fixes a bug in how the library reads partially-signed Bitcoin transactions (PSBTs). Previously, if a PSBT contained an unknown extra field with an empty value, the library would store a dangling pointer to a zero-length buffer …

Use of potentially dangling pointer for zero-length bufferMemory-safety bug in PSBT deserializationAddition of regression test for malformed/edge-case PSBT input
10670278by Jon Griffiths+9−23 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

Bump version to 1.6.1

This commit only updates version numbers across build files, documentation, and package metadata from 1.6.0 to 1.6.1. There are no code logic changes, no bug fixes, and no security-related modifications.

f7b0a15bby Jon Griffiths+12−129 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

tx: add add tx_input_is_issuance/tx_is_input_issuance to determine issuance inputs

This commit adds two new helper functions that let callers ask whether a transaction input is an 'issuance' input on the Elements sidechain. It is a straightforward feature addition: it exposes existing internal data through a new API, mir…

91689c1cby Jon Griffiths+42−58 files
No security note in commit
Low 44 AI analysisMessage 73 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

psbt: Copy the PSET genesis blockhash

This commit fixes a bug where cloning or combining a special Bitcoin transaction format (PSET) dropped the 'genesis blockhash' field. Without that field, valid signatures could not be created for certain transactions using Elements taproot…

Missing field copy in PSET clone/combine pathAffects Elements taproot signature hash computationCould produce an unsignable or invalidly-signed PSET
4b64af46by kkdao+3−01 file
No security note in commit
Moderate 60 AI analysisMessage 68 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

psbt: Refuse upgrading a v0 PSBT with no tx

This commit fixes a crash bug in libwally-core, a Bitcoin/Elements cryptography library. When a user tried to upgrade an older-style PSBT (Partially Signed Bitcoin Transaction) to version 2, the code would follow a pointer to transaction d…

NULL pointer dereference in transaction-version upgrade pathMissing input validation on internal object state before pointer dereferenceConsistency fix aligning with existing psbt_build_tx() and v0 error handling
e76b2304by kkdao+10−02 files
No security note in commit
Low 49 AI analysisMessage 50 · Thin
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

mem: use wally_memcpy for more secret/potentially secret data

This commit replaces ordinary memory-copy operations with a special secure-copy function (wally_memcpy) in a handful of places that handle private keys, BIP32 extended keys, and descriptor template secrets. The goal is to reduce the chance…

secret-data handling (private keys, BIP32 extended keys, SLIP77 blinding key)use of hardened memory-copy primitive (wally_memcpy)defensive hardening against compiler optimization of sensitive copies
473b9161by Jon Griffiths+8−83 files
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

tx: add tx_input_is_pegin/tx_is_input_pegin to determine pegin inputs

This commit is a routine API cleanup: it adds two new functions with clearer names for checking whether a transaction input is a 'pegin' (a special type of cross-chain input used in Elements-based blockchains), and marks the old function n…

1576afb5by Dmytro Hladkykh+48−1610 files
No security note in commit
Low 45 AI analysisMessage 73 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

psbt: Refuse v2 global tx under loose parsing

This change fixes a memory leak in the library's handling of a specific kind of invalid Bitcoin transaction file (PSBT v2 with an unexpected global transaction). Previously, parsing such a file under loose parsing could allocate memory for…

Memory leak on parsing malformed PSBT v2 with global txInvalid PSBT v2 accepted under loose parsing flagPointer overwrite after allocation in psbt_set_global_tx / v2 path
10f41d80by kkdao+17−13 files
No security note in commit
Informational 15 AI analysisMessage 85 · Strong
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

Add 1.6.0 upgrade advice to CHANGES.md

This commit only updates the project's changelog text (CHANGES.md) to match the published 1.6.0 release notes. It adds a sentence telling users that the release contains important bug and security fixes and that they should update. No code…

7f8f89e8by kkdao+3−01 file
Vendor flagged security relevance
Moderate 60 AI analysisMessage 78 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

psbt: fix finalizing large P2SH and bare multisig inputs

This commit fixes two bugs in how the library finalizes old-style multi-signature Bitcoin transactions. First, large multisig setups (like 5-of-5 or 4-of-7) were silently left unfinished because the buffer used was too small. Second, for b…

Buffer size mismatch causing silent failure to finalize large multisig inputsIncorrect scriptSig construction for bare multisig producing invalid spendsHeap allocation introduced to replace undersized stack buffer
cf8eb142by odudex+136−82 files
No security note in commit
Informational 22 AI analysisMessage 73 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

tx: allow getting the weight and vsize of partial transactions

This commit fixes a bug where two helper functions for calculating transaction size/weight would incorrectly reject transactions that were still being built (for example, when a wallet is estimating fees before all inputs and outputs are a…

Behavior change in argument validation pathRelaxation of a previously added strict checkNo memory safety, cryptographic, or authorization changes visible
01d53ac9by odudex+44−22 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

Bump version to 1.6.0

This commit is a routine version bump from 1.5.6 to 1.6.0. It only changes version numbers in build files, documentation, and package metadata. There are no code changes that affect security.

530eb957by Jon Griffiths+14−149 files
No security note in commit
Low 35 AI analysisMessage 73 · Adequate
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

tx: prevent pre-bip144 serialization on elements, share arg checks

This commit tightens and unifies how transaction serialization arguments are checked in libwally-core. It prevents a caller from accidentally producing ambiguous pre-BIP144 transaction formats on Elements-based networks, and makes the leng…

Inconsistent argument validation between length and serialization functionsBehavior change for Elements: pre-BIP144 flag is now ignored rather than honoredDefensive unification of transaction serialization checks
063c195dby Jon Griffiths+33−221 file
No security note in commit
Low 47 AI analysisMessage 50 · Thin
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

psbt: disallow hybrid pubkeys

This commit tightens public-key validation inside PSBT (Partially Signed Bitcoin Transaction) handling by rejecting 'hybrid' public keys. Hybrid keys are an old, non-standard encoding that sits between compressed and uncompressed formats. …

Rejects non-standard hybrid public-key encoding in transaction-related dataNarrows public-key acceptance to only compressed/uncompressed standard encodingsApplies consistent strict validation across keypath, signature, and blinding pubkey paths
06fba283by Jon Griffiths+4−42 files
No security note in commit
Informational 23 AI analysisMessage 83 · Strong
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

expose ec_public_key_strict_verify to verify non-hybrid pubkeys

This commit adds a new public function that lets callers check whether a Bitcoin-style public key is valid and is not an old, rarely-used 'hybrid' key format. It does not change existing behavior; it only exposes a new, stricter verificati…

New strict public-key validation API rejecting hybrid (0x06/0x07 prefixed uncompressed) public keysHybrid keys are still accepted by the pre-existing wally_ec_public_key_verify; only the new strict call rejects themNo buffer overflow, memory corruption, or cryptographic flaw visible in the diff
e9ff9b8eby Jon Griffiths+39−09 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

bip39: document that mnemonic/passphrase arguments require ascii/utf8 nfkd

This commit only updates documentation comments in a header file. It adds a note that BIP39 mnemonic and passphrase arguments must be ASCII or UTF-8 NFKD encoded. No code behavior changed, no bug was fixed, and no security vulnerability wa…

abbe03ceby Jon Griffiths+6−61 file
No security note in commit
Moderate 51 AI analysisMessage 50 · Thin
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

bip39: fail if the callers requested language is not found

This commit fixes a behavior in the BIP39 (mnemonic seed phrase) code where, if a caller asked for a language that wasn't supported, the library would quietly give them the English wordlist instead of reporting an error. The patch makes th…

Silent fallback to default language could cause language/cross-check mismatchesBehavioral change from permissive fallback to explicit failurePotential downstream impact if callers previously passed invalid language strings and relied on English fallback
9f912adaby Jon Griffiths+8−41 file
No security note in commit
Informational 14 AI analysisMessage 93 · Strong
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

build(deps-dev): bump fast-uri from 3.1.7 to 3.1.9 in /src/wasm_package

This is an automated Dependabot update that bumps a JavaScript development dependency called fast-uri from version 3.1.7 to 3.1.9 inside the WebAssembly packaging directory. The change only updates a package-lock.json file. There is no dir…

Dependency bump of a URI-parsing library, which is a component class commonly associated with input-validation vulnerabilitiesNo explicit security claim, CVE, or advisory reference in the commit or supplied materialsNo source code changes beyond lockfile metadata
9bfb5c78by dependabot[bot]+6−61 file
No security note in commit
Moderate 64 AI analysisMessage 95 · Strong
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

sign: verify schnorr sigs after creation

This commit adds a safety check when creating Schnorr digital signatures in libwally-core. After a signature is generated, the code now immediately verifies it using the corresponding public key. If the signature fails verification, it is …

Schnorr signature verification immediately after signingOutput buffer cleared when signature generation or verification failsPrivate-key leakage risk explicitly mentioned in commit message
4e3d596fby Jon Griffiths+8−11 file
Vendor flagged security relevance
Low 44 AI analysisMessage 38 · Opaque
EP Elements Projectlibwally-core BitcoinCryptographic librariesSoftware wallets

bip38: fail if aes fails

This commit fixes a programming oversight in the BIP38 encrypted-key code. Previously, the AES encryption/decryption helper functions ignored any error returned by the underlying AES routine. If AES failed for some reason, the code would c…

Unchecked return value from cryptographic primitive (wally_aes) fixedAES failure during BIP38 encryption/decryption could previously produce or accept malformed key materialError propagation added to both encryption and decryption paths
7a723188by Jon Griffiths+26−141 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedbuild(deps-dev): bump fast-uri from 3.1.0 to 3.1.2 in /src/wasm_packageby dependabot[bot] · 32a17131 · May 9, 2026 · 1 fileMessage 93 · StrongInformational 13Details
Commit message · dependabot[bot]

build(deps-dev): bump fast-uri from 3.1.0 to 3.1.2 in /src/wasm_package

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.0 to 3.1.2.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](https://github.com/fastify/fast-uri/compare/v3.1.0...v3.1.2)

---
updated-dependencies:
- dependency-name: fast-uri
dependency-version: 3.1.2
dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
automated dependency-update discountsecond-pass: broader security terminology
AI analysis · Informational 13/100

This is an automated Dependabot update that bumps the JavaScript development dependency fast-uri from version 3.1.0 to 3.1.2 inside the WebAssembly (WASM) packaging directory. The change only updates a package-lock.json file. There is no direct evidence in the commit that this fixes a security issue, but version bumps of URI-parsing libraries can sometimes address security bugs. Because it is a devDependency used during build/packaging, any risk is likely limited to the build environment rather than end users of the compiled library.

Lower-prioritydescriptor: add elements wallet policy testsby Jon Griffiths · c7f5ec10 · May 6, 2026 · 2 filesMessage 55 · ThinInformational 14Details
Commit message · Jon Griffiths

descriptor: add elements wallet policy tests

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 14/100

This commit only adds new test cases for Elements/Liquid confidential wallet policies. It does not change any library code, only test files. There is no security fix or vulnerability introduced here.

Lower-prioritydescriptor: make test keys explicitby Jon Griffiths · 3243cec6 · May 6, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · Jon Griffiths

descriptor: make test keys explicit

No functional changes.

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes test code. It makes the key maps used in descriptor tests explicit by adding an index field to each test case, instead of the test runner guessing which map to use based on counting '@' characters. The commit message says 'No functional changes' and the diff supports that: no library code is modified.

Security candidatedescriptor: support elements confidential wallet policiesby Jon Griffiths · 6bbe9eeb · May 6, 2026 · 1 fileMessage 78 · AdequateLow 27Details
Commit message · Jon Griffiths

descriptor: support elements confidential wallet policies

These are the same as existing wallet policies except that the blinding
key placeholder must be '@B`, which must be given first in the policy
key map when parsing.

This allows the blinding scheme and key to be presented separately from
the rest of the policy which will then be identical (modulo el-prefixes)
between elements and bitcoin for the same wallet structure.

This also allows the distinction between blinding keys and policy keys
to remain intact. Blinding keys are qualitatively different from
derivation keys; they may for example be a real pubkey, raw entropy,
and/or/in addition to an algorithm that operates on the result of the
policy for given derivation indices (in the case of deterministic
blinding). For these reasons blinding keys remain outside standard key
iteration in a parsed descriptor.

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomness
AI analysis · Low 27/100

This commit adds support in libwally-core for a new Elements/Liquid confidential-wallet policy format. It lets wallet policies include a special '@B' blinding key placeholder, kept separate from ordinary derivation keys. The change is a feature addition with embedded validation rules; it does not appear to fix a known vulnerability, but it does touch sensitive descriptor-parsing code that handles cryptographic keys. There is no vendor statement that this is a security fix, and no independent researcher is credited.

Lower-prioritydescriptor: fix error code on OOMby Daniel Newton · 6d365ec0 · May 5, 2026 · 1 fileMessage 45 · ThinInformational 18Details
Commit message · Daniel Newton

descriptor: fix error code on OOM

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100

This is a tiny one-line fix that changes the error code returned when memory allocation fails inside a Bitcoin descriptor policy-map validation function. Previously the code incorrectly reported a generic invalid-parameter error (WALLY_EINVAL) instead of an out-of-memory error (WALLY_ENOMEM). It does not fix a memory leak, crash, or code-execution bug; it only makes the reported error more accurate so callers can distinguish OOM from bad input.

Lower-prioritydescriptor: disallow leading zeros in descriptor numbersby Daniel Newton · daf02a88 · May 5, 2026 · 2 filesMessage 65 · AdequateLow 37Details
Commit message · Daniel Newton

descriptor: disallow leading zeros in descriptor numbers

Notably this restricts policy key placeholder expressions.

Co-authored-by: Jon Griffiths <jon_p_griffiths@yahoo.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 37/100

This commit tightens the rules for numbers used in Bitcoin-style output descriptors, specifically for policy key placeholders like @0, @1, etc. It now rejects numbers with leading zeros (for example @00 or @01) and negative numbers with leading zeros. Such lax parsing can, in some contexts, allow two different-looking strings to refer to the same numeric key or trick downstream code that compares keys as text. The change is defensive and reduces the chance of descriptor ambiguity or canonicalization bugs.

Lower-prioritybuild: bump dso version for 1.5.3by Jon Griffiths · 00013739 · Apr 15, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Jon Griffiths

build: bump dso version for 1.5.3

Changes to the AES checking are technically an ABI change, although it
is not expected that any user will be affected.

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit only changes the shared library version numbers in the build file (Makefile.am) in preparation for a new release. It does not change any actual program code, cryptographic functions, or user-facing behavior. The commit message mentions that earlier AES-related changes were technically an ABI change, but this commit itself is purely a build/versioning adjustment.

Security candidatejs: update aes testby Jon Griffiths · dac66cfe · Apr 15, 2026 · 1 fileMessage 38 · OpaqueInformational 15Details
Commit message · Jon Griffiths

js: update aes test

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only updates a JavaScript test file for AES encryption in the WebAssembly package. It changes how empty plaintext or ciphertext test vectors are handled (treating zero-length buffers as null) and adds a debug console.log statement. There is no change to the actual cryptographic library code, only to test expectations.

AI review queuedjs: regenerate wrappersby Jon Griffiths · 019385e5 · Apr 15, 2026 · 1 fileMessage 28 · OpaqueInformational 18Details
Commit message · Jon Griffiths

js: regenerate wrappers

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 18/100

This commit only updates the TypeScript type-declaration file for the JavaScript/WebAssembly wrapper. It widens many function parameters from 'Buffer|Uint8Array' to 'Buffer|Uint8Array|null', meaning callers are now allowed to pass null. The change is purely in type definitions; the actual C/WASM implementation is not modified here. It makes the API more permissive on paper, which could hide programming mistakes, but it does not by itself create a runtime vulnerability.

Lower-priorityjs: allow null buffers for bytes inputsby Jon Griffiths · 070c2139 · Apr 15, 2026 · 2 filesMessage 45 · ThinLow 28Details
Commit message · Jon Griffiths

js: allow null buffers for bytes inputs

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 28/100

This commit updates the JavaScript/WebAssembly wrapper for libwally-core so that functions expecting a raw byte input (like a cryptographic key or transaction data) can now accept `null` in addition to a buffer. Previously, passing `null` would likely throw a type error. The change is small and appears intended to support C functions that treat a NULL pointer plus zero length as a valid 'no data' input. There is no direct evidence in the commit that this fixes a security vulnerability, but it could prevent application crashes or incorrect behavior when callers intentionally pass no data.

AI review queuedBump version to 1.5.3by Jon Griffiths · 43b97bed · Apr 13, 2026 · 9 filesMessage 38 · OpaqueInformational 15Details
Commit message · Jon Griffiths

Bump version to 1.5.3

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a routine version bump from 1.5.2 to 1.5.3 across build files, documentation, and package metadata. No code logic, cryptographic functions, or security behavior changed.

Lower-priorityupdate CHANGES.md for release 1.5.3by Jon Griffiths · 096dc37f · Apr 13, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Jon Griffiths

update CHANGES.md for release 1.5.3

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is only a changelog update for libwally-core version 1.5.3. It does not change any source code, cryptographic logic, or build configuration. The diff adds release notes describing new features and bug fixes that were made in earlier commits. Because no code is modified, this commit itself cannot introduce or fix a security vulnerability.

Lower-prioritymap: fix incorrect clear when reinserting an integer after removing bytesby Jon Griffiths · c93c0d8b · Apr 13, 2026 · 2 filesMessage 73 · AdequateModerate 61Details
Commit message · Jon Griffiths

map: fix incorrect clear when reinserting an integer after removing bytes

Reported-by: Jordan Mecom (@jmecom) via https://github.com/jmecom/odo

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
AI analysis · Moderate 61/100

This commit fixes a bug in a key-value map used by the libwally-core crypto library. When a caller removed a byte-keyed entry and then reinserted a new integer-keyed entry into the same slot, the code could mistakenly free or overwrite memory that was no longer valid. The fix ensures integer keys are explicitly set to 'no bytes' and null values are handled cleanly, preventing memory corruption.

Security candidateaes: ensure output buffer is valid, share validation code, add testsby Jon Griffiths · d9460a64 · Apr 13, 2026 · 2 filesMessage 83 · StrongLow 46Details
Commit message · Jon Griffiths

aes: ensure output buffer is valid, share validation code, add tests

Reported-by: Jordan Mecom (@jmecom) via https://github.com/jmecom/odo

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Low 46/100

This commit tightens input validation in libwally-core's AES encryption helpers. It makes sure callers pass a valid output buffer and length, and it centralizes the checks so all AES functions behave consistently. The change also adds tests for bad inputs such as missing keys, missing IVs, and NULL output buffers. It appears to fix a bug where a caller could pass an invalid output buffer and not get a clear error.

AI review queuedtx: fix output clearing size on tx_input_init_alloc failureby Jon Griffiths · 2b5fc0ec · Apr 9, 2026 · 1 fileMessage 73 · AdequateLow 44Details
Commit message · Jon Griffiths

tx: fix output clearing size on tx_input_init_alloc failure

Reported-by: Jordan Mecom (@jmecom) via https://github.com/jmecom/odo

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit fixes a small but real bug in a Bitcoin/Elements transaction library. When creating a new transaction input fails, the code was trying to securely wipe memory using the wrong size: it used the size of a transaction output instead of the size of a transaction input. On most systems this means the clearing is ineffective or incomplete, so secret data (like scripts or witness data) could remain in memory longer than intended. It is a memory-clearing bug, not a direct remote exploit, but it weakens a security safeguard.

Lower-priorityblech32: ensure buffers are cleared if encoding failsby Jon Griffiths · ccb26df0 · Apr 9, 2026 · 1 fileMessage 73 · AdequateLow 42Details
Commit message · Jon Griffiths

blech32: ensure buffers are cleared if encoding fails

Reported-by: Jordan Mecom (@jmecom) via https://github.com/jmecom/odo

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
AI analysis · Low 42/100

This commit fixes a small cleanup bug in the confidential address encoding function. Previously, if the final blech32 encoding step failed, the function returned an error immediately without jumping to the shared cleanup code. That meant temporary buffers holding sensitive data (like the public key and hash) might not be securely wiped from memory. The change makes sure cleanup always runs, even on failure, so secrets are cleared properly.

AI review queuedtx: add missing check for NULL written paramby Jon Griffiths · 53284275 · Apr 9, 2026 · 1 fileMessage 68 · AdequateLow 36Details
Commit message · Jon Griffiths

tx: add missing check for NULL written param

Reported-by: Jordan Mecom (@jmecom) via https://github.com/jmecom/odo

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 36/100

This commit fixes a simple but real bug in a transaction helper function. Before the fix, if a caller accidentally passed a null pointer as the output parameter, the library would crash by writing to address zero. The fix adds a standard null check and returns an error instead. It is a defensive hardening change rather than an active remote exploit, but it removes a reliable local crash path.

Lower-prioritytx: reject non-corresponding output as per bip341by Jon Griffiths · a86b8abc · Apr 9, 2026 · 1 fileMessage 68 · AdequateHigh 73Details
Commit message · Jon Griffiths

tx: reject non-corresponding output as per bip341

Reported-by: Jordan Mecom (@jmecom) via https://github.com/jmecom/odo

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
AI analysis · High 73/100

This commit fixes a bug in how Bitcoin taproot-style transaction signatures (BIP341) are computed. Under a special signature mode called SIGHASH_SINGLE, the code previously did not check whether the requested transaction output actually exists. BIP341 says such signatures must be rejected. Without this check, a wallet or signer could produce an invalid or ambiguous signature that other software might accept differently, potentially leading to unexpected transaction behavior or security issues in multi-party signing.

Lower-prioritydocs: update reporting PGP key to github which is always up-to-dateby Jon Griffiths · 01a50459 · Apr 8, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Jon Griffiths

docs: update reporting PGP key to github which is always up-to-date

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates the project's security documentation. It removes a long embedded PGP public key block and replaces it with a link to the same key hosted on GitHub. There are no code changes and no security vulnerability is introduced or fixed.

AI review queuedbuild(deps): bump serialize-javascript and terser-webpack-pluginby dependabot[bot] · a24d8fcd · Mar 19, 2026 · 1 fileMessage 93 · StrongInformational 17Details
Commit message · dependabot[bot]

build(deps): bump serialize-javascript and terser-webpack-plugin

Removes [serialize-javascript](https://github.com/yahoo/serialize-javascript). It's no longer used after updating ancestor dependency [terser-webpack-plugin](https://github.com/webpack/terser-webpack-plugin). These dependencies need to be updated together.


Removes `serialize-javascript`

Updates `terser-webpack-plugin` from 5.3.16 to 5.4.0
- [Release notes](https://github.com/webpack/terser-webpack-plugin/releases)
- [Changelog](https://github.com/webpack/terser-webpack-plugin/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webpack/terser-webpack-plugin/compare/v5.3.16...v5.4.0)

---
updated-dependencies:
- dependency-name: serialize-javascript
dependency-version:
dependency-type: indirect
- dependency-name: terser-webpack-plugin
dependency-version: 5.4.0
dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
automated dependency-update discountsecond-pass: broader security terminology
AI analysis · Informational 17/100

This is an automated dependency update that removes an old JavaScript helper package called serialize-javascript and upgrades a build tool called terser-webpack-plugin. The change only affects the build-time tooling for the WebAssembly package, not the core cryptographic library. It is a routine maintenance patch with no direct evidence of an active security flaw being fixed in the project's own code.

Security candidatebip32: add some of the new bip32 checks to bip32_key_unserializeby Ondřej Češka · 2b74c8d7 · Mar 18, 2026 · 2 filesMessage 50 · ThinModerate 59Details
Commit message · Ondřej Češka

bip32: add some of the new bip32 checks to bip32_key_unserialize

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Moderate 59/100

This commit adds a safety check when loading BIP32 extended keys. Before, the code accepted any 33-byte public key bytes without verifying they form a valid public key. Now it calls a public-key validation function and rejects invalid keys. The change is defensive: it prevents malformed or attacker-chosen public keys from being treated as legitimate BIP32 keys later. The commit also adds test vectors for many other invalid key types, though only the public-key validation is newly enforced in this patch.

AI review queuedtx: pre-allocate the full number of witnesses when deserializingby Jon Griffiths · 455ec5b0 · Mar 5, 2026 · 3 filesMessage 73 · AdequateModerate 50Details
Commit message · Jon Griffiths

tx: pre-allocate the full number of witnesses when deserializing

Prevents quadratic resizing for deserializing non-standard txs with
many witnesses. Note in the transaction.c case, analyze_tx has already
run and validated that the number of witnesses is sane.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 50/100

This change fixes a performance problem when reading Bitcoin-style transactions that contain an unusually large number of 'witness' data pieces. Previously the code started with a small buffer and repeatedly grew it, which made processing time balloon (a 'quadratic' slowdown). The patch pre-allocates the exact needed size during deserialization, so large-but-valid transactions no longer cause severe delays. It is a denial-of-service/performance fix rather than a memory-corruption bug.

AI review queuedfuzz: add support for fuzzing tx parsingby Jon Griffiths · 9e8f9459 · Feb 12, 2026 · 4 filesMessage 55 · ThinInformational 15Details
Commit message · Jon Griffiths

fuzz: add support for fuzzing tx parsing

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new software testing tools (fuzzing harnesses) for parsing Bitcoin-style transactions and PSBTs. It does not change the actual transaction/PSBT parsing library code, so it cannot by itself introduce a security vulnerability or fix one. It is a test-infrastructure change.

Security candidatebuild: add fuzzing infrastructure for security testingby Erick Cestari · c824172a · Feb 12, 2026 · 7 filesMessage 100 · StrongInformational 15Details
Commit message · Erick Cestari

build: add fuzzing infrastructure for security testing

Enable continuous security testing through libFuzzer integration.
Fuzzing helps discover memory corruption bugs, parsing edge cases,
and undefined behavior that traditional unit tests often miss.

Add --enable-fuzzing, --enable-address-sanitizer, and
--enable-ub-sanitizer options to both autotools and CMake.

Initial fuzz target covers PSBT parsing with round-trip verification
to catch serialization inconsistencies.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validationfuzzing or regression evidencesigning or wallet path
AI analysis · Informational 15/100

This commit only adds new build options and a test harness for fuzzing (automated security testing). It does not change any existing library code that handles PSBTs or other data, so it cannot by itself introduce a security vulnerability or fix one. It is purely an infrastructure addition to help future security testing.

Lower-prioritybuild: disable unaligned access under ubsanby Jon Griffiths · b56a0b68 · Feb 12, 2026 · 2 filesMessage 72 · AdequateInformational 12Details
Commit message · Jon Griffiths

build: disable unaligned access under ubsan

Avoids false positives on e.g. x86 platforms.

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 12/100

This commit changes the build configuration so that when the Undefined Behavior Sanitizer (UBSan) is enabled, the project pretends the CPU cannot do unaligned memory reads/writes. This is done to silence UBSan warnings that are technically false alarms on x86 CPUs. It is a build/test-hygiene change, not a fix for an exploitable bug.