What changed, and why it matters
This commit only changes the project's continuous integration (CI) configuration. It re-enables a set of tests called 'clear tests' that were previously disabled in automated build pipelines, and adds a compiler warning suppression for an amalgamation compile test. There is no change to the actual library code that users run, so this commit does not introduce or fix a security vulnerability in the software itself.
No security action required. Treat as a normal CI maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .gitlab-ci.yml only. It removes –disable-clear-tests from three configure invocations (test_asan_ubsan_gcc, test_scan_build_clang, test_no_elements_abi) so that clear-tests run during CI again. It also adds -Wno-unknown-attributes to the test_amalgamation compile command. No source code, build system defaults, or runtime behavior of libwally-core is changed.
Changed components
.gitlab-ci.ymlInspect captured patch +4 / −4
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 4b6657e..546b35c 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -37,7 +37,7 @@ test_asan_ubsan_gcc:
- CONFIGURE_ARGS: [ --enable-elements=no, --enable-elements=no --enable-minimal=yes, "", --enable-minimal=yes ]
script:
- ./tools/cleanup.sh && ./tools/autogen.sh
- - CC=gcc CFLAGS="-O2 -fsanitize=address -fsanitize=bounds -fsanitize=undefined -fsanitize=alignment -fsanitize-address-use-after-scope -fno-sanitize-recover=all" ./configure --enable-export-all --enable-swig-python --enable-swig-java $CONFIGURE_ARGS --enable-shared --disable-static --disable-clear-tests --disable-asm
+ - CC=gcc CFLAGS="-O2 -fsanitize=address -fsanitize=bounds -fsanitize=undefined -fsanitize=alignment -fsanitize-address-use-after-scope -fno-sanitize-recover=all" ./configure --enable-export-all --enable-swig-python --enable-swig-java $CONFIGURE_ARGS --enable-shared --disable-static --disable-asm
- sed -i 's/^PYTHON = /PYTHON = LD_PRELOAD=\/usr\/lib\/gcc\/x86_64-linux-gnu\/14\/libasan.so /g' src/Makefile
- sed -i 's/^JAVA = /JAVA = LD_PRELOAD=\/usr\/lib\/gcc\/x86_64-linux-gnu\/14\/libasan.so /g' src/Makefile
- make -j $(($(grep ^processor /proc/cpuinfo | wc -l) / 2))
@@ -50,7 +50,7 @@ test_scan_build_clang:
- CONFIGURE_ARGS: [ --enable-elements=no, --enable-elements=no --enable-minimal=yes, "", --enable-minimal=yes ]
script:
- ./tools/cleanup.sh && ./tools/autogen.sh
- - CC=clang scan-build-19 ./configure --enable-export-all --enable-swig-python --enable-swig-java --disable-clear-tests --disable-asm $CONFIGURE_ARGS
+ - CC=clang scan-build-19 ./configure --enable-export-all --enable-swig-python --enable-swig-java --disable-asm $CONFIGURE_ARGS
- scan-build-19 --keep-cc --exclude src/secp256k1/ --status-bugs --keep-empty -o scan-build-output make -j $(($(grep ^processor /proc/cpuinfo | wc -l) / 2))
artifacts:
expire_in: 3 days
@@ -93,7 +93,7 @@ test_amalgamation:
BUILD_ARGS: [ "", -DBUILD_MINIMAL, -DBUILD_ELEMENTS, -DBUILD_ELEMENTS -DBUILD_MINIMAL ]
script:
- touch config.h
- - $CC $BUILD_ARGS -Wall -W -Wextra -Werror -I. -I./src -I./src/ccan -I./src/secp256k1/include src/ctest/amalgamation_compile_test.c
+ - $CC $BUILD_ARGS -Wall -W -Wextra -Werror -Wno-unknown-attributes -I. -I./src -I./src/ccan -I./src/secp256k1/include src/ctest/amalgamation_compile_test.c
test_mingw_static_build:
extends: .test_template
@@ -107,7 +107,7 @@ test_no_elements_abi:
artifacts:
script:
- ./tools/cleanup.sh && ./tools/autogen.sh
- - CFLAGS='-Wall -W -Wextra -Werror' ./configure --disable-swig-python --disable-swig-java --disable-clear-tests --enable-elements=no --enable-elements-abi=no
+ - CFLAGS='-Wall -W -Wextra -Werror' ./configure --disable-swig-python --disable-swig-java --enable-elements=no --enable-elements-abi=no
- make -j $(($(grep ^processor /proc/cpuinfo | wc -l) / 2))
build_wally_release_files:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.