EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsActive incident
Repository coverage

1361 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

108security candidates322second-pass queue1084AI analyses
90commits · 30 days
200commits · 60 days
570commits · 180 days
1124commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
252Strong · 80–100
675Adequate · 60–79
388Thin · 40–59
46Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
SomberNight42533373163
ThomasV16511104163
ghost4376626170
f321x44128400070
Sander van Grieken12412112057
Felix54720070
user323062
ekzyis222053
accumulator28111072
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 10 minutes ago

Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11172 from accumulator/qml_crash_reporter_threading

This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…

Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
45ad42f7by Felix+4−11 file
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: crash reporter: handle threading.excepthook arguments

This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…

Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
2e7fe460by Sander van Grieken+4−11 file
No security note in commit
Low 40 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…

Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
ff273162by ThomasV+4−11 file
No security note in commit
Low 29 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

wallet: make_unsigned_tx: follow-up prev

This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…

Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
462f631dby SomberNight+2−01 file
No security note in commit
Low 28 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11097 from SomberNight/202610_bump_deps

This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…

Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
84345fdcby ghost43+934−103048 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11139 from accumulator/consolidate_platform_checks

This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…

22e24580by ghost43+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

consolidate platform checks into platform.py

This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…

9715f882by Sander van Grieken+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

version: bump to 4.8.4

This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.

0c661eb8by f321x+1−11 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

make_unsigned_transaction: do not require coins if there is a base_tx

This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…

Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
876360deby ThomasV+2−11 file
No security note in commit
Informational 17 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11111 from accumulator/qml_bip39recovery_task_refactor

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…

Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
896a68d7by Felix+44−332 files
No security note in commit
Informational 12 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: refactor BIP39 account scan to asyncio tasks.

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…

00ed883aby Sander van Grieken+44−332 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: paytoedit: complete contacts to their key, not 'name <key>'

This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…

UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
dd1b50fbby f321x+47−132 files
No security note in commit
Informational 18 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11092 from f321x/qml_address_history_labels

This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…

No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
9242c505by Felix+334−8412 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: avoid potential Ok signal by tapping while dialog is closing,

This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…

Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
00f981edby Sander van Grieken+8−01 file
No security note in commit
Informational 21 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11091 from f321x/fix_num_parents_perf_simple

This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …

Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
4ec70746by ThomasV+82−463 files
No security note in commit
Informational 24 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11047 from fametrano/old-seed-odd-length

This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…

Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
fc31115eby ghost43+93−157 files
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11096 from f321x/followup_11094

This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…

Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
54c355feby Felix+9−75 files
No security note in commit
Informational 23 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11094 from devdavidejesus/fix-10760-storage-not-utf8

This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…

Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
2a20256fby Felix+10−12 files
No security note in commit
Informational 20 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: show StorageReadWriteError to user instead of crash reporting it

This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…

No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
5a971b11by f321x+2−11 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

keystore: follow-up prev: small clean-up

This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…

Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
ead42d09by SomberNight+35−154 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge pull request #10893 from f321x/fix_10891by ghost43 · 37a09e79 · Aug 25, 2026 · 3 filesMessage 68 · AdequateLow 25Details
Commit message · ghost43

Merge pull request #10893 from f321x/fix_10891

wallet: fix sweeping with imported address watch only wallet

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit fixes a bug in the Electrum Bitcoin wallet that could crash or fail when trying to move funds from a watch-only wallet that only has imported addresses (no private keys). The fix makes the wallet more careful when it doesn't know the exact script type for an address, returning 'unknown' instead of crashing, and only setting a script descriptor when one actually exists. There is no direct evidence this was a security vulnerability exploitable by an attacker; it appears to be a reliability/functional bug fix.

AI review queuedtests: (trivial) wallet_vertical: sweep_p2wpkh: use subTestsby SomberNight · bc4ac541 · Aug 25, 2026 · 1 fileMessage 75 · AdequateInformational 15Details
Commit message · SomberNight

tests: (trivial) wallet_vertical: sweep_p2wpkh: use subTests

make separation of logic somewhat clearer

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a purely cosmetic change to a test file. It wraps two existing test blocks inside Python 'subTest' contexts so that if one part fails, the other still runs and the failure message is clearer. No production code was changed, and no security behavior is affected.

AI review queuedMerge pull request #10877 from f321x/swaps_pop_invoiceby ThomasV · 0a1977a7 · Aug 25, 2026 · 4 filesMessage 73 · AdequateLow 42Details
Commit message · ThomasV

Merge pull request #10877 from f321x/swaps_pop_invoice

swap server: simplify LN invoice payment

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100

This commit refactors how Electrum's submarine-swap server pays Lightning invoices from clients. The main visible change is that the swap server no longer maintains its own retry queue for pending invoices; instead it delegates directly to the wallet's existing invoice-payment logic, which now rejects duplicate in-flight payment attempts. A new regression test confirms that a second payment attempt with the same payment hash is blocked while the first is still running. The commit also fixes a small bug where an HTTP endpoint called a coroutine without awaiting it. Overall the change looks like a hardening/cleanup rather than an obvious vulnerability fix, but it removes a custom retry mechanism and tightens duplicate-payment protection, which can have security relevance in Lightning.

Security candidateMerge pull request #10885 from SomberNight/202608_crypto_sanity_checksby Felix · 29991f4a · Aug 25, 2026 · 1 fileMessage 58 · ThinLow 27Details
Commit message · Felix

Merge pull request #10885 from SomberNight/202608_crypto_sanity_checks

crypto.py: add some sanity checks

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 27/100

This commit adds safety checks to Electrum's encryption helper functions and includes a self-test that runs when the program starts. The new checks make sure AES keys and initialization vectors (IVs) are the correct length before encrypting or decrypting, which helps catch programming mistakes early. The self-tests verify that hash and encryption functions produce known correct outputs, so Electrum will fail immediately if a cryptographic library is broken or misconfigured rather than silently producing bad results.

Security candidatecrypto: add runtime sanity checksby SomberNight · 1e3792f0 · Aug 22, 2026 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · SomberNight

crypto: add runtime sanity checks

- if one of the critical hash functions is broken, we should panic early
(sha256/sha512/hash160), as the consequences could be devastating.
- sha512 is used for bip32
- sha256/hash160 are used for deriving addresses

- but we might as well also test the symmetric ciphers
- though those checks are a bit slower
- but I would prefer erring on the side of paranoia and doing the check

naive benchmarks:
(it's not AES that is slow, but the first invocations of the symmetric ciphers)
```
>>> from electrum.crypto import *
backends: HAS_CRYPTODOME=True, HAS_CRYPTOGRAPHY=False
time taken by 'hash functions1': 0.065 msec
time taken by 'aes1': 3.377 msec
time taken by 'aes2': 0.047 msec
time taken by 'chacha20': 0.182 msec
time taken by 'chacha20-poly1305': 0.405 msec
total time taken: 4.235 msec
```
```
>>> from electrum.crypto import *
backends: HAS_CRYPTODOME=False, HAS_CRYPTOGRAPHY=True
time taken by 'hash functions1': 0.064 msec
time taken by 'aes1': 7.131 msec
time taken by 'aes2': 0.040 msec
time taken by 'chacha20': 0.056 msec
time taken by 'chacha20-poly1305': 0.023 msec
total time taken: 7.446 msec
```

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Informational 15/100

This commit adds self-tests to Electrum's cryptography code. When the program starts, it now runs a few known test vectors through hash and encryption functions and crashes immediately if the results are wrong. This is a defensive hardening change, not a fix for an active security flaw.

AI review queuedlogging: get_git_version: add timeoutby SomberNight · df770bb0 · Aug 21, 2026 · 1 fileMessage 58 · ThinInformational 17Details
Commit message · SomberNight

logging: get_git_version: add timeout

note: this is currently only used by the crash reporter, on-demand when constructing a report

f321x said:
> Some git commands can be really slow on certain filesystems setups, this is for example the output on a virtio9p mount in a vm:
>
> user@debian-vm:~/code/electrum$ time git describe --always --dirty
> 4.8.1-62-gab813173cd
>
> real 0m2.614s
> user 0m0.109s
> sys 0m0.196s

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 17/100

This commit adds a 5-second timeout and a small cache to a helper that runs the 'git describe' command when Electrum's crash reporter builds a diagnostic report. The change mainly prevents the crash reporter from hanging on slow filesystems. A code comment also flags that the helper searches the system path for a program named 'git', which could theoretically be abused if an attacker controls the program search path, but the commit does not claim this is an exploitable vulnerability.

Security candidateMerge pull request #10881 from ekzyis/bip32-reject-depth0-nonzero-metadataby ghost43 · 92357801 · Aug 21, 2026 · 2 filesMessage 73 · AdequateLow 44Details
Commit message · ghost43

Merge pull request #10881 from ekzyis/bip32-reject-depth0-nonzero-metadata

bip32: reject master key with non-zero child/fingerprint

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 44/100

This change tightens validation of BIP32 master keys (the root keys used to derive all wallet addresses). Previously, Electrum would accept an extended public or private key that claimed to be a master key (depth 0) but had a non-zero child number or parent fingerprint. Such keys violate the BIP32 specification and could cause confusion or interoperability problems, but the patch is a defensive validation fix rather than a clear remote-exploitable vulnerability.

Security candidateMerge pull request #10880 from ekzyis/bip32-reject-xpriv-non-zero-key-prefixby ghost43 · e3384174 · Aug 21, 2026 · 2 filesMessage 78 · AdequateLow 44Details
Commit message · ghost43

Merge pull request #10880 from ekzyis/bip32-reject-xpriv-non-zero-key-prefix

bip32: reject extended private key with non-zero key prefix

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 44/100

This update makes Electrum stricter when reading a BIP32 extended private key (the long encoded string that can generate all your wallet's addresses). BIP32 requires that the 33-byte private-key field start with a zero byte before the actual 32-byte secret. Electrum now rejects keys that violate this rule, which closes a gap where a malformed key could be accepted and later produce unexpected public keys or wallet behavior.

Security candidatebip32: reject master key with non-zero child/fingerprintby ekzyis · afb5c7ad · Aug 21, 2026 · 2 filesMessage 50 · ThinLow 47Details
Commit message · ekzyis

bip32: reject master key with non-zero child/fingerprint

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Low 47/100

This commit tightens validation of Bitcoin wallet master keys. Under the BIP32 standard, a master key must have zero values for its 'child number' and 'parent fingerprint' fields. The change makes Electrum reject extended keys that violate this rule, preventing malformed or intentionally crafted master keys from being accepted. This is a defensive correctness fix rather than an active exploit patch.

Security candidatebip32: reject extended private key with non-zero key prefixby ekzyis · ea285d5e · Aug 21, 2026 · 2 filesMessage 55 · ThinModerate 59Details
Commit message · ekzyis

bip32: reject extended private key with non-zero key prefix

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Moderate 59/100

Electrum added a check to reject malformed BIP32 extended private keys ('xprv...') where the private key data does not start with a required zero byte. Previously, such invalid keys may have been accepted. This is a defensive validation fix that prevents non-standard or corrupted keys from being processed, reducing the risk of key-handling bugs or unexpected behavior.

Security candidateMerge pull request #10872 from f321x/trezor_always_on_device_passphraseby ghost43 · 3d41451f · Aug 19, 2026 · 2 filesMessage 73 · AdequateLow 29Details
Commit message · ghost43

Merge pull request #10872 from f321x/trezor_always_on_device_passphrase

plugin: trezor: fix usage with passphrase

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Low 29/100

This commit fixes how Electrum's Trezor hardware wallet plugin handles passphrases. Previously, the code could prompt the user to enter their passphrase on the computer even when the Trezor device was configured to ask for the passphrase on the device itself. This could make users type their passphrase twice or, worse, enter a sensitive passphrase into the computer when they expected to enter it only on the device. The patch also makes the settings screen more robust when the device is locked. It is a usability and security-hardening fix rather than a remote-exploitable vulnerability.

Security candidateplugin: trezor: handle empty passphrase feature in settings dialogby f321x · 617dc34c · Aug 19, 2026 · 1 fileMessage 85 · StrongInformational 17Details
Commit message · f321x

plugin: trezor: handle empty passphrase feature in settings dialog

The settings dialog would raise after disabling the passphrase because
the feature is None after disconnecting:

```
24.43 | I | plugins.trezor.clientbase.TrezorClientBase | locking: <trezorlib.protocol_v1.TrezorClientV1 object at 0x7fec5f7d45e0>
24.82 | I | plugins.trezor.clientbase.TrezorClientBase | closing: SessionV1(id=fec9fa77e94f52faa50e3aa5573d6e760a028e2e6cd2366bc998dcc9870f2382)
24.97 | E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter
Traceback (most recent call last):
File "/var/home/user/code/code_vm/electrum-3/electrum/gui/common_qt/util.py", line 175, in on_done
cb_result(result)
~~~~~~~~~^^^^^^^^
File "/var/home/user/code/code_vm/electrum-3/electrum/plugins/trezor/qt.py", line 534, in update
passphrases_label.setText(disen[features.passphrase_protection])
~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: list indices must be integers or slices, not NoneType
```

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
access control
AI analysis · Informational 17/100

This commit fixes a crash in Electrum's settings window for Trezor hardware wallets. After a user disabled the passphrase feature and disconnected the device, the settings dialog tried to read a value that had become 'None', causing a TypeError and crashing the dialog. The patch stores the device features before disconnecting and gracefully handles the 'None' case by showing 'Unknown' instead of crashing.

Security candidateplugin: trezor: handle passphrase_always_on_deviceby f321x · 5237805b · Aug 19, 2026 · 1 fileMessage 81 · StrongInformational 22Details
Commit message · f321x

plugin: trezor: handle passphrase_always_on_device

Trezor devices have a config option `passphrase_always_on_device`
that might be set
(e.g. through the CLI `trezorctl set passphrase on --force-on-device`).
This makes the device enforce passphrase input on the device (in
comparison to input through the Electrum GUI).

There were two issues when this config is enabled:
1. On V1 devices the passphrase would be prompted twice. Once
after entering the PIN (automatically by the device), then
Electrum would initiate a second, redundant passphrase prompt.
2. On THP devices (Safe 7), the setup would error as
`client.get_session()` must receive `PassphraseSettings.ON_DEVICE`
which it didn't.

Tested on Safe 3 and Safe 7.
Fixes https://github.com/spesmilo/electrum/issues/10868

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access control
AI analysis · Informational 22/100

This commit fixes a bug in how Electrum talks to Trezor hardware wallets when a device setting forces passphrase entry on the Trezor itself instead of in Electrum. Previously, older Trezor devices could ask for the passphrase twice, and newer Safe 7 devices would fail to set up. The fix checks the device's setting and tells the Trezor library to handle the passphrase on the device when appropriate. It is a usability/compatibility fix, not a vulnerability patch.

AI review queuedMerge pull request #10863 from SomberNight/202608_config_consistencyby Felix · cfa0c533 · Aug 18, 2026 · 3 filesMessage 73 · AdequateInformational 21Details
Commit message · Felix

Merge pull request #10863 from SomberNight/202608_config_consistency

add sanity check: wallet.config == lnworker.config == network.config

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This commit adds internal consistency checks to make sure a wallet, its lightning component, and the network layer all share the same configuration object. It is a defensive hardening change: it does not fix an active bug by itself, but makes future misconfigurations fail loudly during development/testing rather than silently causing odd behavior.

AI review queuedadd sanity check: wallet.config == lnworker.config == network.configby SomberNight · 87aee714 · Aug 17, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · SomberNight

add sanity check: wallet.config == lnworker.config == network.config

useful for unit tests where it is easy to slip-up and break this invariant when creating a MockNetwork

ref https://github.com/spesmilo/electrum/pull/10852#discussion_r3796948136

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds internal consistency checks (assertions) to make sure that a wallet, its lightning worker, and the network connection all share the same configuration object. It is a hardening/test-quality change only; it does not fix any user-facing bug or vulnerability and does not change runtime behavior except to fail loudly during tests or development if the invariant is violated.

AI review queuedMerge pull request #10830 from accumulator/qml_trustedcoin_wallet_scopeby ghost43 · a357e86f · Aug 14, 2026 · 3 filesMessage 73 · AdequateLow 42Details
Commit message · ghost43

Merge pull request #10830 from accumulator/qml_trustedcoin_wallet_scope

qml: wallet, tx and callbacks were incorrectly scoped to class level for trustedcoin plugin.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100

This change fixes a programming mistake in Electrum's mobile/QML user interface where the trustedcoin two-factor authentication (2FA) plugin stored wallet, transaction, and callback information as shared class-level data instead of per-use data. In practice, this could mean that if multiple wallets or transactions requested an OTP at the same time, the wrong wallet or transaction could be signed, or a stale callback could run. The patch scopes those values to each individual OTP request so they cannot collide or leak across requests.

AI review queuedMerge pull request #10853 from f321x/swapserver_negative_nonceby ghost43 · 0d6df530 · Aug 14, 2026 · 2 filesMessage 73 · AdequateLow 49Details
Commit message · ghost43

Merge pull request #10853 from f321x/swapserver_negative_nonce

swaps: handle negative PoW nonce gracefully

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Low 49/100

This patch fixes a small bug in how Electrum checks proof-of-work (PoW) nonces from Nostr swap server announcements. Previously, a missing or negative nonce was treated as having zero PoW, which is correct for missing nonces but the code also allowed negative nonces to be passed into the hash calculation. The patch now explicitly rejects negative nonces and moves the PoW check inside the try block so any parsing error skips the announcement. In practical terms, a malicious or buggy swap server could have advertised a negative nonce; depending on the exact behavior of the hash function with negative numbers, this could have caused a crash, incorrect PoW evaluation, or unexpected filtering of swap servers.

AI review queuedswaps: handle negative PoW nonce gracefullyby f321x · 290c0a48 · Aug 14, 2026 · 2 filesMessage 60 · AdequateLow 37Details
Commit message · f321x

swaps: handle negative PoW nonce gracefully

Handle negative nonces in swap announcement events gracefully.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Low 37/100

This commit fixes a small bug in Electrum's submarine swap feature. When a swap server advertises itself using a Nostr event, the client checks a 'proof-of-work nonce' to verify the server did enough computational work. Before the patch, a negative nonce could slip through and be treated as valid, potentially letting a low-effort or malicious swap server bypass the anti-spam check. The fix treats negative nonces the same as a missing nonce (zero proof-of-work bits).

AI review queuedMerge pull request #10851 from f321x/fix_7513_non_deterministic_walletby ghost43 · 78469e38 · Aug 14, 2026 · 1 fileMessage 73 · AdequateModerate 56Details
Commit message · ghost43

Merge pull request #10851 from f321x/fix_7513_non_deterministic_wallet

wallet: don't remove ln xprv from wallet backup

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 56/100

This change fixes a bug in Electrum wallet backups. Previously, when creating a backup of a wallet that had Lightning (Bitcoin's layer-2 network) enabled, the backup code was incorrectly wiping out the Lightning private key from the backup copy. A backup without this key cannot fully restore the wallet's Lightning funds and state. The fix simply stops removing that key, so backups remain complete and recoverable.

AI review queuedwallet: don't remove ln xprv from wallet backupby f321x · a1039232 · Aug 14, 2026 · 1 fileMessage 76 · AdequateModerate 64Details
Commit message · f321x

wallet: don't remove ln xprv from wallet backup

Fixes the same issue described in https://github.com/spesmilo/electrum/issues/7513
for non-deterministic lightning wallets.

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 64/100

This commit fixes a bug in Electrum's wallet backup feature. Previously, when creating a backup, the software incorrectly wiped a private Lightning key ('lightning_privkey2') from non-deterministic Lightning wallets. That meant backups could be incomplete and users might not be able to recover their Lightning funds from the backup. The fix simply stops removing that key during backup.

Security candidateMerge pull request #10842 from SomberNight/202608_macos_readme_codesigning_privkeyby ThomasV · e7330679 · Aug 13, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · ThomasV

Merge pull request #10842 from SomberNight/202608_macos_readme_codesigning_privkey

macos: readme: add sections with codesigning issues and fixes

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydocumentation-only discountmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only updates a macOS build documentation file (README.md). It adds troubleshooting instructions for developers who are code-signing Electrum app bundles, including how to fix private-key access control and certificate trust settings. There is no code change, no wallet behavior change, and no security vulnerability being fixed.

Security candidateMerge pull request #10845 from f321x/hide_passphrase_entryby accumulator · baa49ba3 · Aug 13, 2026 · 1 fileMessage 73 · AdequateInformational 20Details
Commit message · accumulator

Merge pull request #10845 from f321x/hide_passphrase_entry

qml: wizard: hide passphrase input if disabled

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 20/100

This change tweaks a mobile-style setup wizard so that the optional passphrase text box is hidden when its checkbox is not selected, instead of merely grayed out. The commit message says this was done because users were confusing the passphrase field with the seed re-entry field. It is a usability fix, not a security bug fix.

Security candidaterelease notes: add pre-notification of security fixes for 4.8.1by SomberNight · c4cc40fd · Aug 12, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · SomberNight

release notes: add pre-notification of security fixes for 4.8.1

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
explicit security language
AI analysis · Informational 15/100

This commit only edits the project's release notes to add a vague pre-notification that version 4.8.1 will contain undisclosed security fixes. It does not include any actual code changes, patches, or details about what the security issues are.

AI review queuedprepare release 4.8.1by SomberNight · 59d1b201 · Aug 10, 2026 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · SomberNight

prepare release 4.8.1

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a routine version bump and release-notes update for Electrum 4.8.1. It does not change any executable code, only the version string and the changelog. The changelog itself lists many fixes from prior commits, but this specific commit only packages those notes for release.

AI review queuedqml: styling OTP dialogby Sander van Grieken · b7f124fc · Aug 10, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Sander van Grieken

qml: styling OTP dialog

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is purely a user-interface styling tweak for the one-time password (OTP) dialog in Electrum's QML (mobile-style) GUI. It sets the character used to calculate the input field width to '8', adds left/right padding to that width calculation, and changes how an error label is horizontally centered. There is no security-relevant change.